Attention is currently required from: laforge, pespin.
Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmo-netif/+/41953?usp=email )
Change subject: gitignore: ignore generated .wasm files
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS1:
> I agree, we don't need that auto-detection for one specific rare build environment. […]
Understood, auto-detection has been dropped. The change is now limited to the .gitignore part only.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/41953?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I023158cc39989d6fe98080fecb61410aa4e535ab
Gerrit-Change-Number: 41953
Gerrit-PatchSet: 5
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 26 Jan 2026 18:44:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: Timur Davydov.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-netif/+/41953?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: gitignore: ignore generated .wasm files
......................................................................
gitignore: ignore generated .wasm files
Change-Id: I023158cc39989d6fe98080fecb61410aa4e535ab
---
M .gitignore
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/53/41953/5
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/41953?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I023158cc39989d6fe98080fecb61410aa4e535ab
Gerrit-Change-Number: 41953
Gerrit-PatchSet: 5
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>
Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41957?usp=email )
Change subject: xua_snm: Fix typo in comment
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41957?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I533809a0d319e75f2f18c706ddc4318503b9915a
Gerrit-Change-Number: 41957
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 26 Jan 2026 18:34:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: dexter, fixeria.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41890?usp=email )
Change subject: pySimLogger: user __name__ of the module when creating a new logger
......................................................................
Patch Set 2:
(3 comments)
File contrib/csv-to-pgsql.py:
https://gerrit.osmocom.org/c/pysim/+/41890/comment/d39d8c3e_6c7fa219?usp=em… :
PS1, Line 38: log = PySimLogger.get(__name__)
> I remember having problems here. This code location was not able to access the globel log object. […]
this is odd, the code should have acces to global variabls of the same module. WE definitely don't want to pass the log object around explicitly.
File contrib/csv-to-pgsql.py:
https://gerrit.osmocom.org/c/pysim/+/41890/comment/806c0158_35bbe05a?usp=em… :
PS2, Line 15: log = PySimLogger.get("csv-to-pqsql")
you can generalize this with
```
from pathlib import Path
print(Path(__file__).stem)
```
this way it automatically adjusts if we should ever rename the script file.
File contrib/es2p_server.py:
https://gerrit.osmocom.org/c/pysim/+/41890/comment/dfdb3b62_d0ef2dd2?usp=em… :
PS2, Line 35: logger = logging.getLogger("es2p_server")
you can generalize this with
```
from pathlib import Path
print(Path(__file__).stem)
```
this way it automatically adjusts if we should ever rename the script file.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/41890?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I49a9beb98845f66247edd42ed548980c97a7151a
Gerrit-Change-Number: 41890
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 26 Jan 2026 18:33:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: Timur Davydov, pespin.
laforge has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmo-abis/+/41955?usp=email )
Change subject: lapd-over-datagram-user: fix printf format for timeval fields
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File doc/examples/lapd-over-datagram/lapd-over-datagram-user.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/41955/comment/99179cfa_4700a049… :
PS1, Line 167: "in %" PRIdMAX ".%06" PRIdMAX "\n",
> Good catch, my bad. […]
Done
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/41955?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I7067eae1132c604aff3b37e5dff06fadb0759cb6
Gerrit-Change-Number: 41955
Gerrit-PatchSet: 2
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Comment-Date: Mon, 26 Jan 2026 18:24:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>