January 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-sgsn[master]: Modified to dynamically adjust the returned QoS length to ensure comp...
by fixeria 27 Jan '26

27 Jan '26

Attention is currently required from: canghaiwuhen, pespin. fixeria has posted comments on this change by canghaiwuhen. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41948?usp=email ) Change subject: Modified to dynamically adjust the returned QoS length to ensure compatibility with older modules. ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: You need to rebase this patch on top of master. It's currently on top of an abandoned patch, so you won't be able to merge it. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/41948?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I872d882de4ce186f644b1b3ab684963050709d4f Gerrit-Change-Number: 41948 Gerrit-PatchSet: 6 Gerrit-Owner: canghaiwuhen <canghaiwuhen(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: canghaiwuhen <canghaiwuhen(a)gmail.com> Gerrit-Comment-Date: Tue, 27 Jan 2026 06:20:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-sgsn[master]: Modified to dynamically adjust the returned QoS length to ensure comp...
by fixeria 27 Jan '26

27 Jan '26

Attention is currently required from: canghaiwuhen, pespin. fixeria has posted comments on this change by canghaiwuhen. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41948?usp=email ) Change subject: Modified to dynamically adjust the returned QoS length to ensure compatibility with older modules. ...................................................................... Patch Set 6: Code-Review+1 (4 comments) File src/sgsn/gprs_sm.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/b1f05aa3_4306a799?us… : PS1, Line 210: ANTIGRAVITY PATCH: True Echo. > What does this mean? Done https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/109b0034_71f18df4?us… : PS1, Line 219: if (qos_len > sizeof(default_qos)) > ```suggestion […] Done https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/bd2ad1ca_c3de232c?us… : PS1, Line 340: tp->lv[OSMO_IE_GSM_REQ_QOS].len > ```suggestion […] Done File src/sgsn/gprs_sm.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/95358616_721c2ccb?us… : PS3, Line 221: msgb_lv_put(msg, qos_len, (uint8_t *)&default_qos); > let's better do: […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/41948?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I872d882de4ce186f644b1b3ab684963050709d4f Gerrit-Change-Number: 41948 Gerrit-PatchSet: 6 Gerrit-Owner: canghaiwuhen <canghaiwuhen(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: canghaiwuhen <canghaiwuhen(a)gmail.com> Gerrit-Comment-Date: Tue, 27 Jan 2026 06:18:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-sgsn[master]: Modified to dynamically adjust the returned QoS length to ensure comp...
by Jenkins Builder 27 Jan '26

27 Jan '26

Attention is currently required from: canghaiwuhen. Jenkins Builder has posted comments on this change by canghaiwuhen. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41948?usp=email ) Change subject: Modified to dynamically adjust the returned QoS length to ensure compatibility with older modules. ...................................................................... Patch Set 5: (3 comments) File src/sgsn/gprs_sm.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/212e39b8_24e88194?us… : PS5, Line 215: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/120108b3_f59a502c?us… : PS5, Line 215: code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/e19a8041_7cd8576e?us… : PS5, Line 215: please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/41948?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I872d882de4ce186f644b1b3ab684963050709d4f Gerrit-Change-Number: 41948 Gerrit-PatchSet: 5 Gerrit-Owner: canghaiwuhen <canghaiwuhen(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: canghaiwuhen <canghaiwuhen(a)gmail.com> Gerrit-Comment-Date: Tue, 27 Jan 2026 05:47:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-sgsn[master]: Modified to dynamically adjust the returned QoS length to ensure comp...
by Jenkins Builder 27 Jan '26

27 Jan '26

Attention is currently required from: canghaiwuhen. Jenkins Builder has posted comments on this change by canghaiwuhen. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41948?usp=email ) Change subject: Modified to dynamically adjust the returned QoS length to ensure compatibility with older modules. ...................................................................... Patch Set 4: (15 comments) File src/sgsn/gprs_sm.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/63636a23_7f585a14?us… : PS4, Line 214: uint8_t qos_len; code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/cb543d06_28a499c5?us… : PS4, Line 214: uint8_t qos_len; please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/01b18d85_0e3adcd6?us… : PS4, Line 215: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/1c8ced0d_1631ff87?us… : PS4, Line 215: code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/c2ed8207_cef06627?us… : PS4, Line 215: please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/ea785cf1_70f6457b?us… : PS4, Line 216: if (pdp->req_qos_len == 0 || pdp->req_qos_len > sizeof(default_qos)) code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/a57aee26_717b0277?us… : PS4, Line 216: if (pdp->req_qos_len == 0 || pdp->req_qos_len > sizeof(default_qos)) please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/9eea306f_27a61c7d?us… : PS4, Line 216: if (pdp->req_qos_len == 0 || pdp->req_qos_len > sizeof(default_qos)) suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/264430df_a6d61480?us… : PS4, Line 217: qos_len = sizeof(default_qos); code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/1b7aa66f_20b8e671?us… : PS4, Line 217: qos_len = sizeof(default_qos); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/177cc261_fc114c3c?us… : PS4, Line 218: else code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/84e8518c_0c76cd3b?us… : PS4, Line 218: else please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/fbadf544_3a6f6a32?us… : PS4, Line 218: else suspect code indent for conditional statements (8, 12) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/3acca790_ff2899c7?us… : PS4, Line 219: qos_len = pdp->req_qos_len; code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/41948/comment/2aea1bf5_8fa0b5e8?us… : PS4, Line 219: qos_len = pdp->req_qos_len; please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/41948?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I872d882de4ce186f644b1b3ab684963050709d4f Gerrit-Change-Number: 41948 Gerrit-PatchSet: 4 Gerrit-Owner: canghaiwuhen <canghaiwuhen(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: canghaiwuhen <canghaiwuhen(a)gmail.com> Gerrit-Comment-Date: Tue, 27 Jan 2026 02:09:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in libosmo-sigtran[master]: xua_snm: Fix typo in comment
by pespin 27 Jan '26

27 Jan '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41957?usp=email ) Change subject: xua_snm: Fix typo in comment ...................................................................... xua_snm: Fix typo in comment Change-Id: I533809a0d319e75f2f18c706ddc4318503b9915a --- M src/xua_snm.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/xua_snm.c b/src/xua_snm.c index efa7e91..e983293 100644 --- a/src/xua_snm.c +++ b/src/xua_snm.c @@ -321,7 +321,7 @@ if (!osmo_ss7_asp_active(asp)) continue; - /* only send DAVA/DUNA if we locally are the SG and the remote is ASP */ + /* only send DUPU if we locally are the SG and the remote is ASP */ if (asp->cfg.role != OSMO_SS7_ASP_ROLE_SG) continue; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41957?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I533809a0d319e75f2f18c706ddc4318503b9915a Gerrit-Change-Number: 41957 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: xua: Implement User Part Unavailable HMDT -> HMRT
by pespin 27 Jan '26

27 Jan '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41949?usp=email ) Change subject: xua: Implement User Part Unavailable HMDT -> HMRT ...................................................................... xua: Implement User Part Unavailable HMDT -> HMRT Related: OS#6891 Change-Id: Iab2ffc3a86243d5eeedcc4fd3d558796ede9afc3 --- M src/m3ua.c M src/mtp3_hmdt.c M src/sua.c M src/xua_internal.h 4 files changed, 127 insertions(+), 8 deletions(-) Approvals: pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/src/m3ua.c b/src/m3ua.c index 2b7c1e7..e4173bd 100644 --- a/src/m3ua.c +++ b/src/m3ua.c @@ -910,9 +910,9 @@ } /* 3.4.5 Destination User Part Unavailable (DUPU) */ -static struct xua_msg *m3ua_encode_dupu(const uint32_t *rctx, unsigned int num_rctx, - uint32_t dpc, uint16_t user, uint16_t cause, - const char *info_string) +struct xua_msg *m3ua_encode_dupu(const uint32_t *rctx, unsigned int num_rctx, + uint32_t dpc, uint16_t user, uint16_t cause, + const char *info_string) { struct xua_msg *xua = xua_msg_alloc(); uint32_t user_cause = (cause << 16) | user; diff --git a/src/mtp3_hmdt.c b/src/mtp3_hmdt.c index a6cf1b3..a844864 100644 --- a/src/mtp3_hmdt.c +++ b/src/mtp3_hmdt.c @@ -23,14 +23,124 @@ * */ +#include <osmocom/core/logging.h> + #include <osmocom/sigtran/protocol/m3ua.h> +#include <osmocom/sigtran/protocol/sua.h> +#include <osmocom/sigtran/osmo_ss7.h> #include <osmocom/sigtran/mtp_sap.h> +#include "ss7_as.h" #include "ss7_instance.h" +#include "ss7_internal.h" +#include "ss7_route.h" +#include "ss7_route_table.h" #include "ss7_user.h" #include "xua_internal.h" #include "xua_msg.h" +/* Generate a DUPU message to be sent back to originator. */ +static struct xua_msg *gen_dupu_ret_msg(enum osmo_ss7_asp_protocol proto, uint8_t user_part, const struct xua_msg *orig_xua) +{ + struct xua_msg *xua; + struct xua_msg_part *rctx_ie; + unsigned int num_rctx = 0; + uint32_t rctx = 0; + const char *info_str = "(Local) User Part Unavailable"; + const uint16_t cause = MTP_UNAVAIL_C_UNKNOWN; + + switch (proto) { + case OSMO_SS7_ASP_PROT_M3UA: + if ((rctx_ie = xua_msg_find_tag(orig_xua, M3UA_IEI_ROUTE_CTX))) { + rctx = xua_msg_part_get_u32(rctx_ie); + num_rctx = 1; + } + xua = m3ua_encode_dupu(&rctx, num_rctx, orig_xua->mtp.dpc, user_part, cause, info_str); + break; + case OSMO_SS7_ASP_PROT_SUA: + if ((rctx_ie = xua_msg_find_tag(orig_xua, SUA_IEI_ROUTE_CTX))) { + rctx = xua_msg_part_get_u32(rctx_ie); + num_rctx = 1; + } + xua = sua_encode_dupu(&rctx, num_rctx, orig_xua->mtp.dpc, user_part, cause, info_str); + break; + default: + OSMO_ASSERT(0); + } + OSMO_ASSERT(xua); + + xua->mtp = orig_xua->mtp; + xua->mtp.opc = orig_xua->mtp.dpc; + xua->mtp.dpc = orig_xua->mtp.opc; + return xua; +} + +/* ITU Q.704 Figure 25/Q.704 (sheet 2 of 3) "User Part Unavailable HMDT -> HMRT" + * See also ITU Q.704 2.4.2 */ +static int mtp3_hmdt_rx_msg_for_local_unavailable_part(struct osmo_ss7_instance *inst, uint8_t user_part, const struct xua_msg *orig_xua) +{ + struct xua_msg *xua; + char buf_orig_opc[MAX_PC_STR_LEN]; + char buf_orig_dpc[MAX_PC_STR_LEN]; + struct osmo_ss7_route_label rtlabel; + struct osmo_ss7_route *rt; + + if (osmo_ss7_pc_is_local(inst, orig_xua->mtp.opc)) { + /* This shouldn't happen, if a MTP3 User sends data down the + * stack it should also be there to receive it back and hence we + * shouldn't have entered this step... */ + LOGSS7(inst, LOGL_ERROR, "Rx xUA message from local PC and unavailable part!\n"); + return -1; + } + + /* We should only be sending DUPU to M3UA peers, hence why we don't + * simply call mtp3_hmrt_message_for_routing() here. */ + rtlabel = (struct osmo_ss7_route_label){ + .opc = orig_xua->mtp.dpc, + .dpc = orig_xua->mtp.opc, + .sls = orig_xua->mtp.sls, + }; + rt = ss7_instance_lookup_route(inst, &rtlabel); + if (!rt) { + LOGSS7(inst, LOGL_NOTICE, "Tx DUPU %u=%s User %u=%s to concerned SP %u=%s: no route!\n", + orig_xua->mtp.dpc, osmo_ss7_pointcode_print_buf(buf_orig_dpc, sizeof(buf_orig_dpc), inst, orig_xua->mtp.dpc), + user_part, get_value_string(mtp_si_vals, user_part), + orig_xua->mtp.opc, osmo_ss7_pointcode_print_buf(buf_orig_opc, sizeof(buf_orig_opc), inst, orig_xua->mtp.opc)); + return 0; + } + if (!rt->dest.as) { + LOGSS7(inst, LOGL_ERROR, "Tx DUPU %u=%s User %u=%s to concerned SP %u=%s: unsupported for linkset!\n", + orig_xua->mtp.dpc, osmo_ss7_pointcode_print_buf(buf_orig_dpc, sizeof(buf_orig_dpc), inst, orig_xua->mtp.dpc), + user_part, get_value_string(mtp_si_vals, user_part), + orig_xua->mtp.opc, osmo_ss7_pointcode_print_buf(buf_orig_opc, sizeof(buf_orig_opc), inst, orig_xua->mtp.opc)); + return 0; + } + + switch (rt->dest.as->cfg.proto) { + case OSMO_SS7_ASP_PROT_M3UA: + case OSMO_SS7_ASP_PROT_SUA: + LOGSS7(inst, LOGL_INFO, "Message received for unavailable SP %u=%s User %u=%s. Tx DUPU to concerned SP %u=%s\n", + orig_xua->mtp.dpc, osmo_ss7_pointcode_print_buf(buf_orig_dpc, sizeof(buf_orig_dpc), inst, orig_xua->mtp.dpc), + user_part, get_value_string(mtp_si_vals, user_part), + orig_xua->mtp.opc, osmo_ss7_pointcode_print_buf(buf_orig_opc, sizeof(buf_orig_opc), inst, orig_xua->mtp.opc)); + xua = gen_dupu_ret_msg(rt->dest.as->cfg.proto, user_part, orig_xua); + return m3ua_tx_xua_as(rt->dest.as, xua); + case OSMO_SS7_ASP_PROT_IPA: + /* FIXME: No DUPU in IPA, maybe send SUA CLDR (SCCP UDTS) instead? (see send_back_udts()) */ + LOGSS7(inst, LOGL_INFO, "Message received for unavailable SP %u=%s User %u=%s, " + "but concerned SP %u=%s is IPA-based and doesn't support DUPU\n", + orig_xua->mtp.dpc, osmo_ss7_pointcode_print_buf(buf_orig_dpc, sizeof(buf_orig_dpc), inst, orig_xua->mtp.dpc), + user_part, get_value_string(mtp_si_vals, user_part), + orig_xua->mtp.opc, osmo_ss7_pointcode_print_buf(buf_orig_opc, sizeof(buf_orig_opc), inst, orig_xua->mtp.opc)); + return 0; + default: + LOGSS7(inst, LOGL_ERROR, "DUPU message for ASP of unknown protocol %u\n", + rt->dest.as->cfg.proto); + return 0; + } + + return 0; +} /* convert from M3UA message to MTP-TRANSFER.ind osmo_mtp_prim */ static struct osmo_mtp_prim *m3ua_to_xfer_ind(struct xua_msg *xua) @@ -86,6 +196,7 @@ struct m3ua_data_hdr *mdh; const struct osmo_ss7_user *osu; uint32_t service_ind; + int rc; switch (xua->hdr.msg_class) { case M3UA_MSGC_XFER: @@ -116,9 +227,10 @@ if (!osu) { /* "Discard Message" */ LOGSS7(inst, LOGL_NOTICE, "No MTP-User for SI %u\n", service_ind); - /* FIXME: User Part Unavailable HMDT -> HMRT */ + /* User Part Unavailable HMDT -> HMRT */ + rc = mtp3_hmdt_rx_msg_for_local_unavailable_part(inst, service_ind, xua); xua_msg_free(xua); - return -1; + return rc; } /* "MTP Transfer indication HMDT→L4" */ diff --git a/src/sua.c b/src/sua.c index e81590d..eccecdd 100644 --- a/src/sua.c +++ b/src/sua.c @@ -886,9 +886,9 @@ } /* 3.4.5 Destination User Part Unavailable (DUPU) */ -static struct xua_msg *sua_encode_dupu(const uint32_t *rctx, unsigned int num_rctx, - uint32_t dpc, uint16_t user, uint16_t cause, - const char *info_string) +struct xua_msg *sua_encode_dupu(const uint32_t *rctx, unsigned int num_rctx, + uint32_t dpc, uint16_t user, uint16_t cause, + const char *info_string) { struct xua_msg *xua = xua_msg_alloc(); uint32_t user_cause = (user << 16) | cause; diff --git a/src/xua_internal.h b/src/xua_internal.h index 8674ef5..c5bd009 100644 --- a/src/xua_internal.h +++ b/src/xua_internal.h @@ -37,6 +37,10 @@ void sua_tx_dupu(struct osmo_ss7_asp *asp, const uint32_t *rctx, unsigned int num_rctx, uint32_t dpc, uint16_t user, uint16_t cause, const char *info_str); +struct xua_msg *sua_encode_dupu(const uint32_t *rctx, unsigned int num_rctx, + uint32_t dpc, uint16_t user, uint16_t cause, + const char *info_string); + struct xua_msg *sua_gen_cldr(const struct xua_msg *xua_in, uint32_t route_ctx, uint32_t ret_cause); struct msgb *m3ua_to_msg(struct xua_msg *xua); @@ -56,6 +60,9 @@ struct xua_msg *m3ua_encode_duna(const uint32_t *rctx, unsigned int num_rctx, const uint32_t *aff_pc, unsigned int num_aff_pc, const char *info_string); +struct xua_msg *m3ua_encode_dupu(const uint32_t *rctx, unsigned int num_rctx, + uint32_t dpc, uint16_t user, uint16_t cause, + const char *info_string); void xua_tx_snm_available(struct osmo_ss7_asp *asp, const uint32_t *rctx, unsigned int num_rctx, const uint32_t *aff_pc, unsigned int num_aff_pc, -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41949?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Iab2ffc3a86243d5eeedcc4fd3d558796ede9afc3 Gerrit-Change-Number: 41949 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: xua: Implement User Part Unavailable HMDT -> HMRT
by pespin 27 Jan '26

27 Jan '26

Attention is currently required from: daniel, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41949?usp=email ) Change subject: xua: Implement User Part Unavailable HMDT -> HMRT ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41949?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Iab2ffc3a86243d5eeedcc4fd3d558796ede9afc3 Gerrit-Change-Number: 41949 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jan 2026 21:13:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmocore[master]: logging: Make struct log_context and struct log_target private
by pespin 27 Jan '26

27 Jan '26

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41891?usp=email ) Change subject: logging: Make struct log_context and struct log_target private ...................................................................... Patch Set 9: (1 comment) Patchset: PS1: > As you all know, I'm rather opposed to breaking API compatibility. […] @laforge@gnumonks.org Yes, I think I already listed them in a comment here. I already fixed all the users, it was almost 100% 4-5 users of the logging filters feature, which have been converted to use the new APIs which were merged a few days ago. All those patches are merged so afaict there are no active users of the struct field. This commit itself doesn't break the ABI in the sense that it's not really changing the structure itself, though it becomes private and hence may be changed in the future (future=next patch ;) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41891?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iecbd07995ccb465a44be0debcc97458b2b240a0e Gerrit-Change-Number: 41891 Gerrit-PatchSet: 9 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jan 2026 21:12:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: remove references to define EMBEDDED in public headers
by pespin 27 Jan '26

27 Jan '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/41932?usp=email ) Change subject: remove references to define EMBEDDED in public headers ...................................................................... remove references to define EMBEDDED in public headers It's not a good idea to base opt-in/out of code in public headers based on some specific non-standard define being set at compile time when calling the compiler. Get rid of those references; Now that osmocom/core/socket.h can be included thanks to improved osmocom/core/socket_compat.h, it shouldn't be a problem. Change-Id: I7a657d67077dfbe861959c6123eb9163bc791694 --- M include/osmocom/core/netdev.h M include/osmocom/core/tun.h M include/osmocom/gsm/gsup.h 3 files changed, 0 insertions(+), 8 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve diff --git a/include/osmocom/core/netdev.h b/include/osmocom/core/netdev.h index fb0f124..4d505fe 100644 --- a/include/osmocom/core/netdev.h +++ b/include/osmocom/core/netdev.h @@ -2,7 +2,6 @@ * network device (interface) convenience functions. */ #pragma once -#if (!EMBEDDED) #include <stddef.h> #include <stdint.h> @@ -47,5 +46,4 @@ uint8_t dst_prefixlen, const struct osmo_sockaddr *gw_addr); int osmo_netdev_ifupdown(struct osmo_netdev *netdev, bool ifupdown); -#endif /* (!EMBEDDED) */ /*! @} */ diff --git a/include/osmocom/core/tun.h b/include/osmocom/core/tun.h index 21e7703..1351d04 100644 --- a/include/osmocom/core/tun.h +++ b/include/osmocom/core/tun.h @@ -2,7 +2,6 @@ * tunnel network device convenience functions. */ #pragma once -#if (!EMBEDDED) #include <stddef.h> #include <stdint.h> @@ -40,6 +39,4 @@ struct osmo_netdev *osmo_tundev_get_netdev(struct osmo_tundev *tundev); int osmo_tundev_send(struct osmo_tundev *tundev, struct msgb *msg); - -#endif /* (!EMBEDDED) */ /*! @} */ diff --git a/include/osmocom/gsm/gsup.h b/include/osmocom/gsm/gsup.h index 6ad72d2..3ef03a9 100644 --- a/include/osmocom/gsm/gsup.h +++ b/include/osmocom/gsm/gsup.h @@ -37,7 +37,6 @@ * */ #pragma once -#if (!EMBEDDED) #include <stdint.h> #include <osmocom/core/msgb.h> @@ -421,6 +420,4 @@ int osmo_gsup_encode(struct msgb *msg, const struct osmo_gsup_message *gsup_msg); int osmo_gsup_get_err_msg_type(enum osmo_gsup_message_type type_in) OSMO_DEPRECATED("Use OSMO_GSUP_TO_MSGT_ERROR() instead"); - -#endif /* (!EMBEDDED) */ /*! @} */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41932?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7a657d67077dfbe861959c6123eb9163bc791694 Gerrit-Change-Number: 41932 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmocore[master]: socket_compat.h improvements to always have struct osmo_sockaddr avai...
by pespin 27 Jan '26

27 Jan '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/41931?usp=email ) Change subject: socket_compat.h improvements to always have struct osmo_sockaddr available ...................................................................... socket_compat.h improvements to always have struct osmo_sockaddr available Having a #if (!EMBEDDED) based on compiler defined variable is not a good idea. Instead, add minimal sys/socket.h and netient/in.h to always have the definition of struct osmo_sockaddr available. Change-Id: I5b10e09770727c72812af15360ab3385b957509b --- M configure.ac M include/osmocom/core/Makefile.am M include/osmocom/core/socket.h M include/osmocom/core/socket_compat.h.tpl 4 files changed, 73 insertions(+), 15 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/configure.ac b/configure.ac index 7cb8727..ee779ea 100644 --- a/configure.ac +++ b/configure.ac @@ -75,6 +75,7 @@ dnl checks for header files AC_HEADER_STDC AC_CHECK_HEADERS(arpa/inet.h execinfo.h poll.h sys/select.h sys/socket.h sys/signalfd.h sys/eventfd.h sys/timerfd.h ctype.h netinet/tcp.h netinet/in.h) +AC_CHECK_DECL(HAVE_NETINET_IN_H, AC_SUBST(HAVE_NETINET_IN_H, 1), AC_SUBST(HAVE_NETINET_IN_H, 0)) AC_CHECK_DECL(HAVE_SYS_SOCKET_H, AC_SUBST(HAVE_SYS_SOCKET_H, 1), AC_SUBST(HAVE_SYS_SOCKET_H, 0)) # for src/conv.c AC_FUNC_ALLOCA diff --git a/include/osmocom/core/Makefile.am b/include/osmocom/core/Makefile.am index 9a949ae..18ee283 100644 --- a/include/osmocom/core/Makefile.am +++ b/include/osmocom/core/Makefile.am @@ -100,7 +100,9 @@ socket_compat.h: socket_compat.h.tpl $(AM_V_GEN)$(MKDIR_P) $(dir $@) - $(AM_V_GEN)sed -e's/XX/$(HAVE_SYS_SOCKET_H)/g' $< > $@ + $(AM_V_GEN)sed -e's/__LIBOSMOCORE_HAVE_SYS_SOCKET_H XX/__LIBOSMOCORE_HAVE_SYS_SOCKET_H $(HAVE_SYS_SOCKET_H)/g' \ + -e's/__LIBOSMOCORE_HAVE_NETINET_IN_H XX/__LIBOSMOCORE_HAVE_NETINET_IN_H $(HAVE_NETINET_IN_H)/g' \ + $< > $@ version.h: version.h.tpl $(AM_V_GEN)$(MKDIR_P) $(dir $@) diff --git a/include/osmocom/core/socket.h b/include/osmocom/core/socket.h index 845efd7..726e0d5 100644 --- a/include/osmocom/core/socket.h +++ b/include/osmocom/core/socket.h @@ -2,7 +2,6 @@ * Osmocom socket convenience functions. */ #pragma once -#if (!EMBEDDED) /*! \defgroup socket Socket convenience functions * @{ @@ -12,9 +11,8 @@ #include <stdbool.h> #include <stddef.h> -#include <netinet/in.h> - #include <osmocom/core/defs.h> +#include <osmocom/core/socket_compat.h> /*! maximum number of local or remote addresses supported by an osmo_sock instance */ #define OSMO_SOCK_MAX_ADDRS 32 @@ -29,9 +27,6 @@ /*! maximum length of a multia-address socket name ("r=(::2|1.2.3.4):123<->l=(5.6.7.8|::9):987") */ #define OSMO_SOCK_MULTIADDR_NAME_MAXLEN (OSMO_SOCK_MULTIADDR_PEER_STR_MAXLEN + 7) - -struct sockaddr_in; -struct sockaddr; struct osmo_fd; struct sctp_paddrinfo; @@ -59,7 +54,7 @@ { if (!addr) return 0; - +#if __LIBOSMOCORE_HAVE_SYS_SOCKET_H switch (addr->u.sa.sa_family) { case AF_INET: return sizeof(struct sockaddr_in); @@ -68,6 +63,9 @@ default: return sizeof(struct osmo_sockaddr); } +#else + return 0; +#endif /* if __LIBOSMOCORE_HAVE_SYS_SOCKET_H */ } unsigned int osmo_sockaddr_to_str_and_uint(char *addr, unsigned int addr_len, uint16_t *port, @@ -224,5 +222,4 @@ int osmo_sock_sctp_get_peer_addr_info(int fd, struct sctp_paddrinfo *pinfo, size_t *pinfo_cnt); -#endif /* (!EMBEDDED) */ /*! @} */ diff --git a/include/osmocom/core/socket_compat.h.tpl b/include/osmocom/core/socket_compat.h.tpl index 43bee9e..4254d68 100644 --- a/include/osmocom/core/socket_compat.h.tpl +++ b/include/osmocom/core/socket_compat.h.tpl @@ -1,10 +1,68 @@ -#define HAVE_STRUCT_SOCKADDR_STORAGE XX +#define __LIBOSMOCORE_HAVE_SYS_SOCKET_H XX +#define __LIBOSMOCORE_HAVE_NETINET_IN_H XX -#if HAVE_STRUCT_SOCKADDR_STORAGE +#if __LIBOSMOCORE_HAVE_SYS_SOCKET_H #include <sys/socket.h> #else -struct sockaddr_storage { - unsigned short ss_family; - char __data[128 - sizeof(unsigned short)]; +/* Minimal netinet/in.h as per POSIX https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sys_socket.h.html */ +#include <stdint.h> +typedef uint32_t socklen_t; +typedef unsigned short sa_family_t; + +struct sockaddr { + sa_family_t sa_family; + char sa_data[14]; }; -#endif + +struct sockaddr_storage { + sa_family_t ss_family; + char __data[128 - sizeof(sa_family_t)]; +}; +#endif /* if __LIBOSMOCORE_HAVE_SYS_SOCKET_H */ + +#if __LIBOSMOCORE_HAVE_NETINET_IN_H + #include <netinet/in.h> +#else +/* Minimal netinet/in.h as per POSIX https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/netinet_in.h.html */ +#include <stdint.h> + +typedef uint32_t in_addr_t; +struct in_addr { + in_addr_t s_addr; +}; + +typedef uint16_t in_port_t; + +struct in6_addr { + union { + uint8_t __u6_addr8[16]; + uint16_t __u6_addr16[8]; + uint32_t __u6_addr32[4]; + } __in6_u; + #define s6_addr __in6_u.__u6_addr8 + #define s6_addr16 __in6_u.__u6_addr16 + #define s6_addr32 __in6_u.__u6_addr32 +}; + +#define INET_ADDRSTRLEN 16 +#define INET6_ADDRSTRLEN 46 + +struct sockaddr_in { + sa_family_t sin_family; + in_port_t sin_port; + struct in_addr sin_addr; + unsigned char sin_zero[sizeof (struct sockaddr) + - sizeof (sa_family_t) + - sizeof (in_port_t) + - sizeof (struct in_addr)]; +}; + +struct sockaddr_in6 { + sa_family_t sin6_family; + in_port_t sin6_port; + uint32_t sin6_flowinfo; + struct in6_addr sin6_addr; + uint32_t sin6_scope_id; +}; + +#endif /* if __LIBOSMOCORE_HAVE_NETINET_IN_H */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41931?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5b10e09770727c72812af15360ab3385b957509b Gerrit-Change-Number: 41931 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log January 2026