January 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ttcn3-hacks[master]: bts: TC_pcu_{rts_req,time_ind}: Relax expectancies on rx primitive count
by pespin 08 Jan '26

08 Jan '26

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41783?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: bts: TC_pcu_{rts_req,time_ind}: Relax expectancies on rx primitive count ...................................................................... bts: TC_pcu_{rts_req,time_ind}: Relax expectancies on rx primitive count Even with latest changes I can still sometimes run into up to 6 FNs less than the currently minimum expected. That's usually 1-2 primitives less, which in the number of >100 we are receiving over 5 seconds, seems like a plausible drift. Change-Id: I887bd80a90e3ef8142cc29acde2ac9a3ea4869d6 --- M bts/BTS_Tests.ttcn 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/83/41783/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41783?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I887bd80a90e3ef8142cc29acde2ac9a3ea4869d6 Gerrit-Change-Number: 41783 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[XS] Change in osmo-ttcn3-hacks[master]: bts: TC_pcu_{rts_req,time_ind}: Relax expectancies on rx primitive count
by pespin 08 Jan '26

08 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41783?usp=email ) Change subject: bts: TC_pcu_{rts_req,time_ind}: Relax expectancies on rx primitive count ...................................................................... bts: TC_pcu_{rts_req,time_ind}: Relax expectancies on rx primitive count Even with latest changes I can still sometimes run into up to 6 FNs less than the currently minimum expected. That's usually 1-2 primitives less, which in the number of >1000 we are receiving over 5 seconds, seems like a plausible drift. Change-Id: I887bd80a90e3ef8142cc29acde2ac9a3ea4869d6 --- M bts/BTS_Tests.ttcn 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/83/41783/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index bf59eb8..b43706c 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -6101,7 +6101,7 @@ /* verify the number of frames expired matches our expectation */ const float c_GSM_FN_DURATION_MS := 4.61538; var float fn_expected := test_duration * 1000.0 / c_GSM_FN_DURATION_MS; - var template integer t_fn_expected := f_tolerance(float2int(fn_expected), 1, 100000, 20); + var template integer t_fn_expected := f_tolerance(float2int(fn_expected), 1, 100000, 30); if (not match(fn_expired, t_fn_expected)) { setverdict(fail, "Number of TDMA Frames (", fn_expired, ") not matching ", t_fn_expected); } @@ -6135,6 +6135,7 @@ T.start(test_duration); alt { [] as_pcuif_msg(msg, tr_PCUIF_RTS_REQ(0, 0, 7, PCU_IF_SAPI_PDTCH, ?, ?)) { + log("PESPIN: Rx PDTCH ", msg.u.rts_req.fn); num_rts_pdtch := num_rts_pdtch + 1; if (isbound(pdtch_first_fn)) { var integer exp_fn := f_next_pdtch_block(pdtch_last_fn); @@ -6151,6 +6152,7 @@ repeat; } [] as_pcuif_msg(msg, tr_PCUIF_RTS_REQ(0, 0, 7, PCU_IF_SAPI_PTCCH, ?, ?)) { + log("PESPIN: Rx PTCCH ", msg.u.rts_req.fn); num_rts_ptcch := num_rts_ptcch + 1; if (isbound(ptcch_first_fn)) { var integer exp_fn := f_next_ptcch_dl_block(ptcch_last_fn); @@ -6189,7 +6191,7 @@ /* verify the number of frames expired matches our expectation */ const float c_GSM_FN_DURATION_MS := 4.61538; var float fn_expected := test_duration * 1000.0 / c_GSM_FN_DURATION_MS; - var template integer t_fn_expected := f_tolerance(float2int(fn_expected), 1, 100000, 20); + var template integer t_fn_expected := f_tolerance(float2int(fn_expected), 1, 100000, 30); if (not match(fn_expired, t_fn_expected)) { setverdict(fail, "Number of TDMA Frames (", fn_expired, ") not matching ", t_fn_expected); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41783?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I887bd80a90e3ef8142cc29acde2ac9a3ea4869d6 Gerrit-Change-Number: 41783 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts: TC_pcu_{rts_req,time_ind}: process FNs in port queue after time out
by pespin 08 Jan '26

08 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41782?usp=email ) Change subject: bts: TC_pcu_{rts_req,time_ind}: process FNs in port queue after time out ...................................................................... bts: TC_pcu_{rts_req,time_ind}: process FNs in port queue after time out Since we sometimes run short on counted FNs, but we validate that there were no FN gaps, it means we are simply late counting the generated RTS.req from IUT. Let's try to get a more accurate count by trying to process RTS.req in the port queue after the timeframe of the test finishes. In the end, we want to count the RTS.req transmitted by the IUT, not the ones we can receive in time. Change-Id: Iacd4eafbdb42207465ac0c5e03492c460280ecf7 --- M bts/BTS_Tests.ttcn 1 file changed, 20 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/82/41782/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 592e58f..bf59eb8 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -6062,6 +6062,7 @@ var float test_duration := 5.0; var PCUIF_Message msg; timer T; + timer Tcountremaining; f_init_with_pcuif(); f_TC_pcu_act_req(0, 0, 7, true); @@ -6084,7 +6085,15 @@ [] PCU.receive { repeat; } - [] T.timeout {} + [] T.timeout { + /* Disable new incoming elements; but current queue elements are still processed. + * This way we get a more accurate count of TIME_IND submitted by IUT during the specified time. */ + PCU.halt; + log("Finish processing remaining queued messages"); + Tcountremaining.start(1.0); + repeat; + } + [] Tcountremaining.timeout { } } var integer fn_expired := last_fn - first_fn; log(fn_expired, " fn expired with ", num_time_ind, " PCU_TIME.ind"); @@ -6117,6 +6126,7 @@ var float test_duration := 5.0; var PCUIF_Message msg; timer T; + timer Tcountremaining; f_init_with_pcuif(); f_TC_pcu_act_req(0, 0, 7, true); @@ -6163,7 +6173,15 @@ [] PCU.receive { repeat; } - [] T.timeout {} + [] T.timeout { + /* Disable new incoming elements; but current queue elements are still processed. + * This way we get a more accurate count of RTS.req submitted by IUT during the specified time. */ + PCU.halt; + log("Finish processing remaining queued messages"); + Tcountremaining.start(1.0); + repeat; + } + [] Tcountremaining.timeout { } } var integer fn_expired := f_max(pdtch_last_fn, ptcch_last_fn) - f_min(pdtch_first_fn, ptcch_first_fn); log(fn_expired, " fn expired with num_rts_pdtch=", num_rts_pdtch, ", num_rts_ptcch=", num_rts_ptcch); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41782?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iacd4eafbdb42207465ac0c5e03492c460280ecf7 Gerrit-Change-Number: 41782 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: Move function to calculate next PDTCH block FN to library
by pespin 08 Jan '26

08 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41780?usp=email ) Change subject: Move function to calculate next PDTCH block FN to library ...................................................................... Move function to calculate next PDTCH block FN to library It will be used in a follow-up patch to validate RTS.req in BTS_Tests testsuite. Take the chance to rename the function since it actually calculates PDTCH blocks. Change-Id: I49289029c89367c8c6a5db7fafda099748ec15b6 --- M library/GSM_Types.ttcn M pcu/GPRS_Components.ttcn M pcu/PCU_Tests.ttcn 3 files changed, 20 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/80/41780/1 diff --git a/library/GSM_Types.ttcn b/library/GSM_Types.ttcn index 6d3e170..8333e58 100644 --- a/library/GSM_Types.ttcn +++ b/library/GSM_Types.ttcn @@ -535,5 +535,16 @@ /* TS 24.008 10.5.1.1 */ type uint16_t CellIdentity; +/* 3GPP TS 45.002 Table 6 */ +private function fn2bn(GsmFrameNumber fn) return uint32_t { + return (fn mod 52) / 4; +} +function f_next_pdtch_block(GsmFrameNumber fn) return GsmFrameNumber +{ + var uint32_t bn := fn2bn(fn) + 1; + fn := fn - (fn mod 52); + fn := fn + bn * 4 + bn / 3; + return fn mod GsmMaxFrameNumber; +} } with { encode "RAW"; variant "FIELDORDER(msb)" } diff --git a/pcu/GPRS_Components.ttcn b/pcu/GPRS_Components.ttcn index c48497a..50b552d 100644 --- a/pcu/GPRS_Components.ttcn +++ b/pcu/GPRS_Components.ttcn @@ -242,17 +242,6 @@ return 51 * ((st.t3 - st.t2) mod 26) + st.t3 + 51 * 26 * st.t1; } -function fn2bn(GsmFrameNumber fn) return uint32_t { - return (fn mod 52) / 4; -} -function f_next_pdch_block(GsmFrameNumber fn) return GsmFrameNumber -{ - var uint32_t bn := fn2bn(fn) + 1; - fn := fn - (fn mod 52); - fn := fn + bn * 4 + bn / 3; - return fn mod GsmMaxFrameNumber; -} - function f_ultbf_new_from_rr_imm_ass(in GsmRrMessage rr_imm_ass) runs on MS_BTS_IFACE_CT return UlTbf { var UlTbf ul_tbf := valueof(t_UlTbf_def); diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index 23709dc..98fbbf6 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -1433,7 +1433,7 @@ if (rx_usf == ms.ul_tbf.usf[valueof(nr.ts_nr)]) { /* PCU requests our USF, transmit WITHOUT tlli to avoid contention resolution success */ ul_tbf_usf_req := true; - f_ms_tx_ul_data_block(ms, f_rnd_octstring(10), cv := 15, with_tlli := false, fn := f_next_pdch_block(data_msg.raw.fn)) + f_ms_tx_ul_data_block(ms, f_rnd_octstring(10), cv := 15, with_tlli := false, fn := f_next_pdtch_block(data_msg.raw.fn)) } else if (rx_usf == USF_UNUSED) { if (data_msg.raw.fn >= ms.ul_tbf.start_time_fn) { if (ul_tbf_usf_req) { @@ -2240,7 +2240,7 @@ /* Wait until PCU starts requesting for UL block on this TBF: */ dl_fn := f_ms_wait_usf(ms, nr := f_ms_tx_TsTrxBtsNum(ms)); - sched_fn := f_next_pdch_block(dl_fn); + sched_fn := f_next_pdtch_block(dl_fn); /* Send one UL block (with TLLI since we are in One-Phase Access * contention resolution) and make sure it is ACKED fine. */ @@ -3448,7 +3448,7 @@ /* Wait until PCU starts requesting for UL block on this TBF: */ dl_fn := f_ms_wait_usf(ms, nr := f_ms_tx_TsTrxBtsNum(ms)); - sched_fn := f_next_pdch_block(dl_fn); + sched_fn := f_next_pdtch_block(dl_fn); /* Send one UL block (with TLLI since we are in One-Phase Access contention resolution) and make sure it is ACKED fine */ @@ -3514,7 +3514,7 @@ /* Wait until PCU starts requesting for UL block on this TBF: */ dl_fn := f_ms_wait_usf(ms, nr := f_ms_tx_TsTrxBtsNum(ms)); - sched_fn := f_next_pdch_block(dl_fn); + sched_fn := f_next_pdtch_block(dl_fn); /* Send one UL block (with TLLI since we are in One-Phase Access * contention resolution) and make sure it is ACKED fine. */ @@ -3929,7 +3929,7 @@ /* Wait until PCU starts requesting for UL block on this TBF: */ dl_fn := f_ms_wait_usf(ms); - sched_fn := f_next_pdch_block(dl_fn); + sched_fn := f_next_pdtch_block(dl_fn); /* Send one UL block (with TLLI since we are in One-Phase Access contention resolution) and make sure it is ACKED fine. */ @@ -4459,7 +4459,7 @@ contention resolution) and make sure it is ACKED fine. */ payload := f_rnd_octstring(f_ultbf_payload_fill_length(ms.ul_tbf, true)); dl_fn := f_rx_rlcmac_dl_block_exp_dummy(dl_block); - f_ms_tx_ul_data_block(ms, payload, cv := 1, with_tlli := true, fn := f_next_pdch_block(dl_fn)); + f_ms_tx_ul_data_block(ms, payload, cv := 1, with_tlli := true, fn := f_next_pdtch_block(dl_fn)); f_rx_rlcmac_dl_block_exp_ack_nack(dl_block, sched_fn); payload := f_rnd_octstring(f_ultbf_payload_fill_length(ms.ul_tbf, false)); @@ -4528,7 +4528,7 @@ contention resolution) and make sure it is ACKED fine. */ payload := f_rnd_octstring(f_ultbf_payload_fill_length(ms.ul_tbf, true)); dl_fn := f_rx_rlcmac_dl_block_exp_dummy(dl_block); - f_ms_tx_ul_data_block(ms, payload, cv := 1, with_tlli := true, fn := f_next_pdch_block(dl_fn)); + f_ms_tx_ul_data_block(ms, payload, cv := 1, with_tlli := true, fn := f_next_pdtch_block(dl_fn)); f_rx_rlcmac_dl_block_exp_ack_nack(dl_block, sched_fn); payload := f_rnd_octstring(f_ultbf_payload_fill_length(ms.ul_tbf, false)); @@ -4554,7 +4554,7 @@ /* Send one UL block (with TLLI since we are in One-Phase Access * contention resolution) and make sure it is ACKED fine. */ payload := f_rnd_octstring(f_ultbf_payload_fill_length(ms.ul_tbf, true)); - f_ms_tx_ul_data_block(ms, payload, cv := 1, with_tlli := true, fn := f_next_pdch_block(dl_fn)); + f_ms_tx_ul_data_block(ms, payload, cv := 1, with_tlli := true, fn := f_next_pdtch_block(dl_fn)); /* UL ACK/NACK sets poll+rrbp requesting PACKET CONTROL ACK */ f_rx_rlcmac_dl_block_exp_ack_nack(dl_block, sched_fn); @@ -4608,7 +4608,7 @@ contention resolution) and make sure it is ACKED fine. */ payload := f_rnd_octstring(f_ultbf_payload_fill_length(ms.ul_tbf, true)); dl_fn := f_rx_rlcmac_dl_block_exp_dummy(dl_block); - f_ms_tx_ul_data_block(ms, payload, cv := 1, with_tlli := true, fn := f_next_pdch_block(dl_fn)); + f_ms_tx_ul_data_block(ms, payload, cv := 1, with_tlli := true, fn := f_next_pdtch_block(dl_fn)); f_rx_rlcmac_dl_block_exp_ack_nack(dl_block, sched_fn); payload := f_rnd_octstring(f_ultbf_payload_fill_length(ms.ul_tbf, false)); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41780?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I49289029c89367c8c6a5db7fafda099748ec15b6 Gerrit-Change-Number: 41780 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: bts: Validate no PDTCH/PTCCH block gaps in TC_pcu_rts_req
by pespin 08 Jan '26

08 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41781?usp=email ) Change subject: bts: Validate no PDTCH/PTCCH block gaps in TC_pcu_rts_req ...................................................................... bts: Validate no PDTCH/PTCCH block gaps in TC_pcu_rts_req Change-Id: I0bf3540523c231ed7172cab720163816d5d81e26 --- M bts/BTS_Tests.ttcn M library/GSM_Types.ttcn 2 files changed, 40 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/81/41781/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 7bac7ee..592e58f 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -6110,7 +6110,8 @@ /* test for periodic RTS_REQ; check number of FN expired and number of RTS_IND per SAPI */ testcase TC_pcu_rts_req() runs on test_CT { - var integer first_fn, last_fn; + var integer pdtch_first_fn, pdtch_last_fn; + var integer ptcch_first_fn, ptcch_last_fn; var integer num_rts_pdtch := 0; var integer num_rts_ptcch := 0; var float test_duration := 5.0; @@ -6125,18 +6126,34 @@ alt { [] as_pcuif_msg(msg, tr_PCUIF_RTS_REQ(0, 0, 7, PCU_IF_SAPI_PDTCH, ?, ?)) { num_rts_pdtch := num_rts_pdtch + 1; - if (not isbound(first_fn)) { - first_fn := msg.u.rts_req.fn; + if (isbound(pdtch_first_fn)) { + var integer exp_fn := f_next_pdtch_block(pdtch_last_fn); + if (msg.u.rts_req.fn != exp_fn) { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Rx RTS.req for PDTCH FN ", msg.u.rts_req.fn, + " vs exp ", exp_fn, " (last_fn " , pdtch_last_fn, ")")); + } + pdtch_last_fn := msg.u.rts_req.fn; + } else { + pdtch_first_fn := msg.u.rts_req.fn; + pdtch_last_fn := msg.u.rts_req.fn; } - last_fn := msg.u.rts_req.fn; repeat; } [] as_pcuif_msg(msg, tr_PCUIF_RTS_REQ(0, 0, 7, PCU_IF_SAPI_PTCCH, ?, ?)) { num_rts_ptcch := num_rts_ptcch + 1; - if (not isbound(first_fn)) { - first_fn := msg.u.rts_req.fn; + if (isbound(ptcch_first_fn)) { + var integer exp_fn := f_next_ptcch_dl_block(ptcch_last_fn); + if (msg.u.rts_req.fn != exp_fn) { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Rx RTS.req for PTTCH FN ", msg.u.rts_req.fn, + " vs exp ", exp_fn, " (last_fn " , ptcch_last_fn, ")")); + } + ptcch_last_fn := msg.u.rts_req.fn; + } else { + ptcch_first_fn := msg.u.rts_req.fn; + ptcch_last_fn := msg.u.rts_req.fn; } - last_fn := msg.u.rts_req.fn; repeat; } [] as_pcuif_msg(msg, tr_PCUIF_RTS_REQ) { @@ -6148,9 +6165,8 @@ } [] T.timeout {} } - var integer fn_expired := last_fn - first_fn; - log(fn_expired, " fn expired with num_rts_pdtch=", num_rts_pdtch, - ", num_rts_ptcch=", num_rts_ptcch); + var integer fn_expired := f_max(pdtch_last_fn, ptcch_last_fn) - f_min(pdtch_first_fn, ptcch_first_fn); + log(fn_expired, " fn expired with num_rts_pdtch=", num_rts_pdtch, ", num_rts_ptcch=", num_rts_ptcch); /* verify the number of frames expired matches our expectation */ const float c_GSM_FN_DURATION_MS := 4.61538; @@ -6164,7 +6180,7 @@ var float ptcch_expected := int2float(fn_expired) / 52.0 * 0.5; var template integer t_ptcch_exp := f_tolerance(float2int(ptcch_expected), 1, 100000, 1); if (not match(num_rts_ptcch, t_ptcch_exp)) { - setverdict(fail, "Number of RTS.ind for PTCCH (", num_rts_ptcch, ") not matching ", + setverdict(fail, "Number of RTS.req for PTCCH (", num_rts_ptcch, ") not matching ", t_ptcch_exp); } @@ -6172,7 +6188,7 @@ var float pdtch_expected := int2float(fn_expired) / 52.0 * 12.0; var template integer t_pdtch_exp := f_tolerance(float2int(pdtch_expected), 1, 100000, 2); if (not match(num_rts_pdtch, t_pdtch_exp)) { - setverdict(fail, "Number of RTS.ind for PDTCH (", num_rts_pdtch, ") not matching ", + setverdict(fail, "Number of RTS.req for PDTCH (", num_rts_pdtch, ") not matching ", t_pdtch_exp); } diff --git a/library/GSM_Types.ttcn b/library/GSM_Types.ttcn index 8333e58..b3b6dc9 100644 --- a/library/GSM_Types.ttcn +++ b/library/GSM_Types.ttcn @@ -547,4 +547,16 @@ return fn mod GsmMaxFrameNumber; } +private function ptcch_fn2bn(GsmFrameNumber fn) return uint32_t { + return (fn mod 416) / 104; +} +function f_next_ptcch_dl_block(GsmFrameNumber fn) return GsmFrameNumber +{ + var uint32_t bn := ptcch_fn2bn(fn) + 1; + fn := fn - (fn mod 416); + fn := fn + bn * 104 + 12; + return fn mod GsmMaxFrameNumber; +} + + } with { encode "RAW"; variant "FIELDORDER(msb)" } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41781?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0bf3540523c231ed7172cab720163816d5d81e26 Gerrit-Change-Number: 41781 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: library/NGAP_Templates: PDUSessionResourceSetupRequest: Allow matchin...
by pespin 08 Jan '26

08 Jan '26

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41746?usp=email ) Change subject: library/NGAP_Templates: PDUSessionResourceSetupRequest: Allow matching optional IEs ...................................................................... Patch Set 2: (1 comment) File library/ngap/NGAP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41746/comment/c2cb40eb_2d65… : PS1, Line 150: omit > Because with this type of function construct we don't really support matching against *. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41746?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7a61b4d7a70994e35f2fa5cbadc90f1088b32e64 Gerrit-Change-Number: 41746 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 08 Jan 2026 10:56:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: library/NGAP_Templates: PDUSessionResourceSetupRequest: Allow matchin...
by pespin 08 Jan '26

08 Jan '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41746?usp=email ) Change subject: library/NGAP_Templates: PDUSessionResourceSetupRequest: Allow matching optional IEs ...................................................................... library/NGAP_Templates: PDUSessionResourceSetupRequest: Allow matching optional IEs Change-Id: I7a61b4d7a70994e35f2fa5cbadc90f1088b32e64 --- M library/ngap/NGAP_Templates.ttcn 1 file changed, 79 insertions(+), 28 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve diff --git a/library/ngap/NGAP_Templates.ttcn b/library/ngap/NGAP_Templates.ttcn index 1910120..27a9e33 100644 --- a/library/ngap/NGAP_Templates.ttcn +++ b/library/ngap/NGAP_Templates.ttcn @@ -145,35 +145,86 @@ /** * @see ETSI TS 138 413 V16.12.0 (2023-05) Clause 9.2.1.1 PDU SESSION RESOURCE SETUP REQUEST */ - template (present) InitiatingMessage mw_n2_PDUSessionResourceSetupRequest( - template (present) AMF_UE_NGAP_ID p_amfUeNgapID := ?, - template (present) RAN_UE_NGAP_ID p_ranUeNgapID := ?, - template (present) PDUSessionResourceSetupListSUReq p_pDUSessionResourceSetupListSUReq := ? - ) := { - procedureCode := id_PDUSessionResourceSetup, - criticality := reject, - value_ := { - PDUSessionResourceSetupRequest := { - protocolIEs := { - { - id := id_AMF_UE_NGAP_ID, - criticality := reject, - value_ := { AMF_UE_NGAP_ID := p_amfUeNgapID } - }, - { - id := id_RAN_UE_NGAP_ID, - criticality := reject, - value_ := { RAN_UE_NGAP_ID := p_ranUeNgapID } - }, - { - id := id_PDUSessionResourceSetupListSUReq, - criticality := reject, - value_ := { PDUSessionResourceSetupListSUReq := p_pDUSessionResourceSetupListSUReq } - } - } - } + function f_mw_n2_PDUSessionResourceSetupRequest(template (present) AMF_UE_NGAP_ID p_amfUeNgapID := ?, + template (present) RAN_UE_NGAP_ID p_ranUeNgapID := ?, + template RANPagingPriority p_rANPagingPriority := omit, + template NAS_PDU p_nAS_PDU := omit, + template (present) PDUSessionResourceSetupListSUReq p_pDUSessionResourceSetupListSUReq := ?, + template UEAggregateMaximumBitRate p_uEAggregateMaximumBitRate := omit, + template UESliceMaximumBitRateList p_uESliceMaximumBitRateList := omit + ) return template (present) InitiatingMessage { + + var template (present) InitiatingMessage pdu := { + procedureCode := id_PDUSessionResourceSetup, + criticality := reject, + value_ := { + PDUSessionResourceSetupRequest := { + protocolIEs := { + { + id := id_AMF_UE_NGAP_ID, + criticality := reject, + value_ := { AMF_UE_NGAP_ID := p_amfUeNgapID } + }, + { + id := id_RAN_UE_NGAP_ID, + criticality := reject, + value_ := { RAN_UE_NGAP_ID := p_ranUeNgapID } } - } // End of template mw_n2_PDUSessionResourceSetupRequest + } + } + } + }; + var integer idx := lengthof(pdu.value_.PDUSessionResourceSetupRequest.protocolIEs); + + /* RAN Paging Priority */ + if (not istemplatekind(p_rANPagingPriority, "omit")) { + pdu.value_.PDUSessionResourceSetupRequest.protocolIEs[idx] := { + id := id_RANPagingPriority, + criticality := ignore, + value_ := { RANPagingPriority := p_rANPagingPriority } + }; + idx := idx + 1; + } + + /* NAS-PDU */ + if (not istemplatekind(p_nAS_PDU, "omit")) { + pdu.value_.PDUSessionResourceSetupRequest.protocolIEs[idx] := { + id := id_NAS_PDU, + criticality := reject, + value_ := { NAS_PDU := p_nAS_PDU } + }; + idx := idx + 1; + } + + /* PDU Session Resource Setup Request List */ + pdu.value_.PDUSessionResourceSetupRequest.protocolIEs[idx] := { + id := id_PDUSessionResourceSetupListSUReq, + criticality := reject, + value_ := { PDUSessionResourceSetupListSUReq := p_pDUSessionResourceSetupListSUReq } + }; + idx := idx + 1; + + /* UE Aggregate Maximum Bit Rate */ + if (not istemplatekind(p_uEAggregateMaximumBitRate, "omit")) { + pdu.value_.PDUSessionResourceSetupRequest.protocolIEs[idx] := { + id := id_UEAggregateMaximumBitRate, + criticality := ignore, + value_ := { UEAggregateMaximumBitRate := p_uEAggregateMaximumBitRate } + }; + idx := idx + 1; + } + + /* UE Slice Maximum Bit Rate List */ + if (not istemplatekind(p_uESliceMaximumBitRateList, "omit")) { + pdu.value_.PDUSessionResourceSetupRequest.protocolIEs[idx] := { + id := id_UESliceMaximumBitRateList, + criticality := ignore, + value_ := { UESliceMaximumBitRateList := p_uESliceMaximumBitRateList } + }; + idx := idx + 1; + } + return pdu; + } // End of function f_mw_n2_PDUSessionResourceSetupRequest } // End of group Receive -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41746?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7a61b4d7a70994e35f2fa5cbadc90f1088b32e64 Gerrit-Change-Number: 41746 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: library/NGAP_Templates: PDUSessionResourceSetupRequest: Allow matchin...
by pespin 08 Jan '26

08 Jan '26

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41746?usp=email ) Change subject: library/NGAP_Templates: PDUSessionResourceSetupRequest: Allow matching optional IEs ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41746?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7a61b4d7a70994e35f2fa5cbadc90f1088b32e64 Gerrit-Change-Number: 41746 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 08 Jan 2026 10:53:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in pysim[master]: personalization: make sense of SdKey subclasses
by neels 07 Jan '26

07 Jan '26

neels has abandoned this change. ( https://gerrit.osmocom.org/c/pysim/+/40205?usp=email ) Change subject: personalization: make sense of SdKey subclasses ...................................................................... Abandoned superseded by Ic92ddea6e1fad8167ea75baf78ffc3eb419838c4 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40205?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8c9e6095e200103d2e1779964be06fff63c5cebf Gerrit-Change-Number: 40205 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[S] Change in pysim[master]: personalization: set example input values
by neels 07 Jan '26

07 Jan '26

Attention is currently required from: laforge. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40094?usp=email ) Change subject: personalization: set example input values ...................................................................... Patch Set 8: (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/40094/comment/d1018ee7_55fa0e72?usp=em… : PS2, Line 278: default_value > there is never any use case for an all-zero ICCID. […] Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40094?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2672fedcbc32cb7a6cb0c233a4a22112bd9aae03 Gerrit-Change-Number: 40094 Gerrit-PatchSet: 8 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 08 Jan 2026 01:03:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

2026

2025

2024

2023

2022

gerrit-log January 2026