January 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bts[master]: ms_power_control: Apply defaults during reset
by pespin 09 Jan '26

09 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/41795?usp=email ) Change subject: ms_power_control: Apply defaults during reset ...................................................................... ms_power_control: Apply defaults during reset lchan_ms_pwr_ctrl_reset() is already called furhter above in rsl_rx_chan_activ(), so simplify mode the default values there and no need to re-apply them twice. Change-Id: I5c0137ba8bf1e057abdc1911716e3d1bf8c61ea3 --- M src/common/power_control.c M src/common/rsl.c 2 files changed, 9 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/95/41795/1 diff --git a/src/common/power_control.c b/src/common/power_control.c index bf310c6..187c5da 100644 --- a/src/common/power_control.c +++ b/src/common/power_control.c @@ -145,6 +145,10 @@ * state->dpc_params = NULL (static mode). * state->skip_block_num = 0, so that 1st power input is taken into account. */ memset(state, 0, sizeof(*state)); + + state->max = ms_pwr_ctl_lvl(lchan->ts->trx->bts->band, 0); + /* XXX: should we use the maximum power level instead of 0 dBm? */ + state->current = state->max; } /* Shall we skip current block based on configured interval? */ diff --git a/src/common/rsl.c b/src/common/rsl.c index 863167e..07d5e6d 100644 --- a/src/common/rsl.c +++ b/src/common/rsl.c @@ -1989,8 +1989,6 @@ } } - lchan_ms_pwr_ctrl_reset(lchan); - /* 9.3.6 Channel Mode */ if (type != RSL_ACT_OSMO_PDCH) { if (rsl_handle_chan_mod_ie(lchan, &tp, &cause) != 0) @@ -2050,11 +2048,12 @@ } /* 9.3.13 MS Power */ - if (TLVP_PRES_LEN(&tp, RSL_IE_MS_POWER, 1)) + lchan_ms_pwr_ctrl_reset(lchan); + if (TLVP_PRES_LEN(&tp, RSL_IE_MS_POWER, 1)) { lchan->ms_power_ctrl.max = *TLVP_VAL(&tp, RSL_IE_MS_POWER) & 0x1F; - else /* XXX: should we use the maximum power level instead of 0 dBm? */ - lchan->ms_power_ctrl.max = ms_pwr_ctl_lvl(lchan->ts->trx->bts->band, 0); - lchan->ms_power_ctrl.current = lchan->ms_power_ctrl.max; + /* XXX: should we use the maximum power level instead of 0 dBm? */ + lchan->ms_power_ctrl.current = lchan->ms_power_ctrl.max; + } /* 9.3.24 Timing Advance */ if (TLVP_PRES_LEN(&tp, RSL_IE_TIMING_ADVANCE, 1)) -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41795?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5c0137ba8bf1e057abdc1911716e3d1bf8c61ea3 Gerrit-Change-Number: 41795 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-bts[master]: bs_power_control: Apply defaults during reset
by pespin 09 Jan '26

09 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/41794?usp=email ) Change subject: bs_power_control: Apply defaults during reset ...................................................................... bs_power_control: Apply defaults during reset lchan_bs_pwr_ctrl_reset() is already called furhter above in rsl_rx_chan_activ(), so simplify mode the default values there and no need to re-apply them twice. Change-Id: I00d9205d114b2d507c1048375693de4aa06bebbe --- M src/common/power_control.c M src/common/rsl.c 2 files changed, 4 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/94/41794/1 diff --git a/src/common/power_control.c b/src/common/power_control.c index 0520ed8..bf310c6 100644 --- a/src/common/power_control.c +++ b/src/common/power_control.c @@ -325,9 +325,12 @@ struct lchan_power_ctrl_state *state = &lchan->bs_power_ctrl; /* This below implicitly sets: + * state->current = 0 (it's safer to start from 0 unless told differently). * state->dpc_params = NULL (static mode). * state->skip_block_num = 0, so that 1st power input is taken into account. */ memset(state, 0, sizeof(*state)); + + state->max = 2 * 15; /* maximum defined in 9.3.4 */ } /*! compute the new Downlink attenuation value for the given logical channel. diff --git a/src/common/rsl.c b/src/common/rsl.c index cb13977..863167e 100644 --- a/src/common/rsl.c +++ b/src/common/rsl.c @@ -1989,8 +1989,6 @@ } } - /* Initialize MS/BS Power Control state */ - lchan_bs_pwr_ctrl_reset(lchan); lchan_ms_pwr_ctrl_reset(lchan); /* 9.3.6 Channel Mode */ @@ -2028,6 +2026,7 @@ } /* 9.3.4 BS Power */ + lchan_bs_pwr_ctrl_reset(lchan); if (TLVP_PRES_LEN(&tp, RSL_IE_BS_POWER, 1)) { if (*TLVP_VAL(&tp, RSL_IE_BS_POWER) & (1 << 4)) { LOGPLCHAN(lchan, DRSL, LOGL_NOTICE, @@ -2048,9 +2047,6 @@ LOGPLCHAN(lchan, DRSL, LOGL_DEBUG, "BS Power attenuation %u dB\n", lchan->bs_power_ctrl.current); - } else { - lchan->bs_power_ctrl.max = 2 * 15; /* maximum defined in 9.3.4 */ - lchan->bs_power_ctrl.current = 0; } /* 9.3.13 MS Power */ @@ -2096,9 +2092,6 @@ LOGPLCHAN(lchan, DRSL, LOGL_ERROR, "Failed to parse BS Power Parameters IE\n"); return rsl_tx_chan_act_nack(lchan, RSL_ERR_IE_CONTENT); } - - /* NOTE: it's safer to start from 0 */ - lchan->bs_power_ctrl.current = 0; lchan->bs_power_ctrl.dpc_params = params; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41794?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I00d9205d114b2d507c1048375693de4aa06bebbe Gerrit-Change-Number: 41794 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-bts[master]: {bs,ms}_power_control: Reset state during lchan deactivation
by pespin 09 Jan '26

09 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/41793?usp=email ) Change subject: {bs,ms}_power_control: Reset state during lchan deactivation ...................................................................... {bs,ms}_power_control: Reset state during lchan deactivation Change-Id: I0c247414d27d7ac636c6dbb294b0dd3bffc4ed97 --- M src/common/lchan.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/93/41793/1 diff --git a/src/common/lchan.c b/src/common/lchan.c index 7123cee..b115e1e 100644 --- a/src/common/lchan.c +++ b/src/common/lchan.c @@ -326,6 +326,8 @@ lchan->pending_rel_ind_msg = NULL; msgb_free(lchan->pending_chan_activ); lchan->pending_chan_activ = NULL; + lchan_bs_pwr_ctrl_reset(lchan); + lchan_ms_pwr_ctrl_reset(lchan); lchan_ms_ta_ctrl_reset(lchan); /* fall through */ default: -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41793?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0c247414d27d7ac636c6dbb294b0dd3bffc4ed97 Gerrit-Change-Number: 41793 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-bts[master]: ta_control: Fix skip_block_num not reset when switching TS to PDCH
by pespin 09 Jan '26

09 Jan '26

Attention is currently required from: fixeria, jolly, laforge. Hello fixeria, jolly, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/41790?usp=email to look at the new patch set (#2). Change subject: ta_control: Fix skip_block_num not reset when switching TS to PDCH ...................................................................... ta_control: Fix skip_block_num not reset when switching TS to PDCH Change-Id: Id3e81ebec04042dd7d8e4805762e3e518790706d --- M include/osmo-bts/ta_control.h M src/common/rsl.c M src/common/ta_control.c 3 files changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/90/41790/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41790?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id3e81ebec04042dd7d8e4805762e3e518790706d Gerrit-Change-Number: 41790 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-bts[master]: {bs,ms}_power_control: Add helper function to reset state
by pespin 09 Jan '26

09 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/41792?usp=email ) Change subject: {bs,ms}_power_control: Add helper function to reset state ...................................................................... {bs,ms}_power_control: Add helper function to reset state This way we can better document and identify places where the state is reset. Change-Id: I3e010a4ed72ba2574ce6c1316b8460689fc1d482 --- M include/osmo-bts/power_control.h M src/common/power_control.c M src/common/rsl.c 3 files changed, 27 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/92/41792/1 diff --git a/include/osmo-bts/power_control.h b/include/osmo-bts/power_control.h index 0764ba7..031d462 100644 --- a/include/osmo-bts/power_control.h +++ b/include/osmo-bts/power_control.h @@ -81,10 +81,12 @@ void power_ctrl_params_def_reset(struct gsm_power_ctrl_params *params, bool is_bs_pwr); struct gsm_lchan; +void lchan_ms_pwr_ctrl_reset(struct gsm_lchan *lchan); int lchan_ms_pwr_ctrl(struct gsm_lchan *lchan, const uint8_t ms_power_lvl, const int8_t ul_rssi_dbm, const int16_t ul_lqual_cb); +void lchan_bs_pwr_ctrl_reset(struct gsm_lchan *lchan); int lchan_bs_pwr_ctrl(struct gsm_lchan *lchan, const struct gsm48_meas_res *mr); diff --git a/src/common/power_control.c b/src/common/power_control.c index 45d8969..0520ed8 100644 --- a/src/common/power_control.c +++ b/src/common/power_control.c @@ -137,6 +137,16 @@ return delta; } +void lchan_ms_pwr_ctrl_reset(struct gsm_lchan *lchan) +{ + struct lchan_power_ctrl_state *state = &lchan->ms_power_ctrl; + + /* This below implicitly sets: + * state->dpc_params = NULL (static mode). + * state->skip_block_num = 0, so that 1st power input is taken into account. */ + memset(state, 0, sizeof(*state)); +} + /* Shall we skip current block based on configured interval? */ static bool ctrl_interval_skip_block(const struct gsm_power_ctrl_params *params, struct lchan_power_ctrl_state *state) @@ -310,6 +320,16 @@ return 1; } +void lchan_bs_pwr_ctrl_reset(struct gsm_lchan *lchan) +{ + struct lchan_power_ctrl_state *state = &lchan->bs_power_ctrl; + + /* This below implicitly sets: + * state->dpc_params = NULL (static mode). + * state->skip_block_num = 0, so that 1st power input is taken into account. */ + memset(state, 0, sizeof(*state)); +} + /*! compute the new Downlink attenuation value for the given logical channel. * \param lchan logical channel for which to compute (and in which to store) new power value. * \param[in] mr pointer to a *valid* Measurement Report. diff --git a/src/common/rsl.c b/src/common/rsl.c index ba403bc..cb13977 100644 --- a/src/common/rsl.c +++ b/src/common/rsl.c @@ -58,6 +58,7 @@ #include <osmo-bts/pcuif_proto.h> #include <osmo-bts/notification.h> #include <osmo-bts/asci.h> +#include <osmo-bts/power_control.h> #include <osmo-bts/ta_control.h> //#define FAKE_CIPH_MODE_COMPL @@ -1764,8 +1765,8 @@ lchan->tch_mode = 0; memset(&lchan->encr, 0, sizeof(lchan->encr)); memset(&lchan->ho, 0, sizeof(lchan->ho)); - memset(&lchan->ms_power_ctrl, 0, sizeof(lchan->ms_power_ctrl)); - memset(&lchan->bs_power_ctrl, 0, sizeof(lchan->bs_power_ctrl)); + lchan_bs_pwr_ctrl_reset(lchan); + lchan_ms_pwr_ctrl_reset(lchan); lchan_ms_ta_ctrl_reset(lchan); copy_sacch_si_to_lchan(lchan); memset(&lchan->tch, 0, sizeof(lchan->tch)); @@ -1989,8 +1990,8 @@ } /* Initialize MS/BS Power Control state */ - memset(&lchan->ms_power_ctrl, 0, sizeof(lchan->ms_power_ctrl)); - memset(&lchan->bs_power_ctrl, 0, sizeof(lchan->bs_power_ctrl)); + lchan_bs_pwr_ctrl_reset(lchan); + lchan_ms_pwr_ctrl_reset(lchan); /* 9.3.6 Channel Mode */ if (type != RSL_ACT_OSMO_PDCH) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41792?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3e010a4ed72ba2574ce6c1316b8460689fc1d482 Gerrit-Change-Number: 41792 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-bts[master]: ta_control: Fix skip_block_num not reset when switching TS to PDCH
by pespin 09 Jan '26

09 Jan '26

Attention is currently required from: fixeria, jolly, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bts/+/41790?usp=email ) Change subject: ta_control: Fix skip_block_num not reset when switching TS to PDCH ...................................................................... Patch Set 1: (1 comment) File src/common/ta_control.c: https://gerrit.osmocom.org/c/osmo-bts/+/41790/comment/04d08fd7_c2883c90?usp… : PS1, Line 52: lchan->ta_ctrl.skip_block_num = lchan->ts->trx->ta_ctrl_interval * 2 - 1; We may actually want to do "lchan->ta_ctrl.skip_block_num = 0" here, so that the first TA input after lchan creation is taken into account. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41790?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id3e81ebec04042dd7d8e4805762e3e518790706d Gerrit-Change-Number: 41790 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Jan 2026 11:21:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-bts[master]: ta_control: Reset state during lchan deactivation
by pespin 09 Jan '26

09 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/41791?usp=email ) Change subject: ta_control: Reset state during lchan deactivation ...................................................................... ta_control: Reset state during lchan deactivation Otherwise next time the lchan is activated, its ta_ctrl.skip_block_num will be different based on previous lchan state. Change-Id: I2aacbbc5b2db46c17b1266b5b5e84d8286d0cf83 --- M src/common/lchan.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/91/41791/1 diff --git a/src/common/lchan.c b/src/common/lchan.c index 0afc294..7123cee 100644 --- a/src/common/lchan.c +++ b/src/common/lchan.c @@ -34,6 +34,7 @@ #include <osmo-bts/l1sap.h> #include <osmo-bts/bts_model.h> #include <osmo-bts/asci.h> +#include <osmo-bts/ta_control.h> #include <errno.h> static const struct value_string lchan_s_names[] = { @@ -325,6 +326,7 @@ lchan->pending_rel_ind_msg = NULL; msgb_free(lchan->pending_chan_activ); lchan->pending_chan_activ = NULL; + lchan_ms_ta_ctrl_reset(lchan); /* fall through */ default: if (lchan->early_rr_ia) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41791?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I2aacbbc5b2db46c17b1266b5b5e84d8286d0cf83 Gerrit-Change-Number: 41791 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-bts[master]: ta_control: Fix skip_block_num not reset when switching TS to PDCH
by pespin 09 Jan '26

09 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/41790?usp=email ) Change subject: ta_control: Fix skip_block_num not reset when switching TS to PDCH ...................................................................... ta_control: Fix skip_block_num not reset when switching TS to PDCH Change-Id: Id3e81ebec04042dd7d8e4805762e3e518790706d --- M include/osmo-bts/ta_control.h M src/common/rsl.c M src/common/ta_control.c 3 files changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/90/41790/1 diff --git a/include/osmo-bts/ta_control.h b/include/osmo-bts/ta_control.h index bf99331..e003245 100644 --- a/include/osmo-bts/ta_control.h +++ b/include/osmo-bts/ta_control.h @@ -2,4 +2,6 @@ #include <osmo-bts/gsm_data.h> +void lchan_ms_ta_ctrl_reset(struct gsm_lchan *lchan); + void lchan_ms_ta_ctrl(struct gsm_lchan *lchan, uint8_t ms_tx_ta, int16_t toa256); diff --git a/src/common/rsl.c b/src/common/rsl.c index f16fe7c..ba403bc 100644 --- a/src/common/rsl.c +++ b/src/common/rsl.c @@ -58,6 +58,7 @@ #include <osmo-bts/pcuif_proto.h> #include <osmo-bts/notification.h> #include <osmo-bts/asci.h> +#include <osmo-bts/ta_control.h> //#define FAKE_CIPH_MODE_COMPL @@ -1765,7 +1766,7 @@ memset(&lchan->ho, 0, sizeof(lchan->ho)); memset(&lchan->ms_power_ctrl, 0, sizeof(lchan->ms_power_ctrl)); memset(&lchan->bs_power_ctrl, 0, sizeof(lchan->bs_power_ctrl)); - lchan->ta_ctrl.current = 0; + lchan_ms_ta_ctrl_reset(lchan); copy_sacch_si_to_lchan(lchan); memset(&lchan->tch, 0, sizeof(lchan->tch)); } diff --git a/src/common/ta_control.c b/src/common/ta_control.c index 64c44be..0fae5a4 100644 --- a/src/common/ta_control.c +++ b/src/common/ta_control.c @@ -42,6 +42,16 @@ #define TA_MAX_INC_STEP 2 #define TA_MAX_DEC_STEP 2 +void lchan_ms_ta_ctrl_reset(struct gsm_lchan *lchan) +{ + /* Reset the number of SACCH blocks to be skipped: + * ctrl_interval=0 => 0 blocks to skip, + * ctrl_interval=1 => 1 blocks to skip, + * ctrl_interval=2 => 3 blocks to skip, + * so basically ctrl_interval * 2 - 1. */ + lchan->ta_ctrl.skip_block_num = lchan->ts->trx->ta_ctrl_interval * 2 - 1; + lchan->ta_ctrl.current = 0; +} /* Shall we skip current block based on configured interval? */ static bool ctrl_interval_skip_block(struct gsm_lchan *lchan) -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41790?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id3e81ebec04042dd7d8e4805762e3e518790706d Gerrit-Change-Number: 41790 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-bts[master]: ta_control: Add missing include for lchan.h
by pespin 09 Jan '26

09 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/41789?usp=email ) Change subject: ta_control: Add missing include for lchan.h ...................................................................... ta_control: Add missing include for lchan.h Change-Id: Iea1f7ed303ebd0c12a48bb3edf73a494b8736a39 --- M src/common/ta_control.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/89/41789/1 diff --git a/src/common/ta_control.c b/src/common/ta_control.c index 10b04a9..64c44be 100644 --- a/src/common/ta_control.c +++ b/src/common/ta_control.c @@ -27,6 +27,7 @@ #include <osmo-bts/gsm_data.h> #include <osmo-bts/bts_trx.h> +#include <osmo-bts/lchan.h> #include <osmo-bts/logging.h> /* 3GPP TS 45.010 sec 5.6.3 Delay assessment error: -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41789?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iea1f7ed303ebd0c12a48bb3edf73a494b8736a39 Gerrit-Change-Number: 41789 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-bts[master]: ta_control: Move skip_block logic to helper function
by pespin 09 Jan '26

09 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/41787?usp=email ) Change subject: ta_control: Move skip_block logic to helper function ...................................................................... ta_control: Move skip_block logic to helper function This makes it more similar to code in power_control.c. Change-Id: I174f2f941fbedbe0793cc0b93d01e53e23328cf2 --- M src/common/ta_control.c 1 file changed, 21 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/87/41787/1 diff --git a/src/common/ta_control.c b/src/common/ta_control.c index 6fe409a..c3e4d67 100644 --- a/src/common/ta_control.c +++ b/src/common/ta_control.c @@ -22,6 +22,9 @@ /* Related specs: 3GPP TS 45.010 sections 5.5, 5.6 */ +#include <stdint.h> +#include <stdbool.h> + #include <osmo-bts/gsm_data.h> #include <osmo-bts/bts_trx.h> #include <osmo-bts/logging.h> @@ -39,6 +42,22 @@ #define TA_MAX_DEC_STEP 2 +/* Shall we skip current block based on configured interval? */ +static bool ctrl_interval_skip_block(struct gsm_lchan *lchan) +{ + /* TA control interval: how many blocks do we skip? */ + if (lchan->ta_ctrl.skip_block_num-- > 0) + return true; + + /* Reset the number of SACCH blocks to be skipped: + * ctrl_interval=0 => 0 blocks to skip, + * ctrl_interval=1 => 1 blocks to skip, + * ctrl_interval=2 => 3 blocks to skip, + * so basically ctrl_interval * 2 - 1. */ + lchan->ta_ctrl.skip_block_num = lchan->ts->trx->ta_ctrl_interval * 2 - 1; + return false; +} + /*! compute the new "Ordered Timing Advance" communicated to the MS and store it in lchan. * \param lchan logical channel for which to compute (and in which to store) new power value. * \param[in] ms_tx_ta The TA used by the MS and reported in L1SACCH, see struct gsm_sacch_l1_hdr field "ta". @@ -47,19 +66,11 @@ void lchan_ms_ta_ctrl(struct gsm_lchan *lchan, uint8_t ms_tx_ta, int16_t toa256) { int16_t new_ta; + /* Shall we skip current block based on configured interval? */ - - /* TA control interval: how many blocks do we skip? */ - if (lchan->ta_ctrl.skip_block_num-- > 0) + if (ctrl_interval_skip_block(lchan)) return; - /* Reset the number of SACCH blocks to be skipped: - * ctrl_interval=0 => 0 blocks to skip, - * ctrl_interval=1 => 1 blocks to skip, - * ctrl_interval=2 => 3 blocks to skip, - * so basically ctrl_interval * 2 - 1. */ - lchan->ta_ctrl.skip_block_num = lchan->ts->trx->ta_ctrl_interval * 2 - 1; - int16_t delta_ta = toa256/256; if (toa256 >= 0) { if ((toa256 - (256 * delta_ta)) > TOA256_THRESH) -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41787?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I174f2f941fbedbe0793cc0b93d01e53e23328cf2 Gerrit-Change-Number: 41787 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log January 2026