January 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-bts[master]: ta_control: Add missing include for lchan.h
by pespin 09 Jan '26

09 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/41789?usp=email ) Change subject: ta_control: Add missing include for lchan.h ...................................................................... ta_control: Add missing include for lchan.h Change-Id: Iea1f7ed303ebd0c12a48bb3edf73a494b8736a39 --- M src/common/ta_control.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/89/41789/1 diff --git a/src/common/ta_control.c b/src/common/ta_control.c index 10b04a9..64c44be 100644 --- a/src/common/ta_control.c +++ b/src/common/ta_control.c @@ -27,6 +27,7 @@ #include <osmo-bts/gsm_data.h> #include <osmo-bts/bts_trx.h> +#include <osmo-bts/lchan.h> #include <osmo-bts/logging.h> /* 3GPP TS 45.010 sec 5.6.3 Delay assessment error: -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41789?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iea1f7ed303ebd0c12a48bb3edf73a494b8736a39 Gerrit-Change-Number: 41789 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in pysim[master]: Print SMSC in read mode
by laforge 09 Jan '26

09 Jan '26

Attention is currently required from: phcoder. laforge has posted comments on this change by phcoder. ( https://gerrit.osmocom.org/c/pysim/+/41786?usp=email ) Change subject: Print SMSC in read mode ...................................................................... Patch Set 2: Code-Review-1 (1 comment) Patchset: PS2: I don't think we want to merge this, sorry. `pySim-{read,prog}` are legacy tools that are virtually unmaintained except major bugfixes for many years by now. The proper thing to do is to reimplement the same functionality based on `pySim.filesystem` and all the powerful encoder/decoder functionality we have in `pySim-shell`. But sadly we haven't seen anyone volunteering fo that yet ;) Meanwhilw, if we were to add a new decoder for a file (like SMSP here), it should use the class `pySim.ts_51_011.EF_SMSP()` for decoding and not implement another open-coded/manual encoder. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41786?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I17067b68086316d51fd71ba77049874605594e3f Gerrit-Change-Number: 41786 Gerrit-PatchSet: 2 Gerrit-Owner: phcoder <phcoder(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: phcoder <phcoder(a)gmail.com> Gerrit-Comment-Date: Fri, 09 Jan 2026 10:25:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: Print SMSC in read mode
by phcoder 09 Jan '26

09 Jan '26

Attention is currently required from: phcoder. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/41786?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Print SMSC in read mode ...................................................................... Print SMSC in read mode Change-Id: I17067b68086316d51fd71ba77049874605594e3f --- M pySim-read.py M pySim/legacy/utils.py 2 files changed, 12 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/86/41786/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41786?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I17067b68086316d51fd71ba77049874605594e3f Gerrit-Change-Number: 41786 Gerrit-PatchSet: 2 Gerrit-Owner: phcoder <phcoder(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: phcoder <phcoder(a)gmail.com>

1 0

[S] Change in pysim[master]: Print SMSC in read mode
by phcoder 09 Jan '26

09 Jan '26

phcoder has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/41786?usp=email ) Change subject: Print SMSC in read mode ...................................................................... Print SMSC in read mode Change-Id: I17067b68086316d51fd71ba77049874605594e3f --- M pySim-read.py M pySim/legacy/utils.py 2 files changed, 12 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/86/41786/1 diff --git a/pySim-read.py b/pySim-read.py index 9829a15..ab2049b 100755 --- a/pySim-read.py +++ b/pySim-read.py @@ -43,7 +43,7 @@ from pySim.exceptions import SwMatchError from pySim.legacy.cards import card_detect, SimCard, UsimCard, IsimCard from pySim.utils import dec_imsi, dec_iccid -from pySim.legacy.utils import format_xplmn_w_act, dec_st, dec_msisdn +from pySim.legacy.utils import format_xplmn_w_act, dec_st, dec_msisdn, dec_smsc_from_smsp option_parser = argparse.ArgumentParser(description='Legacy tool for reading some parts of a SIM card', formatter_class=argparse.ArgumentDefaultsHelpFormatter) @@ -141,6 +141,7 @@ (res, sw) = card.read_record('SMSP', 1) if sw == '9000': print("SMSP: %s" % (res,)) + print("SMSC: %s" % (dec_smsc_from_smsp(res),)) else: print("SMSP: Can't read, response code = %s" % (sw,)) diff --git a/pySim/legacy/utils.py b/pySim/legacy/utils.py index 49c8633..f96e318 100644 --- a/pySim/legacy/utils.py +++ b/pySim/legacy/utils.py @@ -334,6 +334,16 @@ return s +def dec_smsc_from_smsp(smsp): + y = (len(smsp) // 2) - 28 + if y <= 0: + return (None, sw) + tp_sca = smsp[((y+14)*2):((y+25)*2)] + prefix = '+' if tp_sca[0:2] == '91' else '' + + return prefix + swap_nibbles(tp_sca[2:]).rstrip('f') + + def dec_msisdn(ef_msisdn: Hexstr) -> Optional[Tuple[int, int, Optional[str]]]: """ Decode MSISDN from EF.MSISDN or EF.ADN (same structure). -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41786?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I17067b68086316d51fd71ba77049874605594e3f Gerrit-Change-Number: 41786 Gerrit-PatchSet: 1 Gerrit-Owner: phcoder <phcoder(a)gmail.com>

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts: Fix sporadic failure in TC_rsl_ms_pwr_ctrl
by laforge 08 Jan '26

08 Jan '26

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41785?usp=email ) Change subject: bts: Fix sporadic failure in TC_rsl_ms_pwr_ctrl ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41785?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I088b58bf76765c8a5bd167590c5afc5055fbdbf8 Gerrit-Change-Number: 41785 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 08 Jan 2026 20:25:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts: Fix sporadic failure in TC_rsl_ms_pwr_ctrl
by pespin 08 Jan '26

08 Jan '26

Attention is currently required from: fixeria, laforge. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41785?usp=email to look at the new patch set (#2). Change subject: bts: Fix sporadic failure in TC_rsl_ms_pwr_ctrl ...................................................................... bts: Fix sporadic failure in TC_rsl_ms_pwr_ctrl Fix following sporadic race condition: TTCN-MS IUTS-BTS TTCN-BSC | |<----CHAN_ACT------| |<--SACCH(A)-- | | | |<--MS_PWR_CTRL(B)- | |<--SACCH(B)---| Change-Id: I088b58bf76765c8a5bd167590c5afc5055fbdbf8 --- M bts/BTS_Tests.ttcn 1 file changed, 12 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/85/41785/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41785?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I088b58bf76765c8a5bd167590c5afc5055fbdbf8 Gerrit-Change-Number: 41785 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts: Fix sporafic failure in TC_rsl_ms_pwr_ctrl
by pespin 08 Jan '26

08 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41785?usp=email ) Change subject: bts: Fix sporafic failure in TC_rsl_ms_pwr_ctrl ...................................................................... bts: Fix sporafic failure in TC_rsl_ms_pwr_ctrl Fix following sporadic race condition: TTCN-MS IUTS-BTS TTCN-BSC | |<----CHAN_ACT------| |<--SACCH(A)-- | | | |<--MS_PWR_CTRL(B)- | |<--SACCH(B)---| Change-Id: I088b58bf76765c8a5bd167590c5afc5055fbdbf8 --- M bts/BTS_Tests.ttcn 1 file changed, 12 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/85/41785/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 26fe18d..b2d7252 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -3834,6 +3834,7 @@ private function f_tc_rsl_ms_pwr_ctrl(charstring id) runs on ConnHdlr { var SacchL1Header l1h; var uint5_t power_level := 0; + var boolean first_after_wait := true; f_l1_tune(L1CTL); RSL.clear; @@ -3849,10 +3850,18 @@ alt { [] as_l1_sacch_l1h(l1h, do_apply := false) { if (l1h.ms_power_lvl != power_level) { - setverdict(fail, "Power level := ", l1h.ms_power_lvl, "does not ", - "match the signaled (RSL) power level := ", power_level); - Misc_Helpers.f_shutdown(__BFILE__, __LINE__); + if (first_after_wait) { + /* It may happen that BTS transmits SACCH before it receives our RSL MS POWER CONTROL: */ + log("Power level := ", l1h.ms_power_lvl, " does not ", + "match the signaled (RSL) power level := ", power_level); + first_after_wait := false; + repeat; + } + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Power level := ", l1h.ms_power_lvl, " does not ", + "match the signaled (RSL) power level := ", power_level)); } + first_after_wait := true; /* Signal a new power level via RSL for the next turn. */ if (power_level < 31) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41785?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I088b58bf76765c8a5bd167590c5afc5055fbdbf8 Gerrit-Change-Number: 41785 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in pysim[master]: personalization: set example input values
by laforge 08 Jan '26

08 Jan '26

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40094?usp=email ) Change subject: personalization: set example input values ...................................................................... Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40094?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2672fedcbc32cb7a6cb0c233a4a22112bd9aae03 Gerrit-Change-Number: 40094 Gerrit-PatchSet: 8 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 08 Jan 2026 15:02:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: personalization: refactor SmspTpScAddr
by laforge 08 Jan '26

08 Jan '26

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/41779?usp=email ) Change subject: personalization: refactor SmspTpScAddr ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41779?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2600369e195e9f5aed7f4e6ff99ae273ed3ab3bf Gerrit-Change-Number: 41779 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 08 Jan 2026 15:01:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: personalization: refactor SmspTpScAddr
by laforge 08 Jan '26

08 Jan '26

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/41779?usp=email ) Change subject: personalization: refactor SmspTpScAddr ...................................................................... Patch Set 1: (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/41779/comment/cff9854e_eccc28d3?usp=em… : PS1, Line 362: val must be a tuple (international[bool], digits[str]) this should be given as type annotation instead of a comment. I realize that the original code didn't have it, but if you're adding that missing annotation, please do it in a way that benefits both linters and the human developer instead of just the latter. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41779?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2600369e195e9f5aed7f4e6ff99ae273ed3ab3bf Gerrit-Change-Number: 41779 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 08 Jan 2026 14:57:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

2026

2025

2024

2023

2022

gerrit-log January 2026