January 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-bts[master]: vty: document default value for 'paging queue-size'
by pespin 15 Jan '26

15 Jan '26

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/41851?usp=email to look at the new patch set (#3). Change subject: vty: document default value for 'paging queue-size' ...................................................................... vty: document default value for 'paging queue-size' Change-Id: I34c1529c63544ccd472b53fc7370e742ae5e3a02 --- M include/osmo-bts/paging.h M src/common/bts.c M src/common/vty.c 3 files changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/51/41851/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41851?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I34c1529c63544ccd472b53fc7370e742ae5e3a02 Gerrit-Change-Number: 41851 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: vty: Fix extern var declared inside ifdef
by osmith 15 Jan '26

15 Jan '26

Attention is currently required from: daniel, fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41848?usp=email ) Change subject: vty: Fix extern var declared inside ifdef ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41848?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9d769ff007a4eaf613691a0491b0b4e07472df98 Gerrit-Change-Number: 41848 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Jan 2026 13:24:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-bts[master]: vty: document default value for 'paging queue-size'
by pespin 15 Jan '26

15 Jan '26

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/41851?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: vty: document default value for 'paging queue-size' ...................................................................... vty: document default value for 'paging queue-size' Change-Id: I34c1529c63544ccd472b53fc7370e742ae5e3a02 --- M include/osmo-bts/paging.h M src/common/bts.c M src/common/vty.c 3 files changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/51/41851/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41851?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I34c1529c63544ccd472b53fc7370e742ae5e3a02 Gerrit-Change-Number: 41851 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-gsm-manuals[master]: logging: Improve file & stderr log documentation
by osmith 15 Jan '26

15 Jan '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41843?usp=email ) Change subject: logging: Improve file & stderr log documentation ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41843?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I90114f634ae0411e58d2f3da86d5a2e470b4d828 Gerrit-Change-Number: 41843 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Jan 2026 13:23:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-gsm-manuals[master]: logging: Improve GSMTAP log documentation
by osmith 15 Jan '26

15 Jan '26

Attention is currently required from: daniel, fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41842?usp=email ) Change subject: logging: Improve GSMTAP log documentation ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41842?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I9434939d2a9a41bb0011a067f5ff9b94752fa781 Gerrit-Change-Number: 41842 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Jan 2026 13:23:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-bts[master]: vty: document default value for 'paging queue-size'
by pespin 15 Jan '26

15 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/41851?usp=email ) Change subject: vty: document default value for 'paging queue-size' ...................................................................... vty: document default value for 'paging queue-size' Change-Id: I34c1529c63544ccd472b53fc7370e742ae5e3a02 --- M include/osmo-bts/paging.h M src/common/bts.c M src/common/vty.c 3 files changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/51/41851/1 diff --git a/include/osmo-bts/paging.h b/include/osmo-bts/paging.h index d8efb34..5d26459 100644 --- a/include/osmo-bts/paging.h +++ b/include/osmo-bts/paging.h @@ -57,6 +57,8 @@ } nln_pch; }; +#define NUM_PAGING_MAX_DEFAULT 200 + /* initialize paging code */ struct paging_state *paging_init(struct gsm_bts *bts, unsigned int num_paging_max, diff --git a/src/common/bts.c b/src/common/bts.c index 73cb8a6..ea6b3d6 100644 --- a/src/common/bts.c +++ b/src/common/bts.c @@ -336,7 +336,7 @@ bts->agch_queue.thresh_level = GSM_BTS_AGCH_QUEUE_THRESH_LEVEL_DEFAULT; /* configurable via VTY */ - bts->paging_state = paging_init(bts, 200, 0); + bts->paging_state = paging_init(bts, NUM_PAGING_MAX_DEFAULT, 0); bts->rtp_jitter_adaptive = false; bts->rtp_port_range_start = 16384; bts->rtp_port_range_end = 17407; diff --git a/src/common/vty.c b/src/common/vty.c index ca7947b..f9d691a 100644 --- a/src/common/vty.c +++ b/src/common/vty.c @@ -56,6 +56,7 @@ #include <osmo-bts/oml.h> #include <osmo-bts/signal.h> #include <osmo-bts/bts_model.h> +#include <osmo-bts/paging.h> #include <osmo-bts/pcuif_proto.h> #include <osmo-bts/measurement.h> #include <osmo-bts/vty.h> @@ -838,7 +839,7 @@ cfg_bts_paging_queue_size_cmd, "paging queue-size <1-1024>", PAG_STR "Maximum length of BTS-internal paging queue\n" - "Maximum length of BTS-internal paging queue\n", + "Maximum length of BTS-internal paging queue (default " NUM_PAGING_MAX_DEFAULT ")\n", CMD_ATTR_IMMEDIATE) { struct gsm_bts *bts = vty->index; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41851?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I34c1529c63544ccd472b53fc7370e742ae5e3a02 Gerrit-Change-Number: 41851 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-bts[master]: paging: Remove unused function
by pespin 15 Jan '26

15 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/41850?usp=email ) Change subject: paging: Remove unused function ...................................................................... paging: Remove unused function Change-Id: Iff4d062e2d7ea49b61843f929ec19957a38453ab --- M include/osmo-bts/paging.h M src/common/paging.c 2 files changed, 0 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/50/41850/1 diff --git a/include/osmo-bts/paging.h b/include/osmo-bts/paging.h index e74ba3c..d8efb34 100644 --- a/include/osmo-bts/paging.h +++ b/include/osmo-bts/paging.h @@ -61,12 +61,6 @@ struct paging_state *paging_init(struct gsm_bts *bts, unsigned int num_paging_max, unsigned int paging_lifetime); - -/* (re) configure paging code */ -void paging_config(struct paging_state *ps, - unsigned int num_paging_max, - unsigned int paging_lifetime); - void paging_reset(struct paging_state *ps); /* The max number of paging entries */ diff --git a/src/common/paging.c b/src/common/paging.c index bdd5180..9e28de6 100644 --- a/src/common/paging.c +++ b/src/common/paging.c @@ -884,14 +884,6 @@ return ps; } -void paging_config(struct paging_state *ps, - unsigned int num_paging_max, - unsigned int paging_lifetime) -{ - ps->num_paging_max = num_paging_max; - ps->paging_lifetime = paging_lifetime; -} - void paging_reset(struct paging_state *ps) { int i; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41850?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iff4d062e2d7ea49b61843f929ec19957a38453ab Gerrit-Change-Number: 41850 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: Add --disable-syslog-logging configure option
by pespin 15 Jan '26

15 Jan '26

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/41849?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Add --disable-syslog-logging configure option ...................................................................... Add --disable-syslog-logging configure option Right now syslog logging support is built in automatically based on syslog.h being built at compile time. That's not desirable; as with other dependencies make sure there's an explicit configure option for it. Leave it enabled by default since most systems come with syslog.h and it's a feature nice to have by default. It is disabled explicitly when compiling for arm-none-eabi since the toolchain doesn't have syslog.h. Take the chance to completelly skip compiling the logging_syslog.c file if support for syslog logging is disabled. Change-Id: Ifc54d60e24547696b3059b6eb75572f8c84874d0 --- M configure.ac M contrib/jenkins_arm.sh M src/core/Makefile.am M src/core/logging.c M src/core/logging_syslog.c M src/vty/logging_vty.c 6 files changed, 29 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/49/41849/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41849?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ifc54d60e24547696b3059b6eb75572f8c84874d0 Gerrit-Change-Number: 41849 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: vty: Fix extern var declared inside ifdef
by pespin 15 Jan '26

15 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/41848?usp=email ) Change subject: vty: Fix extern var declared inside ifdef ...................................................................... vty: Fix extern var declared inside ifdef "extern struct host host;" was declared inside "ifdef HAVE_SYSLOG_H", but it is actually needed unconditionally because it's also used in the gsmtap log target, which is always built. Change-Id: I9d769ff007a4eaf613691a0491b0b4e07472df98 --- M src/vty/logging_vty.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/48/41848/1 diff --git a/src/vty/logging_vty.c b/src/vty/logging_vty.c index 84e3331..128b23a 100644 --- a/src/vty/logging_vty.c +++ b/src/vty/logging_vty.c @@ -39,6 +39,9 @@ #include <osmocom/vty/telnet_interface.h> #include <osmocom/vty/logging.h> +/* From VTY core code. Used by gsmtap and syslog targets. */ +extern struct host host; + #define LOG_STR "Configure logging sub-system\n" #define LEVEL_STR "Set the log level for a specified category\n" @@ -656,9 +659,6 @@ [7] = LOG_LOCAL7 }; -/* From VTY core code */ -extern struct host host; - static int _cfg_log_syslog(struct vty *vty, int facility) { struct log_target *tgt; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41848?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9d769ff007a4eaf613691a0491b0b4e07472df98 Gerrit-Change-Number: 41848 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: Add --disable-syslog-logging configure option
by pespin 15 Jan '26

15 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/41849?usp=email ) Change subject: Add --disable-syslog-logging configure option ...................................................................... Add --disable-syslog-logging configure option Right now syslog logging support is built in automatically based on syslog.h being built at compile time. That's not desirable; as with other dependencies make sure there's an explicit configure option for it. Leave it enabled by default since most systems come with syslog.h and it's a feature nice to have by default. Take the chance to completelly skip compiling the logging_syslog.c file if support for syslog logging is disabled. Change-Id: Ifc54d60e24547696b3059b6eb75572f8c84874d0 --- M configure.ac M src/core/Makefile.am M src/core/logging.c M src/core/logging_syslog.c M src/vty/logging_vty.c 5 files changed, 27 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/49/41849/1 diff --git a/configure.ac b/configure.ac index 6a5f0c0..625e437 100644 --- a/configure.ac +++ b/configure.ac @@ -74,7 +74,7 @@ dnl checks for header files AC_HEADER_STDC -AC_CHECK_HEADERS(execinfo.h poll.h sys/select.h sys/socket.h sys/signalfd.h sys/eventfd.h sys/timerfd.h syslog.h ctype.h netinet/tcp.h netinet/in.h) +AC_CHECK_HEADERS(execinfo.h poll.h sys/select.h sys/socket.h sys/signalfd.h sys/eventfd.h sys/timerfd.h ctype.h netinet/tcp.h netinet/in.h) AC_CHECK_DECL(HAVE_SYS_SOCKET_H, AC_SUBST(HAVE_SYS_SOCKET_H, 1), AC_SUBST(HAVE_SYS_SOCKET_H, 0)) # for src/conv.c AC_FUNC_ALLOCA @@ -242,6 +242,21 @@ AC_DEFINE([USE_GNUTLS], [1], [Use GnuTLS as a fallback for missing getrandom()]) fi +AC_ARG_ENABLE([syslog_logging], + [AS_HELP_STRING( + [--disable-syslog-logging], + [Build without syslog logging support] + )], + [syslog_logging=$enableval], [syslog_logging="yes"]) +AS_IF([test "x$syslog_logging" = "xyes"], [ + AC_CHECK_HEADER([syslog.h], [SYSLOG_H_FOUND='yes'], + [SYSLOG_H_FOUND='no'; + AC_MSG_ERROR([syslog logging support needs syslog.h header])]) + AC_DEFINE([ENABLE_SYSLOG_LOGGING], [1], [Enable syslog logging target]) +]) +AM_CONDITIONAL(ENABLE_SYSLOG_LOGGING, test "x$syslog_logging" = "xyes") +AC_SUBST(ENABLE_SYSLOG_LOGGING) + AC_ARG_ENABLE([systemd_logging], [AS_HELP_STRING( [--enable-systemd-logging], diff --git a/src/core/Makefile.am b/src/core/Makefile.am index 0b756da..f2cf138 100644 --- a/src/core/Makefile.am +++ b/src/core/Makefile.am @@ -44,7 +44,6 @@ isdnhdlc.c \ it_q.c \ logging.c \ - logging_syslog.c \ logging_gsmtap.c \ loggingrb.c \ macaddr.c \ @@ -137,6 +136,10 @@ libosmocore_la_SOURCES += serial.c endif +if ENABLE_SYSLOG_LOGGING +libosmocore_la_SOURCES += logging_syslog.c +endif + if ENABLE_SYSTEMD_LOGGING libosmocore_la_SOURCES += logging_systemd.c libosmocore_la_LIBADD += $(SYSTEMD_LIBS) diff --git a/src/core/logging.c b/src/core/logging.c index cccfd93..9e5ae9f 100644 --- a/src/core/logging.c +++ b/src/core/logging.c @@ -37,7 +37,7 @@ #include <strings.h> #endif -#ifdef HAVE_SYSLOG_H +#ifdef ENABLE_SYSLOG_LOGGING #include <syslog.h> #endif @@ -1429,11 +1429,11 @@ case LOG_TGT_TYPE_GSMTAP: gsmtap_source_free(target->tgt_gsmtap.gsmtap_inst); break; -#ifdef HAVE_SYSLOG_H +#ifdef ENABLE_SYSLOG_LOGGING case LOG_TGT_TYPE_SYSLOG: closelog(); break; -#endif /* HAVE_SYSLOG_H */ +#endif /* ENABLE_SYSLOG_LOGGING */ default: /* make GCC happy */ break; diff --git a/src/core/logging_syslog.c b/src/core/logging_syslog.c index 1153bdf..eb84057 100644 --- a/src/core/logging_syslog.c +++ b/src/core/logging_syslog.c @@ -24,8 +24,6 @@ #include "config.h" -#ifdef HAVE_SYSLOG_H - #include <stdarg.h> #include <stdlib.h> #include <stdio.h> @@ -84,6 +82,4 @@ return target; } -#endif /* HAVE_SYSLOG_H */ - /* @} */ diff --git a/src/vty/logging_vty.c b/src/vty/logging_vty.c index 128b23a..6fd7abc 100644 --- a/src/vty/logging_vty.c +++ b/src/vty/logging_vty.c @@ -644,7 +644,7 @@ 1 }; -#ifdef HAVE_SYSLOG_H +#ifdef ENABLE_SYSLOG_LOGGING #include <syslog.h> @@ -751,7 +751,7 @@ RET_WITH_UNLOCK(CMD_SUCCESS); } -#endif /* HAVE_SYSLOG_H */ +#endif /* ENABLE_SYSLOG_LOGGING */ DEFUN(cfg_log_systemd_journal, cfg_log_systemd_journal_cmd, "log systemd-journal [raw]", @@ -1049,7 +1049,7 @@ vty_out(vty, "log stderr blocking-io%s", VTY_NEWLINE); break; case LOG_TGT_TYPE_SYSLOG: -#ifdef HAVE_SYSLOG_H +#ifdef ENABLE_SYSLOG_LOGGING vty_out(vty, "log syslog %s%s", get_value_string(sysl_level_names, tgt->tgt_syslog.facility), @@ -1302,7 +1302,7 @@ install_lib_element(CONFIG_NODE, &cfg_no_log_file_cmd); install_lib_element(CONFIG_NODE, &cfg_log_alarms_cmd); install_lib_element(CONFIG_NODE, &cfg_no_log_alarms_cmd); -#ifdef HAVE_SYSLOG_H +#ifdef ENABLE_SYSLOG_LOGGING install_lib_element(CONFIG_NODE, &cfg_log_syslog_cmd); install_lib_element(CONFIG_NODE, &cfg_log_syslog_local_cmd); install_lib_element(CONFIG_NODE, &cfg_no_log_syslog_cmd); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41849?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ifc54d60e24547696b3059b6eb75572f8c84874d0 Gerrit-Change-Number: 41849 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log January 2026