Attention is currently required from: pespin.
Hello Jenkins Builder, fixeria, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41852?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: vty_cpu_sched.adoc: Document how to allow users to run with rtprio
......................................................................
vty_cpu_sched.adoc: Document how to allow users to run with rtprio
Change-Id: I2281bef252f5ed60fd830714798c587173e7fbb5
---
M common/chapters/vty_cpu_sched.adoc
1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/52/41852/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41852?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: I2281bef252f5ed60fd830714798c587173e7fbb5
Gerrit-Change-Number: 41852
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/41858?usp=email )
Change subject: jobs/ttcn3-testsuites: disable bpftrace
......................................................................
jobs/ttcn3-testsuites: disable bpftrace
The bpftrace process doesn't stop properly with some scripts. Disable it
for now, we can still enable it in copies of the job.
Related: OS#6925
Change-Id: I78c18c2e18d66408ac7de7cd24fafdf3f7e5202d
---
M jobs/ttcn3-testsuites.yml
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, approved
diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml
index 40a2183..3202212 100644
--- a/jobs/ttcn3-testsuites.yml
+++ b/jobs/ttcn3-testsuites.yml
@@ -95,7 +95,6 @@
builders:
- shell: |-
export REGISTRY_HOST="registry.osmocom.org"
- export RUN_BPFTRACE=1
# Translate job name to docker-playground dir and relevant
# environment variables
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41858?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I78c18c2e18d66408ac7de7cd24fafdf3f7e5202d
Gerrit-Change-Number: 41858
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/41858?usp=email )
Change subject: jobs/ttcn3-testsuites: disable bpftrace
......................................................................
jobs/ttcn3-testsuites: disable bpftrace
The bpftrace process doesn't stop properly with some scripts. Disable it
for now, we can still enable it in copies of the job.
Related: OS#6925
Change-Id: I78c18c2e18d66408ac7de7cd24fafdf3f7e5202d
---
M jobs/ttcn3-testsuites.yml
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/58/41858/1
diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml
index 40a2183..3202212 100644
--- a/jobs/ttcn3-testsuites.yml
+++ b/jobs/ttcn3-testsuites.yml
@@ -95,7 +95,6 @@
builders:
- shell: |-
export REGISTRY_HOST="registry.osmocom.org"
- export RUN_BPFTRACE=1
# Translate job name to docker-playground dir and relevant
# environment variables
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41858?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I78c18c2e18d66408ac7de7cd24fafdf3f7e5202d
Gerrit-Change-Number: 41858
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41842?usp=email )
Change subject: logging: Improve GSMTAP log documentation
......................................................................
logging: Improve GSMTAP log documentation
The section about "logs are also duplicated to stderr" is removed
because it's more or less obvious that differnet log targets work
indepndently and the force-all part is already covered further above in
the file in the general section.
Change-Id: I9434939d2a9a41bb0011a067f5ff9b94752fa781
---
M common/chapters/logging.adoc
1 file changed, 52 insertions(+), 10 deletions(-)
Approvals:
pespin: Looks good to me, approved
osmith: Looks good to me, but someone else must approve
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
diff --git a/common/chapters/logging.adoc b/common/chapters/logging.adoc
index 0b31211..b8365ec 100644
--- a/common/chapters/logging.adoc
+++ b/common/chapters/logging.adoc
@@ -215,27 +215,67 @@
----
OsmoBSC> enable
OsmoBSC# configure terminal
-OsmoBSC(config)# log gsmtap 192.168.2.3
+OsmoBSC(config)# log gsmtap 192.168.2.3 <1>
OsmoBSC(config-log)#
----
+<1> Configure a GSMTAP logging target recording to 192.168.2.3
The hostname/ip argument is optional: if omitted the default 127.0.0.1 will be used. The log strings inside GSMTAP are already
supported by Wireshark. Capturing for `port 4729` on appropriate interface will reveal log messages including source file
name and line number as well as application. This makes it easy to consolidate logs from several different network components
alongside the air frames. You can also use Wireshark to quickly filter logs for a given subsystem, severity, file name etc.
+The GSMTAP logging target also has different implementation I/O modes, which can
+be configured during the VTY "log gmstap" VTY command:
+
+nonblocking-io::
+ Use non-blocking, synchronous I/O. This is the default mode. It will set
+ the GSMTAP source socket as non-blocking, and attempt synchronous write
+ to the UDP socket, discarding a message if the UDP socket's send buffer
+ is full during write.
+blocking-io::
+ Use blocking, synchronous I/O. It will use the GSMTAP source socket in
+ blocking mode, and attempt synchronous write to the UDP socket, blocking
+ the entire thread if the UDP socket's send buffer is full during write.
+ This I/O mode should not be used in any osmocom program driven by an
+ event loop (which includes any program using a VTY), since it may block
+ the thread for an unspecified (potentially long or even infinite)
+ amount of time and hence prevent the event loop to run and process
+ events. This I/O mode should only be used under specific circumstances,
+ like debugging a crash, in which case it's interesting to get the
+ logging output to the UDP socket and hence recorded before the program
+ crashes.
+wq::
+ Workqueue mode: Use non-blocking, asynchronous I/O. It will set the
+ GSMTAP source socket as non-blocking, and attempt asynchronous write to
+ the UDP socket by means of a work queue driven by the process poll event
+ loop, delaying writing to the UDP socket until there's enough free space
+ in its send buffer. Since the workqueue has a maximum size, messages
+ will be discarded similar to _nonblocking-io_ once the UDP socket's send
+ buffer *and* the GSMTAP log target workqueue are full. This I/O mode
+ provides some extra buffering space in the userspace workqueue, at the
+ expense of extra overhead and delay to transmit messages asynchronously
+ waiting for POLLOUT event from the UDP socket.
+
+In any of the I/O modes above, the UDP socket send buffer size of the GSMTAP log
+target influences where messages may be dropped (_nonblocking-io_|_wq_) or the
+process blocked (_blocking-io_) whenever a high number of messages or test are
+transmitted in a short time. For that reason, the GSMTAP log target will attempt
+to set the `SO_SNDBUF` sockopt of the UDP socket to 4MB. In Linux, the
+`SO_SNDBUF` value being set on the socket will be trimmed by the kernel to a
+maximum allowed by sysctl `net.core.wmem_max`. Hence, if you want to be on a
+safer side minimizing dropping messages or blocking the process (depending on
+the I/O mode set), make sure sysctl `net.core.wmem_max` on your system is set to
+`4194304` (4MB) or more.
+
+NOTE: Linux Kernel used to have a `net.core.wmem_max` of `212992`(208KB) until
+recently (2025, a6d4f25888b83b8300aef28d9ee22765c1cc9b34), where it was
+increased to `4194304` (4MB) .
+
[[fig-wireshark-gsmtap-log]]
.Wireshark with logs delivered over GSMTAP
image::./common/images/wireshark-gsmtap-log.png[]
-Note: the logs are also duplicated to stderr when GSMTAP logging is configured because stderr is the default log target which is
-initialized automatically. To descrease stderr logging to absolute minimum, you can configure it as follows:
-----
-OsmoBSC> enable
-OsmoBSC# configure terminal
-OsmoBSC(config)# log stderr
-OsmoBSC(config-log)# logging level force-all fatal
-----
NOTE: Every time you generate GSMTAP messages and send it to a unicast (non-broadcast/multicast) IP address,
please make sure that the destination IP address actually has a socket open on the specified port, or drops
@@ -244,7 +284,9 @@
arriving at the source (the host on which you run the Osmocom software sending GSMTAP), suppress generation
of further GSMTAP messages for some time, resulting in incomplete files. In case of doubt, either send GSMTAP
to multicast IP addresses, or run something like `nc -l -u -p 4729 > /dev/null` on the destination host to
-open the socket at the GSMTAP port and discard anything arriving at it.
+at the GSMTAP port and discard anything arriving at it. If the GSMTAP recording address is identified as a
+local address, upon creation of the GSMTAP log target, an attempt will be made to create a dummy sink socket
+to avoid such problems automatically.
==== Logging to a file
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41842?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: I9434939d2a9a41bb0011a067f5ff9b94752fa781
Gerrit-Change-Number: 41842
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41852?usp=email )
Change subject: vty_cpu_sched.adoc: Document how to allow users to run with rtprio
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41852?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: I2281bef252f5ed60fd830714798c587173e7fbb5
Gerrit-Change-Number: 41852
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 16 Jan 2026 10:24:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: dexter, laforge, neels, pespin.
fixeria has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39742?usp=email )
Change subject: personalization: refactor ConfigurableParameter, Iccid, Imsi
......................................................................
Patch Set 16:
(1 comment)
File pySim/esim/saip/personalization.py:
https://gerrit.osmocom.org/c/pysim/+/39742/comment/700e9523_cd141005?usp=em… :
PS13, Line 50: r"""Base class representing a part of the eSIM profile that is configurable during the
> re the build failure, dear Vadim, on the contrary.
> This is a prime example why we don't need to prevent instantiation.
> The apply_val() implementation follows in a separate patch, neatly separated for readability during CR. I spent time to separate that.
If something is not there yet, one can still define a stub like this:
```
def apply_val(cls, pes: ProfileElementSequence, val):
raise NotImplementedError # XXX/TODO
```
Anyways, I am not willing/going to block here. "Heightening the misery" is certainly not what I was aiming for. I just shared my understanding of the `abc` stuff in Python and I am sorry if my comments were giving you additional headaches. This is not a project that I am directly involved in and you're not modifying the code that I wrote, so I am bailing out from the review loop of this patchset.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/39742?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I6522be4c463e34897ca9bff2309b3706a88b3ce8
Gerrit-Change-Number: 39742
Gerrit-PatchSet: 16
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 15 Jan 2026 22:06:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bts/+/41851?usp=email )
Change subject: vty: document default value for 'paging queue-size'
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41851?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I34c1529c63544ccd472b53fc7370e742ae5e3a02
Gerrit-Change-Number: 41851
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 15 Jan 2026 21:28:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bts/+/41850?usp=email )
Change subject: paging: Remove unused function
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41850?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Iff4d062e2d7ea49b61843f929ec19957a38453ab
Gerrit-Change-Number: 41850
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 15 Jan 2026 21:28:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes