Attention is currently required from: osmith.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41843?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: logging: Improve file & stderr log documentation
......................................................................
logging: Improve file & stderr log documentation
Change-Id: I90114f634ae0411e58d2f3da86d5a2e470b4d828
---
M common/chapters/logging.adoc
1 file changed, 20 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/43/41843/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41843?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: I90114f634ae0411e58d2f3da86d5a2e470b4d828
Gerrit-Change-Number: 41843
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41844?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: logging: Improve systemd-journal log documentation
......................................................................
logging: Improve systemd-journal log documentation
Change-Id: I9a67b9b8c38868004a794164724cdffc5b86a044
---
M common/chapters/logging.adoc
1 file changed, 26 insertions(+), 8 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/44/41844/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41844?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: I9a67b9b8c38868004a794164724cdffc5b86a044
Gerrit-Change-Number: 41844
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: daniel, fixeria, laforge, pespin.
Hello Jenkins Builder, daniel, fixeria, laforge, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41842?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: logging: Improve GSMTAP log documentation
......................................................................
logging: Improve GSMTAP log documentation
The section about "logs are also duplicated to stderr" is removed
because it's more or less obvious that differnet log targets work
indepndently and the force-all part is already covered further above in
the file in the general section.
Change-Id: I9434939d2a9a41bb0011a067f5ff9b94752fa781
---
M common/chapters/logging.adoc
1 file changed, 52 insertions(+), 10 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/42/41842/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41842?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: I9434939d2a9a41bb0011a067f5ff9b94752fa781
Gerrit-Change-Number: 41842
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Attention is currently required from: osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41843?usp=email )
Change subject: logging: Improve file & stderr log documentation
......................................................................
Patch Set 2:
(2 comments)
File common/chapters/logging.adoc:
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41843/comment/8479c207_e7f0… :
PS2, Line 320: _blocking-io_ parameter. This I/O mode should not be used in any osmocom program
> How about referring to the "blocking-io" section from the previous patch on details about why this s […]
I think this part is important enough to have it covered and repeated here. In the end somebody reading this section to configure a logging file doesn't necessarily need to read about a gsmtap log target, which has tons more of different context.
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41843/comment/bb448235_1b8b… :
PS2, Line 322: block the thread for an un specified (potentially long or event infinite) amount
> ```suggestion […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41843?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: I90114f634ae0411e58d2f3da86d5a2e470b4d828
Gerrit-Change-Number: 41843
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 15 Jan 2026 10:53:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Attention is currently required from: daniel, fixeria, laforge, pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41842?usp=email )
Change subject: logging: Improve GSMTAP log documentation
......................................................................
Patch Set 2:
(1 comment)
File common/chapters/logging.adoc:
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41842/comment/7494cb4f_bbe9… :
PS2, Line 239:
> Ah yes I read it to quickly, I thought it meant logging to gsmtap also meant logging to stderr. […]
fine with me, but then the commit message should be adjusted to reflect this
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41842?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: I9434939d2a9a41bb0011a067f5ff9b94752fa781
Gerrit-Change-Number: 41842
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 15 Jan 2026 10:52:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: daniel, fixeria, laforge, osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41842?usp=email )
Change subject: logging: Improve GSMTAP log documentation
......................................................................
Patch Set 2:
(1 comment)
File common/chapters/logging.adoc:
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41842/comment/50a4023b_b160… :
PS2, Line 239:
> I just tested it with osmo-mgw and it works as described in the section you have deleted: […]
Ah yes I read it to quickly, I thought it meant logging to gsmtap also meant logging to stderr. In any case, IMHO it is kind of obvios that you configure each log target independently, and then this kind of announce should be put in each other log target section. So I think it's best to drop it. The "force-all" stuff is already covered further above in the file.
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41842?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: I9434939d2a9a41bb0011a067f5ff9b94752fa781
Gerrit-Change-Number: 41842
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 15 Jan 2026 10:50:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/41846?usp=email )
Change subject: ttcn3-bts-test: add --no-warnings to bpftrace
......................................................................
ttcn3-bts-test: add --no-warnings to bpftrace
Since switching to debian 13 and having bpftrace 0.23.2 instead of
0.17.0, bpftrace is constantly printing warnings. Turn off warnings by
default so we don't end up filling up the disk space of jenkins runners
while ttcn3-bts-test runs for >2h.
We can turn on warnings in copies of the main jenkins job for
development, while also ensuring that we only run a few tests instead of
the whole testsuite.
Warnings look like this:
root@deb12build-ansible:/home/osmocom-build/jenkins/workspace/ttcn3-bts-test/logs/bts/bpftrace# head udp_sendmsg_delay.log
[Thu Jan 15 01:31:13 UTC 2026] respawn: 0: starting: /data/bpftrace/udp_sendmsg_delay.sh
+ pidof osmo-bts-trx
+ bpftrace /data/bpftrace/udp_sendmsg_delay.bt -p 9
Attaching 3 probes...
Tracing udp_sendmsg() latency... Hit Ctrl-C to end.
/data/bpftrace/udp_sendmsg_delay.bt:29:3-13: WARNING: Invalid argument
Additional Info - helper: get_ns_current_pid_tgid, retcode: -22
@start[tid] = nsecs;
~~~~~~~~~~
/data/bpftrace/udp_sendmsg_delay.bt:30:3-13: WARNING: Invalid argument
Change-Id: I0e4c62f27f67d4b8601516ce5c1ebfa415331b4a
---
M ttcn3-bts-test/jenkins.sh
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
laforge: Looks good to me, but someone else must approve
Jenkins Builder: Verified
pespin: Looks good to me, approved
diff --git a/ttcn3-bts-test/jenkins.sh b/ttcn3-bts-test/jenkins.sh
index 6e5cc67..6d738c4 100755
--- a/ttcn3-bts-test/jenkins.sh
+++ b/ttcn3-bts-test/jenkins.sh
@@ -90,8 +90,13 @@
cp "$script" "$VOL_BASE_DIR"/bts/bpftrace
+ # --no-warnings: without this, the log file can easily
+ # fill up gigabytes of data while ttcn3-bts-test does a
+ # full run. For development --no-warnings can be
+ # removed, but make sure that only few tests are
+ # running!
( echo "#!/bin/sh -ex"
- echo "bpftrace /data/bpftrace/$(basename "$script") -p \$(pidof osmo-bts-$variant)" ) >"$startscript"
+ echo "bpftrace --no-warnings /data/bpftrace/$(basename "$script") -p \$(pidof osmo-bts-$variant)" ) >"$startscript"
chmod +x "$startscript"
docker exec \
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41846?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I0e4c62f27f67d4b8601516ce5c1ebfa415331b4a
Gerrit-Change-Number: 41846
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria, laforge.
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/docker-playground/+/41846?usp=email )
Change subject: ttcn3-bts-test: add --no-warnings to bpftrace
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> yes, these warnings (all complaining about tid being invalid it seems) are printed over and over aga […]
Done
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41846?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I0e4c62f27f67d4b8601516ce5c1ebfa415331b4a
Gerrit-Change-Number: 41846
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 15 Jan 2026 10:40:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>