September 2025 - gerrit-log - lists.osmocom.org

[M] Change in ...osmo-s1gw[master]: s1ap_proxy: Add support for S1 HANDOVER procedure

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006?usp=email ) Change subject: s1ap_proxy: Add support for S1 HANDOVER procedure ...................................................................... s1ap_proxy: Add support for S1 HANDOVER procedure The HANDOVER procedure consists of two parts: * Preparation of handover on the source eNB A list of E-RABs to be released are processed by the proxy. * Resource allocation on the target eNB A list of E-RABs to be established are processed by the proxy. GTP-TEIDs and transport layer addresses will be modified. Change-Id: Ib2c8b1787c60d35a512c3c78d35e1f72a9d7bb08 Related: osmo-ttcn3-hacks.git Id349c84749f7e897defa8cfd2ecd2c1f2fb52fc7 Related: SYS#7309 --- M include/s1gw_metrics.hrl M src/s1ap_proxy.erl M src/s1gw_metrics.erl 3 files changed, 127 insertions(+), 4 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/include/s1gw_metrics.hrl b/include/s1gw_metrics.hrl index 83ec768..5afbff0 100644 --- a/include/s1gw_metrics.hrl +++ b/include/s1gw_metrics.hrl @@ -31,6 +31,9 @@ -define(S1GW_CTR_S1AP_PROXY_IN_PKT_RELEASE_CTX_REQ, [ctr, s1ap, proxy, in_pkt, release_ctx_req]). -define(S1GW_CTR_S1AP_PROXY_IN_PKT_RELEASE_CTX_CMD, [ctr, s1ap, proxy, in_pkt, release_ctx_cmd]). -define(S1GW_CTR_S1AP_PROXY_IN_PKT_RELEASE_CTX_COMPL, [ctr, s1ap, proxy, in_pkt, release_ctx_compl]). +-define(S1GW_CTR_S1AP_PROXY_IN_PKT_HANDOVER_CMD, [ctr, s1ap, proxy, in_pkt, handover_cmd]). +-define(S1GW_CTR_S1AP_PROXY_IN_PKT_HANDOVER_REQ, [ctr, s1ap, proxy, in_pkt, handover_req]). +-define(S1GW_CTR_S1AP_PROXY_IN_PKT_HANDOVER_REQ_ACK, [ctr, s1ap, proxy, in_pkt, handover_req_ack]). -define(S1GW_CTR_S1AP_PROXY_OUT_PKT_FWD_ALL, [ctr, s1ap, proxy, out_pkt, forward, all]). -define(S1GW_CTR_S1AP_PROXY_OUT_PKT_FWD_PROC, [ctr, s1ap, proxy, out_pkt, forward, proc]). -define(S1GW_CTR_S1AP_PROXY_OUT_PKT_FWD_UNMODIFIED, [ctr, s1ap, proxy, out_pkt, forward, unmodified]). diff --git a/src/s1ap_proxy.erl b/src/s1ap_proxy.erl index a08f61d..0046167 100644 --- a/src/s1ap_proxy.erl +++ b/src/s1ap_proxy.erl @@ -626,10 +626,58 @@ dict:to_list(ERABs)), {forward, S}; %% forward as-is, there's nothing to patch -%% TODO: 9.1.5.2 HANDOVER COMMAND :: (O) UL/DL Transport Layer Address -%% TODO: 9.1.5.4 HANDOVER REQUEST :: (M) Transport Layer Address -%% TODO: 9.1.5.5 HANDOVER REQUEST ACKNOWLEDGE :: (M) Transport Layer Address, -%% (O) UL/DL Transport Layer Address +%% 9.1.5.2 HANDOVER COMMAND +handle_pdu({successfulOutcome, + #'SuccessfulOutcome'{procedureCode = ?'id-HandoverPreparation', + value = C0}}, S0) -> + ?LOG_DEBUG("Processing HANDOVER COMMAND"), + ctr_inc(?S1GW_CTR_S1AP_PROXY_IN_PKT_HANDOVER_CMD, S0), + case handle_ies(?'id-E-RABtoReleaseListHOCmd', + C0#'HandoverCommand'.protocolIEs, S0) of + {{ok, _}, S1} -> + {forward, S1}; %% forward as-is, there's nothing to patch + {{error, Reason}, S1} -> + ?LOG_NOTICE("Failed to process HANDOVER COMMAND: ~p", [Reason]), + ctr_inc(?S1GW_CTR_S1AP_PROXY_IN_PKT_PROC_ERROR, S1), + {forward, S1} + end; + +%% 9.1.5.4 HANDOVER REQUEST +handle_pdu({Outcome = initiatingMessage, + #'InitiatingMessage'{procedureCode = ?'id-HandoverResourceAllocation', + value = C0} = Msg}, S0) -> + ?LOG_DEBUG("Processing HANDOVER REQUEST"), + ctr_inc(?S1GW_CTR_S1AP_PROXY_IN_PKT_HANDOVER_REQ, S0), + case handle_ies(?'id-E-RABToBeSetupListHOReq', + C0#'HandoverRequest'.protocolIEs, S0) of + {{ok, IEs}, S1} -> + C1 = C0#'HandoverRequest'{protocolIEs = IEs}, + PDU = {Outcome, Msg#'InitiatingMessage'{value = C1}}, + {{forward, PDU}, S1}; %% forward patched PDU + {{error, Reason}, S1} -> + ?LOG_NOTICE("Failed to process HANDOVER REQUEST: ~p", [Reason]), + ctr_inc(?S1GW_CTR_S1AP_PROXY_IN_PKT_PROC_ERROR, S1), + {drop, S1} %% drop this PDU + end; + +%% 9.1.5.5 HANDOVER REQUEST ACKNOWLEDGE, +handle_pdu({Outcome = successfulOutcome, + #'SuccessfulOutcome'{procedureCode = ?'id-HandoverResourceAllocation', + value = C0} = Msg}, S0) -> + ?LOG_DEBUG("Processing HANDOVER REQUEST ACKNOWLEDGE"), + ctr_inc(?S1GW_CTR_S1AP_PROXY_IN_PKT_HANDOVER_REQ_ACK, S0), + case handle_ies(?'id-E-RABAdmittedList', + C0#'HandoverRequestAcknowledge'.protocolIEs, S0) of + {{ok, IEs}, S1} -> + C1 = C0#'HandoverRequestAcknowledge'{protocolIEs = IEs}, + PDU = {Outcome, Msg#'SuccessfulOutcome'{value = C1}}, + {{forward, PDU}, S1}; %% forward patched PDU + {{error, Reason}, S1} -> + ?LOG_NOTICE("Failed to process HANDOVER REQUEST ACKNOWLEDGE: ~p", [Reason]), + ctr_inc(?S1GW_CTR_S1AP_PROXY_IN_PKT_PROC_ERROR, S1), + {drop, S1} %% drop this PDU + end; + %% TODO: 9.1.5.8 PATH SWITCH REQUEST :: (M) Transport Layer Address %% TODO: 9.1.5.9 PATH SWITCH REQUEST ACKNOWLEDGE :: (M) Transport Layer Address @@ -1010,6 +1058,74 @@ {{error, erab_not_registered}, S} end; +%% HANDOVER COMMAND related IEs +handle_ie([?'id-E-RABtoReleaseListHOCmd'], C, S) -> + %% This IE contains a list of E-RABItem, so patch inner IEs + handle_ies(?'id-E-RABItem', C, S); + +handle_ie([?'id-E-RABItem', + ?'id-E-RABtoReleaseListHOCmd'], + #'E-RABItem'{'e-RAB-ID' = ERABId} = C, S) -> + %% poke E-RAB FSM + case erab_fsm_find(ERABId, S) of + {ok, Pid} -> + ok = erab_fsm:erab_release_ind(Pid), + {{ok, C}, S}; + error -> + ?LOG_ERROR("E-RAB-ID ~p is not registered", [erab_uid(ERABId, S)]), + {{error, erab_not_registered}, S} + end; + +%% HANDOVER REQUEST related IEs +handle_ie([?'id-E-RABToBeSetupListHOReq'], C, S) -> + %% This IE contains a list of E-RABToBeSetupItemHOReq, so patch inner IEs + handle_ies(?'id-E-RABToBeSetupItemHOReq', C, S); + +handle_ie([?'id-E-RABToBeSetupItemHOReq', + ?'id-E-RABToBeSetupListHOReq'], + #'E-RABToBeSetupItemHOReq'{'e-RAB-ID' = ERABId, + 'transportLayerAddress' = TLA_In, + 'gTP-TEID' = << TEID_In:32/big >>} = C0, S0) -> + %% start and register an E-RAB FSM + {Pid, S1} = erab_fsm_start_reg(ERABId, S0), + case erab_fsm:erab_setup_req(Pid, {TEID_In, TLA_In}) of + {ok, {TEID_Out, TLA_Out}} -> + C1 = C0#'E-RABToBeSetupItemHOReq'{'transportLayerAddress' = TLA_Out, + 'gTP-TEID' = << TEID_Out:32/big >>}, + {{ok, C1}, S1}; + {error, Reason} -> + {{error, Reason}, S1} + end; + +%% HANDOVER REQUEST ACKNOWLEDGE related IEs +handle_ie([?'id-E-RABAdmittedList'], C, S) -> + %% This IE contains a list of E-RABAdmittedItem, so patch inner IEs + handle_ies(?'id-E-RABAdmittedItem', C, S); + +handle_ie([?'id-E-RABAdmittedItem', + ?'id-E-RABAdmittedList'], + #'E-RABAdmittedItem'{'e-RAB-ID' = ERABId, + 'transportLayerAddress' = TLA_In, + 'gTP-TEID' = << TEID_In:32/big >>} = C0, S) -> + %% indicate eNB's address to the gtpu_kpi module + gtpu_kpi_enb_set_addr({s1ap, tla_str(TLA_In)}), + %% poke E-RAB FSM + case erab_fsm_find(ERABId, S) of + {ok, Pid} -> + case erab_fsm:erab_setup_rsp(Pid, {TEID_In, TLA_In}) of + {ok, {TEID_Out, TLA_Out}} -> + C1 = C0#'E-RABAdmittedItem'{'transportLayerAddress' = TLA_Out, + 'gTP-TEID' = << TEID_Out:32/big >>}, + {{ok, C1}, S}; + {error, Reason} -> + {{error, Reason}, S} + end; + error -> + ?LOG_ERROR("E-RAB-ID ~p is not registered", [erab_uid(ERABId, S)]), + {{error, erab_not_registered}, S} + end; + + %% Catch-all variant, which should not be called normally handle_ie(P, C, S) -> ?LOG_ERROR("[BUG] Unhandled S1AP IE: ~p, ~p", [P, C]), diff --git a/src/s1gw_metrics.erl b/src/s1gw_metrics.erl index 1c3d76e..8a74774 100644 --- a/src/s1gw_metrics.erl +++ b/src/s1gw_metrics.erl @@ -86,6 +86,10 @@ ?S1GW_CTR_S1AP_PROXY_IN_PKT_RELEASE_CTX_REQ, %% UE CONTEXT RELEASE.req PDUs ?S1GW_CTR_S1AP_PROXY_IN_PKT_RELEASE_CTX_CMD, %% UE CONTEXT RELEASE.cmd PDUs ?S1GW_CTR_S1AP_PROXY_IN_PKT_RELEASE_CTX_COMPL, %% UE CONTEXT RELEASE.compl PDUs + ?S1GW_CTR_S1AP_PROXY_IN_PKT_HANDOVER_CMD, %% HANDOVER COMMAND PDUs + ?S1GW_CTR_S1AP_PROXY_IN_PKT_HANDOVER_REQ, %% HANDOVER REQUEST PDUs + ?S1GW_CTR_S1AP_PROXY_IN_PKT_HANDOVER_REQ_ACK, %% HANDOVER REQUEST ACKNOWLEDGE PDUs + %% s1ap_proxy: OUTgoing PDU counters ?S1GW_CTR_S1AP_PROXY_OUT_PKT_FWD_ALL, %% forwarded: total ?S1GW_CTR_S1AP_PROXY_OUT_PKT_FWD_PROC, %% forwarded: processed -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ib2c8b1787c60d35a512c3c78d35e1f72a9d7bb08 Gerrit-Change-Number: 41006 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 weeks, 1 day

1
0
0 0

[XS] Change in ...osmo-epdg[master]: s2b: set correct instance values for Bearers

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37899?usp=email ) Change subject: s2b: set correct instance values for Bearers ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37899?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Ibce4a2e44a3bb0d7e1d86953a94929242d45a3dd Gerrit-Change-Number: 37899 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 07 Sep 2025 20:57:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 1 day

1
0
0 0

[M] Change in ...osmo-s1gw[master]: s1ap_proxy_test: Add unit tests for S1 HANDOVER procedure

by pespin

Attention is currently required from: fixeria, jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029?usp=email ) Change subject: s1ap_proxy_test: Add unit tests for S1 HANDOVER procedure ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I400ac73343f2a795c8206aeee75a31f1455adbd0 Gerrit-Change-Number: 41029 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 07 Sep 2025 20:54:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 1 day

1
0
0 0

[M] Change in ...osmo-s1gw[master]: s1ap_proxy: Add support for S1 HANDOVER procedure

by pespin

Attention is currently required from: fixeria, jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006?usp=email ) Change subject: s1ap_proxy: Add support for S1 HANDOVER procedure ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ib2c8b1787c60d35a512c3c78d35e1f72a9d7bb08 Gerrit-Change-Number: 41006 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 07 Sep 2025 20:52:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 1 day

1
0
0 0

[XL] Change in osmo-ttcn3-hacks[master]: mme: Split ConnHdlr to its own file

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41065?usp=email ) Change subject: mme: Split ConnHdlr to its own file ...................................................................... Patch Set 1: (1 comment) File mme/ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41065/comment/71059991_34b3… : PS1, Line 927: } > "No newline at end of right file. […] Just did: https://stackoverflow.com/questions/44704968/visual-studio-code-insert-newl… I'll fix this. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41065?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I322e679fa252388649b897a13d2d4a325212a71a Gerrit-Change-Number: 41065 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 07 Sep 2025 20:50:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

2 weeks, 1 day

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: mme: Move g_Tguard to MTC_CT

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41063?usp=email ) Change subject: mme: Move g_Tguard to MTC_CT ...................................................................... Patch Set 3: (1 comment) File mme/MME_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41063/comment/a2b947c3_4880… : PS3, Line 102: 45.0; > The commit message says "move", but you're also increasing (30 -> 45) it? […] Yes that's exactly it. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41063?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8b766ad83030ac5c92fe64b7ea2df35468b23fc0 Gerrit-Change-Number: 41063 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 07 Sep 2025 20:46:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

2 weeks, 1 day

1
0
0 0

[XS] Change in ...osmo-epdg[master]: s2b: set correct instance values for Bearers

by fixeria

Attention is currently required from: lynxis lazus, pespin. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37899?usp=email ) Change subject: s2b: set correct instance values for Bearers ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37899/comment/45fef9d9_a628… : PS1, Line 9: explicit > I see no changes... Done -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37899?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Ibce4a2e44a3bb0d7e1d86953a94929242d45a3dd Gerrit-Change-Number: 37899 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 07 Sep 2025 16:33:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

2 weeks, 1 day

1
0
0 0

[XS] Change in ...osmo-epdg[master]: s2b: set correct instance values for Bearers

by lynxis lazus

Attention is currently required from: fixeria, lynxis lazus, pespin. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37899?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+2 by pespin, Verified+1 by Jenkins Builder The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: s2b: set correct instance values for Bearers ...................................................................... s2b: set correct instance values for Bearers The instance value is explicitly defined in 3GPP TS 29.274 for a given F-TEID in the Bearer IE and is coupled to the F-TEID type on a specific interface. Change-Id: Ibce4a2e44a3bb0d7e1d86953a94929242d45a3dd --- M src/epdg_gtpc_s2b.erl 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/99/37899/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37899?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Ibce4a2e44a3bb0d7e1d86953a94929242d45a3dd Gerrit-Change-Number: 37899 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

2 weeks, 2 days

1
0
0 0

[XS] Change in ...osmo-epdg[master]: s2b: set correct instance values for Bearers

by fixeria

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37899?usp=email ) Change subject: s2b: set correct instance values for Bearers ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37899/comment/194afbb1_4097… : PS1, Line 9: explicit > Done I see no changes... -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37899?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Ibce4a2e44a3bb0d7e1d86953a94929242d45a3dd Gerrit-Change-Number: 37899 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 07 Sep 2025 10:56:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

2 weeks, 2 days

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: S1GW tests: Add test cases for S1 handover procedure

by fixeria

Attention is currently required from: jolly, pespin. fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009?usp=email ) Change subject: S1GW tests: Add test cases for S1 handover procedure ...................................................................... Patch Set 1: (15 comments) Patchset: PS1: You're adding new testcases, so please edit `s1gw/expected-results.xml` accordingly. Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/7c8ce8c9_418a… : PS1, Line 9: preperation prepare, not prepere https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/0b464bca_3959… : PS1, Line 12: Change-Id: Id349c84749f7e897defa8cfd2ecd2c1f2fb52fc7 `Related: SYS#7309` File s1gw/S1GW_ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/6f5bd778_8884… : PS1, Line 76: /* PLMNidentity */ '62F210'O, > you know you can assign by field name instead of commenting all of them? […] Ack, let's please use field names here. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/f989c95b_9ac5… : PS1, Line 1072: function f_ConnHdlr_tx_handover_req(in ERabList erabs, > either add in to all params or to none. […] I intentionally use `in` / `out` in this API to clearly indicate whether the given E-RAB list is to be modified or to remain unchanged. For the `MME_UE_S1AP_ID` it does not really matter and I like the way it is. It's consistent with the existing code (for instance, see `f_ConnHdlr_{tx,rx}_initial_ctx_setup_rsp()`). https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/1e576a5f_449a… : PS1, Line 1090: items[i] := ts_E_RABToBeSetupListHOReq(item)[0]; > see the problem I mentioned in the previous commit? You end up doing weird stuff with [0] because yo […] As explained in the previous commit, it's not possible to define the templates for a single item. This is why we have this hack here (and in the other existing functions too). https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/07dba3f4_d2dc… : PS1, Line 1115: item := tr_E_RABToBeSetupItemHOReq(rab_id := erabs[i].erab_id, cosmetic: alignment issues https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/603cf104_9397… : PS1, Line 1185: in ERabList erabs Unused argument, not needed here. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/ddae016e_69bb… : PS1, Line 1197: in ERabList erabs Unused argument, not needed here. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/d84f913a_3790… : PS1, Line 1207: ts_TargetID `tr_TargetID` (receive template, not send). https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/f2b4e16a_3e7e… : PS1, Line 1629: MME_UE_S1AP_ID mme_ue_id) cosmetic: alignment issues https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/97024f96_48c1… : PS1, Line 1678: inout ERabList erabs This function does not modify the given list, so it should be `in`. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/5cf3f587_a363… : PS1, Line 1693: inout ERabList erabs This function does not modify the given list, so it should be `in`. File s1gw/S1GW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/99189321_8cb9… : PS1, Line 872: Handover Request I would say "Handover Preparation procedures" here. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/e6e0872c_81e8… : PS1, Line 873: preperation "prepare", not "prepere" -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id349c84749f7e897defa8cfd2ecd2c1f2fb52fc7 Gerrit-Change-Number: 41009 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 07 Sep 2025 10:52:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

2 weeks, 2 days

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2025