September 2025 - gerrit-log - lists.osmocom.org

[M] Change in osmo-bts[master]: FR/HR/EFR: centralize TCH UL SID classification

by fixeria

Attention is currently required from: falconia. fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/41048?usp=email ) Change subject: FR/HR/EFR: centralize TCH UL SID classification ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/41048/comment/843d933e_8e3bda70?usp… : PS2, Line 2358: /* This static function should never be called except for : * V1 and EFR speech modes. */ : > If we were to call `tch_ul_fr_hr_efr()` from `l1sap_tch_ind()` unconditionally like you suggest, the […] I guess you mean the code you're adding in a follow-up patch, resetting `ul_sid_filter`? My suggestion arose before I saw next patches :) Makes sense, I am fine keeping it as-is. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41048?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id6c8c146962de2f173760889eb232693bb4229d3 Gerrit-Change-Number: 41048 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Fri, 05 Sep 2025 22:33:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

2 weeks, 3 days

1
0
0 0

[M] Change in osmo-bts[master]: HRv1 codec: add support for TW-TS-002

by falconia

Attention is currently required from: fixeria, pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/41050?usp=email ) Change subject: HRv1 codec: add support for TW-TS-002 ...................................................................... Patch Set 3: (1 comment) File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/41050/comment/4cc5a517_9e35db46?usp… : PS2, Line 2278: send_frame > I'll spin another revision of this patch, modified per your suggestion. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41050?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Icf11e43d4ce9df990d0e0a856d62d9ea11cb837c Gerrit-Change-Number: 41050 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Sep 2025 22:22:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

2 weeks, 3 days

1
0
0 0

[M] Change in osmo-bts[master]: HRv1 codec: add support for TW-TS-002

by falconia

Attention is currently required from: fixeria, pespin. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/41050?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: HRv1 codec: add support for TW-TS-002 ...................................................................... HRv1 codec: add support for TW-TS-002 OsmoBTS supports TW-TS-001 enhanced RTP format for FR and EFR codecs since 2024, providing functional equivalent of GSM 08.60 TRAU-UL output over IP physical transport. Now do the same with TW-TS-002, IP equivalent of GSM 08.61 for HRv1 codec. Only TCH UL path is affected; no changes are needed to TCH DL path because existing RTP Rx handling for RFC 5993 also covers TW-TS-002. Related: OS#6036 Change-Id: Icf11e43d4ce9df990d0e0a856d62d9ea11cb837c --- M src/common/bts.c M src/common/l1sap.c 2 files changed, 71 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/50/41050/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41050?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Icf11e43d4ce9df990d0e0a856d62d9ea11cb837c Gerrit-Change-Number: 41050 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

2 weeks, 3 days

1
0
0 0

[M] Change in osmo-bts[master]: HRv1 codec: add support for TW-TS-002

by falconia

Attention is currently required from: fixeria. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/41050?usp=email ) Change subject: HRv1 codec: add support for TW-TS-002 ...................................................................... Patch Set 2: (1 comment) File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/41050/comment/4289bca2_ad86b2cd?usp… : PS2, Line 2278: send_frame > You could do `ft != FT_NO_DATA` here and eliminate `bool send_frame`. Not critical though. I'll spin another revision of this patch, modified per your suggestion. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41050?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Icf11e43d4ce9df990d0e0a856d62d9ea11cb837c Gerrit-Change-Number: 41050 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Sep 2025 22:14:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

2 weeks, 3 days

1
0
0 0

[M] Change in osmo-bts[master]: FR/HR/EFR: centralize TCH UL SID classification

by falconia

Attention is currently required from: fixeria. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/41048?usp=email ) Change subject: FR/HR/EFR: centralize TCH UL SID classification ...................................................................... Patch Set 2: (1 comment) File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/41048/comment/f4506f26_b85231c0?usp… : PS2, Line 2358: /* This static function should never be called except for : * V1 and EFR speech modes. */ : > I suggest to return here, like you do above: […] If we were to call `tch_ul_fr_hr_efr()` from `l1sap_tch_ind()` unconditionally like you suggest, the code at the top of `tch_ul_fr_hr_efr()` before the per-codec switch will execute for all channel modes, including those that aren't FR/HR/EFR. While no actual harm will result, it still feels philosophically wrong. Therefore, I prefer to keep the current arrangement. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41048?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id6c8c146962de2f173760889eb232693bb4229d3 Gerrit-Change-Number: 41048 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Sep 2025 22:09:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

2 weeks, 3 days

1
0
0 0

[M] Change in osmo-bts[master]: HRv1 codec: add support for TW-TS-002

by fixeria

Attention is currently required from: falconia. fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/41050?usp=email ) Change subject: HRv1 codec: add support for TW-TS-002 ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/41050/comment/0badb61c_4a826d09?usp… : PS2, Line 2278: send_frame You could do `ft != FT_NO_DATA` here and eliminate `bool send_frame`. Not critical though. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41050?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Icf11e43d4ce9df990d0e0a856d62d9ea11cb837c Gerrit-Change-Number: 41050 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Fri, 05 Sep 2025 21:00:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

2 weeks, 3 days

1
0
0 0

[M] Change in osmo-bts[master]: FR/HR/EFR: centralize TCH UL SID classification

by fixeria

Attention is currently required from: falconia. fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/41048?usp=email ) Change subject: FR/HR/EFR: centralize TCH UL SID classification ...................................................................... Patch Set 2: (1 comment) File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/41048/comment/cf2575bf_d2e579d8?usp… : PS2, Line 2460: This logic can also set : * BFI that wasn't set before > Is this really the case? I can see `tch_ul_msg_bfi()` being used to check for BFI, but not actually […] Indeed, I see the BFI flag being set in the next patch. Marking as resolved. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41048?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id6c8c146962de2f173760889eb232693bb4229d3 Gerrit-Change-Number: 41048 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Fri, 05 Sep 2025 20:53:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

2 weeks, 3 days

1
0
0 0

[M] Change in osmo-bts[master]: FR/HR/EFR: implement SID filter in TCH UL path

by fixeria

Attention is currently required from: falconia. fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/41049?usp=email ) Change subject: FR/HR/EFR: implement SID filter in TCH UL path ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/41049/comment/c1f49ad4_30a5fac0?usp… : PS2, Line 30: https://osmocom.org/projects/retro-gsm/wiki/DTXu_half-blocks BTW, very interesting read, thanks! -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41049?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I46c62312316b04567bcadf6050597673f071247d Gerrit-Change-Number: 41049 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Fri, 05 Sep 2025 20:52:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

2 weeks, 3 days

1
0
0 0

[M] Change in osmo-bts[master]: FR/HR/EFR: centralize TCH UL SID classification

by fixeria

Attention is currently required from: falconia. fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/41048?usp=email ) Change subject: FR/HR/EFR: centralize TCH UL SID classification ...................................................................... Patch Set 2: Code-Review+1 (2 comments) File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/41048/comment/1f345a2a_434f314a?usp… : PS2, Line 2358: /* This static function should never be called except for : * V1 and EFR speech modes. */ : I suggest to return here, like you do above: ```suggestion return; ``` This way you can call `tch_ul_fr_hr_efr()` from `l1sap_tch_ind()` unconditionally, avoiding additional `lchan->tch_mode == ...` checks. https://gerrit.osmocom.org/c/osmo-bts/+/41048/comment/5a168792_2f5f5b7e?usp… : PS2, Line 2460: This logic can also set : * BFI that wasn't set before Is this really the case? I can see `tch_ul_msg_bfi()` being used to check for BFI, but not actually setting the BFI flag. Maybe this will be the case in one of the next patches? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41048?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id6c8c146962de2f173760889eb232693bb4229d3 Gerrit-Change-Number: 41048 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Fri, 05 Sep 2025 20:40:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

2 weeks, 3 days

1
0
0 0

[M] Change in osmo-bts[master]: TCH UL path: add out-of-band BFI flag

by fixeria

Attention is currently required from: dexter, falconia. fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/41047?usp=email ) Change subject: TCH UL path: add out-of-band BFI flag ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41047?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8097946429e83eae90f89e49d17ffb8eb0636fcb Gerrit-Change-Number: 41047 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Sep 2025 20:01:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 3 days

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2025