September 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmocom-bb[master]: debian: fix empty osmocom-bb-{trxcon,virtphy} packages

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41068?usp=email ) Change subject: debian: fix empty osmocom-bb-{trxcon,virtphy} packages ...................................................................... debian: fix empty osmocom-bb-{trxcon,virtphy} packages For each of layer23, trxcon, and virt_phy: * Configure/build using the top-level Makefile. * Install into its own DESTDIR (`debian/tmp/$PROJ`). * Add the respective `*.install` file. Change-Id: Ieee634f7f643a7599c735a5b77549cf34deb7fb9 Related: OS#6851 --- A debian/osmocom-bb-layer23.install A debian/osmocom-bb-trxcon.install A debian/osmocom-bb-virtphy.install M debian/rules 4 files changed, 12 insertions(+), 28 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/68/41068/1 diff --git a/debian/osmocom-bb-layer23.install b/debian/osmocom-bb-layer23.install new file mode 100644 index 0000000..7a31ca5 --- /dev/null +++ b/debian/osmocom-bb-layer23.install @@ -0,0 +1 @@ +layer23/usr/local/bin/* usr/bin diff --git a/debian/osmocom-bb-trxcon.install b/debian/osmocom-bb-trxcon.install new file mode 100644 index 0000000..3876e55 --- /dev/null +++ b/debian/osmocom-bb-trxcon.install @@ -0,0 +1 @@ +trxcon/usr/local/bin/trxcon usr/bin diff --git a/debian/osmocom-bb-virtphy.install b/debian/osmocom-bb-virtphy.install new file mode 100644 index 0000000..858e4f0 --- /dev/null +++ b/debian/osmocom-bb-virtphy.install @@ -0,0 +1 @@ +virt_phy/usr/local/bin/virtphy usr/bin diff --git a/debian/rules b/debian/rules index e4f5cb0..ea20439 100755 --- a/debian/rules +++ b/debian/rules @@ -1,34 +1,15 @@ #!/usr/bin/make -f -DH_ARGS := -D src/host/$$SUBPKG_DIR --with-autoreconf %: - export SUBPKG=layer23; \ - export SUBPKG_DIR=layer23; \ - export SUBPKG_CFG=--with-gapk-io; \ - dh $@ $(DH_ARGS) + dh $@ - export SUBPKG=trxcon; \ - export SUBPKG_DIR=trxcon; \ - dh $@ $(DH_ARGS) +override_dh_auto_build: + $(MAKE) -C src layer23 HOST_CONFARGS="--with-gapk-io" + $(MAKE) -C src trxcon + $(MAKE) -C src virtphy - export SUBPKG=virtphy; \ - export SUBPKG_DIR=virt_phy; \ - dh $@ $(DH_ARGS) +# Installs a sub-project from src/host/ to its own DESTDIR +install-%: src/host/% + $(MAKE) -C "$^" DESTDIR="$(CURDIR)/debian/tmp/$*" install -# We need to run autoreconf multiple times, but dh_autoreconf can only run once -# (see dh-autoreconf(7)). Run autoreconf directly to work around this. -override_dh_autoreconf: - cd src/host/$$SUBPKG_DIR && autoreconf -fi - -override_dh_auto_configure: - dh_auto_configure -D src/host/$$SUBPKG_DIR -- $$SUBPKG_CFG - -override_dh_auto_install: - dh_auto_install -O-Dsrc/host/$$SUBPKG_DIR --destdir=debian/osmocom-bb-$$SUBPKG/ - -# Run dh_prep only for the first subpackage. Otherwise previously built -# binaries get removed and we end up with empty packages. -override_dh_prep: - if [ "$$SUBPKG" = "layer23" ]; then \ - dh_prep; \ - fi +override_dh_auto_install: install-layer23 install-trxcon install-virt_phy -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41068?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ieee634f7f643a7599c735a5b77549cf34deb7fb9 Gerrit-Change-Number: 41068 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

2 weeks, 1 day

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: Add templates for S1AP Handover procedure

by jolly

Attention is currently required from: fixeria, pespin. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008?usp=email ) Change subject: Add templates for S1AP Handover procedure ...................................................................... Patch Set 2: (5 comments) File library/s1ap/S1AP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/50ff79ed_2e9e… : PS1, Line 2293: procedureCode := S1AP_Constants.id_HandoverPreparation, > Are you sure this ID is correct? Yes, this ID in conjunction with initiating meassage defines the message type. Wireshark trace confirms this. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/fde8dc55_1c1a… : PS1, Line 2337: procedureCode := S1AP_Constants.id_HandoverPreparation, > Are you sure this ID is correct? Yes, dito. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/ab2cc1f3_37b3… : PS1, Line 2370: } > Optional IEs can be added later whenever they're needed. […] I agree. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/e8e74a4c_8599… : PS1, Line 2391: template (omit) TransportLayerAddress dl_tla, > we usually set default value to ":= omit" for "template (omit)". Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/37cef340_c0e2… : PS1, Line 2638: *, > I see no optional IEs between the `E-RABs To Be Setup List` and `Source to Target […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib8b8aee0665a4f6644287b802f5e941bd82128f6 Gerrit-Change-Number: 41008 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Sep 2025 13:36:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

2 weeks, 1 day

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: S1GW tests: Add test cases for S1 handover procedure

by jolly

Attention is currently required from: fixeria, pespin. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009?usp=email ) Change subject: S1GW tests: Add test cases for S1 handover procedure ...................................................................... Patch Set 1: (14 comments) Patchset: PS1: > You're adding new testcases, so please edit `s1gw/expected-results.xml` accordingly. Done Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/125200c8_ab91… : PS1, Line 9: preperation > prepare, not prepere Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/e900f8bb_eed9… : PS1, Line 12: Change-Id: Id349c84749f7e897defa8cfd2ecd2c1f2fb52fc7 > `Related: SYS#7309` Done File s1gw/S1GW_ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/48079bf9_0fa8… : PS1, Line 71: template TargetID > const c_TargetID Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/760ad866_2470… : PS1, Line 76: /* PLMNidentity */ '62F210'O, > Ack, let's please use field names here. Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/b27cca8e_eea6… : PS1, Line 1115: item := tr_E_RABToBeSetupItemHOReq(rab_id := erabs[i].erab_id, > cosmetic: alignment issues Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/38a7f95a_45c7… : PS1, Line 1185: in ERabList erabs > Unused argument, not needed here. Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/c07daa34_791d… : PS1, Line 1197: in ERabList erabs > Unused argument, not needed here. Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/6e106b36_c207… : PS1, Line 1207: ts_TargetID > `tr_TargetID` (receive template, not send). Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/1a3b070a_e559… : PS1, Line 1629: MME_UE_S1AP_ID mme_ue_id) > cosmetic: alignment issues Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/f06a167e_e10c… : PS1, Line 1678: inout ERabList erabs > This function does not modify the given list, so it should be `in`. Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/82934de1_d147… : PS1, Line 1693: inout ERabList erabs > This function does not modify the given list, so it should be `in`. Done File s1gw/S1GW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/db866013_2857… : PS1, Line 872: Handover Request > I would say "Handover Preparation procedures" here. Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/744937ea_92b2… : PS1, Line 873: preperation > "prepare", not "prepere" Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id349c84749f7e897defa8cfd2ecd2c1f2fb52fc7 Gerrit-Change-Number: 41009 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Sep 2025 13:36:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

2 weeks, 1 day

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: Add templates for S1AP Handover procedure

by jolly

Attention is currently required from: jolly, pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: Add templates for S1AP Handover procedure ...................................................................... Add templates for S1AP Handover procedure These templates include handover preperation and resource allocation for S1 handover procedure. It supports mandatory information elements only at this time. Related: SYS#7309 Change-Id: Ib8b8aee0665a4f6644287b802f5e941bd82128f6 --- M library/s1ap/S1AP_Templates.ttcn 1 file changed, 492 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/08/41008/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib8b8aee0665a4f6644287b802f5e941bd82128f6 Gerrit-Change-Number: 41008 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

2 weeks, 1 day

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: S1GW tests: Add test cases for S1 handover procedure

by jolly

Attention is currently required from: jolly, pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: S1GW tests: Add test cases for S1 handover procedure ...................................................................... S1GW tests: Add test cases for S1 handover procedure The test cases expect the handover preparation and resource allocation to be passed on correctly with expected modifcation of E-RABs. Related: SYS#7309 Change-Id: Id349c84749f7e897defa8cfd2ecd2c1f2fb52fc7 --- M s1gw/S1GW_ConnHdlr.ttcn M s1gw/S1GW_Tests.ttcn M s1gw/expected-results.xml 3 files changed, 323 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/09/41009/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id349c84749f7e897defa8cfd2ecd2c1f2fb52fc7 Gerrit-Change-Number: 41009 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

2 weeks, 1 day

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: library/SGsAP_CodecPort: Properly fill in ASP_Send record

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41060?usp=email ) Change subject: library/SGsAP_CodecPort: Properly fill in ASP_Send record ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41060?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6434a6522af3cae35824df5931ad5c33d79c505b Gerrit-Change-Number: 41060 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Sep 2025 13:31:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 1 day

1
0
0 0

[L] Change in ...osmo-python-tests[master]: Drop osmopy/twisted_ipa.py and scripts/{ctrl2cgi.py,soap.py}

by laforge

Attention is currently required from: fixeria, osmith, pespin. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/41055?usp=email ) Change subject: Drop osmopy/twisted_ipa.py and scripts/{ctrl2cgi.py,soap.py} ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/41055?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Change-Id: I848f60270dd683a56f56117c328d9961ac678d4b Gerrit-Change-Number: 41055 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Sep 2025 13:30:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 1 day

1
0
0 0

[XS] Change in ...osmo-python-tests[master]: debian: install /etc/osmocom/osmo-trap2cgi.ini

by laforge

Attention is currently required from: fixeria, osmith, pespin. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/41054?usp=email ) Change subject: debian: install /etc/osmocom/osmo-trap2cgi.ini ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/41054?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Change-Id: I6251364e36c691b7a8348c4adc4ee34ff141bca6 Gerrit-Change-Number: 41054 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Sep 2025 13:29:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 1 day

1
0
0 0

[S] Change in ...osmo-python-tests[master]: debian: add python3-osmopy-{libs,utils}.install

by laforge

Attention is currently required from: fixeria, osmith, pespin. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/41053?usp=email ) Change subject: debian: add python3-osmopy-{libs,utils}.install ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/41053?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Change-Id: I94b940789e138341792f40eedeedb73d4e4d421e Gerrit-Change-Number: 41053 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Sep 2025 13:29:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 1 day

1
0
0 0

[XS] Change in libosmo-asn1-tcap[master]: Fix decoding of TCAP messages

by laforge

Attention is currently required from: daniel, fixeria, osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41021?usp=email ) Change subject: Fix decoding of TCAP messages ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41021?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I4a27a52b2be70b1fc50e0a3d5441ded4c151fe65 Gerrit-Change-Number: 41021 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Sep 2025 13:28:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 1 day

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2025