September 2025 - gerrit-log - lists.osmocom.org

[XS] Change in libosmo-asn1-tcap[master]: Fix decoding of TCAP messages
by osmith 15 Sep '25

15 Sep '25

osmith has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41021?usp=email ) Change subject: Fix decoding of TCAP messages ...................................................................... Fix decoding of TCAP messages Recent versions of asn1c fail while decoding the DialoguePortion of a TCAP message - probably because Tag APPLICATION 11 is sent as constructed tag and the WS adaptation expects a primitive one. Not sure if this ever worked with an older asn1c version, maybe it ignored this discrepancy. The described behavior also happens with mouse07410/asn1c 2c06555 used in the next patch to regenerate the code. In any case the correct encoding of the DialoguePortion is as EXTERNAL. Support for proper EXTERNAL asn1c decoding is missing in all versions of asn1c except https://github.com/mouse07410/asn1c (See PR #3/#5) so use that when regenerating. Related: SYS#7486 Change-Id: I4a27a52b2be70b1fc50e0a3d5441ded4c151fe65 --- M asn/tcap.asn 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve osmith: Verified diff --git a/asn/tcap.asn b/asn/tcap.asn index 9df2e5b..2b967cd 100644 --- a/asn/tcap.asn +++ b/asn/tcap.asn @@ -66,11 +66,11 @@ -- APDU, or by the TC-User in which case it could be either an ABRT APDU or data in some user-defined -- abstract syntax. ---DialoguePortion ::= [APPLICATION 11] EXPLICIT EXTERNAL +DialoguePortion ::= [APPLICATION 11] EXPLICIT EXTERNAL -- WS adaptation -DialoguePortion ::= [APPLICATION 11] IMPLICIT DialogueOC -DialogueOC ::= OCTET STRING +--DialoguePortion ::= [APPLICATION 11] IMPLICIT DialogueOC +--DialogueOC ::= OCTET STRING -- The dialogue portion carries the dialogue control PDUs as value of the external data type. -- The direct reference should be set to { ccitt recommendation q 773 as (1) dialogue-as (1) version (1) } -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41021?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I4a27a52b2be70b1fc50e0a3d5441ded4c151fe65 Gerrit-Change-Number: 41021 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de>

1 0

[XS] Change in ...osmo-s1gw[master]: debian: add osmo-s1gw.install
by fixeria 14 Sep '25

14 Sep '25

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41110?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: debian: add osmo-s1gw.install ...................................................................... debian: add osmo-s1gw.install The `*.install` files give precise control over what gets packaged, allowing to exclude files and/or include additional ones. This will be needed in a follow-up patches adding misc files. Change-Id: Ia396351a73b665cbb9927b525e01ab451a6b0f78 --- A debian/osmo-s1gw.install M debian/rules 2 files changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/10/41110/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41110?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ia396351a73b665cbb9927b525e01ab451a6b0f78 Gerrit-Change-Number: 41110 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in ...osmo-s1gw[master]: debian: add missing libsctp dependency
by fixeria 14 Sep '25

14 Sep '25

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41111?usp=email ) Change subject: debian: add missing libsctp dependency ...................................................................... debian: add missing libsctp dependency This dependency is *not* added automatically by `${shlibs:Depends}` because it's not a dependency of `erlang-base`: it's listed as a recommendation (in `Recommends`). The `osmo-s1gw` package needs to depend on libsctp explicitly; otherwise it will not work in a clean environment. Change-Id: I9add00e501110b54447faf89fce0f18432663463 --- M debian/control 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/11/41111/1 diff --git a/debian/control b/debian/control index b0bb9b4..45c3847 100644 --- a/debian/control +++ b/debian/control @@ -15,7 +15,8 @@ Package: osmo-s1gw Architecture: any Depends: ${shlibs:Depends}, - ${misc:Depends} + ${misc:Depends}, + ${libsctp:Version} Multi-Arch: foreign Description: Osmocom S1 gateway This can be used on the S1 interface between eNB and MME/CN, and -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41111?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I9add00e501110b54447faf89fce0f18432663463 Gerrit-Change-Number: 41111 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in ...osmo-s1gw[master]: [REST] osmo-s1gw-cli.py skeleton
by fixeria 14 Sep '25

14 Sep '25

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41097?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: [REST] osmo-s1gw-cli.py skeleton ...................................................................... [REST] osmo-s1gw-cli.py skeleton This is an interactive shell based on Python's cmd2 library, providing an alternative to the traditional VTY interface used in many Osmocom projects. It communicates with the main process via the REST interface. Currently there's only one command fetching the OpenAPI specification. More commands will be introduced in follow-up commits. Change-Id: I05600f2fa6d213b9cee28871761231722ff5b876 Related: SYS#7066 --- M Makefile M README.md A contrib/osmo-s1gw-cli.py M debian/control M debian/copyright A debian/osmo-s1gw-cli.install 6 files changed, 212 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/97/41097/5 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41097?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I05600f2fa6d213b9cee28871761231722ff5b876 Gerrit-Change-Number: 41097 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in ...osmo-s1gw[master]: debian: add osmo-s1gw.install
by fixeria 14 Sep '25

14 Sep '25

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41110?usp=email ) Change subject: debian: add osmo-s1gw.install ...................................................................... debian: add osmo-s1gw.install The `*.install` files give precise control over what gets packaged, allowing to exclude files and/or include additional ones. This will be needed in a follow-up patches adding misc files. Change-Id: Ia396351a73b665cbb9927b525e01ab451a6b0f78 --- A debian/osmo-s1gw.install 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/10/41110/1 diff --git a/debian/osmo-s1gw.install b/debian/osmo-s1gw.install new file mode 100644 index 0000000..b52efe2 --- /dev/null +++ b/debian/osmo-s1gw.install @@ -0,0 +1,4 @@ +usr/bin/osmo-s1gw +usr/lib/osmo-s1gw +etc/osmocom/osmo-s1gw.config +lib/systemd/system/osmo-s1gw.service -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41110?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ia396351a73b665cbb9927b525e01ab451a6b0f78 Gerrit-Change-Number: 41110 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in ...osmo-s1gw[master]: [REST] OpenAPI specification skeleton
by fixeria 14 Sep '25

14 Sep '25

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41096?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: [REST] OpenAPI specification skeleton ...................................................................... [REST] OpenAPI specification skeleton Change-Id: I84e6ef5cc67cd26b11f7bed8510420e43e18c69b Related: SYS#7066 --- M Makefile M README.md A contrib/openapi.yaml A contrib/yaml2json.py M debian/copyright M debian/osmo-s1gw.install A priv/openapi.json 7 files changed, 57 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/96/41096/5 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41096?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I84e6ef5cc67cd26b11f7bed8510420e43e18c69b Gerrit-Change-Number: 41096 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in ...osmo-s1gw[master]: contrib/generate_build_dep.sh: pass '-f' to mv
by fixeria 13 Sep '25

13 Sep '25

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41109?usp=email ) Change subject: contrib/generate_build_dep.sh: pass '-f' to mv ...................................................................... contrib/generate_build_dep.sh: pass '-f' to mv It may happen that the same directory is present in both `_build/default/lib` and `_build/default/plugins` directories. In this case the `mv` command will fail, and this is exactly what happens when adding a new dependency in a follow-up patch: mv: cannot move './_build/default/plugins/ncalendar' to '_checkouts/ncalendar': Directory not empty mv: cannot move './_build/default/plugins/ndto' to '_checkouts/ndto': Directory not empty mv: cannot move './_build/default/plugins/njson' to '_checkouts/njson': Directory not empty Pass `-f` to allow overwriting already existing checkouts. Change-Id: I9a95afcac54dec9684f34224a912574bb387e96c --- M contrib/generate_build_dep.sh 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/09/41109/1 diff --git a/contrib/generate_build_dep.sh b/contrib/generate_build_dep.sh index 08efac9..c91b8e3 100755 --- a/contrib/generate_build_dep.sh +++ b/contrib/generate_build_dep.sh @@ -13,9 +13,9 @@ REBAR_PROFILE=default rebar3 get-deps REBAR_PROFILE=test rebar3 get-deps mkdir _checkouts -mv ./_build/default/lib/* _checkouts/ -mv ./_build/default/plugins/* _checkouts/ -mv ./_build/test/lib/meck _checkouts/ +mv -f ./_build/default/lib/* _checkouts/ +mv -f ./_build/default/plugins/* _checkouts/ +mv -f ./_build/test/lib/meck _checkouts/ # delete erlang bytecode find _checkouts/ -iname '*beam' -delete tar czf build_dep.tar.gz ./_checkouts -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41109?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I9a95afcac54dec9684f34224a912574bb387e96c Gerrit-Change-Number: 41109 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in ...osmo-s1gw[master]: [REST] osmo-s1gw-cli.py skeleton
by fixeria 13 Sep '25

13 Sep '25

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41097?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: [REST] osmo-s1gw-cli.py skeleton ...................................................................... [REST] osmo-s1gw-cli.py skeleton This is an interactive shell based on Python's cmd2 library, providing an alternative to the traditional VTY interface used in many Osmocom projects. It communicates with the main process via the REST interface. Currently there's only one command fetching the OpenAPI specification. More commands will be introduced in follow-up commits. Change-Id: I05600f2fa6d213b9cee28871761231722ff5b876 Related: SYS#7066 --- M Makefile M README.md A contrib/osmo-s1gw-cli.py M debian/control M debian/copyright A debian/osmo-s1gw-cli.install A debian/osmo-s1gw.install 7 files changed, 214 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/97/41097/4 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41097?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I05600f2fa6d213b9cee28871761231722ff5b876 Gerrit-Change-Number: 41097 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[XS] Change in ...osmo-s1gw[master]: README.md: mention 'make analyze'
by fixeria 13 Sep '25

13 Sep '25

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41107?usp=email ) Change subject: README.md: mention 'make analyze' ...................................................................... README.md: mention 'make analyze' Change-Id: I5af11dc51ccb514918dd145975bed55381d4b76b --- M README.md 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/07/41107/1 diff --git a/README.md b/README.md index d26c505..cfb6f52 100644 --- a/README.md +++ b/README.md @@ -93,6 +93,12 @@ $ make check ``` +Additionally, you can run the static analyser (Dialyzer): + +``` +$ make analyze +``` + Running ------- -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41107?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I5af11dc51ccb514918dd145975bed55381d4b76b Gerrit-Change-Number: 41107 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in ...osmo-s1gw[master]: README.md: cosmetic: s/osmo_s1gw/OsmoS1GW/
by fixeria 13 Sep '25

13 Sep '25

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41106?usp=email ) Change subject: README.md: cosmetic: s/osmo_s1gw/OsmoS1GW/ ...................................................................... README.md: cosmetic: s/osmo_s1gw/OsmoS1GW/ Change-Id: I0346123cccf78c85d36ce71e68e83204178a5ee9 --- M README.md 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/06/41106/1 diff --git a/README.md b/README.md index b85bbbc..d26c505 100644 --- a/README.md +++ b/README.md @@ -97,7 +97,7 @@ Running ------- -Once `osmo_s1gw` is built, you can start it this way: +Once OsmoS1GW is built, you can start it this way: ``` $ make run -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41106?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I0346123cccf78c85d36ce71e68e83204178a5ee9 Gerrit-Change-Number: 41106 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log September 2025