September 2025 - gerrit-log - lists.osmocom.org

[XL] Change in libosmo-asn1-tcap[master]: Regenerate code with newer asn1c

by pespin

Attention is currently required from: daniel, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022?usp=email ) Change subject: Regenerate code with newer asn1c ...................................................................... Patch Set 5: Code-Review-1 (2 comments) File include/osmocom/tcap/Makefile.am: https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022/comment/3b4a153a_10a… : PS5, Line 3: TCAP_RLRQ-apdu.h \ I'd really welcome splitting all these TCAP_* generated headers into a separate variable (and then included here), so that later on we can easily see the skeleton generic files vs the ASN1-specific-file generated ones. File include/osmocom/tcap/TCAP_Unidirectional.h: https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022/comment/43111d77_4b3… : PS5, Line 16: #include <constr_SEQUENCE.h> All these includes most probably need to be patched during Makefile to be prefixed"<osmocom/tcap/...", otherwise projects including several libraries may end up with collisions. -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: If43a5d518f94fa558a3dff563a1c7aa31c925fec Gerrit-Change-Number: 41022 Gerrit-PatchSet: 5 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Sep 2025 16:02:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

2 weeks

1
0
0 0

[M] Change in ...osmo-epdg[master]: diameter_3gpp_ts29_273_swx: add missing include for MAR

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41072?usp=email ) Change subject: diameter_3gpp_ts29_273_swx: add missing include for MAR ...................................................................... diameter_3gpp_ts29_273_swx: add missing include for MAR Add a test case to check if MAR can be encoded. Testcases can be run by `rebar3 eunit` Change-Id: I5e2cd3eaaa43f7396f6578531911c21941a3ea6b --- M dia/diameter_3gpp_ts29_273_swx.dia A src/aaa_diameter_swx_tests.erl 2 files changed, 92 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/72/41072/1 diff --git a/dia/diameter_3gpp_ts29_273_swx.dia b/dia/diameter_3gpp_ts29_273_swx.dia index 6db8958..5ccc655 100644 --- a/dia/diameter_3gpp_ts29_273_swx.dia +++ b/dia/diameter_3gpp_ts29_273_swx.dia @@ -43,6 +43,7 @@ @inherits diameter_3gpp_ts32_299 @inherits diameter_etsi_es283_034 @inherits diameter_rfc4004 +@inherits diameter_rfc4005_nasreq Framed-Interface-Id Framed-IP-Address Framed-IPv6-Prefix @inherits diameter_rfc4006_cc @inherits diameter_rfc5447 @inherits diameter_rfc5580 diff --git a/src/aaa_diameter_swx_tests.erl b/src/aaa_diameter_swx_tests.erl new file mode 100644 index 0000000..fef295d --- /dev/null +++ b/src/aaa_diameter_swx_tests.erl @@ -0,0 +1,91 @@ +% SWx: AAA side test +% +% TS 29.273 +% +% (C) 2025 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> +% Author: Alexander Couzens <lynxis(a)fe80.eu> +% +% All Rights Reserved +% +% This program is free software; you can redistribute it and/or modify +% it under the terms of the GNU Affero General Public License as +% published by the Free Software Foundation; either version 3 of the +% License, or (at your option) any later version. +% +% This program is distributed in the hope that it will be useful, +% but WITHOUT ANY WARRANTY; without even the implied warranty of +% MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +% GNU General Public License for more details. +% +% You should have received a copy of the GNU Affero General Public License +% along with this program. If not, see <https://www.gnu.org/licenses/>. +% +% Additional Permission under GNU AGPL version 3 section 7: +% +% If you modify this Program, or any covered work, by linking or +% combining it with runtime libraries of Erlang/OTP as released by +% Ericsson on https://www.erlang.org (or a modified version of these +% libraries), containing parts covered by the terms of the Erlang Public +% License (https://www.erlang.org/EPLICENSE), the licensors of this +% Program grant you additional permission to convey the resulting work +% without the need to license the runtime libraries of Erlang/OTP under +% the GNU Affero General Public License. Corresponding Source for a +% non-source form of such a combination shall include the source code +% for the parts of the runtime libraries of Erlang/OTP used as well as +% that of the covered work. + + +-module(aaa_diameter_swx_tests). +-author('Alexander Couzens <lynxis(a)fe80.eu>'). + +-include_lib("diameter_3gpp_ts29_273_swx.hrl"). +-include_lib("diameter/include/diameter_gen_base_rfc6733.hrl"). +-include_lib("diameter/include/diameter.hrl"). + +-include_lib("eunit/include/eunit.hrl"). +-include_lib("kernel/include/logger.hrl"). + +% "har.localdomain","localdomain","localdomain", % origin host, origin realm, dest realm +encode_mar_test() -> + % copied from ttcn3 tests + AMar = {'MAR', + ["epdg.localdomain",";","1818836830",";","1",";","nonode@nohost"], + 1, % auth session state + undefined, undefined, undefined, % origin host, origin realm, dest realm + "262426399104394", + {'Vendor-Specific-Application-Id',10415,[16777265],[]}, + {'SIP-Auth-Data-Item',[],["EAP-AKA"],[],[],[],[],[],[],<<"">>,[],[],[],[]}, + 1,[],1,[],[],[],[],[],[],[],[]}, + AMar2 = AMar#'MAR'{ + 'Origin-Host' = "origin", + 'Origin-Realm' = "foo", + 'Destination-Host' = ["hss.localdomain"], + 'Destination-Realm' = "localdomain"}, + + Hdr = #diameter_header{version = 1, + end_to_end_id = 23, + hop_by_hop_id = 42}, + Encoded = diameter_codec:encode(diameter_3gpp_ts29_273_swx, + #{ordered_encode => true}, + #diameter_packet{header = Hdr, + msg = AMar2}), + ?LOG_DEBUG("Diameter encoded as: ~p", [Encoded]), + + <<1,0,1,28,192,0,1,47,1,0,0,49,0,0,0,42,0,0,0,23,0, + 0,1,7,64,0,0,51,101,112,100,103,46,108,111,99,97, + 108,100,111,109,97,105,110,59,49,56,49,56,56,51, + 54,56,51,48,59,49,59,110,111,110,111,100,101,64, + 110,111,104,111,115,116,0,0,0,1,21,64,0,0,12,0,0, + 0,1,0,0,1,8,64,0,0,14,111,114,105,103,105,110,0, + 0,0,0,1,40,64,0,0,11,102,111,111,0,0,0,1,27,64,0, + 0,19,108,111,99,97,108,100,111,109,97,105,110,0, + 0,0,0,1,64,0,0,23,50,54,50,52,50,54,51,57,57,49, + 48,52,51,57,52,0,0,0,1,4,64,0,0,32,0,0,1,10,64,0, + 0,12,0,0,40,175,0,0,1,2,64,0,0,12,1,0,0,49,0,0,2, + 100,192,0,0,40,0,0,40,175,0,0,2,96,192,0,0,19,0, + 0,40,175,69,65,80,45,65,75,65,0,0,0,0,8,64,0,0,8, + 0,0,2,95,192,0,0,16,0,0,40,175,0,0,0,1,0,0,1,37, + 64,0,0,23,104,115,115,46,108,111,99,97,108,100, + 111,109,97,105,110,0,0,0,4,8,128,0,0,16,0,0,40, + 175,0,0,0,1>> = Encoded#diameter_packet.bin. + -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41072?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I5e2cd3eaaa43f7396f6578531911c21941a3ea6b Gerrit-Change-Number: 41072 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

2 weeks

1
0
0 0

[XL] Change in libosmo-asn1-tcap[master]: Regenerate code with newer asn1c

by daniel

Attention is currently required from: osmith, pespin. daniel has removed a vote from this change. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022?usp=email ) Change subject: Regenerate code with newer asn1c ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: deleteVote Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: If43a5d518f94fa558a3dff563a1c7aa31c925fec Gerrit-Change-Number: 41022 Gerrit-PatchSet: 5 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

2 weeks

1
0
0 0

[XL] Change in libosmo-asn1-tcap[master]: Regenerate code with newer asn1c

by daniel

Attention is currently required from: osmith, pespin. daniel has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022?usp=email ) Change subject: Regenerate code with newer asn1c ...................................................................... Patch Set 5: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: If43a5d518f94fa558a3dff563a1c7aa31c925fec Gerrit-Change-Number: 41022 Gerrit-PatchSet: 5 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Sep 2025 15:12:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks

1
0
0 0

[XL] Change in libosmo-asn1-tcap[master]: Regenerate code with newer asn1c

by daniel

Attention is currently required from: osmith, pespin. daniel has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022?usp=email ) Change subject: Regenerate code with newer asn1c ...................................................................... Patch Set 5: (2 comments) This change is ready for review. Patchset: PS4: > Change order in Makefile.am, from "SUBDIRS = src include" to "SUBDIRS = include src" […] Seems I missed the generated (TCAP_*.h) headers.. Patchset: PS5: This now passes make distcheck. debian jobs are expected to fail until "debian: initial" I guess the linter is meaningless for generated code -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: If43a5d518f94fa558a3dff563a1c7aa31c925fec Gerrit-Change-Number: 41022 Gerrit-PatchSet: 5 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Sep 2025 15:11:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

2 weeks

1
0
0 0

[S] Change in libosmo-asn1-tcap[master]: Generate a version.h file

by daniel

Attention is currently required from: fixeria, laforge, osmith, pespin. daniel has uploaded a new patch set (#6) to the change originally created by osmith. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41027?usp=email ) The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified-1 by Jenkins Builder Change subject: Generate a version.h file ...................................................................... Generate a version.h file Related: OS#6626 Change-Id: I2ee394086af3ccf0ec789e2cba627054c09fe1cd --- M .gitignore M include/osmocom/tcap/Makefile.am A include/osmocom/tcap/version.h.tpl 3 files changed, 34 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-asn1-tcap refs/changes/27/41027/6 -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41027?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I2ee394086af3ccf0ec789e2cba627054c09fe1cd Gerrit-Change-Number: 41027 Gerrit-PatchSet: 6 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

2 weeks

1
0
0 0

[S] Change in osmocom-bb[master]: debian: add osmocom-bb-{gprsdecode,osmocon} packages

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41071?usp=email ) Change subject: debian: add osmocom-bb-{gprsdecode,osmocon} packages ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41071?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia96c418a610863b5d9d0fc10c6d78b80163dc651 Gerrit-Change-Number: 41071 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Sep 2025 14:36:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks

1
0
0 0

[XS] Change in osmocom-bb[master]: debian: install *.cfg and *.lua examples

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41070?usp=email ) Change subject: debian: install *.cfg and *.lua examples ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41070?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I10ed0d68cd91126cefd431a1375b72dd6ae3f2d0 Gerrit-Change-Number: 41070 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Sep 2025 14:36:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks

1
0
0 0

[XS] Change in osmocom-bb[master]: debian: install /etc/osmocom/{mobile,modem}.cfg

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41069?usp=email ) Change subject: debian: install /etc/osmocom/{mobile,modem}.cfg ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41069?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ic405512330358e7d4cf81db6d4e83f5ffc920f64 Gerrit-Change-Number: 41069 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Sep 2025 14:35:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks

1
0
0 0

[XL] Change in libosmo-netif[master]: doc: add twrtp guide document

by laforge

Attention is currently required from: falconia, fixeria, jolly. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39291?usp=email ) Change subject: doc: add twrtp guide document ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39291?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I90976edfd8c66c2d1c5bc7939e0a49f725a02f3f Gerrit-Change-Number: 39291 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Sep 2025 14:35:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2025