September 2025 - gerrit-log - lists.osmocom.org

[S] Change in ...osmo-epdg[master]: aaa_diameter_swx_tests: use MAR record to improve readability

by Jenkins Builder

Attention is currently required from: fixeria, pespin. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41077?usp=email ) Change subject: aaa_diameter_swx_tests: use MAR record to improve readability ...................................................................... Patch Set 1: (2 comments) File src/aaa_diameter_swx_tests.erl: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41077/comment/5e1c425e_0e84… : PS1, Line 52: VAID = #'Vendor-Specific-Application-Id'{'Vendor-Id' = 10415, 'VAID' may be misspelled - perhaps 'VALID'? Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41077/comment/8f2be459_f0d3… : PS1, Line 61: 'Vendor-Specific-Application-Id' = VAID, 'VAID' may be misspelled - perhaps 'VALID'? -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41077?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I0e77aae792fb9bc2e7277668a4fdda21a993aaa2 Gerrit-Change-Number: 41077 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Sep 2025 20:37:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

2 weeks

1
0
0 0

[S] Change in ...osmo-epdg[master]: aaa_diameter_swx_tests: explicit set Framed-IP-Address

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41076?usp=email ) Change subject: aaa_diameter_swx_tests: explicit set Framed-IP-Address ...................................................................... aaa_diameter_swx_tests: explicit set Framed-IP-Address Change-Id: I08dbe7f2466c3af1ee4792c03e1e1fa307d4de25 --- M src/aaa_diameter_swx_tests.erl 1 file changed, 18 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/76/41076/1 diff --git a/src/aaa_diameter_swx_tests.erl b/src/aaa_diameter_swx_tests.erl index fef295d..7230e75 100644 --- a/src/aaa_diameter_swx_tests.erl +++ b/src/aaa_diameter_swx_tests.erl @@ -54,7 +54,7 @@ undefined, undefined, undefined, % origin host, origin realm, dest realm "262426399104394", {'Vendor-Specific-Application-Id',10415,[16777265],[]}, - {'SIP-Auth-Data-Item',[],["EAP-AKA"],[],[],[],[],[],[],<<"">>,[],[],[],[]}, + {'SIP-Auth-Data-Item',[],["EAP-AKA"],[],[],[],[],[],[],[<<255,255,255,254>>],[],[],[],[]}, 1,[],1,[],[],[],[],[],[],[],[]}, AMar2 = AMar#'MAR'{ 'Origin-Host' = "origin", @@ -69,23 +69,22 @@ #{ordered_encode => true}, #diameter_packet{header = Hdr, msg = AMar2}), - ?LOG_DEBUG("Diameter encoded as: ~p", [Encoded]), + ?LOG_ERROR("Diameter encoded as: ~p", [Encoded]), - <<1,0,1,28,192,0,1,47,1,0,0,49,0,0,0,42,0,0,0,23,0, - 0,1,7,64,0,0,51,101,112,100,103,46,108,111,99,97, - 108,100,111,109,97,105,110,59,49,56,49,56,56,51, - 54,56,51,48,59,49,59,110,111,110,111,100,101,64, - 110,111,104,111,115,116,0,0,0,1,21,64,0,0,12,0,0, - 0,1,0,0,1,8,64,0,0,14,111,114,105,103,105,110,0, - 0,0,0,1,40,64,0,0,11,102,111,111,0,0,0,1,27,64,0, - 0,19,108,111,99,97,108,100,111,109,97,105,110,0, - 0,0,0,1,64,0,0,23,50,54,50,52,50,54,51,57,57,49, - 48,52,51,57,52,0,0,0,1,4,64,0,0,32,0,0,1,10,64,0, - 0,12,0,0,40,175,0,0,1,2,64,0,0,12,1,0,0,49,0,0,2, - 100,192,0,0,40,0,0,40,175,0,0,2,96,192,0,0,19,0, - 0,40,175,69,65,80,45,65,75,65,0,0,0,0,8,64,0,0,8, - 0,0,2,95,192,0,0,16,0,0,40,175,0,0,0,1,0,0,1,37, - 64,0,0,23,104,115,115,46,108,111,99,97,108,100, - 111,109,97,105,110,0,0,0,4,8,128,0,0,16,0,0,40, - 175,0,0,0,1>> = Encoded#diameter_packet.bin. + <<1,0,1,32,192,0,1,47,1,0,0,49,0,0,0,42,0,0,0,23,0,0, + 1,7,64,0,0,51,101,112,100,103,46,108,111,99,97,108, + 100,111,109,97,105,110,59,49,56,49,56,56,51,54,56, + 51,48,59,49,59,110,111,110,111,100,101,64,110,111, + 104,111,115,116,0,0,0,1,21,64,0,0,12,0,0,0,1,0,0,1, + 8,64,0,0,14,111,114,105,103,105,110,0,0,0,0,1,40,64, + 0,0,11,102,111,111,0,0,0,1,27,64,0,0,19,108,111,99, + 97,108,100,111,109,97,105,110,0,0,0,0,1,64,0,0,23, + 50,54,50,52,50,54,51,57,57,49,48,52,51,57,52,0,0,0, + 1,4,64,0,0,32,0,0,1,10,64,0,0,12,0,0,40,175,0,0,1,2, + 64,0,0,12,1,0,0,49,0,0,2,100,192,0,0,44,0,0,40,175, + 0,0,2,96,192,0,0,19,0,0,40,175,69,65,80,45,65,75,65, + 0,0,0,0,8,64,0,0,12,255,255,255,254,0,0,2,95,192,0, + 0,16,0,0,40,175,0,0,0,1,0,0,1,37,64,0,0,23,104,115, + 115,46,108,111,99,97,108,100,111,109,97,105,110,0,0, + 0,4,8,128,0,0,16,0,0,40,175,0,0,0,1>> = Encoded#diameter_packet.bin. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41076?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I08dbe7f2466c3af1ee4792c03e1e1fa307d4de25 Gerrit-Change-Number: 41076 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

2 weeks

1
0
0 0

[S] Change in ...osmo-epdg[master]: aaa_diameter_swx_tests: use MAR record to improve readability

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41077?usp=email ) Change subject: aaa_diameter_swx_tests: use MAR record to improve readability ...................................................................... aaa_diameter_swx_tests: use MAR record to improve readability Change-Id: I0e77aae792fb9bc2e7277668a4fdda21a993aaa2 --- M src/aaa_diameter_swx_tests.erl 1 file changed, 21 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/77/41077/1 diff --git a/src/aaa_diameter_swx_tests.erl b/src/aaa_diameter_swx_tests.erl index 7230e75..0258980 100644 --- a/src/aaa_diameter_swx_tests.erl +++ b/src/aaa_diameter_swx_tests.erl @@ -48,27 +48,31 @@ % "har.localdomain","localdomain","localdomain", % origin host, origin realm, dest realm encode_mar_test() -> % copied from ttcn3 tests - AMar = {'MAR', - ["epdg.localdomain",";","1818836830",";","1",";","nonode@nohost"], - 1, % auth session state - undefined, undefined, undefined, % origin host, origin realm, dest realm - "262426399104394", - {'Vendor-Specific-Application-Id',10415,[16777265],[]}, - {'SIP-Auth-Data-Item',[],["EAP-AKA"],[],[],[],[],[],[],[<<255,255,255,254>>],[],[],[],[]}, - 1,[],1,[],[],[],[],[],[],[],[]}, - AMar2 = AMar#'MAR'{ - 'Origin-Host' = "origin", - 'Origin-Realm' = "foo", - 'Destination-Host' = ["hss.localdomain"], - 'Destination-Realm' = "localdomain"}, + SessionId = ["epdg.localdomain",";","1818836830",";","1",";","nonode@nohost"], + VAID = #'Vendor-Specific-Application-Id'{'Vendor-Id' = 10415, + 'Auth-Application-Id' = [16777265]}, + AMar = #'MAR'{'Session-Id' = SessionId, + 'Origin-Host' = "origin", + 'Origin-Realm' = "foo", + 'Destination-Host' = ["hss.localdomain"], + 'Destination-Realm' = "localdomain", + 'Auth-Session-State' = 1, + 'User-Name' = "262426399104394", + 'Vendor-Specific-Application-Id' = VAID, + 'SIP-Auth-Data-Item' = #'SIP-Auth-Data-Item'{ + 'SIP-Authentication-Scheme' = ["EAP-AKA"], + 'Framed-IP-Address' = [<<255,255,255,254>>]}, + 'SIP-Number-Auth-Items' = 1, + 'RAT-Type' = 1}, Hdr = #diameter_header{version = 1, - end_to_end_id = 23, - hop_by_hop_id = 42}, - Encoded = diameter_codec:encode(diameter_3gpp_ts29_273_swx, + end_to_end_id = 23, + hop_by_hop_id = 42}, + Encoded = diameter_codec:encode( + diameter_3gpp_ts29_273_swx, #{ordered_encode => true}, #diameter_packet{header = Hdr, - msg = AMar2}), + msg = AMar}), ?LOG_ERROR("Diameter encoded as: ~p", [Encoded]), <<1,0,1,32,192,0,1,47,1,0,0,49,0,0,0,42,0,0,0,23,0,0, -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41077?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I0e77aae792fb9bc2e7277668a4fdda21a993aaa2 Gerrit-Change-Number: 41077 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: mme: Mark GTP and diameter emulations alive

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41074?usp=email ) Change subject: mme: Mark GTP and diameter emulations alive ...................................................................... mme: Mark GTP and diameter emulations alive Change-Id: I53851dc981e9395e025cd5d2fb0122bea49564ee --- M mme/MME_Tests.ttcn 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/74/41074/1 diff --git a/mme/MME_Tests.ttcn b/mme/MME_Tests.ttcn index 5a58f96..2847bcc 100644 --- a/mme/MME_Tests.ttcn +++ b/mme/MME_Tests.ttcn @@ -197,7 +197,7 @@ }; g_enb_pars[num] := enb_pars; - vc_S1AP[num] := S1AP_Emulation_CT.create(id); + vc_S1AP[num] := S1AP_Emulation_CT.create(id) alive; map(vc_S1AP[num]:S1AP, system:S1AP_CODEC_PT); connect(vc_S1AP[num]:S1AP_PROC, self:S1AP_PROC[num]); connect(vc_S1AP[num]:S1AP_UNIT, self:S1AP_UNIT[num]); @@ -255,7 +255,7 @@ auth_app_id := omit, vendor_app_id := c_DIAMETER_3GPP_S6_AID }; - vc_DIAMETER := DIAMETER_Emulation_CT.create(id); + vc_DIAMETER := DIAMETER_Emulation_CT.create(id) alive; map(vc_DIAMETER:DIAMETER, system:DIAMETER_CODEC_PT); connect(vc_DIAMETER:DIAMETER_UNIT, self:DIAMETER_UNIT); connect(vc_DIAMETER:DIAMETER_PROC, self:DIAMETER_PROC); @@ -273,7 +273,7 @@ sgsn_role := true }; - vc_GTP := GTP_Emulation_CT.create(id); + vc_GTP := GTP_Emulation_CT.create(id) alive; vc_GTP.start(GTP_Emulation.main(gtp_cfg)); } @@ -288,7 +288,7 @@ sgw_role := true }; - vc_GTP2 := GTPv2_Emulation_CT.create(id); + vc_GTP2 := GTPv2_Emulation_CT.create(id) alive; map(vc_GTP2:GTP2C, system:GTP2C); connect(vc_GTP2:TEIC0, self:TEIC0); vc_GTP2.start(GTPv2_Emulation.main(cfg)); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41074?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I53851dc981e9395e025cd5d2fb0122bea49564ee Gerrit-Change-Number: 41074 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: library/s1ap: Support receiving UEContextModificationRequest

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41075?usp=email ) Change subject: library/s1ap: Support receiving UEContextModificationRequest ...................................................................... library/s1ap: Support receiving UEContextModificationRequest Change-Id: Iadb80eea7281b3bdf3359b0e2956e18bdb208207 --- M library/S1AP_Functions.ttcn M library/s1ap/S1AP_Templates.ttcn 2 files changed, 31 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/75/41075/1 diff --git a/library/S1AP_Functions.ttcn b/library/S1AP_Functions.ttcn index 63bdaa4..fbdcada 100644 --- a/library/S1AP_Functions.ttcn +++ b/library/S1AP_Functions.ttcn @@ -43,6 +43,9 @@ return omit; } } + case (tr_S1AP_UeContextModificationReq) { + return im.value_.UEContextModificationRequest.protocolIEs[1].value_.ENB_UE_S1AP_ID; + } case (tr_S1AP_ConnEstInd) { return im.value_.ConnectionEstablishmentIndication.protocolIEs[1].value_.ENB_UE_S1AP_ID; } @@ -98,6 +101,9 @@ case (tr_S1AP_ConnEstInd) { return im.value_.ConnectionEstablishmentIndication.protocolIEs[0].value_.MME_UE_S1AP_ID; } + case (tr_S1AP_UeContextModificationReq) { + return im.value_.UEContextModificationRequest.protocolIEs[0].value_.MME_UE_S1AP_ID; + } /* TODO */ } } else if (ischosen(s1ap.successfulOutcome)) { diff --git a/library/s1ap/S1AP_Templates.ttcn b/library/s1ap/S1AP_Templates.ttcn index 2ba2b36..70601e8 100644 --- a/library/s1ap/S1AP_Templates.ttcn +++ b/library/s1ap/S1AP_Templates.ttcn @@ -990,6 +990,31 @@ } } +/* 9.1.4.8 UE CONTEXT MODIFICATION REQUEST */ +template (present) S1AP_PDU +tr_S1AP_UeContextModificationReq(template (present) MME_UE_S1AP_ID mme_id := ?, + template (present) ENB_UE_S1AP_ID enb_id := ?) := { + initiatingMessage := { + procedureCode := id_UEContextModification, + criticality := reject, + value_ := { + UEContextModificationRequest := { + protocolIEs := { + { + id := S1AP_Constants.id_MME_UE_S1AP_ID, + criticality := reject, + value_ := {MME_UE_S1AP_ID := mme_id} + }, { + id := S1AP_Constants.id_eNB_UE_S1AP_ID, + criticality := reject, + value_ := {ENB_UE_S1AP_ID := enb_id} + }, * + } + } + } + } +} + /* 9.1.4.20 CONNECTION ESTABLISHMENT INDICATION */ template (value) S1AP_PDU ts_S1AP_ConnEstInd(template (value) MME_UE_S1AP_ID mme_id, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41075?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iadb80eea7281b3bdf3359b0e2956e18bdb208207 Gerrit-Change-Number: 41075 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: mme: Set EPS Attach Type to valid value 'EPS Attach'

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41073?usp=email ) Change subject: mme: Set EPS Attach Type to valid value 'EPS Attach' ...................................................................... mme: Set EPS Attach Type to valid value 'EPS Attach' Previous value 0 is unused, see TS 3GPP TS 24.301 9.9.3.11. Change-Id: I7b0c028620ee1ff6b819cce95b39fb93a70d4106 --- M mme/ConnHdlr.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/73/41073/1 diff --git a/mme/ConnHdlr.ttcn b/mme/ConnHdlr.ttcn index 8c4afed..d4a33ae 100644 --- a/mme/ConnHdlr.ttcn +++ b/mme/ConnHdlr.ttcn @@ -691,14 +691,14 @@ } } -function f_attach() runs on ConnHdlr { +function f_attach(BIT3 att_type := '001'B) runs on ConnHdlr { var template (value) EPS_MobileIdentityV mi := ts_NAS_MobileId_IMSI(g_pars.ue_pars.imsi); var template (value) PDU_NAS_EPS nas_esm, nas_emm; timer T := 5.0; nas_esm := ts_NAS_PdnConnReq(bearer_id := '0000'B, proc_tid := int2bit(1,8), pdn_type := NAS_PDN_T_IPv4, req_type := '001'B); - nas_emm := ts_NAS_AttachRequest(att_type := '000'B, kset_id := g_pars.kset_id, mobile_id := mi, + nas_emm := ts_NAS_AttachRequest(att_type := att_type, kset_id := g_pars.kset_id, mobile_id := mi, ue_net_cap := c_NAS_defaultUeNetCap, esm_enc := enc_PDU_NAS_EPS(valueof(nas_esm))); var template (value) S1AP_PDU tx; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41073?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7b0c028620ee1ff6b819cce95b39fb93a70d4106 Gerrit-Change-Number: 41073 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

2 weeks

1
0
0 0

[S] Change in osmocom-bb[master]: debian: fix empty osmocom-bb-{trxcon,virtphy} packages

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41068?usp=email ) Change subject: debian: fix empty osmocom-bb-{trxcon,virtphy} packages ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > why do we need to install into different DESTDIR? This way it's a lot easier to describe package contents in the `*.install` files. See `debian/osmocom-bb-layer23.install`, for instance, where instead of listing each and every binary I can simply do `layer23/usr/local/bin/*`. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41068?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ieee634f7f643a7599c735a5b77549cf34deb7fb9 Gerrit-Change-Number: 41068 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Sep 2025 17:37:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

2 weeks

1
0
0 0

[M] Change in ...osmo-epdg[master]: diameter_3gpp_ts29_273_swx: add missing include for MAR

by fixeria

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41072?usp=email ) Change subject: diameter_3gpp_ts29_273_swx: add missing include for MAR ...................................................................... Patch Set 1: (2 comments) File src/aaa_diameter_swx_tests.erl: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41072/comment/0a329009_1ea2… : PS1, Line 51: AMar = {'MAR', : ["epdg.localdomain",";","1818836830",";","1",";","nonode@nohost"], : 1, % auth session state : undefined, undefined, undefined, % origin host, origin realm, dest realm : "262426399104394", : {'Vendor-Specific-Application-Id',10415,[16777265],[]}, : {'SIP-Auth-Data-Item',[],["EAP-AKA"],[],[],[],[],[],[],<<"">>,[],[],[],[]}, : There exists a record for this called `#'MAR'` in `include/diameter_3gpp_ts29_273_swx.hrl`: ```suggestion SessionId = ["epdg.localdomain",";","1818836830",";","1",";","nonode@nohost"], VAID = #'Vendor-Specific-Application-Id'{'Vendor-Id' = 10415, 'Auth-Application-Id' = [16777265]}, AMar = #'MAR'{'Session-Id' = SessionId, 'Auth-Session-State' = 1, 'User-Name' = "262426399104394", 'Vendor-Specific-Application-Id' = VAID, 'SIP-Auth-Data-Item' =, 'SIP-Number-Auth-Items' = 1, 'RAT-Type' = 1}, ``` This would have been a lot more readable. https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41072/comment/a6f6f5e8_4d8e… : PS1, Line 90: = Encoded#diameter_packet.bin. You should be using `?assertEqual` and `?assertMatch` if you want to match something. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41072?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I5e2cd3eaaa43f7396f6578531911c21941a3ea6b Gerrit-Change-Number: 41072 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 08 Sep 2025 17:36:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

2 weeks

1
0
0 0

[XL] Change in libosmo-netif[master]: doc: add twrtp guide document

by falconia

Attention is currently required from: fixeria, jolly, pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39291?usp=email ) Change subject: doc: add twrtp guide document ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > @falcon@freecalypso. […] https://www.freecalypso.org/TW-doc/twrtp-guide-osmo.pdf -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39291?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I90976edfd8c66c2d1c5bc7939e0a49f725a02f3f Gerrit-Change-Number: 39291 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Sep 2025 17:17:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

2 weeks

1
0
0 0

[S] Change in ...osmo-python-tests[master]: debian: add python3-osmopy-{libs,utils}.install

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/41053?usp=email ) Change subject: debian: add python3-osmopy-{libs,utils}.install ...................................................................... debian: add python3-osmopy-{libs,utils}.install Add debian/*.install files to avoid the need to override Debian's dh_auto_install or other debhelper rules. This also provides a cleaner way to install miscellaneous files (e.g. config examples and systemd unit files) and simplifies maintenance of the packaging. Change-Id: I94b940789e138341792f40eedeedb73d4e4d421e --- A debian/python3-osmopy-libs.install A debian/python3-osmopy-utils.install D debian/python3-osmopy-utils.osmo-trap2cgi.service M debian/rules 4 files changed, 3 insertions(+), 12 deletions(-) Approvals: pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/debian/python3-osmopy-libs.install b/debian/python3-osmopy-libs.install new file mode 100644 index 0000000..6845771 --- /dev/null +++ b/debian/python3-osmopy-libs.install @@ -0,0 +1 @@ +usr/lib diff --git a/debian/python3-osmopy-utils.install b/debian/python3-osmopy-utils.install new file mode 100644 index 0000000..af0ad3d --- /dev/null +++ b/debian/python3-osmopy-utils.install @@ -0,0 +1,2 @@ +usr/bin/*.py +contrib/systemd/osmo-trap2cgi.service lib/systemd/system/ diff --git a/debian/python3-osmopy-utils.osmo-trap2cgi.service b/debian/python3-osmopy-utils.osmo-trap2cgi.service deleted file mode 120000 index f1cd169..0000000 --- a/debian/python3-osmopy-utils.osmo-trap2cgi.service +++ /dev/null @@ -1 +0,0 @@ -../contrib/systemd/osmo-trap2cgi.service \ No newline at end of file diff --git a/debian/rules b/debian/rules index 84ef719..641186e 100755 --- a/debian/rules +++ b/debian/rules @@ -2,14 +2,3 @@ %: dh $@ --with python3 --buildsystem=pybuild - -override_dh_auto_install: - python3 setup.py install --install-layout=deb --root=$(CURDIR)/debian/python3-osmopy-libs - rm -rf $(CURDIR)/debian/python3-osmopy-libs/usr/bin - python3 setup.py install --install-layout=deb --root=$(CURDIR)/debian/python3-osmopy-utils - rm -rf $(CURDIR)/debian/python3-osmopy-utils/usr/lib - -override_dh_installinit: - # Install service file with different name than package name: - # https://unix.stackexchange.com/questions/306234/is-it-possible-to-install-t… - dh_installinit --name=osmo-trap2cgi -- To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/41053?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Change-Id: I94b940789e138341792f40eedeedb73d4e4d421e Gerrit-Change-Number: 41053 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de>

2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2025