Attention is currently required from: fixeria, pespin.
Hello Jenkins Builder, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41080?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by fixeria, Verified+1 by Jenkins Builder
Change subject: mme: Add missing tests to expected-results.xml
......................................................................
mme: Add missing tests to expected-results.xml
Change-Id: I9fbe1dd102268558f4b360dc8e870117e4e17096
---
M mme/expected-results.xml
1 file changed, 7 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/80/41080/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41080?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9fbe1dd102268558f4b360dc8e870117e4e17096
Gerrit-Change-Number: 41080
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41082?usp=email )
Change subject: s1ap/S1AP_Templates.ttcn: Add templates to handle CS Fallback related procedures
......................................................................
Patch Set 1:
(1 comment)
File library/s1ap/S1AP_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41082/comment/b7b6e45e_12ec… :
PS1, Line 1075: return pdu;
> Do we expect any optional IEs here? […]
Yes there are many more optional IEs, but for now it's fine as is.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41082?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I87fa7d988bec90ccade2f40ac4d2a0924059058e
Gerrit-Change-Number: 41082
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 09 Sep 2025 13:27:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41082?usp=email )
Change subject: s1ap/S1AP_Templates.ttcn: Add templates to handle CS Fallback related procedures
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File library/s1ap/S1AP_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41082/comment/576163e0_370c… :
PS1, Line 1020: f_tr_S1AP_UeContextModificationReq
Most of the existing functions in this file are private and return a list of IEs. Not critical, but for the sake of consistency I suggest to have a template and a function (see e.g. `f_ts_S1AP_RABSetupRsp()` and `f_tr_S1AP_RABSetupRsp()`). Not blocking, though.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41082/comment/c2cdb77f_bc28… :
PS1, Line 1075: return pdu;
Do we expect any optional IEs here?
```
/* ignore the remaining IEs */
pdu.initiatingMessage.value_.UEContextModificationRequest.protocolIEs[idx] := *;
```
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41082?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I87fa7d988bec90ccade2f40ac4d2a0924059058e
Gerrit-Change-Number: 41082
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 09 Sep 2025 12:58:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41080?usp=email )
Change subject: mme: Add missing tests to expected-results.xml
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File mme/expected-results.xml:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41080/comment/6b3bb0e4_9a04… :
PS1, Line 2: tests='71' failures='8'
Not sure if the number of `tests`/`failures` really matters here, since we only use this file to compare the outcome (`compare-results.py`). But maybe take a chance to update the values here?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41080?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9fbe1dd102268558f4b360dc8e870117e4e17096
Gerrit-Change-Number: 41080
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 09 Sep 2025 12:46:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria, laforge.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41046?usp=email )
Change subject: mme: Initial working state for MME_Tests_SGsAP.ttcn tests
......................................................................
Patch Set 4:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41046?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If07f1a67eb4213985da82afec94adb08786a0980
Gerrit-Change-Number: 41046
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 09 Sep 2025 12:43:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No