September 2025 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-sigtran[master]: Propagate rx M3UA SCON -> MTP-STATUS.ind -> N-PCSTATE.ind

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41092?usp=email ) Change subject: Propagate rx M3UA SCON -> MTP-STATUS.ind -> N-PCSTATE.ind ...................................................................... Propagate rx M3UA SCON -> MTP-STATUS.ind -> N-PCSTATE.ind Change-Id: I82541612c039b1cc0191cb44d2eecdcbb07fae96 --- M include/osmocom/sigtran/protocol/mtp.h M src/sccp_internal.h M src/sccp_scmg.c M src/xua_snm.c 4 files changed, 74 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/92/41092/1 diff --git a/include/osmocom/sigtran/protocol/mtp.h b/include/osmocom/sigtran/protocol/mtp.h index 2f0c7ac..408e442 100644 --- a/include/osmocom/sigtran/protocol/mtp.h +++ b/include/osmocom/sigtran/protocol/mtp.h @@ -24,11 +24,19 @@ extern const struct value_string mtp_si_vals[]; -/* Chapter 15.17.5 of Q.705 */ +/* Chapter 15.17.5 of Q.704 */ enum mtp_unavail_cause { MTP_UNAVAIL_C_UNKNOWN = 0x0, MTP_UNAVAIL_C_UNEQUIP_REM_USER = 0x1, MTP_UNAVAIL_C_INACC_REM_USER = 0x2, + /* This field is not explicitly listed in Q.705 15.17.5, but it is + * expicitly described as one of four options in: + * Q.701 "TABLE 1" and 8.4 + * Q.704 2.4.2 + * Q.711 "Table 18" and 7.2.4 + * Q.714 "Figure D.4" + */ + MTP_UNAVAIL_C_CONGESTED = 0x3, /* reserved */ }; diff --git a/src/sccp_internal.h b/src/sccp_internal.h index 045e49b..5b1b94d 100644 --- a/src/sccp_internal.h +++ b/src/sccp_internal.h @@ -80,5 +80,5 @@ void sccp_scmg_rx_ssn_prohibited(struct osmo_sccp_instance *inst, uint32_t dpc, uint32_t ssn, uint32_t smi); void sccp_scmg_rx_mtp_pause(struct osmo_sccp_instance *inst, uint32_t dpc); void sccp_scmg_rx_mtp_resume(struct osmo_sccp_instance *inst, uint32_t dpc); -void sccp_scmg_rx_mtp_status(struct osmo_sccp_instance *inst, uint32_t dpc, enum mtp_unavail_cause cause); +void sccp_scmg_rx_mtp_status(struct osmo_sccp_instance *inst, uint32_t dpc, enum mtp_unavail_cause cause, uint8_t cong_level); int sccp_scmg_init(struct osmo_sccp_instance *inst); diff --git a/src/sccp_scmg.c b/src/sccp_scmg.c index 2ffedce..a0f9e1c 100644 --- a/src/sccp_scmg.c +++ b/src/sccp_scmg.c @@ -125,7 +125,8 @@ * [this would require us to track SSNs at each PC, which we don't] */ } -void sccp_scmg_rx_mtp_status(struct osmo_sccp_instance *inst, uint32_t dpc, enum mtp_unavail_cause cause) +/* ITU-T Q.701 8.4, ITU-T Q.711 7.2.4 */ +void sccp_scmg_rx_mtp_status(struct osmo_sccp_instance *inst, uint32_t dpc, enum mtp_unavail_cause cause, uint8_t cong_level) { struct osmo_scu_pcstate_param pcstate; /* 1) Informs the translation function to update the translation tables. */ @@ -142,20 +143,35 @@ case MTP_UNAVAIL_C_UNKNOWN: case MTP_UNAVAIL_C_UNEQUIP_REM_USER: case MTP_UNAVAIL_C_INACC_REM_USER: + /* 4) local broadcast of "user-out-of-service" for each SSN at that dest + * [this would require us to track SSNs at each PC, which we don't] */ + + /* 6) local broadcast of "remote SCCP unavailable" */ + pcstate = (struct osmo_scu_pcstate_param) { + .affected_pc = dpc, + /* cong_level/RIL doesn't apply here: */ + .restricted_importance_level = 0, + .sp_status = OSMO_SCCP_SP_S_ACCESSIBLE, + .remote_sccp_status = OSMO_SCCP_REM_SCCP_S_UNAVAILABLE_UNKNOWN, + }; + sccp_lbcs_local_bcast_pcstate(inst, &pcstate); + break; + case MTP_UNAVAIL_C_CONGESTED: + /* ITU-T Q.714 5.2.4 Signalling point congested + * ITU-T Q.714 5.2.8 Inter- and Intra- SCCP management congestion reports procedure + * ITU-T Q.714 5.3.6.6 Restricted importance level reporting + * ITU-T Q.714 Figure D.4 + * ITU-T Q.715 9.5 Coordination of congestion control measures between SCCP and other MTP users */ + pcstate = (struct osmo_scu_pcstate_param) { + .affected_pc = dpc, + .restricted_importance_level = cong_level, + .sp_status = OSMO_SCCP_SP_S_CONGESTED, + .remote_sccp_status = (cong_level == 0) ? OSMO_SCCP_REM_SCCP_S_AVAILABLE : + OSMO_SCCP_REM_SCCP_S_CONGESTED, + }; + sccp_lbcs_local_bcast_pcstate(inst, &pcstate); break; } - - /* 4) local broadcast of "user-out-of-service" for each SSN at that dest - * [this would require us to track SSNs at each PC, which we don't] */ - - /* 6) local broadcast of "remote SCCP unavailable" */ - pcstate = (struct osmo_scu_pcstate_param) { - .affected_pc = dpc, - .restricted_importance_level = 0, - .sp_status = OSMO_SCCP_SP_S_ACCESSIBLE, - .remote_sccp_status = OSMO_SCCP_REM_SCCP_S_UNAVAILABLE_UNKNOWN, - }; - sccp_lbcs_local_bcast_pcstate(inst, &pcstate); } const struct value_string sccp_scmg_msgt_names[] = { diff --git a/src/xua_snm.c b/src/xua_snm.c index 344cc63..fd2ef24 100644 --- a/src/xua_snm.c +++ b/src/xua_snm.c @@ -309,7 +309,7 @@ /* Translate to MTP-STATUS.ind towards SCCP (will create N-PCSTATE.ind to SCU) */ if (s7i->sccp && user == MTP_SI_SCCP) - sccp_scmg_rx_mtp_status(s7i->sccp, dpc, cause); + sccp_scmg_rx_mtp_status(s7i->sccp, dpc, cause, 0); /* inform remote ASPs via DUPU */ llist_for_each_entry(asp, &s7i->asp_list, list) { @@ -331,6 +331,34 @@ } } +/* ITU Q.701 8.4 "The level value is included if national options with congestion priorities or multiple signalling link states +without congestion priorities as in Recommendation Q.704 are implemented" */ +static void xua_snm_scon_to_sccp(struct osmo_sccp_instance *sccp, + const uint32_t *aff_pc, unsigned int num_aff_pc, + uint8_t cong_level) +{ + int i; + + for (i = 0; i < num_aff_pc; i++) { + /* 32bit "Affected Point Code" consists of a 7-bit mask followed by 14/16/24-bit SS7 PC, + * see RFC 4666 3.4.1 */ + uint32_t _aff_pc = ntohl(aff_pc[i]); + uint32_t pc = _aff_pc & 0xffffff; + uint8_t mask = _aff_pc >> 24; + + if (!mask) { + sccp_scmg_rx_mtp_status(sccp, pc, MTP_UNAVAIL_C_CONGESTED, cong_level); + } else { + /* we have to send one MTP primitive for each individual point + * code within that mask */ + uint32_t maskbits = (1 << mask) - 1; + uint32_t fullpc; + for (fullpc = (pc & ~maskbits); fullpc <= (pc | maskbits); fullpc++) + sccp_scmg_rx_mtp_status(sccp, fullpc, MTP_UNAVAIL_C_CONGESTED, cong_level); + } + } +} + static void xua_snm_scon(struct osmo_ss7_as *as, const uint32_t *aff_pc, unsigned int num_aff_pc, const uint32_t *concerned_dpc, const uint8_t *cong_level, const char *info_string) { @@ -339,7 +367,12 @@ uint32_t rctx[OSMO_SS7_MAX_RCTX_COUNT]; unsigned int num_rctx; - /* TODO: Translate to MTP-STATUS.ind towards SCCP (will create N-PCSTATE.ind to SCU) */ + /* TODO: Change Congested level/state of related routes, + * see ITU Q.704 3.8.4 "Congestion status of signalling route sets" */ + + /* Translate to MTP-STATUS.ind towards SCCP (will create N-PCSTATE.ind to SCU) */ + if (s7i->sccp) + xua_snm_scon_to_sccp(s7i->sccp, aff_pc, num_aff_pc, cong_level ? *cong_level : 0); /* RFC4666 1.4.6: "When an SG receives a congestion message (SCON) from an ASP and the SG * determines that an SPMC is now encountering congestion, it MAY trigger SS7 MTP3 Transfer -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41092?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I82541612c039b1cc0191cb44d2eecdcbb07fae96 Gerrit-Change-Number: 41092 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 week, 4 days

1
0
0 0

[S] Change in libosmo-sigtran[master]: m3ua: Fix memleak in m3ua_rx_snm_sg() and some paths of m3ua_rx_snm()

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41090?usp=email ) Change subject: m3ua: Fix memleak in m3ua_rx_snm_sg() and some paths of m3ua_rx_snm() ...................................................................... m3ua: Fix memleak in m3ua_rx_snm_sg() and some paths of m3ua_rx_snm() Own and free the xua msg in the main m3ua_rx_snm*() as done for other message types. Change-Id: Iab795da63e65d9539a44c985d9ca85aa76d203c6 --- M src/m3ua.c 1 file changed, 24 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/90/41090/1 diff --git a/src/m3ua.c b/src/m3ua.c index 7d3945c..3e1c109 100644 --- a/src/m3ua.c +++ b/src/m3ua.c @@ -1005,16 +1005,16 @@ } /* received SNM message on ASP side - * This function takes ownership of xua msg passed to it. */ + * xua is owned by parent call m3ua_rx_snm() */ static int m3ua_rx_snm_asp(struct osmo_ss7_asp *asp, struct xua_msg *xua) { struct osmo_ss7_as *as = NULL; struct xua_msg_part *rctx_ie = xua_msg_find_tag(xua, M3UA_IEI_ROUTE_CTX); - int rc; + int rc = 0; rc = xua_find_as_for_asp(&as, asp, rctx_ie); if (rc) - goto ret_free; + return rc; /* report those up the stack so both other ASPs and local SCCP users can be notified */ switch (xua->hdr.msg_type) { @@ -1051,12 +1051,11 @@ rc = M3UA_ERR_UNSUPP_MSG_TYPE; } -ret_free: - xua_msg_free(xua); return rc; } -/* received SNM message on SG side */ +/* received SNM message on SG side + * xua is owned by parent call m3ua_rx_snm() */ static int m3ua_rx_snm_sg(struct osmo_ss7_asp *asp, struct xua_msg *xua) { switch (xua->hdr.msg_type) { @@ -1070,9 +1069,12 @@ return 0; } +/* received SNM message + * This function takes ownership of xua msg passed to it. */ static int m3ua_rx_snm(struct osmo_ss7_asp *asp, struct xua_msg *xua) { struct xua_msg_part *na_ie = xua_msg_find_tag(xua, M3UA_IEI_NET_APPEAR); + int rc; /* SNM only permitted in ACTIVE state */ if (asp->fi->state != XUA_ASP_S_ACTIVE) { @@ -1083,7 +1085,8 @@ } else { LOGPASP(asp, DLM3UA, LOGL_ERROR, "Rx M3UA SNM not permitted " "while ASP in state %s\n", osmo_fsm_inst_state_name(asp->fi)); - return M3UA_ERR_UNEXPECTED_MSG; + rc = M3UA_ERR_UNEXPECTED_MSG; + goto ret_free; } } @@ -1095,16 +1098,25 @@ "Unsupported 'Network Appearance' IE '0x%08x' in message type '%s', sending 'Error'.\n", na, get_value_string(m3ua_xfer_msgt_names, xua->hdr.msg_type)); if (na_ie->len != 4) - return M3UA_ERR_PARAM_FIELD_ERR; - return M3UA_ERR_INVAL_NET_APPEAR; + rc = M3UA_ERR_PARAM_FIELD_ERR; + else + rc = M3UA_ERR_INVAL_NET_APPEAR; + goto ret_free; } switch (asp->cfg.role) { case OSMO_SS7_ASP_ROLE_SG: - return m3ua_rx_snm_sg(asp, xua); + rc = m3ua_rx_snm_sg(asp, xua); + break; case OSMO_SS7_ASP_ROLE_ASP: - return m3ua_rx_snm_asp(asp, xua); + rc = m3ua_rx_snm_asp(asp, xua); + break; default: - return M3UA_ERR_UNSUPP_MSG_CLASS; + rc = M3UA_ERR_UNSUPP_MSG_CLASS; + break; } + +ret_free: + xua_msg_free(xua); + return rc; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41090?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Iab795da63e65d9539a44c985d9ca85aa76d203c6 Gerrit-Change-Number: 41090 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 week, 4 days

1
0
0 0

[S] Change in ...osmo-s1gw[master]: s1ap_proxy: Handle "E-RABs Failed to Setup List" IE

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41089?usp=email ) Change subject: s1ap_proxy: Handle "E-RABs Failed to Setup List" IE ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41089?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I207094fd0019d10a61a5566c649ded1f98a41967 Gerrit-Change-Number: 41089 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 11 Sep 2025 19:38:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 week, 4 days

1
0
0 0

[S] Change in ...osmo-s1gw[master]: s1ap_proxy: Handle "E-RABs Failed to Setup List" IE

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41089?usp=email ) Change subject: s1ap_proxy: Handle "E-RABs Failed to Setup List" IE ...................................................................... s1ap_proxy: Handle "E-RABs Failed to Setup List" IE The HANDOVER REQUEST ACKNOWLEDGE PDU may contain an optional IE with the list of E-RABs that the eNB failed to setup. The S1GW needs to handle this list and terminate the respective E-RAB FSMs. Change-Id: I207094fd0019d10a61a5566c649ded1f98a41967 Related: 05b55609 ("s1ap_proxy: Add support for S1 HANDOVER procedure") Related: SYS#7309 --- M src/s1ap_proxy.erl 1 file changed, 26 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/89/41089/1 diff --git a/src/s1ap_proxy.erl b/src/s1ap_proxy.erl index 0046167..5260348 100644 --- a/src/s1ap_proxy.erl +++ b/src/s1ap_proxy.erl @@ -666,8 +666,9 @@ value = C0} = Msg}, S0) -> ?LOG_DEBUG("Processing HANDOVER REQUEST ACKNOWLEDGE"), ctr_inc(?S1GW_CTR_S1AP_PROXY_IN_PKT_HANDOVER_REQ_ACK, S0), - case handle_ies(?'id-E-RABAdmittedList', - C0#'HandoverRequestAcknowledge'.protocolIEs, S0) of + %% handle the list of admitted E-RABs + {Result, S2} = case handle_ies(?'id-E-RABAdmittedList', + C0#'HandoverRequestAcknowledge'.protocolIEs, S0) of {{ok, IEs}, S1} -> C1 = C0#'HandoverRequestAcknowledge'{protocolIEs = IEs}, PDU = {Outcome, Msg#'SuccessfulOutcome'{value = C1}}, @@ -676,7 +677,13 @@ ?LOG_NOTICE("Failed to process HANDOVER REQUEST ACKNOWLEDGE: ~p", [Reason]), ctr_inc(?S1GW_CTR_S1AP_PROXY_IN_PKT_PROC_ERROR, S1), {drop, S1} %% drop this PDU - end; + end, + %% handle the (optional) list of failed E-RABs + %% no #proxy_state modification is expected here + handle_ies(?'id-E-RABFailedToSetupListHOReqAck', + C0#'HandoverRequestAcknowledge'.protocolIEs, S2), + {Result, S2}; + %% TODO: 9.1.5.8 PATH SWITCH REQUEST :: (M) Transport Layer Address %% TODO: 9.1.5.9 PATH SWITCH REQUEST ACKNOWLEDGE :: (M) Transport Layer Address @@ -1125,6 +1132,22 @@ {{error, erab_not_registered}, S} end; +handle_ie([?'id-E-RABFailedToSetupListHOReqAck'], C, S) -> + %% This IE contains a list of id-E-RABFailedtoSetupItemHOReqAck, so patch inner IEs + handle_ies(?'id-E-RABFailedtoSetupItemHOReqAck', C, S); + +handle_ie([?'id-E-RABFailedtoSetupItemHOReqAck', + ?'id-E-RABFailedToSetupListHOReqAck'], + #'E-RABFailedToSetupItemHOReqAck'{'e-RAB-ID' = ERABId} = C, S) -> + %% poke E-RAB FSM + case erab_fsm_find(ERABId, S) of + {ok, Pid} -> + ok = erab_fsm:erab_release_ind(Pid), + {{ok, C}, S}; + error -> + ?LOG_ERROR("E-RAB-ID ~p is not registered", [erab_uid(ERABId, S)]), + {{error, erab_not_registered}, S} + end; %% Catch-all variant, which should not be called normally handle_ie(P, C, S) -> -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41089?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I207094fd0019d10a61a5566c649ded1f98a41967 Gerrit-Change-Number: 41089 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: jolly <andreas(a)eversberg.eu>

1 week, 4 days

1
0
0 0

[S] Change in osmo-gsm-manuals[master]: sigtran-osmocom.adoc: Improve route section

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41088?usp=email ) Change subject: sigtran-osmocom.adoc: Improve route section ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41088?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ice7c6f09bbf37c032af9a7f6f21d7994ce53ea82 Gerrit-Change-Number: 41088 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 11 Sep 2025 17:17:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 week, 4 days

1
0
0 0

[XS] Change in osmo-gsm-manuals[master]: sigtran.adoc: small fixes and improvements

by fixeria

Attention is currently required from: daniel, laforge, osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41087?usp=email ) Change subject: sigtran.adoc: small fixes and improvements ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41087?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ia8457f3fef3c7e455b102b4685850be5fbf6f186 Gerrit-Change-Number: 41087 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 11 Sep 2025 14:47:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 week, 4 days

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: s1ap/S1AP_Templates.ttcn: Add templates to handle CS Fallback related...

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41082?usp=email ) Change subject: s1ap/S1AP_Templates.ttcn: Add templates to handle CS Fallback related procedures ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41082?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I87fa7d988bec90ccade2f40ac4d2a0924059058e Gerrit-Change-Number: 41082 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 11 Sep 2025 14:31:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 week, 4 days

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: s1ap/S1AP_Templates.ttcn: Add templates to handle CS Fallback related...

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41082?usp=email ) Change subject: s1ap/S1AP_Templates.ttcn: Add templates to handle CS Fallback related procedures ...................................................................... Patch Set 2: (2 comments) File library/s1ap/S1AP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41082/comment/f555769c_29c7… : PS1, Line 1020: f_tr_S1AP_UeContextModificationReq > Most of the existing functions in this file are private and return a list of IEs. […] Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41082/comment/0c08ceb0_0df9… : PS1, Line 1075: return pdu; > > there are many more optional IEs, but for now it's fine as is. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41082?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I87fa7d988bec90ccade2f40ac4d2a0924059058e Gerrit-Change-Number: 41082 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 11 Sep 2025 14:08:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 week, 4 days

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: mme: Initial working state for MME_Tests_SGsAP.ttcn tests

by pespin

Attention is currently required from: fixeria, laforge. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41046?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: mme: Initial working state for MME_Tests_SGsAP.ttcn tests ...................................................................... mme: Initial working state for MME_Tests_SGsAP.ttcn tests MME_Tests_SGsAP.ttcn tests were introduced to the repository many years ago (~2019), but they were mostly WIP and were never run as part of the regular testsuite. This commit reworks and extends previous work to get them up to date with current MME_Tests and makes most of them passing. TC_sgsap_alert_* tests are still in WIP and will be fixed in follow-up work. Related: OS#6850 Change-Id: If07f1a67eb4213985da82afec94adb08786a0980 --- M library/SGsAP_Templates.ttcn M mme/ConnHdlr.ttcn M mme/MME_Tests.cfg M mme/MME_Tests.ttcn M mme/MME_Tests_SGsAP.ttcn M mme/expected-results.xml M mme/open5gs-mme.yaml 7 files changed, 296 insertions(+), 129 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/46/41046/8 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41046?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If07f1a67eb4213985da82afec94adb08786a0980 Gerrit-Change-Number: 41046 Gerrit-PatchSet: 8 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 week, 4 days

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: s1ap/S1AP_Templates.ttcn: Add templates to handle CS Fallback related...

by pespin

Attention is currently required from: fixeria, pespin. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41082?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Verified+1 by Jenkins Builder Change subject: s1ap/S1AP_Templates.ttcn: Add templates to handle CS Fallback related procedures ...................................................................... s1ap/S1AP_Templates.ttcn: Add templates to handle CS Fallback related procedures These will be used to test MT CS call over SGsAP in MME_Tests_SGsAP. Change-Id: I87fa7d988bec90ccade2f40ac4d2a0924059058e --- M library/s1ap/S1AP_Templates.ttcn 1 file changed, 95 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/82/41082/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41082?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I87fa7d988bec90ccade2f40ac4d2a0924059058e Gerrit-Change-Number: 41082 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 week, 4 days

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2025