Attention is currently required from: fixeria, pespin.
Hello Jenkins Builder, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41075?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by fixeria, Verified+1 by Jenkins Builder
Change subject: library/s1ap: Support receiving UEContextModificationRequest
......................................................................
library/s1ap: Support receiving UEContextModificationRequest
Change-Id: Iadb80eea7281b3bdf3359b0e2956e18bdb208207
---
M library/S1AP_Functions.ttcn
M library/s1ap/S1AP_Templates.ttcn
2 files changed, 31 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/75/41075/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41075?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iadb80eea7281b3bdf3359b0e2956e18bdb208207
Gerrit-Change-Number: 41075
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41079?usp=email )
Change subject: asterisk/gen_links.sh: fix broken symlink
......................................................................
asterisk/gen_links.sh: fix broken symlink
There exist two files named `PIPEasp_Templates.ttcn`:
* library/PIPEasp_Templates.ttcn
* deps/titan.TestPorts.PIPEasp/demo/PIPEasp_Templates.ttcn
We use our own one from the library, not the demo one.
In `asterisk/gen_links.sh` we first create a broken symlink, and then
overwrite it with a valid symlink to `library/PIPEasp_Templates.ttcn`.
This should not be a problem, since `gen_links.inc.sh` is calling ln
with flags `-sf`, yet we saw a build failure in Jenkins:
https://jenkins.osmocom.org/jenkins/view/TTCN3/job/ttcn3-asterisk-ims-ue-te…
------
> [3/5] RUN TTCN3-DOCKER-PREPARE "master" asterisk:
0.463 '/ttcn3-dumpcap-stop.sh' -> '/osmo-ttcn3-hacks/ttcn3-dumpcap-stop.sh'
0.463 + ln -sv /osmo-ttcn3-hacks/ttcn3-tcpdump-stop.sh /ttcn3-tcpdump-stop.sh
0.464 '/ttcn3-tcpdump-stop.sh' -> '/osmo-ttcn3-hacks/ttcn3-tcpdump-stop.sh'
0.465 + ln -sv /osmo-ttcn3-hacks/_scripts /_scripts
0.466 '/_scripts' -> '/osmo-ttcn3-hacks/_scripts'
0.466 + make asterisk
0.581 (cd asterisk && ./gen_links.sh && ./regen_makefile.sh)
0.627 ttcn3_makefilegen: error: Cannot find any source file for argument `PIPEasp_Templates.ttcn'.
0.631 ttcn3_makefilegen: warning: TTCN-3 preprocessing (option `-p') is enabled,
but no TTCN-3 files to be preprocessed were given for the Makefile.
0.632 make: *** [Makefile:131: _build/asterisk/Makefile] Error 1
------
Change-Id: Id79bd056716c34c4de02aba68caab95d185e6e48
---
M asterisk/gen_links.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, approved
diff --git a/asterisk/gen_links.sh b/asterisk/gen_links.sh
index 4113965..1dba2b9 100755
--- a/asterisk/gen_links.sh
+++ b/asterisk/gen_links.sh
@@ -16,7 +16,7 @@
gen_links $DIR $FILES
DIR=$BASEDIR/titan.TestPorts.PIPEasp/src
-FILES="PIPEasp_PT.cc PIPEasp_PT.hh PIPEasp_Types.ttcn PIPEasp_PortType.ttcn PIPEasp_Templates.ttcn "
+FILES="PIPEasp_PT.cc PIPEasp_PT.hh PIPEasp_Types.ttcn PIPEasp_PortType.ttcn "
gen_links $DIR $FILES
DIR=$BASEDIR/titan.TestPorts.IPL4asp/src
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41079?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id79bd056716c34c4de02aba68caab95d185e6e48
Gerrit-Change-Number: 41079
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41079?usp=email )
Change subject: asterisk/gen_links.sh: fix broken symlink
......................................................................
asterisk/gen_links.sh: fix broken symlink
There exist two files named `PIPEasp_Templates.ttcn`:
* library/PIPEasp_Templates.ttcn
* deps/titan.TestPorts.PIPEasp/demo/PIPEasp_Templates.ttcn
We use our own one from the library, not the demo one.
In `asterisk/gen_links.sh` we first create a broken symlink, and then
overwrite it with a valid symlink to `library/PIPEasp_Templates.ttcn`.
This should not be a problem, since `gen_links.inc.sh` is calling ln
with flags `-sf`, yet we saw a build failure in Jenkins:
https://jenkins.osmocom.org/jenkins/view/TTCN3/job/ttcn3-asterisk-ims-ue-te…
------
> [3/5] RUN TTCN3-DOCKER-PREPARE "master" asterisk:
0.463 '/ttcn3-dumpcap-stop.sh' -> '/osmo-ttcn3-hacks/ttcn3-dumpcap-stop.sh'
0.463 + ln -sv /osmo-ttcn3-hacks/ttcn3-tcpdump-stop.sh /ttcn3-tcpdump-stop.sh
0.464 '/ttcn3-tcpdump-stop.sh' -> '/osmo-ttcn3-hacks/ttcn3-tcpdump-stop.sh'
0.465 + ln -sv /osmo-ttcn3-hacks/_scripts /_scripts
0.466 '/_scripts' -> '/osmo-ttcn3-hacks/_scripts'
0.466 + make asterisk
0.581 (cd asterisk && ./gen_links.sh && ./regen_makefile.sh)
0.627 ttcn3_makefilegen: error: Cannot find any source file for argument `PIPEasp_Templates.ttcn'.
0.631 ttcn3_makefilegen: warning: TTCN-3 preprocessing (option `-p') is enabled,
but no TTCN-3 files to be preprocessed were given for the Makefile.
0.632 make: *** [Makefile:131: _build/asterisk/Makefile] Error 1
------
Change-Id: Id79bd056716c34c4de02aba68caab95d185e6e48
---
M asterisk/gen_links.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/79/41079/1
diff --git a/asterisk/gen_links.sh b/asterisk/gen_links.sh
index 4113965..1dba2b9 100755
--- a/asterisk/gen_links.sh
+++ b/asterisk/gen_links.sh
@@ -16,7 +16,7 @@
gen_links $DIR $FILES
DIR=$BASEDIR/titan.TestPorts.PIPEasp/src
-FILES="PIPEasp_PT.cc PIPEasp_PT.hh PIPEasp_Types.ttcn PIPEasp_PortType.ttcn PIPEasp_Templates.ttcn "
+FILES="PIPEasp_PT.cc PIPEasp_PT.hh PIPEasp_Types.ttcn PIPEasp_PortType.ttcn "
gen_links $DIR $FILES
DIR=$BASEDIR/titan.TestPorts.IPL4asp/src
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41079?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id79bd056716c34c4de02aba68caab95d185e6e48
Gerrit-Change-Number: 41079
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>