July 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ttcn3-hacks[master]: bsc: TC_mscpool_sccp_n_pcstate_detaches_msc: wait for AS to become un...

by pespin

Attention is currently required from: lynxis lazus, pespin. Hello Jenkins Builder, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40620?usp=email to look at the new patch set (#4). Change subject: bsc: TC_mscpool_sccp_n_pcstate_detaches_msc: wait for AS to become unavailable ...................................................................... bsc: TC_mscpool_sccp_n_pcstate_detaches_msc: wait for AS to become unavailable Otherwise race conditions can ocurr, specially since during some time the AS can be in PENDING state until finally going into DOWN state and notifying the peer. Change-Id: Idc84929d89cbac4eb67cd2740f98844253dde70d --- M bsc/BSC_Tests.ttcn 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/20/40620/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40620?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idc84929d89cbac4eb67cd2740f98844253dde70d Gerrit-Change-Number: 40620 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

2 weeks, 6 days

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce test TC_stat_stp_sctp_disconnected

by pespin

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40592?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Code-Review+1 by lynxis lazus, Verified+1 by Jenkins Builder Change subject: hnbgw: Introduce test TC_stat_stp_sctp_disconnected ...................................................................... hnbgw: Introduce test TC_stat_stp_sctp_disconnected Related: OS#5917 Depends: libosmo-sigtran.git Change-Id I7e4eedb65c4f2952f8b39ca4c539ca2f40e9946c Change-Id: I079f2da09ff8d52e614ff6f5d267cd5429e4eb58 --- M hnbgw/HNBGW_Tests.default M hnbgw/HNBGW_Tests.ttcn M hnbgw/expected-results.xml 3 files changed, 110 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/92/40592/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40592?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I079f2da09ff8d52e614ff6f5d267cd5429e4eb58 Gerrit-Change-Number: 40592 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

2 weeks, 6 days

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: bsc: TC_mscpool_sccp_n_pcstate_detaches_msc: wait for AS to become un...

by fixeria

Attention is currently required from: lynxis lazus, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40620?usp=email ) Change subject: bsc: TC_mscpool_sccp_n_pcstate_detaches_msc: wait for AS to become unavailable ...................................................................... Patch Set 3: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40620/comment/689eb2f4_c8e8… : PS3, Line 13: This is the case for instance in test This statement is incomplete. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40620?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idc84929d89cbac4eb67cd2740f98844253dde70d Gerrit-Change-Number: 40620 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 09 Jul 2025 12:49:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

2 weeks, 6 days

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: bsc: TC_mscpool_sccp_n_pcstate_detaches_msc: wait for AS to become un...

by pespin

Attention is currently required from: lynxis lazus, pespin. Hello Jenkins Builder, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40620?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by lynxis lazus, Verified+1 by Jenkins Builder Change subject: bsc: TC_mscpool_sccp_n_pcstate_detaches_msc: wait for AS to become unavailable ...................................................................... bsc: TC_mscpool_sccp_n_pcstate_detaches_msc: wait for AS to become unavailable Otherwise race conditions can ocurr, specially since during some time the AS can be in PENDING state until finally going into DOWN state and notifying the peer. This is the case for instance in test Change-Id: Idc84929d89cbac4eb67cd2740f98844253dde70d --- M bsc/BSC_Tests.ttcn 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/20/40620/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40620?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idc84929d89cbac4eb67cd2740f98844253dde70d Gerrit-Change-Number: 40620 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

2 weeks, 6 days

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce test TC_stat_stp_sctp_disconnected

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40592?usp=email ) Change subject: hnbgw: Introduce test TC_stat_stp_sctp_disconnected ...................................................................... Patch Set 3: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40592/comment/bc2e8fbe_0977… : PS3, Line 8: > you could add some more contexts for such a long test. […] The test itself is properly explained as a comment on its header, I see no point in duplicating the description here tbh: ```` /* When a peer point-code gets an SCCP N-PCSTATE saying it is unreachable, * immediately mark the CN link as unusable. * In this scenario, the SCCP N-PCSTATE is triggered by instructing the STP to * shutdown the ASP serving the HNBGW, which will close the SCTP assoc between * itself and IUT (HNBGW), which should then generate an N-PCSTATE.ind. */ function f_TC_stat_stp_sctp_disconnected_UnitdataCallback(RANAP_PDU ranap) runs on RAN_Emulation_CT return template RANAP_PDU { ```` -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40592?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I079f2da09ff8d52e614ff6f5d267cd5429e4eb58 Gerrit-Change-Number: 40592 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 08 Jul 2025 18:29:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

2 weeks, 6 days

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: StatsD_Checker: Keep polling IUT if waiting for convergence

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40619?usp=email ) Change subject: StatsD_Checker: Keep polling IUT if waiting for convergence ...................................................................... StatsD_Checker: Keep polling IUT if waiting for convergence The wait_converge feature was implemented and used so far only against IUTs which used also the snapshot feature, due to not having a VTY which allows both resetting and triggering a status report manually. Instead, those relied on IUT reporting changes at a given frequency. If the wait_converge feature is requested and polling mode is used, then make sure we poll once per second after last received statsd UDP msg. Change-Id: Id78b46b88048206f74d1d88672b8309227e9438c --- M library/StatsD_Checker.ttcnpp 1 file changed, 31 insertions(+), 6 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified lynxis lazus: Looks good to me, approved diff --git a/library/StatsD_Checker.ttcnpp b/library/StatsD_Checker.ttcnpp index a944176..081e6e1 100644 --- a/library/StatsD_Checker.ttcnpp +++ b/library/StatsD_Checker.ttcnpp @@ -298,6 +298,24 @@ return result; } +private function using_poll_mode()runs on StatsD_Checker_CT return boolean +{ +#ifdef STATSD_HAVE_VTY + return true; +#else + return false; +#endif +} + +private function poll_stats_report() runs on StatsD_Checker_CT +{ +#ifdef STATSD_HAVE_VTY + f_vty_transceive(STATSVTY, "stats report"); +#else + /* Assume caller knows previous state, eg. gauges may have been 0 due to IUT being reset */ +#endif +} + private function f_statsd_checker_expect(StatsDExpects expects, boolean wait_converge := false, boolean use_snapshot := false, @@ -307,6 +325,8 @@ var StatsDExpectResult res; var Booleans matched := {}; var integer matched_remain := 0; + var boolean poll := using_poll_mode(); + timer T_poll_converge; for (var integer i := 0; i < lengthof(expects); i := i + 1) { matched := matched & {false}; @@ -316,12 +336,8 @@ /* Dismiss any messages we might have skipped from the last report */ STATS.clear; - if (not use_snapshot) { -#ifdef STATSD_HAVE_VTY - f_vty_transceive(STATSVTY, "stats report"); -#else - /* Assume caller knows previous state, eg. gauges may have been 0 due to IUT being reset */ -#endif + if (poll) { + poll_stats_report(); } T_statsd.start(g_timeout); @@ -330,7 +346,15 @@ alt { [] STATS.receive(tr_StatsD_RecvFrom(?, ?)) -> value rf { msg := rf.msg; + if (poll and wait_converge) { + T_poll_converge.stop; + T_poll_converge.start(1.0); } + } + [poll and wait_converge] T_poll_converge.timeout { + poll_stats_report(); + repeat; + } [] T_statsd.timeout { for (var integer i := 0; i < lengthof(expects); i := i + 1) { /* We're still missing some expects, keep looking */ @@ -369,6 +393,7 @@ } } } + T_poll_converge.stop; T_statsd.stop; return true; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40619?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id78b46b88048206f74d1d88672b8309227e9438c Gerrit-Change-Number: 40619 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 weeks, 6 days

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: StatsD_Checker: Allow configuring timeout

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40618?usp=email ) Change subject: StatsD_Checker: Allow configuring timeout ...................................................................... StatsD_Checker: Allow configuring timeout Change-Id: I183ad5810468cba5bfec20eb584a27462fde980c --- M library/StatsD_Checker.ttcnpp 1 file changed, 9 insertions(+), 6 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified lynxis lazus: Looks good to me, approved diff --git a/library/StatsD_Checker.ttcnpp b/library/StatsD_Checker.ttcnpp index b2b8332..a944176 100644 --- a/library/StatsD_Checker.ttcnpp +++ b/library/StatsD_Checker.ttcnpp @@ -80,7 +80,8 @@ #endif port STATSD_PROC_PT STATSD_PROC; port STATSD_CODEC_PT STATS; - timer T_statsd := 5.0; + var float g_timeout; + timer T_statsd; } type component StatsD_ConnHdlr { @@ -99,7 +100,7 @@ /* StatsD checker component */ -function main(charstring statsd_host, integer statsd_port) runs on StatsD_Checker_CT { +function main(charstring statsd_host, integer statsd_port, float statsd_timeout := 5.0) runs on StatsD_Checker_CT { var StatsD_ConnHdlr vc_conn; var StatsDMetricKeys keys; var boolean since_last_snapshot; @@ -109,6 +110,8 @@ var StatsDMetrics snapshot; var Result res; + g_timeout := statsd_timeout; + while (not mp_enable_stats) { log("StatsD checker disabled by modulepar"); f_sleep(3600.0); @@ -192,7 +195,7 @@ f_vty_transceive(STATSVTY, "stats report"); #endif - T_statsd.start; + T_statsd.start(g_timeout); while (seen_remain > 0) { var StatsD_RecvFrom rf; alt { @@ -321,7 +324,7 @@ #endif } - T_statsd.start; + T_statsd.start(g_timeout); while (matched_remain > 0) { var StatsD_RecvFrom rf; alt { @@ -370,11 +373,11 @@ return true; } -function f_init_statsd(charstring id, inout StatsD_Checker_CT vc_STATSD, charstring local_addr, integer local_port) { +function f_init_statsd(charstring id, inout StatsD_Checker_CT vc_STATSD, charstring local_addr, integer local_port, float statsd_timeout := 5.0) { id := id & "-STATS"; vc_STATSD := StatsD_Checker_CT.create(id); - vc_STATSD.start(StatsD_Checker.main(local_addr, local_port)); + vc_STATSD.start(StatsD_Checker.main(local_addr, local_port, statsd_timeout)); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40618?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I183ad5810468cba5bfec20eb584a27462fde980c Gerrit-Change-Number: 40618 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 weeks, 6 days

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: RAN_Emulation.ttcnpp: Log ignored rx RANAP msg when no cb set

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40617?usp=email ) Change subject: RAN_Emulation.ttcnpp: Log ignored rx RANAP msg when no cb set ...................................................................... RAN_Emulation.ttcnpp: Log ignored rx RANAP msg when no cb set Change-Id: I15b6fea2d44ab9607db020e1152ee1fd79839a52 --- M library/RAN_Emulation.ttcnpp 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified lynxis lazus: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/library/RAN_Emulation.ttcnpp b/library/RAN_Emulation.ttcnpp index 294954d..9401ed6 100644 --- a/library/RAN_Emulation.ttcnpp +++ b/library/RAN_Emulation.ttcnpp @@ -759,6 +759,7 @@ /* ELSE: handle in user callback */ if (not ispresent(g_ran_ops.ranap_unitdata_cb)) { + log("CommonRanapUnitdataCallback: Ignoring RANAP msg: ", ranap); return omit; } return g_ran_ops.ranap_unitdata_cb.apply(ranap); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40617?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I15b6fea2d44ab9607db020e1152ee1fd79839a52 Gerrit-Change-Number: 40617 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 weeks, 6 days

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: PCU: TC_sns_del: expect NS Alive while preparing the test

by lynxis lazus

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40622?usp=email ) Change subject: PCU: TC_sns_del: expect NS Alive while preparing the test ...................................................................... PCU: TC_sns_del: expect NS Alive while preparing the test f_outgoing_sns_chg_weight() should handle NS Alive until it do the SNS Delete procedure. Related: OS#6751 Change-Id: I7c0991819de48b59e763fbe1ef6df4567c38007c --- M pcu/PCU_Tests_SNS.ttcn 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified daniel: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/pcu/PCU_Tests_SNS.ttcn b/pcu/PCU_Tests_SNS.ttcn index c2fa927..9ce2686 100644 --- a/pcu/PCU_Tests_SNS.ttcn +++ b/pcu/PCU_Tests_SNS.ttcn @@ -354,6 +354,8 @@ testcase TC_sns_del() runs on RAW_Test_CT { f_sns_bringup_1c1u(); + + g_handle_rx_alive := true; f_outgoing_sns_chg_weight(idx_chg := 0, w_sig := 1, w_user := 1, idx := 0); f_sleep(1.0); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40622?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7c0991819de48b59e763fbe1ef6df4567c38007c Gerrit-Change-Number: 40622 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 weeks, 6 days

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: RAW_NS: SNS: allow to set the transaction id of Add/Chg/Del procedures

by lynxis lazus

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40566?usp=email ) Change subject: RAW_NS: SNS: allow to set the transaction id of Add/Chg/Del procedures ...................................................................... RAW_NS: SNS: allow to set the transaction id of Add/Chg/Del procedures Using hardcoded transaction ids are working, but for the TC_SNS_del it would result in descending transaction ids. Related: OS#6751 Change-Id: I1ea0424232ed925fee623568eb0edccdf1ae0368 --- M library/RAW_NS.ttcnpp 1 file changed, 15 insertions(+), 15 deletions(-) Approvals: daniel: Looks good to me, approved laforge: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/library/RAW_NS.ttcnpp b/library/RAW_NS.ttcnpp index a7cdb8a..e7f32d2 100644 --- a/library/RAW_NS.ttcnpp +++ b/library/RAW_NS.ttcnpp @@ -498,7 +498,7 @@ NSCP[idx].send(ts_SNS_ACK(g_nsconfig.nsei, rx.pDU_SNS_Add.transactionID)); } -function f_outgoing_sns_add(integer idx_add, uint8_t w_sig := 1, uint8_t w_user := 1, integer idx := 0, template (omit) NsCause cause := omit) +function f_outgoing_sns_add(integer idx_add, uint8_t w_sig := 1, uint8_t w_user := 1, integer idx := 0, template (omit) NsCause cause := omit, integer tid := 23) runs on RAW_NS_CT { log("f_outgoing_sns_add(idx_add=", idx_add, ")"); var PDU_NS rx; @@ -512,8 +512,8 @@ if (isvalue(cause) and valueof(cause) == NS_CAUSE_UNKNOWN_IP_ENDPOINT) { ack_v4 := v4; } - NSCP[idx].send(ts_SNS_ADD(g_nsconfig.nsei, 23, v4)); - rx := f_ns_exp(tr_SNS_ACK(g_nsconfig.nsei, 23, cause, ack_v4)); + NSCP[idx].send(ts_SNS_ADD(g_nsconfig.nsei, tid, v4)); + rx := f_ns_exp(tr_SNS_ACK(g_nsconfig.nsei, tid, cause, ack_v4)); } else { var template (omit) IP6_Elements v6 := { ts_SNS_IPv6(nsvc_cfg.provider.ip.local_ip, nsvc_cfg.provider.ip.local_udp_port, @@ -522,8 +522,8 @@ if (isvalue(cause) and valueof(cause) == NS_CAUSE_UNKNOWN_IP_ENDPOINT) { ack_v6 := v6; } - NSCP[idx].send(ts_SNS_ADD(g_nsconfig.nsei, 23, omit, v6)); - rx := f_ns_exp(tr_SNS_ACK(g_nsconfig.nsei, 23, cause, omit, ack_v6)); + NSCP[idx].send(ts_SNS_ADD(g_nsconfig.nsei, tid, omit, v6)); + rx := f_ns_exp(tr_SNS_ACK(g_nsconfig.nsei, tid, cause, omit, ack_v6)); } } @@ -549,7 +549,7 @@ } -function f_outgoing_sns_del(integer idx_del, uint8_t w_sig := 1, uint8_t w_user := 1, integer idx := 0) +function f_outgoing_sns_del(integer idx_del, uint8_t w_sig := 1, uint8_t w_user := 1, integer idx := 0, integer tid := 24) runs on RAW_NS_CT { log("f_outgoing_sns_del(idx_del=", idx_del, ")"); var PDU_NS rx; @@ -558,18 +558,18 @@ var template (omit) IP4_Elements v4 := { ts_SNS_IPv4(nsvc_cfg.provider.ip.local_ip, nsvc_cfg.provider.ip.local_udp_port, w_sig, w_user) }; - NSCP[idx].send(ts_SNS_DEL(g_nsconfig.nsei, 24, omit, v4)); - rx := f_ns_exp(tr_SNS_ACK(g_nsconfig.nsei, 24, omit, v4)); + NSCP[idx].send(ts_SNS_DEL(g_nsconfig.nsei, tid, omit, v4)); + rx := f_ns_exp(tr_SNS_ACK(g_nsconfig.nsei, tid, omit, v4)); } else { var template (omit) IP6_Elements v6 := { ts_SNS_IPv6(nsvc_cfg.provider.ip.local_ip, nsvc_cfg.provider.ip.local_udp_port, w_sig, w_user) }; - NSCP[idx].send(ts_SNS_DEL(g_nsconfig.nsei, 24, omit, omit, v6)); - rx := f_ns_exp(tr_SNS_ACK(g_nsconfig.nsei, 24, omit, omit, v6)); + NSCP[idx].send(ts_SNS_DEL(g_nsconfig.nsei, tid, omit, omit, v6)); + rx := f_ns_exp(tr_SNS_ACK(g_nsconfig.nsei, tid, omit, omit, v6)); } } -function f_outgoing_sns_chg_weight(integer idx_chg, uint8_t w_sig, uint8_t w_user, integer idx := 0) +function f_outgoing_sns_chg_weight(integer idx_chg, uint8_t w_sig, uint8_t w_user, integer idx := 0, integer tid := 25) runs on RAW_NS_CT { log("f_outgoing_sns_chg_weight(idx_chg=", idx_chg, ")"); var PDU_NS rx; @@ -578,14 +578,14 @@ var template (omit) IP4_Elements v4 := { ts_SNS_IPv4(nsvc_cfg.provider.ip.local_ip, nsvc_cfg.provider.ip.local_udp_port, w_sig, w_user) }; - NSCP[idx].send(ts_SNS_CHG_WEIGHT(g_nsconfig.nsei, 25, v4)); - rx := f_ns_exp(tr_SNS_ACK(g_nsconfig.nsei, 25, omit, omit)); + NSCP[idx].send(ts_SNS_CHG_WEIGHT(g_nsconfig.nsei, tid, v4)); + rx := f_ns_exp(tr_SNS_ACK(g_nsconfig.nsei, tid, omit, omit)); } else { var template (omit) IP6_Elements v6 := { ts_SNS_IPv6(nsvc_cfg.provider.ip.local_ip, nsvc_cfg.provider.ip.local_udp_port, w_sig, w_user) }; - NSCP[idx].send(ts_SNS_CHG_WEIGHT(g_nsconfig.nsei, 25, omit, v6)); - rx := f_ns_exp(tr_SNS_ACK(g_nsconfig.nsei, 25, omit, omit, omit)); + NSCP[idx].send(ts_SNS_CHG_WEIGHT(g_nsconfig.nsei, tid, omit, v6)); + rx := f_ns_exp(tr_SNS_ACK(g_nsconfig.nsei, tid, omit, omit, omit)); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40566?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1ea0424232ed925fee623568eb0edccdf1ae0368 Gerrit-Change-Number: 40566 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 weeks, 6 days

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2025