July 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-msc[master]: ran_peer: Introuce stats msc.ran_peers.{total,active}
by pespin 14 Jul '25

14 Jul '25

Attention is currently required from: pespin. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/40633?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: ran_peer: Introuce stats msc.ran_peers.{total,active} ...................................................................... ran_peer: Introuce stats msc.ran_peers.{total,active} Change-Id: I36e40510c9a95f0c9cf5f32d2a7baab840aa8660 --- M include/osmocom/msc/gsm_data.h M src/libmsc/ran_peer.c 2 files changed, 33 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/33/40633/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40633?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I36e40510c9a95f0c9cf5f32d2a7baab840aa8660 Gerrit-Change-Number: 40633 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-msc[master]: msc_main: Remove unnedeed include of ranap/iu_client.h
by pespin 14 Jul '25

14 Jul '25

Attention is currently required from: lynxis lazus, pespin. Hello Jenkins Builder, fixeria, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/40642?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: msc_main: Remove unnedeed include of ranap/iu_client.h ...................................................................... msc_main: Remove unnedeed include of ranap/iu_client.h iu_client is so far only used to set up some VTY configs in msc_vty.c, hence not needed here. Change-Id: I4716c5229273b74ee165ebaaf0914e9eebef9e6f --- M src/osmo-msc/msc_main.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/42/40642/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40642?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I4716c5229273b74ee165ebaaf0914e9eebef9e6f Gerrit-Change-Number: 40642 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-msc[master]: vty: Get rid of unneeded iu_client vty config
by pespin 14 Jul '25

14 Jul '25

Attention is currently required from: fixeria, lynxis lazus, neels. Hello Jenkins Builder, lynxis lazus, neels, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/40645?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: vty: Get rid of unneeded iu_client vty config ...................................................................... vty: Get rid of unneeded iu_client vty config Use of osmo-iuh's iu_client API was removed from osmo-msc long time ago (see c4628a3ad4d3c5f65782b152b771bf80357235d6), and its removal is also scheduled in osmo-sgsn. Still, some small reference bits were still left. Remove them. The VTY init functions being dropped basically set g_rab_assign_addr_enc, which doesn't really seem to be used at all, only place is that file for vty related stuff which has actually no use in osmo-msc. Other 2 are asn1c debugging related, which can also probably be dropped. This completelly removes references to iu_client.h in osmo-msc. Related: OS#5487 Change-Id: I9cf83f2255e1e9aa83f3139b88ea81b2f5b686c3 --- M src/libmsc/msc_vty.c 1 file changed, 0 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/45/40645/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40645?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9cf83f2255e1e9aa83f3139b88ea81b2f5b686c3 Gerrit-Change-Number: 40645 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in osmo-msc[master]: ran_peer: Add specific API to free object
by fixeria 14 Jul '25

14 Jul '25

Attention is currently required from: neels, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-msc/+/40632?usp=email ) Change subject: ran_peer: Add specific API to free object ...................................................................... Patch Set 2: -Code-Review (3 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-msc/+/40632/comment/76ca9ff1_03e278cf?usp… : PS2, Line 14: Apparently the object is not being freed anywhere > Now, can you tell me where is the fsm instance being terminated/freed in the codebase? It's never freed anywhere. That's what I meant. Well, here in the COMMIT_MSG you're talking about the object (`struct ran_peer`), not about the FSM instance. But indeed, I see no invocations of `osmo_fsm_inst_term()`/`osmo_fsm_inst_free()` on the `ran_peer_fsm`. I thought it might be terminated as a child of some parent FSM, but this is not the case either. File include/osmocom/msc/ran_peer.h: https://gerrit.osmocom.org/c/osmo-msc/+/40632/comment/eaecfed5_fbdd01b9?usp… : PS2, Line 109: ran_peer_discard_all_conns > It's called by ran_peer_free(), so I need it declared beforehand. […] Ah, I see. Either way is fine with me. File src/libmsc/ran_peer.c: https://gerrit.osmocom.org/c/osmo-msc/+/40632/comment/6dd6627a_6f9fa656?usp… : PS2, Line 79: ran_peer_free > Yeah well, these objects are not actually being freed anywhere in code (yet?). […] Yet you may want to declare this API in `ran_peer.h`? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40632?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I721de21a68a4e336ae508a995e3cfcca05d57efe Gerrit-Change-Number: 40632 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Jul 2025 09:27:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in osmo-msc[master]: ran_peer: Add specific API to free object
by pespin 14 Jul '25

14 Jul '25

Attention is currently required from: fixeria, neels. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-msc/+/40632?usp=email ) Change subject: ran_peer: Add specific API to free object ...................................................................... Patch Set 2: (1 comment) File include/osmocom/msc/ran_peer.h: https://gerrit.osmocom.org/c/osmo-msc/+/40632/comment/b7ba4a67_fb3e81d8?usp… : PS2, Line 109: ran_peer_discard_all_conns > It's called by ran_peer_free(), so I need it declared beforehand. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40632?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I721de21a68a4e336ae508a995e3cfcca05d57efe Gerrit-Change-Number: 40632 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Jul 2025 09:23:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in osmo-msc[master]: msc: Initial implementation of N-PCSTATE.ind
by pespin 14 Jul '25

14 Jul '25

Attention is currently required from: laforge, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-msc/+/40630?usp=email ) Change subject: msc: Initial implementation of N-PCSTATE.ind ...................................................................... Patch Set 2: (1 comment) File src/libmsc/sccp_ran.c: https://gerrit.osmocom.org/c/osmo-msc/+/40630/comment/86a04bf1_4b51151d?usp… : PS2, Line 155: /* TODO: need to change state?! */ > Ack, I forgot to remove it. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40630?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ice1b2c163b1b0d134fcaa1c8bf543038a35fabdf Gerrit-Change-Number: 40630 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 14 Jul 2025 09:20:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-msc[master]: msc: Initial implementation of N-PCSTATE.ind
by pespin 14 Jul '25

14 Jul '25

Attention is currently required from: laforge, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-msc/+/40630?usp=email ) Change subject: msc: Initial implementation of N-PCSTATE.ind ...................................................................... Patch Set 2: (1 comment) File src/libmsc/sccp_ran.c: https://gerrit.osmocom.org/c/osmo-msc/+/40630/comment/b67b7bf1_5415ccd9?usp… : PS2, Line 155: /* TODO: need to change state?! */ > there is a state change in ran_peer_becomes_unreachable, so this todo can be removed? Ack, I forgot to remove it. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40630?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ice1b2c163b1b0d134fcaa1c8bf543038a35fabdf Gerrit-Change-Number: 40630 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 14 Jul 2025 09:17:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: BSSGP_ConnHdlr: f_service_request: prevent a test error in GSUP SAI Req
by pespin 14 Jul '25

14 Jul '25

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40652?usp=email ) Change subject: BSSGP_ConnHdlr: f_service_request: prevent a test error in GSUP SAI Req ...................................................................... Patch Set 2: (1 comment) File sgsn/BSSGP_ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40652/comment/694a1b4c_d2f3… : PS2, Line 798: [not expect_auth] GSUP.receive(tr_GSUP_SAI_REQ(g_pars.imsi)) { This probably needs rebasing on top of current master. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40652?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibfedab844a3703f76538d66febf747fcca5d4d1a Gerrit-Change-Number: 40652 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 14 Jul 2025 09:17:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-ttcn3-hacks[master]: GSUP Fix missing IMSI template present restriction in tr_GSUP_SAI_REQ
by pespin 14 Jul '25

14 Jul '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40639?usp=email ) Change subject: GSUP Fix missing IMSI template present restriction in tr_GSUP_SAI_REQ ...................................................................... GSUP Fix missing IMSI template present restriction in tr_GSUP_SAI_REQ I got this DTE while running SGSN_Tests_Iu.TC_attach_pdp_act_user: """ GSUP_Templates.ttcn:381 Dynamic test case error: Restriction `present' on template of type hexstring violated. """ According to GSUP documentation, the IMSI param is mandatory. Upon fixing it, the compiler found the user causing the problem: """ BSSGP_ConnHdlr.ttcn:797.49: error: Restriction on template formal parameter does not allow usage of any or omit """ That error is also fixed in this same commit. Change-Id: Iea712df2f922fe5eb16e116f7a4609a0e20233b4 --- M library/GSUP_Templates.ttcn M sgsn/BSSGP_ConnHdlr.ttcn 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve lynxis lazus: Looks good to me, approved diff --git a/library/GSUP_Templates.ttcn b/library/GSUP_Templates.ttcn index 327f7f6..227a7d2 100644 --- a/library/GSUP_Templates.ttcn +++ b/library/GSUP_Templates.ttcn @@ -378,7 +378,7 @@ valueof(ts_GSUP_IE_RAND(rand)) }); -template GSUP_PDU tr_GSUP_SAI_REQ(template hexstring imsi) := +template GSUP_PDU tr_GSUP_SAI_REQ(template (present) hexstring imsi) := tr_GSUP_IMSI(OSMO_GSUP_MSGT_SEND_AUTH_INFO_REQUEST, imsi); template GSUP_PDU tr_GSUP_SAI_REQ_UMTS_AKA_RESYNC( diff --git a/sgsn/BSSGP_ConnHdlr.ttcn b/sgsn/BSSGP_ConnHdlr.ttcn index 1b2e5a0..2b95ec0 100644 --- a/sgsn/BSSGP_ConnHdlr.ttcn +++ b/sgsn/BSSGP_ConnHdlr.ttcn @@ -794,7 +794,7 @@ Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Service Request: Unexpected GMM Auth Req"); } - [not expect_auth] GSUP.receive(tr_GSUP_SAI_REQ(*)) { + [not expect_auth] GSUP.receive(tr_GSUP_SAI_REQ(?)) { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Service Request: Unexpected GSUP SAI Req"); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40639?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iea712df2f922fe5eb16e116f7a4609a0e20233b4 Gerrit-Change-Number: 40639 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: sgsn: Use static sigtran config between osmo-sgsn and osmo-stp
by pespin 14 Jul '25

14 Jul '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40640?usp=email ) Change subject: sgsn: Use static sigtran config between osmo-sgsn and osmo-stp ...................................................................... sgsn: Use static sigtran config between osmo-sgsn and osmo-stp This allows referencing/accessing the specific ASP in osmo-stp, which will be needed in a follow-up commit to test IUT behavior when the SCTP conn is dropped. Related: OS#5917 Change-Id: Ie52f4c1877587067af66add56ad8674b82b51718 --- M sgsn/osmo-sgsn.cfg M sgsn/osmo-stp.cfg 2 files changed, 12 insertions(+), 5 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve lynxis lazus: Looks good to me, approved Jenkins Builder: Verified diff --git a/sgsn/osmo-sgsn.cfg b/sgsn/osmo-sgsn.cfg index 4a5f236..ae01923 100644 --- a/sgsn/osmo-sgsn.cfg +++ b/sgsn/osmo-sgsn.cfg @@ -56,7 +56,8 @@ ! cs7 instance 0 point-code 0.23.4 - asp asp-clnt-OsmoSGSN-A 2905 0 m3ua + asp asp-clnt-OsmoSGSN-A 2905 1905 m3ua + local-ip 127.0.0.10 remote-ip 127.0.0.200 role asp sctp-role client diff --git a/sgsn/osmo-stp.cfg b/sgsn/osmo-stp.cfg index e79c298..7b1e965 100644 --- a/sgsn/osmo-stp.cfg +++ b/sgsn/osmo-stp.cfg @@ -37,6 +37,14 @@ ! cs7 instance 0 xua rkm routing-key-allocation dynamic-permitted + asp sgsn0-0 1905 2905 m3ua + local-ip 127.0.0.200 + remote-ip 127.0.0.10 + role sg + sctp-role server + as sgsn0 m3ua + asp sgsn0-0 + routing-key 3 0.23.4 asp virt-rnc0-0 23908 2905 m3ua local-ip 127.0.0.200 remote-ip 127.0.0.104 @@ -46,10 +54,8 @@ asp virt-rnc0-0 routing-key 2 0.24.3 route-table system + update route 0.23.4 7.255.7 linkset sgsn0 update route 0.24.3 7.255.7 linkset virt-rnc0 listen m3ua 2905 local-ip 127.0.0.200 - accept-asp-connections dynamic-permitted - listen ipa 5000 - local-ip 127.0.0.200 - accept-asp-connections dynamic-permitted + accept-asp-connections pre-configured -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40640?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie52f4c1877587067af66add56ad8674b82b51718 Gerrit-Change-Number: 40640 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0