July 2025 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-sigtran[master]: vty: Introduce missing cmd 'point-code override opc'

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40611?usp=email ) Change subject: vty: Introduce missing cmd 'point-code override opc' ...................................................................... vty: Introduce missing cmd 'point-code override opc' This patch introduces several improvements and fixes around the 'point-code override' feature: * properly split overriding OPC vs DPC over VTY: Before this patch only DPC cmd was available despite being used for OPC under ASP role. Even the VTY command had a description entry for OPC but it was not implemented yet. * Allow proper overriding with PC 0. * Allow overriding of both OPC and DPC in SG role. * Figure out role based on role VTY configuration instead of IPA client/server config. Related: OS#6806 Change-Id: Id8ba5252a088dafe85bb25e13298c585acef277d --- M src/ipa.c M src/ss7_as.h M src/ss7_as_vty.c M tests/vty/osmo_stp_test.vty 4 files changed, 107 insertions(+), 30 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/ipa.c b/src/ipa.c index 58646fa..8035889 100644 --- a/src/ipa.c +++ b/src/ipa.c @@ -265,25 +265,40 @@ * information inside the non-CR/CC connection oriented * messages. * - * The only other alternative we have is to simply have a - * STP (server) side configuration that specifies which point - * code those messages are to be routed to, and then use this - * 'override DPC' in the routing decision. We could do the same - * for the source point code to ensure responses are routed back - * to us. This is all quite ugly, but then what can we do :/ + * The only other alternative we have is to: + * + * ASP role: we assume whatever was received at the ASP/AS was meant to + * reach us and hence set the DPC to the PC configured in the + * 'routing-key'. In this case the 'override OPC' is used so that upper + * layers can find out where it came from, so it can answer back if needed. + * + * SG role (STP): By default, the AS associated with the ASP assumes the + * OPC of the message received was transmitted to us from the PC + * configured in the 'routing-key'. If set, 'override OPC' can be used + * to also tweak the originating PC, which can be useful in setups with + * traffic coming from another STP where want to set eg. the OPC to the + * PC of the originating AS. In this case the 'override DPC'. + * allows to find out where those messages are to be routed to in the + * routing decision. + * + * This is all quite ugly, but then what can we do :/ */ /* First, determine the DPC and OPC to use */ - if (asp->cfg.is_server) { - /* Source: the PC of the routing key */ - opc = as->cfg.routing_key.pc; - /* Destination: Based on VTY config */ - dpc = as->cfg.pc_override.dpc; - } else { + if (asp->cfg.role == OSMO_SS7_ASP_ROLE_ASP) { /* Source: Based on VTY config */ - opc = as->cfg.pc_override.dpc; + opc = as->cfg.pc_override.opc; /* Destination: PC of the routing key */ dpc = as->cfg.routing_key.pc; + } else { + /* Source: if set, based on VTY config, + * otherwise by default the PC of the routing key */ + if (as->cfg.pc_override.opc_enabled) + opc = as->cfg.pc_override.opc; + else + opc = as->cfg.routing_key.pc; + /* Destination: Based on VTY config */ + dpc = as->cfg.pc_override.dpc; } /* Second, patch this into the SCCP message */ diff --git a/src/ss7_as.h b/src/ss7_as.h index be10f48..98151f8 100644 --- a/src/ss7_as.h +++ b/src/ss7_as.h @@ -104,6 +104,9 @@ uint32_t recovery_timeout_msec; uint8_t qos_class; struct { + bool opc_enabled; + bool dpc_enabled; + uint32_t opc; uint32_t dpc; enum osmo_ss7_as_patch_sccp_mode sccp_mode; } pc_override; diff --git a/src/ss7_as_vty.c b/src/ss7_as_vty.c index e94e0c2..6ce57d4 100644 --- a/src/ss7_as_vty.c +++ b/src/ss7_as_vty.c @@ -344,18 +344,19 @@ } DEFUN_ATTR(as_pc_override, as_pc_override_cmd, - "point-code override dpc PC", + "point-code override (opc|dpc) PC", "Point Code Specific Features\n" - "Override (force) a point-code to hard-coded value\n" - "Override Source Point Code\n" - "Override Destination Point Code\n" + "Override (force) a point-code of messages received at the AS\n" + "Override Source Point Code of received messages\n" + "Override Destination Point Code of received messages\n" "New Point Code\n", CMD_ATTR_IMMEDIATE) { struct osmo_ss7_as *as = vty->index; - int pc = osmo_ss7_pointcode_parse(as->inst, argv[0]); + bool change_dpc = !strcmp(argv[0], "dpc"); + int pc = osmo_ss7_pointcode_parse(as->inst, argv[1]); if (pc < 0) { - vty_out(vty, "Invalid point code (%s)%s", argv[0], VTY_NEWLINE); + vty_out(vty, "Invalid point code (%s)%s", argv[1], VTY_NEWLINE); return CMD_WARNING; } @@ -365,11 +366,48 @@ return CMD_WARNING; } - as->cfg.pc_override.dpc = pc; + if (change_dpc) { + if (cs7_role == CS7_ROLE_ASP) { + vty_out(vty, "%% Overriding the DPC of AS '%s' in role ASP makes no sense. " + "Assuming user meant 'point-code override opc %s' to stay backway-comaptible. " + "Please update your config!%s", + as->cfg.name, argv[1], VTY_NEWLINE); + as->cfg.pc_override.opc_enabled = true; + as->cfg.pc_override.opc = pc; + return CMD_SUCCESS; + } + as->cfg.pc_override.dpc_enabled = true; + as->cfg.pc_override.dpc = pc; + } else { + as->cfg.pc_override.opc_enabled = true; + as->cfg.pc_override.opc = pc; + } return CMD_SUCCESS; } +DEFUN_ATTR(as_no_pc_override, as_no_pc_override_cmd, + "no point-code override (opc|dpc)", + NO_STR + "Point Code Specific Features\n" + "Override (force) a point-code of messages received at the AS\n" + "Override Source Point Code of received messages\n" + "Override Destination Point Code of received messages\n", + CMD_ATTR_IMMEDIATE) +{ + struct osmo_ss7_as *as = vty->index; + bool change_dpc = !strcmp(argv[0], "dpc"); + + if (change_dpc) { + as->cfg.pc_override.dpc_enabled = false; + as->cfg.pc_override.dpc = 0; + } else { + as->cfg.pc_override.opc_enabled = false; + as->cfg.pc_override.opc = 0; + } + return CMD_SUCCESS; +} + DEFUN_ATTR(as_pc_patch_sccp, as_pc_patch_sccp_cmd, "point-code override patch-sccp (disabled|both)", "Point Code Specific Features\n" @@ -450,7 +488,10 @@ vty_out(vty, " ssn %u", rkey->ssn); vty_out(vty, "%s", VTY_NEWLINE); - if (as->cfg.pc_override.dpc) + if (as->cfg.pc_override.opc_enabled) + vty_out(vty, " point-code override opc %s%s", + osmo_ss7_pointcode_print(as->inst, as->cfg.pc_override.opc), VTY_NEWLINE); + if (as->cfg.pc_override.dpc_enabled) vty_out(vty, " point-code override dpc %s%s", osmo_ss7_pointcode_print(as->inst, as->cfg.pc_override.dpc), VTY_NEWLINE); @@ -584,15 +625,30 @@ /* Config sanity checks: */ - /* AS in ASP role should be configured with a local PC which they can - * then announce using RKM. - * Still, allow STPs to have AS(P) configured in an ASP mode to talk to a - * peer STP by announcing remove PCs. */ - if (cs7_role == CS7_ROLE_ASP && - ss7_as_get_local_role(as) == OSMO_SS7_ASP_ROLE_ASP && - !osmo_ss7_pc_is_local(as->inst, as->cfg.routing_key.pc)) - vty_out(vty, "%% AS with local role ASP should have a local PC configured in its routing-key. Fix your config!%s", VTY_NEWLINE); + if (cs7_role == CS7_ROLE_ASP) { + int as_role = ss7_as_get_local_role(as); + /* AS in ASP role should be configured with a local PC which they can + * then announce using RKM. + * Still, allow STPs to have AS(P) configured in an ASP mode to talk to a + * peer STP by announcing remove PCs. */ + if (as_role == OSMO_SS7_ASP_ROLE_ASP && + !osmo_ss7_pc_is_local(as->inst, as->cfg.routing_key.pc)) + vty_out(vty, "%% AS '%s' with local role ASP should have a local PC configured in its " + "routing-key. Fix your config!%s", as->cfg.name, VTY_NEWLINE); + if (as->cfg.proto == OSMO_SS7_ASP_PROT_IPA) { + if (as_role == OSMO_SS7_ASP_ROLE_ASP && + !as->cfg.pc_override.opc_enabled) + vty_out(vty, "%% ipa AS '%s' with local role ASP should have a " + "'point-code override opc PC' configured in its routing-key. Fix your config!%s", + as->cfg.name, VTY_NEWLINE); + if (as_role == OSMO_SS7_ASP_ROLE_SG && + !as->cfg.pc_override.dpc_enabled) + vty_out(vty, "%% ipa AS '%s' with local role SG should have a " + "'point-code override dpc PC' configured in its routing-key. Fix your config!%s", + as->cfg.name, VTY_NEWLINE); + } + } return 0; } @@ -619,5 +675,6 @@ install_lib_element(L_CS7_AS_NODE, &as_rout_key_ssn_cmd); install_lib_element(L_CS7_AS_NODE, &as_rout_key_si_ssn_cmd); install_lib_element(L_CS7_AS_NODE, &as_pc_override_cmd); + install_lib_element(L_CS7_AS_NODE, &as_no_pc_override_cmd); install_lib_element(L_CS7_AS_NODE, &as_pc_patch_sccp_cmd); } diff --git a/tests/vty/osmo_stp_test.vty b/tests/vty/osmo_stp_test.vty index 4502c74..a253c5a 100644 --- a/tests/vty/osmo_stp_test.vty +++ b/tests/vty/osmo_stp_test.vty @@ -387,7 +387,8 @@ routing-key RCONTEXT DPC si (aal2|bicc|b-isup|h248|isup|sat-isup|sccp|tup) routing-key RCONTEXT DPC ssn SSN routing-key RCONTEXT DPC si (aal2|bicc|b-isup|h248|isup|sat-isup|sccp|tup) ssn SSN - point-code override dpc PC + point-code override (opc|dpc) PC + no point-code override (opc|dpc) point-code override patch-sccp (disabled|both) OsmoSTP(config-cs7-as)# ? @@ -406,6 +407,7 @@ OsmoSTP(config-cs7-as)# no ? asp Specify ASP to be removed from this AS traffic-mode Remove explicit traffic mode of operation of this AS + point-code Point Code Specific Features OsmoSTP(config-cs7-as)# do show cs7 instance 0 as all Routing Routing Key Cic Cic Traffic -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40611?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id8ba5252a088dafe85bb25e13298c585acef277d Gerrit-Change-Number: 40611 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

2 weeks, 5 days

1
0
0 0

[XS] Change in libosmo-sigtran[master]: sccp_scoc_fsm: Fix double free of xua msg

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40613?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: sccp_scoc_fsm: Fix double free of xua msg ...................................................................... sccp_scoc_fsm: Fix double free of xua msg The xua msg is already freed 3 lines above. Fixes: 82c7a3c36c7a3ed282b6684ad71d76ee8e0125dd Change-Id: If51982fc967f5df89cece532e3b0b64a6bc1987c --- M src/sccp_scoc_fsm.c 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/src/sccp_scoc_fsm.c b/src/sccp_scoc_fsm.c index ce186a8..fa3019e 100644 --- a/src/sccp_scoc_fsm.c +++ b/src/sccp_scoc_fsm.c @@ -460,7 +460,6 @@ talloc_free(xua); /* Send RLSD to SCRC */ sccp_conn_xua_gen_relre_and_send(conn, SCCP_RELEASE_CAUSE_INCONSISTENT_CONN_DATA, NULL); - talloc_free(xua); /* Start release timer */ sccp_conn_start_rel_timer(conn); osmo_fsm_inst_state_chg(fi, S_DISCONN_PEND, 0, 0); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40613?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: If51982fc967f5df89cece532e3b0b64a6bc1987c Gerrit-Change-Number: 40613 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

2 weeks, 5 days

1
0
0 0

[XS] Change in libosmo-sigtran[master]: Use xua_msg_free() everywhere to free xua_msg

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40614?usp=email ) Change subject: Use xua_msg_free() everywhere to free xua_msg ...................................................................... Use xua_msg_free() everywhere to free xua_msg Change-Id: I1d43478a5c430e92f1bd5a0b3d3606a39f378e44 --- M src/sccp_scoc_fsm.c M tests/xua/xua_test.c 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved osmith: Looks good to me, but someone else must approve diff --git a/src/sccp_scoc_fsm.c b/src/sccp_scoc_fsm.c index fa3019e..1833b89 100644 --- a/src/sccp_scoc_fsm.c +++ b/src/sccp_scoc_fsm.c @@ -409,7 +409,7 @@ /* Send N-DISCONNECT.ind to local user */ sccp_conn_scu_gen_encode_and_send(conn, event, xua, OSMO_SCU_PRIM_N_DISCONNECT, PRIM_OP_INDICATION); - talloc_free(xua); + xua_msg_free(xua); /* Send RLSD to peer */ sccp_conn_xua_gen_relre_and_send(conn, SCCP_RELEASE_CAUSE_EXPIRATION_INACTIVE, NULL); /* start release timer */ @@ -457,7 +457,7 @@ /* send N-DISCONNECT.ind to user */ sccp_conn_scu_gen_encode_and_send(conn, event, xua, OSMO_SCU_PRIM_N_DISCONNECT, PRIM_OP_INDICATION); - talloc_free(xua); + xua_msg_free(xua); /* Send RLSD to SCRC */ sccp_conn_xua_gen_relre_and_send(conn, SCCP_RELEASE_CAUSE_INCONSISTENT_CONN_DATA, NULL); /* Start release timer */ diff --git a/tests/xua/xua_test.c b/tests/xua/xua_test.c index e3d9ac5..0759ff7 100644 --- a/tests/xua/xua_test.c +++ b/tests/xua/xua_test.c @@ -601,8 +601,8 @@ OSMO_ASSERT(xua_msg_get_u32(nested, M3UA_IEI_LOC_RKEY_ID) == 1); OSMO_ASSERT(xua_msg_get_u32(nested, M3UA_IEI_DEST_PC) == 23); - talloc_free(nested); - talloc_free(xua); + xua_msg_free(nested); + xua_msg_free(xua); } static void test_sccp_addr_cmp(void) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40614?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I1d43478a5c430e92f1bd5a0b3d3606a39f378e44 Gerrit-Change-Number: 40614 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

2 weeks, 5 days

1
0
0 0

[XS] Change in libosmo-sigtran[master]: xua_msg: Constify ptr args in multiple APIs

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40616?usp=email ) Change subject: xua_msg: Constify ptr args in multiple APIs ...................................................................... xua_msg: Constify ptr args in multiple APIs Change-Id: I9f5a564b99cfc62bd3deb98a68d3e36474d3810f --- M src/xua_msg.c M src/xua_msg.h 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/src/xua_msg.c b/src/xua_msg.c index d32d824..bc2a4f7 100644 --- a/src/xua_msg.c +++ b/src/xua_msg.c @@ -504,7 +504,7 @@ } } -char *xua_hdr_dump(struct xua_msg *xua, const struct xua_dialect *dialect) +char *xua_hdr_dump(const struct xua_msg *xua, const struct xua_dialect *dialect) { const struct xua_msg_class *xmc = NULL; static char buf[128]; @@ -551,7 +551,7 @@ return 1; } -char *xua_msg_dump(struct xua_msg *xua, const struct xua_dialect *dialect) +char *xua_msg_dump(const struct xua_msg *xua, const struct xua_dialect *dialect) { static char buf[1024]; struct osmo_strbuf sb = { .buf = buf, .len = sizeof(buf) }; diff --git a/src/xua_msg.h b/src/xua_msg.h index 80d4c79..8311d60 100644 --- a/src/xua_msg.h +++ b/src/xua_msg.h @@ -102,8 +102,8 @@ const char *xua_class_msg_name(const struct xua_msg_class *xmc, uint16_t msg_type); const char *xua_class_iei_name(const struct xua_msg_class *xmc, uint16_t iei); -char *xua_hdr_dump(struct xua_msg *xua, const struct xua_dialect *dialect); -char *xua_msg_dump(struct xua_msg *xua, const struct xua_dialect *dialect); +char *xua_hdr_dump(const struct xua_msg *xua, const struct xua_dialect *dialect); +char *xua_msg_dump(const struct xua_msg *xua, const struct xua_dialect *dialect); int xua_dialect_check_all_mand_ies(const struct xua_dialect *dialect, struct xua_msg *xua); int xua_msg_event_map(const struct xua_msg *xua, -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40616?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I9f5a564b99cfc62bd3deb98a68d3e36474d3810f Gerrit-Change-Number: 40616 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

2 weeks, 5 days

1
0
0 0

[M] Change in libosmo-sigtran[master]: Submit SCRC Routing Failure indications asynchronously

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40615?usp=email ) Change subject: Submit SCRC Routing Failure indications asynchronously ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > I'm not sure I'm following you. […] My point was that if we generically would enqueue all upward primitives at the SCCP user SAP, we wouldn't have to add some mechanism/queue specifically for those routing failures. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40615?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I17ae7174f7ffee8c9a004435e522803a97d4fb7b Gerrit-Change-Number: 40615 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Jul 2025 11:15:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

2 weeks, 5 days

1
0
0 0

[XS] Change in libosmo-sigtran[master]: Use xua_msg_free() everywhere to free xua_msg

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40614?usp=email ) Change subject: Use xua_msg_free() everywhere to free xua_msg ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40614?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I1d43478a5c430e92f1bd5a0b3d3606a39f378e44 Gerrit-Change-Number: 40614 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Jul 2025 11:14:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 5 days

1
0
0 0

[XS] Change in libosmo-sigtran[master]: Improve logging receiving Routing Failure

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40612?usp=email ) Change subject: Improve logging receiving Routing Failure ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40612?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ic7f9fd18e55b673b8be86b5459afefa8abd07628 Gerrit-Change-Number: 40612 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Jul 2025 11:14:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 5 days

1
0
0 0

[M] Change in libosmo-sigtran[master]: vty: Introduce missing cmd 'point-code override opc'

by laforge

Attention is currently required from: daniel, dexter, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40611?usp=email ) Change subject: vty: Introduce missing cmd 'point-code override opc' ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40611?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id8ba5252a088dafe85bb25e13298c585acef277d Gerrit-Change-Number: 40611 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Jul 2025 11:14:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 5 days

1
0
0 0

[M] Change in libosmo-sigtran[master]: vty: Introduce missing cmd 'point-code override opc'

by laforge

Attention is currently required from: daniel, dexter, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40611?usp=email ) Change subject: vty: Introduce missing cmd 'point-code override opc' ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40611?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id8ba5252a088dafe85bb25e13298c585acef277d Gerrit-Change-Number: 40611 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Jul 2025 11:13:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 5 days

1
0
0 0

[S] Change in libosmo-sigtran[master]: vty: Make sure user doesn't configure AS in ASP role with a non-local...

by laforge

Attention is currently required from: daniel, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40586?usp=email ) Change subject: vty: Make sure user doesn't configure AS in ASP role with a non-local PC as routing-key ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-sigtran/+/40586/comment/31e354bb_32eb8… : PS1, Line 9: AS > If the AS(P) of one of the STPs is configured with role ASP, then yeah we may want to configure ther […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40586?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ibbf990fd8dcbdc67ebc4118597b34a5767320cf6 Gerrit-Change-Number: 40586 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Jul 2025 11:13:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

2 weeks, 5 days

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2025