May 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-hnbgw[master]: Makefile.am: format to one file per line

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40241?usp=email ) Change subject: Makefile.am: format to one file per line ...................................................................... Makefile.am: format to one file per line Take the chance to order them alphabetically. Change-Id: I132fa290e3ef06e72d86a78310f33ddff094a9a4 --- M include/osmocom/hnbgw/Makefile.am 1 file changed, 12 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/include/osmocom/hnbgw/Makefile.am b/include/osmocom/hnbgw/Makefile.am index 94781df..03821d5 100644 --- a/include/osmocom/hnbgw/Makefile.am +++ b/include/osmocom/hnbgw/Makefile.am @@ -1,11 +1,17 @@ noinst_HEADERS = \ - vty.h \ - context_map.h hnbgw.h hnbgw_cn.h \ - hnbgw_hnbap.h hnbgw_rua.h hnbgw_ranap.h \ - kpi.h \ - nft_kpi.h \ - ranap_rab_ass.h mgw_fsm.h tdefs.h \ + context_map.h \ + hnbgw.h \ + hnbgw_cn.h \ + hnbgw_hnbap.h \ hnbgw_pfcp.h \ + hnbgw_ranap.h \ + hnbgw_rua.h \ + kpi.h \ + mgw_fsm.h \ + nft_kpi.h \ ps_rab_ass_fsm.h \ ps_rab_fsm.h \ + ranap_rab_ass.h \ + tdefs.h \ + vty.h \ $(NULL) -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40241?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I132fa290e3ef06e72d86a78310f33ddff094a9a4 Gerrit-Change-Number: 40241 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 month, 2 weeks

1
0
0 0

[L] Change in osmo-hnbgw[master]: Move SCCP prim handling to its own hnbgw_sccp.{c,h} file

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40243?usp=email ) Change subject: Move SCCP prim handling to its own hnbgw_sccp.{c,h} file ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40243?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Idb45a25f7ff4bcd38ffd27bf1d3360b9d34149b3 Gerrit-Change-Number: 40243 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 May 2025 17:37:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 2 weeks

1
0
0 0

[M] Change in osmo-hnbgw[master]: Split struct hnbgw_sccp_user allocation & setup to its own function

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40242?usp=email ) Change subject: Split struct hnbgw_sccp_user allocation & setup to its own function ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40242?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I04c36bc0193554fcaf6be5e20573052c421af49d Gerrit-Change-Number: 40242 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 May 2025 17:37:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 2 weeks

1
0
0 0

[S] Change in osmo-hnbgw[master]: Makefile.am: format to one file per line

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40241?usp=email ) Change subject: Makefile.am: format to one file per line ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40241?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I132fa290e3ef06e72d86a78310f33ddff094a9a4 Gerrit-Change-Number: 40241 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 May 2025 17:36:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 2 weeks

1
0
0 0

[XS] Change in libosmo-sigtran[master]: xua: Guard against osmo_fsm_inst_alloc() failures

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40244?usp=email ) Change subject: xua: Guard against osmo_fsm_inst_alloc() failures ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40244?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ie5bd59c62f07a2656ddf5235450b9fd354eab7e0 Gerrit-Change-Number: 40244 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 May 2025 17:36:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 2 weeks

1
0
0 0

[S] Change in libosmo-sigtran[master]: sccp: Implement dpc_accessible()

by pespin

Attention is currently required from: daniel, laforge, neels. Hello Jenkins Builder, daniel, laforge, neels, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40250?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: sccp: Implement dpc_accessible() ...................................................................... sccp: Implement dpc_accessible() Change-Id: I16b0aa71db5be2daf7a8c52da829a38ad564eb7b --- M src/sccp_scrc.c 1 file changed, 25 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/50/40250/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40250?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I16b0aa71db5be2daf7a8c52da829a38ad564eb7b Gerrit-Change-Number: 40250 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

1 month, 2 weeks

1
0
0 0

[L] Change in pysim[master]: Get rid of [now] superfluous HexAdapter

by laforge

Attention is currently required from: dexter, fixeria, laforge. Hello Jenkins Builder, dexter, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/40237?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Get rid of [now] superfluous HexAdapter ...................................................................... Get rid of [now] superfluous HexAdapter With the introduction of using osmocom.construct.{Bytes,GreedyBytes} in Change-Id I1c8df6350c68aa408ec96ff6cd1e405ceb1a4fbb we don't have a need for wrapping each instance of Bytes or GreedyBytes into a HexAdapter anymore. The osmocom.construct.{Bytes,GreedyBytes} will automatically perform the related hex-string-to-bytes conversion if needed - and during printing we have osmocom.utils.JsonEncoder that makes sure to convert any bytes type to a hex-string. Change-Id: I9c77e420c314f5e74458628dc4e767eab6d97123 --- M pySim/cat.py M pySim/cdma_ruim.py M pySim/euicc.py M pySim/global_platform/__init__.py M pySim/global_platform/install_param.py M pySim/gsm_r.py M pySim/sms.py M pySim/sysmocom_sja2.py M pySim/ts_102_221.py M pySim/ts_102_310.py M pySim/ts_31_102.py M pySim/ts_31_103.py M pySim/ts_31_103_shared.py M pySim/ts_51_011.py M tests/unittests/test_utils.py 15 files changed, 202 insertions(+), 197 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/37/40237/4 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40237?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9c77e420c314f5e74458628dc4e767eab6d97123 Gerrit-Change-Number: 40237 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 month, 2 weeks

1
0
0 0

[S] Change in libosmo-sigtran[master]: sccp: Implement dpc_accessible()

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40250?usp=email ) Change subject: sccp: Implement dpc_accessible() ...................................................................... sccp: Implement dpc_accessible() Change-Id: I16b0aa71db5be2daf7a8c52da829a38ad564eb7b --- M src/sccp_scrc.c 1 file changed, 21 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/50/40250/1 diff --git a/src/sccp_scrc.c b/src/sccp_scrc.c index 63ded9d..8a0ddd1 100644 --- a/src/sccp_scrc.c +++ b/src/sccp_scrc.c @@ -62,9 +62,28 @@ return false; } -static bool dpc_accessible(struct osmo_sccp_instance *inst, uint32_t pc) +static bool dpc_accessible(struct osmo_sccp_instance *inst, uint32_t dpc) { - /* TODO: implement this! */ + struct osmo_ss7_route *rt; + struct osmo_ss7_route_label rtlabel; + + if (osmo_ss7_pc_is_local(inst->ss7, dpc)) { + LOGP(DLSCCP, LOGL_DEBUG, "dpc_accessible(%u): true (local)\n", dpc); + return true; + } + + rtlabel = (struct osmo_ss7_route_label){ + .opc = 0, + .dpc = dpc, + .sls = 0, + }; + + rt = ss7_instance_lookup_route(inst->ss7, &rtlabel); + if (!rt) { + LOGP(DLSCCP, LOGL_INFO, "dpc_accessible(%u): false\n", dpc); + return false; + } + LOGP(DLSCCP, LOGL_DEBUG, "dpc_accessible(%u): true\n", dpc); return true; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40250?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I16b0aa71db5be2daf7a8c52da829a38ad564eb7b Gerrit-Change-Number: 40250 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 month, 2 weeks

1
0
0 0

[S] Change in libosmo-sigtran[master]: combined_linkset: Improve logging

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40249?usp=email ) Change subject: combined_linkset: Improve logging ...................................................................... combined_linkset: Improve logging Change-Id: Ide1e72b9737a236561c7b6e86f381d929969346e --- M src/osmo_ss7_combined_linkset.c 1 file changed, 15 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/49/40249/1 diff --git a/src/osmo_ss7_combined_linkset.c b/src/osmo_ss7_combined_linkset.c index b4cd914..412555f 100644 --- a/src/osmo_ss7_combined_linkset.c +++ b/src/osmo_ss7_combined_linkset.c @@ -274,19 +274,22 @@ /* No normal route selected yet: */ if (!eslse->normal_rt) { + bool rt_avail; /* Establish a Normal Route, regardless of available state: */ rt = ss7_combined_linkset_assign_route_roundrobin(clset); /* No route found for Normal Route, regardless of state... */ if (!rt) return NULL; eslse->normal_rt = rt; - LOGPCLSET(clset, DLSS7, LOGL_DEBUG, "RT loookup: OPC=%u=%s,DPC=%u=%s,SLS=%u -> eSLS=%u: " - "picked Normal Route via '%s' round-robin style\n", + rt_avail = ss7_route_is_available(eslse->normal_rt); + LOGPCLSET(clset, DLSS7, LOGL_INFO, "RT loookup: OPC=%u=%s,DPC=%u=%s,SLS=%u -> eSLS=%u: " + "picked Normal Route via '%s' round-robin style (%s)\n", rtlabel->opc, osmo_ss7_pointcode_print(inst, rtlabel->opc), rtlabel->dpc, osmo_ss7_pointcode_print2(inst, rtlabel->dpc), rtlabel->sls, esls, - rt->dest.as ? rt->dest.as->cfg.name : "<linkset>"); - if (ss7_route_is_available(eslse->normal_rt)) { + rt->dest.as ? rt->dest.as->cfg.name : "<linkset>", + rt_avail ? "available" : "unavailable"); + if (rt_avail) { /* Found available Normal Route: */ return eslse->normal_rt; } @@ -306,6 +309,14 @@ rtlabel->sls, esls, eslse->normal_rt->dest.as ? eslse->normal_rt->dest.as->cfg.name : "<linkset>", eslse->alt_rt->dest.as ? eslse->alt_rt->dest.as->cfg.name : "<linkset>"); + } else { + /* No alternative route found, NULL is returned. */ + LOGPCLSET(clset, DLSS7, LOGL_INFO, "RT Lookup: OPC=%u=%s,DPC=%u=%s,SLS=%u -> eSLS=%u: " + "Normal Route via '%s' unavailable, all Alternative Routes unavailable\n", + rtlabel->opc, osmo_ss7_pointcode_print(inst, rtlabel->opc), + rtlabel->dpc, osmo_ss7_pointcode_print2(inst, rtlabel->dpc), + rtlabel->sls, esls, + eslse->normal_rt->dest.as ? eslse->normal_rt->dest.as->cfg.name : "<linkset>"); } return rt; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40249?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ide1e72b9737a236561c7b6e86f381d929969346e Gerrit-Change-Number: 40249 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 month, 2 weeks

1
0
0 0

[S] Change in osmo-hnbgw[master]: sccp: Introduce DL-related cnlink rate counters

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40247?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: sccp: Introduce DL-related cnlink rate counters ...................................................................... sccp: Introduce DL-related cnlink rate counters Change-Id: Ib4a87aec3d7bb01be833dd33c597a33d9bbad859 --- M include/osmocom/hnbgw/hnbgw_cn.h M src/osmo-hnbgw/hnbgw_cn.c M src/osmo-hnbgw/hnbgw_sccp.c 3 files changed, 37 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/47/40247/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40247?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ib4a87aec3d7bb01be833dd33c597a33d9bbad859 Gerrit-Change-Number: 40247 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 month, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2025