May 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-hnbgw[master]: sccp: Introduce UL-related cnlink rate counters

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40252?usp=email ) Change subject: sccp: Introduce UL-related cnlink rate counters ...................................................................... sccp: Introduce UL-related cnlink rate counters Change-Id: I1878fcc8c265dc4d457332e16556d3ece769ea3e --- M include/osmocom/hnbgw/hnbgw_cn.h M src/osmo-hnbgw/cnlink.c M src/osmo-hnbgw/context_map_sccp.c M src/osmo-hnbgw/hnbgw_cn.c 4 files changed, 24 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/52/40252/1 diff --git a/include/osmocom/hnbgw/hnbgw_cn.h b/include/osmocom/hnbgw/hnbgw_cn.h index 917cc07..fc33e5b 100644 --- a/include/osmocom/hnbgw/hnbgw_cn.h +++ b/include/osmocom/hnbgw/hnbgw_cn.h @@ -57,9 +57,13 @@ CNLINK_CTR_RANAP_TX_UDT_RESET_ACK, /* SCCP Counters: */ + CNLINK_CTR_SCCP_N_UNITDATA_REQ, CNLINK_CTR_SCCP_N_UNITDATA_IND, + CNLINK_CTR_SCCP_N_CONNECT_REQ, CNLINK_CTR_SCCP_N_CONNECT_CNF, + CNLINK_CTR_SCCP_N_DATA_REQ, CNLINK_CTR_SCCP_N_DATA_IND, + CNLINK_CTR_SCCP_N_DISCONNECT_REQ, CNLINK_CTR_SCCP_N_DISCONNECT_IND, CNLINK_CTR_SCCP_N_PCSTATE_IND, CNLINK_CTR_SCCP_RLSD_CN_ORIGIN, diff --git a/src/osmo-hnbgw/cnlink.c b/src/osmo-hnbgw/cnlink.c index 477bd68..46f53d7 100644 --- a/src/osmo-hnbgw/cnlink.c +++ b/src/osmo-hnbgw/cnlink.c @@ -140,6 +140,7 @@ static int hnbgw_cnlink_tx_sccp_unitdata_req(struct hnbgw_cnlink *cnlink, struct msgb *msg) { + CNLINK_CTR_INC(cnlink, CNLINK_CTR_SCCP_N_UNITDATA_REQ); return hnbgw_sccp_user_tx_unitdata_req(cnlink->hnbgw_sccp_user, &cnlink->remote_addr, msg); diff --git a/src/osmo-hnbgw/context_map_sccp.c b/src/osmo-hnbgw/context_map_sccp.c index 3c97789..5b5e77f 100644 --- a/src/osmo-hnbgw/context_map_sccp.c +++ b/src/osmo-hnbgw/context_map_sccp.c @@ -128,6 +128,7 @@ ranap_msg = hnbgw_ranap_msg_alloc("SCCP-CR-empty"); } + CNLINK_CTR_INC(map->cnlink, CNLINK_CTR_SCCP_N_CONNECT_REQ); return hnbgw_sccp_user_tx_connect_req(map->cnlink->hnbgw_sccp_user, &map->cnlink->remote_addr, map->scu_conn_id, @@ -146,6 +147,7 @@ return -1; } + CNLINK_CTR_INC(map->cnlink, CNLINK_CTR_SCCP_N_DATA_REQ); return hnbgw_sccp_user_tx_data_req(map->cnlink->hnbgw_sccp_user, map->scu_conn_id, ranap_msg); @@ -160,6 +162,7 @@ return -1; } + CNLINK_CTR_INC(map->cnlink, CNLINK_CTR_SCCP_N_DISCONNECT_REQ); return hnbgw_sccp_user_tx_disconnect_req(map->cnlink->hnbgw_sccp_user, map->scu_conn_id); } diff --git a/src/osmo-hnbgw/hnbgw_cn.c b/src/osmo-hnbgw/hnbgw_cn.c index 8a7f88e..121c77f 100644 --- a/src/osmo-hnbgw/hnbgw_cn.c +++ b/src/osmo-hnbgw/hnbgw_cn.c @@ -462,18 +462,34 @@ }, /* SCCP Counters: */ + [CNLINK_CTR_SCCP_N_UNITDATA_REQ] = { + "sccp:n_unit_data:req", + "Submit SCCP N-UNITDATA.req (UL)" + }, [CNLINK_CTR_SCCP_N_UNITDATA_IND] = { "sccp:n_unit_data:ind", "Received SCCP N-UNITDATA.ind (DL)" }, + [CNLINK_CTR_SCCP_N_CONNECT_REQ] = { + "sccp:n_connect:req", + "Submit SCCP N-CONNECT.req (UL SCCP CR)" + }, [CNLINK_CTR_SCCP_N_CONNECT_CNF] = { "sccp:n_connect:cnf", "Received SCCP N-CONNECT.cnf (DL SCCP CC)" }, + [CNLINK_CTR_SCCP_N_DATA_REQ] = { + "sccp:n_data:req", + "SUBMIT SCCP N-DATA.req (UL)" + }, [CNLINK_CTR_SCCP_N_DATA_IND] = { "sccp:n_data:ind", "Received SCCP N-DATA.ind (DL)" }, + [CNLINK_CTR_SCCP_N_DISCONNECT_REQ] = { + "sccp:n_disconnect:req", + "Submit SCCP N-DISCONNECT.req (UL SCCP RLC)" + }, [CNLINK_CTR_SCCP_N_DISCONNECT_IND] = { "sccp:n_disconnect:ind", "Received SCCP N-DISCONNECT.ind (DL SCCP RLSD)" -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40252?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I1878fcc8c265dc4d457332e16556d3ece769ea3e Gerrit-Change-Number: 40252 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 month, 2 weeks

1
0
0 0

[M] Change in osmo-hnbgw[master]: sccp: Unify path submitting N-*.req

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40251?usp=email ) Change subject: sccp: Unify path submitting N-*.req ...................................................................... sccp: Unify path submitting N-*.req This allows having clearer code paths and adding rate counters. Change-Id: I37b414cf769a16b7c7f596df3bb91a6a91a06298 --- M include/osmocom/hnbgw/hnbgw_sccp.h M src/osmo-hnbgw/cnlink.c M src/osmo-hnbgw/context_map_sccp.c M src/osmo-hnbgw/hnbgw_sccp.c 4 files changed, 113 insertions(+), 35 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/51/40251/1 diff --git a/include/osmocom/hnbgw/hnbgw_sccp.h b/include/osmocom/hnbgw/hnbgw_sccp.h index fbb84f4..d207348 100644 --- a/include/osmocom/hnbgw/hnbgw_sccp.h +++ b/include/osmocom/hnbgw/hnbgw_sccp.h @@ -1,9 +1,12 @@ /* SCCP, ITU Q.711 - Q.714 */ #pragma once +#include <stdint.h> + #include <osmocom/core/hashtable.h> #include <osmocom/core/linuxlist.h> #include <osmocom/core/prim.h> +#include <osmocom/core/msgb.h> #include <osmocom/core/use_count.h> #include <osmocom/sigtran/sccp_sap.h> @@ -46,3 +49,11 @@ OSMO_ASSERT(osmo_use_count_get_put(&(hsu)->use_count, use, -1) == 0) struct hnbgw_sccp_user *hnbgw_sccp_user_alloc(int ss7_inst_id); + +int hnbgw_sccp_user_tx_unitdata_req(struct hnbgw_sccp_user *hsu, const struct osmo_sccp_addr *called_addr, + struct msgb *ranap_msg); +int hnbgw_sccp_user_tx_connect_req(struct hnbgw_sccp_user *hsu, const struct osmo_sccp_addr *called_addr, + uint32_t scu_conn_id, struct msgb *ranap_msg); +int hnbgw_sccp_user_tx_data_req(struct hnbgw_sccp_user *hsu, uint32_t scu_conn_id, + struct msgb *ranap_msg); +int hnbgw_sccp_user_tx_disconnect_req(struct hnbgw_sccp_user *hsu, uint32_t scu_conn_id); diff --git a/src/osmo-hnbgw/cnlink.c b/src/osmo-hnbgw/cnlink.c index 137012a..477bd68 100644 --- a/src/osmo-hnbgw/cnlink.c +++ b/src/osmo-hnbgw/cnlink.c @@ -138,6 +138,13 @@ context_map_cnlink_lost(map); } +static int hnbgw_cnlink_tx_sccp_unitdata_req(struct hnbgw_cnlink *cnlink, struct msgb *msg) +{ + return hnbgw_sccp_user_tx_unitdata_req(cnlink->hnbgw_sccp_user, + &cnlink->remote_addr, + msg); +} + static void tx_reset(struct hnbgw_cnlink *cnlink) { struct msgb *msg; @@ -192,10 +199,7 @@ msg = ranap_new_msg_reset2(cnlink->pool->domain, &cause, use_grnc_id); CNLINK_CTR_INC(cnlink, CNLINK_CTR_RANAP_TX_UDT_RESET); - osmo_sccp_tx_unitdata_msg(cnlink->hnbgw_sccp_user->sccp_user, - &cnlink->hnbgw_sccp_user->local_addr, - &cnlink->remote_addr, - msg); + hnbgw_cnlink_tx_sccp_unitdata_req(cnlink, msg); } static void tx_reset_ack(struct hnbgw_cnlink *cnlink) @@ -243,10 +247,7 @@ msg = ranap_new_msg_reset_ack(cnlink->pool->domain, use_grnc_id); CNLINK_CTR_INC(cnlink, CNLINK_CTR_RANAP_TX_UDT_RESET_ACK); - osmo_sccp_tx_unitdata_msg(cnlink->hnbgw_sccp_user->sccp_user, - &cnlink->hnbgw_sccp_user->local_addr, - &cnlink->remote_addr, - msg); + hnbgw_cnlink_tx_sccp_unitdata_req(cnlink, msg); } static void cnlink_disc_onenter(struct osmo_fsm_inst *fi, uint32_t prev_state) diff --git a/src/osmo-hnbgw/context_map_sccp.c b/src/osmo-hnbgw/context_map_sccp.c index f0bbe1b..3c97789 100644 --- a/src/osmo-hnbgw/context_map_sccp.c +++ b/src/osmo-hnbgw/context_map_sccp.c @@ -117,10 +117,8 @@ static int tx_sccp_cr(struct osmo_fsm_inst *fi, struct msgb *ranap_msg) { struct hnbgw_context_map *map = fi->priv; - struct osmo_scu_prim *prim; - int rc; - if (!map->cnlink || !map->cnlink->hnbgw_sccp_user) { + if (!map->cnlink) { LOGPFSML(fi, LOGL_ERROR, "Failed to send SCCP Connection Request: no CN link\n"); return -1; } @@ -130,53 +128,40 @@ ranap_msg = hnbgw_ranap_msg_alloc("SCCP-CR-empty"); } - prim = (struct osmo_scu_prim *)msgb_push(ranap_msg, sizeof(*prim)); - osmo_prim_init(&prim->oph, SCCP_SAP_USER, OSMO_SCU_PRIM_N_CONNECT, PRIM_OP_REQUEST, ranap_msg); - prim->u.connect.called_addr = map->cnlink->remote_addr; - prim->u.connect.calling_addr = map->cnlink->hnbgw_sccp_user->local_addr; - prim->u.connect.sccp_class = 2; - prim->u.connect.conn_id = map->scu_conn_id; - - rc = osmo_sccp_user_sap_down_nofree(map->cnlink->hnbgw_sccp_user->sccp_user, &prim->oph); - if (rc) - LOGPFSML(fi, LOGL_ERROR, "Failed to send SCCP Connection Request to CN\n"); - return rc; + return hnbgw_sccp_user_tx_connect_req(map->cnlink->hnbgw_sccp_user, + &map->cnlink->remote_addr, + map->scu_conn_id, + ranap_msg); } static int tx_sccp_df1(struct osmo_fsm_inst *fi, struct msgb *ranap_msg) { struct hnbgw_context_map *map = fi->priv; - struct osmo_scu_prim *prim; - int rc; if (!msg_has_l2_data(ranap_msg)) return 0; - if (!map->cnlink || !map->cnlink->hnbgw_sccp_user) { + if (!map->cnlink) { LOGPFSML(fi, LOGL_ERROR, "Failed to send SCCP Data Form 1: no CN link\n"); return -1; } - prim = (struct osmo_scu_prim *)msgb_push(ranap_msg, sizeof(*prim)); - osmo_prim_init(&prim->oph, SCCP_SAP_USER, OSMO_SCU_PRIM_N_DATA, PRIM_OP_REQUEST, ranap_msg); - prim->u.data.conn_id = map->scu_conn_id; - - rc = osmo_sccp_user_sap_down_nofree(map->cnlink->hnbgw_sccp_user->sccp_user, &prim->oph); - if (rc) - LOGPFSML(fi, LOGL_ERROR, "Failed to send SCCP Data Form 1 to CN\n"); - return rc; + return hnbgw_sccp_user_tx_data_req(map->cnlink->hnbgw_sccp_user, + map->scu_conn_id, + ranap_msg); } static int tx_sccp_rlsd(struct osmo_fsm_inst *fi) { struct hnbgw_context_map *map = fi->priv; - if (!map->cnlink || !map->cnlink->hnbgw_sccp_user) { + if (!map->cnlink) { LOGPFSML(fi, LOGL_ERROR, "Failed to send SCCP RLSD: no CN link\n"); return -1; } - return osmo_sccp_tx_disconn(map->cnlink->hnbgw_sccp_user->sccp_user, map->scu_conn_id, NULL, 0); + return hnbgw_sccp_user_tx_disconnect_req(map->cnlink->hnbgw_sccp_user, + map->scu_conn_id); } static int handle_rx_sccp(struct osmo_fsm_inst *fi, struct msgb *ranap_msg) diff --git a/src/osmo-hnbgw/hnbgw_sccp.c b/src/osmo-hnbgw/hnbgw_sccp.c index 999ebde..4699b2f 100644 --- a/src/osmo-hnbgw/hnbgw_sccp.c +++ b/src/osmo-hnbgw/hnbgw_sccp.c @@ -340,6 +340,87 @@ return rc; } +/*********************************************************************** + * Submit primitives to SCCP User SAP + ***********************************************************************/ + +int hnbgw_sccp_user_tx_unitdata_req(struct hnbgw_sccp_user *hsu, const struct osmo_sccp_addr *called_addr, struct msgb *ranap_msg) +{ + if (!hsu) { + LOGP(DCN, LOGL_ERROR, "Failed to send SCCP N-UNITDATA.req: no SCCP User\n"); + return -1; + } + OSMO_ASSERT(called_addr); + return osmo_sccp_tx_unitdata_msg(hsu->sccp_user, + &hsu->local_addr, + called_addr, + ranap_msg); +} + +int hnbgw_sccp_user_tx_connect_req(struct hnbgw_sccp_user *hsu, const struct osmo_sccp_addr *called_addr, uint32_t scu_conn_id, struct msgb *ranap_msg) +{ + struct osmo_scu_prim *prim; + int rc; + + if (!hsu) { + LOGP(DCN, LOGL_ERROR, "Failed to send SCCP N-CONNECT.req(%u): no SCCP User\n", scu_conn_id); + return -1; + } + + OSMO_ASSERT(called_addr); + + prim = (struct osmo_scu_prim *)msgb_push(ranap_msg, sizeof(*prim)); + osmo_prim_init(&prim->oph, SCCP_SAP_USER, OSMO_SCU_PRIM_N_CONNECT, PRIM_OP_REQUEST, ranap_msg); + prim->u.connect.called_addr = *called_addr; + prim->u.connect.calling_addr = hsu->local_addr; + prim->u.connect.sccp_class = 2; + prim->u.connect.conn_id = scu_conn_id; + + rc = osmo_sccp_user_sap_down_nofree(hsu->sccp_user, &prim->oph); + if (rc) + LOG_HSU(hsu, DCN, LOGL_ERROR, "Failed to send SCCP Connection Request to CN\n"); + return rc; +} + +int hnbgw_sccp_user_tx_data_req(struct hnbgw_sccp_user *hsu, uint32_t scu_conn_id, struct msgb *ranap_msg) +{ + struct osmo_scu_prim *prim; + int rc; + + if (!hsu) { + LOGP(DCN, LOGL_ERROR, "Failed to send SCCP N-DATA.req(%u): no SCCP User\n", scu_conn_id); + return -1; + } + + prim = (struct osmo_scu_prim *)msgb_push(ranap_msg, sizeof(*prim)); + osmo_prim_init(&prim->oph, SCCP_SAP_USER, OSMO_SCU_PRIM_N_DATA, PRIM_OP_REQUEST, ranap_msg); + prim->u.data.conn_id = scu_conn_id; + + rc = osmo_sccp_user_sap_down_nofree(hsu->sccp_user, &prim->oph); + if (rc) + LOG_HSU(hsu, DCN, LOGL_ERROR, "Failed to send SCCP N-DATA.req(%u)\n", scu_conn_id); + return rc; +} + +int hnbgw_sccp_user_tx_disconnect_req(struct hnbgw_sccp_user *hsu, uint32_t scu_conn_id) +{ + int rc; + + if (!hsu) { + LOGP(DCN, LOGL_ERROR, "Failed to send SCCP N-DISCONNECT.req(%u): no SCCP User\n", scu_conn_id); + return -1; + } + + rc = osmo_sccp_tx_disconn(hsu->sccp_user, scu_conn_id, NULL, 0); + if (rc) + LOG_HSU(hsu, DCN, LOGL_ERROR, "Failed to send SCCP N-DISCONNECT.req(%u)\n", scu_conn_id); + return rc; +} + +/*********************************************************************** + * struct hnbgw_sccp_user lifecycle: + ***********************************************************************/ + static int hnbgw_sccp_user_use_cb(struct osmo_use_count_entry *e, int32_t old_use_count, const char *file, int line) { struct hnbgw_sccp_user *hsu = e->use_count->talloc_object; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40251?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I37b414cf769a16b7c7f596df3bb91a6a91a06298 Gerrit-Change-Number: 40251 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 month, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: gbproxy: sync configs with docker-playground

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40239?usp=email ) Change subject: gbproxy: sync configs with docker-playground ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40239?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibef7e870c5c90d1cc861c89904950b1ac68dc9b2 Gerrit-Change-Number: 40239 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 May 2025 18:24:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 2 weeks

1
0
0 0

[L] Change in pysim[master]: Get rid of [now] superfluous HexAdapter

by fixeria

Attention is currently required from: dexter, laforge. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/40237?usp=email ) Change subject: Get rid of [now] superfluous HexAdapter ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40237?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9c77e420c314f5e74458628dc4e767eab6d97123 Gerrit-Change-Number: 40237 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 May 2025 18:19:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 2 weeks

1
0
0 0

[M] Change in pysim[master]: docs: Better python doc-strings for better pySim.esim manual

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/40236?usp=email ) Change subject: docs: Better python doc-strings for better pySim.esim manual ...................................................................... docs: Better python doc-strings for better pySim.esim manual Change-Id: I7be6264c665a2a25105681bb5e72d0f6715bbef8 --- M pySim/esim/__init__.py M pySim/esim/bsp.py M pySim/esim/es8p.py M pySim/esim/rsp.py M pySim/esim/saip/__init__.py M pySim/esim/saip/oid.py M pySim/esim/saip/personalization.py M pySim/esim/saip/templates.py M pySim/esim/saip/validation.py M pySim/esim/x509_cert.py 10 files changed, 87 insertions(+), 50 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/pySim/esim/__init__.py b/pySim/esim/__init__.py index 29e2bf4..35b733e 100644 --- a/pySim/esim/__init__.py +++ b/pySim/esim/__init__.py @@ -61,8 +61,8 @@ return asn1tools.compile_string(asn_txt, codec=codec) -# SGP.22 section 4.1 Activation Code class ActivationCode: + """SGP.22 section 4.1 Activation Code""" def __init__(self, hostname:str, token:str, oid: Optional[str] = None, cc_required: Optional[bool] = False): if '$' in hostname: raise ValueError('$ sign not permitted in hostname') @@ -78,6 +78,7 @@ @staticmethod def decode_str(ac: str) -> dict: + """decode an activation code from its string representation.""" if ac[0] != '1': raise ValueError("Unsupported AC_Format '%s'!" % ac[0]) ac_elements = ac.split('$') diff --git a/pySim/esim/bsp.py b/pySim/esim/bsp.py index 862502f..fb4c0b3 100644 --- a/pySim/esim/bsp.py +++ b/pySim/esim/bsp.py @@ -1,11 +1,9 @@ -# Early proof-of-concept implementation of -# GSMA eSIM RSP (Remote SIM Provisioning BSP (BPP Protection Protocol), -# where BPP is the Bound Profile Package. So the full expansion is the -# "GSMA eSIM Remote SIM Provisioning Bound Profile Packate Protection Protocol" -# -# Originally (SGP.22 v2.x) this was called SCP03t, but it has since been -# renamed to BSP. -# +"""Implementation of GSMA eSIM RSP (Remote SIM Provisioning BSP (BPP Protection Protocol), +where BPP is the Bound Profile Package. So the full expansion is the +"GSMA eSIM Remote SIM Provisioning Bound Profile Packate Protection Protocol" + +Originally (SGP.22 v2.x) this was called SCP03t, but it has since been renamed to BSP.""" + # (C) 2023 by Harald Welte <laforge(a)osmocom.org> # # This program is free software: you can redistribute it and/or modify @@ -45,6 +43,7 @@ MAX_SEGMENT_SIZE = 1020 class BspAlgo(abc.ABC): + """Base class representing a cryptographic algorithm within the BSP (BPP Security Protocol).""" blocksize: int def _get_padding(self, in_len: int, multiple: int, padding: int = 0) -> bytes: @@ -62,6 +61,7 @@ return self.__class__.__name__ class BspAlgoCrypt(BspAlgo, abc.ABC): + """Base class representing an encryption/decryption algorithm within the BSP (BPP Security Protocol).""" def __init__(self, s_enc: bytes): self.s_enc = s_enc @@ -93,6 +93,7 @@ """Actual implementation, to be implemented by derived class.""" class BspAlgoCryptAES128(BspAlgoCrypt): + """AES-CBC-128 implementation of the BPP Security Protocol for GSMA SGP.22 eSIM.""" name = 'AES-CBC-128' blocksize = 16 @@ -133,6 +134,7 @@ class BspAlgoMac(BspAlgo, abc.ABC): + """Base class representing a message authentication code algorithm within the BSP (BPP Security Protocol).""" l_mac = 0 # must be overridden by derived class def __init__(self, s_mac: bytes, initial_mac_chaining_value: bytes): @@ -167,6 +169,7 @@ """To be implemented by algorithm specific derived class.""" class BspAlgoMacAES128(BspAlgoMac): + """AES-CMAC-128 implementation of the BPP Security Protocol for GSMA SGP.22 eSIM.""" name = 'AES-CMAC-128' l_mac = 8 diff --git a/pySim/esim/es8p.py b/pySim/esim/es8p.py index dd0c4bc..8bd7e14 100644 --- a/pySim/esim/es8p.py +++ b/pySim/esim/es8p.py @@ -1,6 +1,5 @@ -# Implementation of GSMA eSIM RSP (Remote SIM Provisioning) ES8+ -# as per SGP22 v3.0 Section 5.5 -# +"""Implementation of GSMA eSIM RSP (Remote SIM Provisioning) ES8+ as per SGP22 v3.0 Section 5.5""" + # (C) 2023-2024 by Harald Welte <laforge(a)osmocom.org> # # This program is free software: you can redistribute it and/or modify diff --git a/pySim/esim/rsp.py b/pySim/esim/rsp.py index 4b189e1..3dccf2d 100644 --- a/pySim/esim/rsp.py +++ b/pySim/esim/rsp.py @@ -1,6 +1,5 @@ -# Implementation of GSMA eSIM RSP (Remote SIM Provisioning) -# as per SGP22 v3.0 -# +"""Implementation of GSMA eSIM RSP (Remote SIM Provisioning) as per SGP22 v3.0""" + # (C) 2023-2024 by Harald Welte <laforge(a)osmocom.org> # # This program is free software: you can redistribute it and/or modify diff --git a/pySim/esim/saip/__init__.py b/pySim/esim/saip/__init__.py index 21f44ef..305a373 100644 --- a/pySim/esim/saip/__init__.py +++ b/pySim/esim/saip/__init__.py @@ -1,5 +1,5 @@ -# Implementation of SimAlliance/TCA Interoperable Profile handling -# +"""Implementation of SimAlliance/TCA Interoperable Profile handling""" + # (C) 2023-2024 by Harald Welte <laforge(a)osmocom.org> # # This program is free software: you can redistribute it and/or modify @@ -45,7 +45,7 @@ logger = logging.getLogger(__name__) class Naa: - """A class defining a Network Access Application (NAA).""" + """A class defining a Network Access Application (NAA)""" name = None # AID prefix, as used for ADF and EF.DIR aid = None @@ -61,6 +61,7 @@ return 'adf-' + cls.mandatory_services[0] class NaaCsim(Naa): + """A class representing the CSIM (CDMA) Network Access Application (NAA)""" name = "csim" aid = h2b("") mandatory_services = ["csim"] @@ -68,6 +69,7 @@ templates = [oid.ADF_CSIM_by_default, oid.ADF_CSIMopt_not_by_default] class NaaUsim(Naa): + """A class representing the USIM Network Access Application (NAA)""" name = "usim" aid = h2b("a0000000871002") mandatory_services = ["usim"] @@ -80,6 +82,7 @@ adf = ADF_USIM() class NaaIsim(Naa): + """A class representing the ISIM Network Access Application (NAA)""" name = "isim" aid = h2b("a0000000871004") mandatory_services = ["isim"] @@ -750,6 +753,7 @@ class ProfileElementMF(FsProfileElement): + """Class representing the ProfileElement for the MF (Master File)""" type = 'mf' def __init__(self, decoded: Optional[dict] = None, **kwargs): @@ -763,6 +767,7 @@ # TODO: resize EF.DIR? class ProfileElementPuk(ProfileElement): + """Class representing the ProfileElement for a PUK (PIN Unblocking Code)""" type = 'pukCodes' def __init__(self, decoded: Optional[dict] = None, **kwargs): @@ -793,6 +798,7 @@ class ProfileElementPin(ProfileElement): + """Class representing the ProfileElement for a PIN (Personal Identification Number)""" type = 'pinCodes' def __init__(self, decoded: Optional[dict] = None, **kwargs): @@ -829,6 +835,7 @@ class ProfileElementTelecom(FsProfileElement): + """Class representing the ProfileElement for DF.TELECOM""" type = 'telecom' def __init__(self, decoded: Optional[dict] = None, **kwargs): @@ -841,6 +848,7 @@ self.decoded[fname] = [] class ProfileElementCD(FsProfileElement): + """Class representing the ProfileElement for DF.CD""" type = 'cd' def __init__(self, decoded: Optional[dict] = None, **kwargs): @@ -853,6 +861,7 @@ self.decoded[fname] = [] class ProfileElementPhonebook(FsProfileElement): + """Class representing the ProfileElement for DF.PHONEBOOK""" type = 'phonebook' def __init__(self, decoded: Optional[dict] = None, **kwargs): @@ -865,6 +874,7 @@ self.decoded[fname] = [] class ProfileElementGsmAccess(FsProfileElement): + """Class representing the ProfileElement for ADF.USIM/DF.GSM-ACCESS""" type = 'gsm-access' def __init__(self, decoded: Optional[dict] = None, **kwargs): @@ -877,6 +887,7 @@ self.decoded[fname] = [] class ProfileElementDf5GS(FsProfileElement): + """Class representing the ProfileElement for ADF.USIM/DF.5GS""" type = 'df-5gs' def __init__(self, decoded: Optional[dict] = None, **kwargs): @@ -889,6 +900,7 @@ self.decoded[fname] = [] class ProfileElementEAP(FsProfileElement): + """Class representing the ProfileElement for DF.EAP""" type = 'eap' def __init__(self, decoded: Optional[dict] = None, **kwargs): @@ -901,6 +913,7 @@ self.decoded[fname] = [] class ProfileElementDfSAIP(FsProfileElement): + """Class representing the ProfileElement for DF.SAIP""" type = 'df-saip' def __init__(self, decoded: Optional[dict] = None, **kwargs): @@ -913,6 +926,7 @@ self.decoded[fname] = [] class ProfileElementDfSNPN(FsProfileElement): + """Class representing the ProfileElement for DF.SNPN""" type = 'df-snpn' def __init__(self, decoded: Optional[dict] = None, **kwargs): @@ -925,6 +939,7 @@ self.decoded[fname] = [] class ProfileElementDf5GProSe(FsProfileElement): + """Class representing the ProfileElement for DF.5GProSe""" type = 'df-5gprose' def __init__(self, decoded: Optional[dict] = None, **kwargs): @@ -1218,6 +1233,7 @@ class ProfileElementRFM(ProfileElement): + """Class representing the ProfileElement for RFM (Remote File Management).""" type = 'rfm' def __init__(self, decoded: Optional[dict] = None, @@ -1243,6 +1259,7 @@ } class ProfileElementUSIM(FsProfileElement): + """Class representing the ProfileElement for ADF.USIM Mandatory Files""" type = 'usim' def __init__(self, decoded: Optional[dict] = None, **kwargs): @@ -1265,6 +1282,7 @@ return dec_imsi(b2h(f.body)) class ProfileElementOptUSIM(FsProfileElement): + """Class representing the ProfileElement for ADF.USIM Optional Files""" type = 'opt-usim' def __init__(self, decoded: Optional[dict] = None, **kwargs): @@ -1275,6 +1293,7 @@ self.decoded['templateID'] = str(oid.ADF_USIMopt_not_by_default_v2) class ProfileElementISIM(FsProfileElement): + """Class representing the ProfileElement for ADF.ISIM Mandatory Files""" type = 'isim' def __init__(self, decoded: Optional[dict] = None, **kwargs): @@ -1291,6 +1310,7 @@ return b2h(self.decoded['adf-isim'][0][1]['dfName']) class ProfileElementOptISIM(FsProfileElement): + """Class representing the ProfileElement for ADF.ISIM Optional Files""" type = 'opt-isim' def __init__(self, decoded: Optional[dict] = None, **kwargs): @@ -1302,6 +1322,7 @@ class ProfileElementAKA(ProfileElement): + """Class representing the ProfileElement for Authentication and Key Agreement (AKA).""" type = 'akaParameter' # TODO: RES size for USIM test algorithm can be set to 32, 64 or 128 bits. This value was # previously limited to 128 bits. Recommendation: Avoid using RES size 32 or 64 in Profiles @@ -1381,6 +1402,7 @@ }) class ProfileElementHeader(ProfileElement): + """Class representing the ProfileElement for the Header of the PE-Sequence.""" type = 'header' def __init__(self, decoded: Optional[dict] = None, ver_major: Optional[int] = 2, ver_minor: Optional[int] = 3, @@ -1421,6 +1443,7 @@ raise ValueError("service not in eUICC-Mandatory-services list, cannot remove") class ProfileElementEnd(ProfileElement): + """Class representing the ProfileElement for the End of the PE-Sequence.""" type = 'end' def __init__(self, decoded: Optional[dict] = None, **kwargs): super().__init__(decoded, **kwargs) diff --git a/pySim/esim/saip/oid.py b/pySim/esim/saip/oid.py index 02ef23b..a9c23e2 100644 --- a/pySim/esim/saip/oid.py +++ b/pySim/esim/saip/oid.py @@ -1,5 +1,5 @@ -# Implementation of SimAlliance/TCA Interoperable Profile OIDs -# +"""Implementation of SimAlliance/TCA Interoperable Profile OIDs""" + # (C) 2023-2024 by Harald Welte <laforge(a)osmocom.org> # # This program is free software: you can redistribute it and/or modify diff --git a/pySim/esim/saip/personalization.py b/pySim/esim/saip/personalization.py index cd23944..053ea0c 100644 --- a/pySim/esim/saip/personalization.py +++ b/pySim/esim/saip/personalization.py @@ -1,5 +1,5 @@ -# Implementation of SimAlliance/TCA Interoperable Profile handling -# +"""Implementation of Personalization of eSIM profiles in SimAlliance/TCA Interoperable Profile.""" + # (C) 2023-2024 by Harald Welte <laforge(a)osmocom.org> # # This program is free software: you can redistribute it and/or modify diff --git a/pySim/esim/saip/templates.py b/pySim/esim/saip/templates.py index 3ec0b9b..2c0a8f0 100644 --- a/pySim/esim/saip/templates.py +++ b/pySim/esim/saip/templates.py @@ -1,5 +1,5 @@ -# Implementation of SimAlliance/TCA Interoperable Profile Template handling -# +"""Implementation of SimAlliance/TCA Interoperable Profile Templates.""" + # (C) 2024 by Harald Welte <laforge(a)osmocom.org> # # This program is free software: you can redistribute it and/or modify @@ -224,8 +224,8 @@ # below are transcribed template definitions from "ANNEX A (Normative): File Structure Templates Definition" # of "Profile interoperability specification V3.3.1 Final" (unless other version explicitly specified). -# Section 9.2 class FilesAtMF(ProfileTemplate): + """Files at MF as per Section 9.2""" created_by_default = True oid = OID.MF files = [ @@ -238,8 +238,8 @@ ] -# Section 9.3 class FilesCD(ProfileTemplate): + """Files at DF.CD as per Section 9.3""" created_by_default = False oid = OID.DF_CD files = [ @@ -287,8 +287,8 @@ for i in range(0x98, 0xa0): df_pb_files.append(FileTemplate(0x4f00+i, 'EF.CCP1', 'LF', None, None, 5, None, 'FF...FF', False, ['nb_rec','size','sfi'], ppath=[0x5f3a])) -# Section 9.4 v2.3.1 class FilesTelecom(ProfileTemplate): + """Files at DF.TELECOM as per Section 9.4 v2.3.1""" created_by_default = False oid = OID.DF_TELECOM base_path = Path('MF') @@ -328,8 +328,8 @@ ] -# Section 9.4 class FilesTelecomV2(ProfileTemplate): + """Files at DF.TELECOM as per Section 9.4""" created_by_default = False oid = OID.DF_TELECOM_v2 base_path = Path('MF') @@ -379,8 +379,8 @@ ] -# Section 9.5.1 v2.3.1 class FilesUsimMandatory(ProfileTemplate): + """Mandatory Files at ADF.USIM as per Section 9.5.1 v2.3.1""" created_by_default = True oid = OID.ADF_USIM_by_default files = [ @@ -410,8 +410,8 @@ FileTemplate(0x6fe4, 'EF.EPSNSC', 'LF', 1, 80, 5, 0x18, 'FF...FF', False, ass_serv=[85], high_update=True), ] -# Section 9.5.1 class FilesUsimMandatoryV2(ProfileTemplate): + """Mandatory Files at ADF.USIM as per Section 9.5.1""" created_by_default = True oid = OID.ADF_USIM_by_default_v2 files = [ @@ -442,8 +442,8 @@ ] -# Section 9.5.2 v2.3.1 class FilesUsimOptional(ProfileTemplate): + """Optional Files at ADF.USIM as per Section 9.5.2 v2.3.1""" created_by_default = False optional = True oid = OID.ADF_USIMopt_not_by_default @@ -529,6 +529,7 @@ # Section 9.5.2 class FilesUsimOptionalV2(ProfileTemplate): + """Optional Files at ADF.USIM as per Section 9.5.2""" created_by_default = False optional = True oid = OID.ADF_USIMopt_not_by_default_v2 @@ -622,8 +623,8 @@ FileTemplate(0x6ffd, 'EF.MudMidCfgdata','BT', None, None,2, None, None, True, ['size'], ass_serv=[134]), ] -# Section 9.5.2.3 v3.3.1 class FilesUsimOptionalV3(ProfileTemplate): + """Optional Files at ADF.USIM as per Section 9.5.2.3 v3.3.1""" created_by_default = False optional = True oid = OID.ADF_USIMopt_not_by_default_v3 @@ -633,16 +634,16 @@ FileTemplate(0x6f01, 'EF.eAKA', 'TR', None, 1, 3, None, None, True, ['size'], ass_serv=[134]), ] -# Section 9.5.3 class FilesUsimDfPhonebook(ProfileTemplate): + """DF.PHONEBOOK Files at ADF.USIM as per Section 9.5.3""" created_by_default = False oid = OID.DF_PHONEBOOK_ADF_USIM base_path = Path('ADF.USIM') files = df_pb_files -# Section 9.5.4 class FilesUsimDfGsmAccess(ProfileTemplate): + """DF.GSM-ACCESS Files at ADF.USIM as per Section 9.5.4""" created_by_default = False oid = OID.DF_GSM_ACCESS_ADF_USIM base_path = Path('ADF.USIM') @@ -656,8 +657,8 @@ ] -# Section 9.5.11 v2.3.1 class FilesUsimDf5GS(ProfileTemplate): + """DF.5GS Files at ADF.USIM as per Section 9.5.11 v2.3.1""" created_by_default = False oid = OID.DF_5GS base_path = Path('ADF.USIM') @@ -677,8 +678,8 @@ ] -# Section 9.5.11.2 class FilesUsimDf5GSv2(ProfileTemplate): + """DF.5GS Files at ADF.USIM as per Section 9.5.11.2""" created_by_default = False oid = OID.DF_5GS_v2 base_path = Path('ADF.USIM') @@ -700,8 +701,8 @@ ] -# Section 9.5.11.3 class FilesUsimDf5GSv3(ProfileTemplate): + """DF.5GS Files at ADF.USIM as per Section 9.5.11.3""" created_by_default = False oid = OID.DF_5GS_v3 base_path = Path('ADF.USIM') @@ -724,8 +725,8 @@ FileTemplate(0x4f0c, 'EF.TN3GPPSNN', 'TR', None, 1, 2, 0x0c, '00', False, ass_serv=[135]), ] -# Section 9.5.11.4 class FilesUsimDf5GSv4(ProfileTemplate): + """DF.5GS Files at ADF.USIM as per Section 9.5.11.4""" created_by_default = False oid = OID.DF_5GS_v4 base_path = Path('ADF.USIM') @@ -756,8 +757,8 @@ ] -# Section 9.5.12 class FilesUsimDfSaip(ProfileTemplate): + """DF.SAIP Files at ADF.USIM as per Section 9.5.12""" created_by_default = False oid = OID.DF_SAIP base_path = Path('ADF.USIM') @@ -767,8 +768,8 @@ FileTemplate(0x4f01, 'EF.SUCICalcInfo','TR', None, None, 3, None, 'FF...FF', False, ['size'], ass_serv=[125], pe_name='ef-suci-calc-info-usim'), ] -# Section 9.5.13 class FilesDfSnpn(ProfileTemplate): + """DF.SNPN Files at ADF.USIM as per Section 9.5.13""" created_by_default = False oid = OID.DF_SNPN base_path = Path('ADF.USIM') @@ -778,8 +779,8 @@ FileTemplate(0x4f01, 'EF.PWS_SNPN', 'TR', None, 1, 10, None, None, True, ass_serv=[143]), ] -# Section 9.5.14 class FilesDf5GProSe(ProfileTemplate): + """DF.ProSe Files at ADF.USIM as per Section 9.5.14""" created_by_default = False oid = OID.DF_5GProSe base_path = Path('ADF.USIM') @@ -794,8 +795,8 @@ FileTemplate(0x4f06, 'EF.5G_PROSE_UIR', 'TR', None, 32, 2, 0x06, None, True, ass_serv=[139,1005]), ] -# Section 9.6.1 class FilesIsimMandatory(ProfileTemplate): + """Mandatory Files at ADF.ISIM as per Section 9.6.1""" created_by_default = True oid = OID.ADF_ISIM_by_default files = [ @@ -809,8 +810,8 @@ ] -# Section 9.6.2 v2.3.1 class FilesIsimOptional(ProfileTemplate): + """Optional Files at ADF.ISIM as per Section 9.6.2 of v2.3.1""" created_by_default = False optional = True oid = OID.ADF_ISIMopt_not_by_default @@ -829,8 +830,8 @@ ] -# Section 9.6.2 class FilesIsimOptionalv2(ProfileTemplate): + """Optional Files at ADF.ISIM as per Section 9.6.2""" created_by_default = False optional = True oid = OID.ADF_ISIMopt_not_by_default_v2 @@ -857,8 +858,8 @@ # TODO: CSIM -# Section 9.8 class FilesEap(ProfileTemplate): + """Files at DF.EAP as per Section 9.8""" created_by_default = False oid = OID.DF_EAP files = [ diff --git a/pySim/esim/saip/validation.py b/pySim/esim/saip/validation.py index c253b7a..c115554 100644 --- a/pySim/esim/saip/validation.py +++ b/pySim/esim/saip/validation.py @@ -1,5 +1,5 @@ -# Implementation of SimAlliance/TCA Interoperable Profile handling -# +"""Implementation of SimAlliance/TCA Interoperable Profile validation.""" + # (C) 2023-2024 by Harald Welte <laforge(a)osmocom.org> # # This program is free software: you can redistribute it and/or modify @@ -19,16 +19,21 @@ from pySim.esim.saip import * class ProfileError(Exception): + """Raised when a ProfileConstraintChecker finds an error in a file [structure].""" pass class ProfileConstraintChecker: + """Base class of a constraint checker for a ProfileElementSequence.""" def check(self, pes: ProfileElementSequence): + """Execute all the check_* methods of the ProfileConstraintChecker against the given + ProfileElementSequence""" for name in dir(self): if name.startswith('check_'): method = getattr(self, name) method(pes) class CheckBasicStructure(ProfileConstraintChecker): + """ProfileConstraintChecker for the basic profile structure constraints.""" def _is_after_if_exists(self, pes: ProfileElementSequence, opt:str, after:str): opt_pe = pes.get_pe_for_type(opt) if opt_pe: @@ -38,6 +43,7 @@ # FIXME: check order def check_start_and_end(self, pes: ProfileElementSequence): + """Check for mandatory header and end ProfileElements at the right position.""" if pes.pe_list[0].type != 'header': raise ProfileError('first element is not header') if pes.pe_list[1].type != 'mf': @@ -47,6 +53,7 @@ raise ProfileError('last element is not end') def check_number_of_occurrence(self, pes: ProfileElementSequence): + """Check The number of occurrence of various ProfileElements.""" # check for invalid number of occurrences if len(pes.get_pes_for_type('header')) != 1: raise ProfileError('multiple ProfileHeader') @@ -60,6 +67,7 @@ raise ProfileError('multiple PE-%s' % tn.upper()) def check_optional_ordering(self, pes: ProfileElementSequence): + """Check the ordering of optional PEs following the respective mandatory ones.""" # ordering and required depenencies self._is_after_if_exists(pes,'opt-usim', 'usim') self._is_after_if_exists(pes,'opt-isim', 'isim') @@ -104,17 +112,21 @@ FileChoiceList = List[Tuple] class FileError(ProfileError): + """Raised when a FileConstraintChecker finds an error in a file [structure].""" pass class FileConstraintChecker: def check(self, l: FileChoiceList): + """Execute all the check_* methods of the FileConstraintChecker against the given FileChoiceList""" for name in dir(self): if name.startswith('check_'): method = getattr(self, name) method(l) class FileCheckBasicStructure(FileConstraintChecker): + """Validator for the basic structure of a decoded file.""" def check_seqence(self, l: FileChoiceList): + """Check the sequence/ordering.""" by_type = {} for k, v in l: if k in by_type: diff --git a/pySim/esim/x509_cert.py b/pySim/esim/x509_cert.py index e951de7..c8a0386 100644 --- a/pySim/esim/x509_cert.py +++ b/pySim/esim/x509_cert.py @@ -1,6 +1,5 @@ -# Implementation of X.509 certificate handling in GSMA eSIM -# as per SGP22 v3.0 -# +"""Implementation of X.509 certificate handling in GSMA eSIM as per SGP22 v3.0""" + # (C) 2024 by Harald Welte <laforge(a)osmocom.org> # # This program is free software: you can redistribute it and/or modify -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40236?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7be6264c665a2a25105681bb5e72d0f6715bbef8 Gerrit-Change-Number: 40236 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 month, 2 weeks

1
0
0 0

[M] Change in pysim[master]: docs: Better python doc-strings for better pySim.esim manual

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/40236?usp=email ) Change subject: docs: Better python doc-strings for better pySim.esim manual ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40236?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7be6264c665a2a25105681bb5e72d0f6715bbef8 Gerrit-Change-Number: 40236 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 May 2025 17:54:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 2 weeks

1
0
0 0

[S] Change in osmo-hnbgw[master]: sccp: Introduce rate counter CNLINK_CTR_SCCP_RLSD_CN_ORIGIN

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40248?usp=email ) Change subject: sccp: Introduce rate counter CNLINK_CTR_SCCP_RLSD_CN_ORIGIN ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40248?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Icc6d29192574536d3c954a06645f178fa66bff50 Gerrit-Change-Number: 40248 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 May 2025 17:39:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 2 weeks

1
0
0 0

[S] Change in osmo-hnbgw[master]: sccp: Introduce DL-related cnlink rate counters

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40247?usp=email ) Change subject: sccp: Introduce DL-related cnlink rate counters ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40247?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ib4a87aec3d7bb01be833dd33c597a33d9bbad859 Gerrit-Change-Number: 40247 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 May 2025 17:39:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 2 weeks

1
0
0 0

[M] Change in osmo-hnbgw[master]: Fix lifecycle of struct hnbgw_sccp_user

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40246?usp=email ) Change subject: Fix lifecycle of struct hnbgw_sccp_user ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40246?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I524f6da8e5936135b2153def103d83cec6549f94 Gerrit-Change-Number: 40246 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 May 2025 17:38:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 2 weeks

1
0
0 0

[XS] Change in osmo-hnbgw[master]: sccp: Use proper wording s/LOG_HSI/LOG_HSU

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40245?usp=email ) Change subject: sccp: Use proper wording s/LOG_HSI/LOG_HSU ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40245?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I9b543416488a8396c3b548c63169374f999f32fc Gerrit-Change-Number: 40245 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 May 2025 17:37:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2025