Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40253?usp=email )
Change subject: Move hnbgw_cnlink to cnlink.h and hnbgw_cnpool to hnbgw_cn.h
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40253?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I75988112cff6c8c17d2bdb166a0934934c523dfc
Gerrit-Change-Number: 40253
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 08 May 2025 08:01:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: clufn.
laforge has posted comments on this change by clufn. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255?usp=email )
Change subject: Add required conversions for IPv6 support
......................................................................
Patch Set 2:
(2 comments)
File src/conv.erl:
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255/comment/f69c803b_e570… :
PS2, Line 114: -define(DIAMETER_ERROR_UNKOWN_SERVING_NODE, 5423).
unrelated cosmetic change. Please make sure that your patch/diff only contains actual functional changes related to the feature you introduce, and no unrelaed cosmetic/whitespace changes.
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255/comment/5c293c87_d1c4… :
PS2, Line 145: address => #{ ipv4 => Addr}};
yet another unrelated cosmetic change?
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40255?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I2426e0dcee3ca92075b845f6b21a175a3d047c08
Gerrit-Change-Number: 40255
Gerrit-PatchSet: 2
Gerrit-Owner: clufn <callumfarrbennett(a)yahoo.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: clufn <callumfarrbennett(a)yahoo.com>
Gerrit-Comment-Date: Thu, 08 May 2025 08:00:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/40257?usp=email )
Change subject: common/ttcn3-docker-prepare: add _scripts symlink
......................................................................
common/ttcn3-docker-prepare: add _scripts symlink
The ttcn3-*-{start,stop}.sh scripts include a file from the _scripts dir
since Ia63c37b54fb42a8c64a676334cef6f9df4152e18. As they are called
through symlinks in / in docker-playground.git, we must make the another
symlink available for _scripts as well.
Fix for:
../ttcn3-tcpdump-start.sh: 3: .: cannot open ../_scripts/tcpdump-dumpcap.inc.sh: No such file
Change-Id: I3a093ac7058d31db958785692444cb58525a6181
---
M common/ttcn3-docker-prepare.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
diff --git a/common/ttcn3-docker-prepare.sh b/common/ttcn3-docker-prepare.sh
index c2b28b9..ef684be 100755
--- a/common/ttcn3-docker-prepare.sh
+++ b/common/ttcn3-docker-prepare.sh
@@ -33,7 +33,7 @@
fi
# Link start/stop scripts to /
-for i in ttcn3-*-start.sh ttcn3-*-stop.sh; do
+for i in ttcn3-*-start.sh ttcn3-*-stop.sh _scripts; do
ln -sv "/osmo-ttcn3-hacks/$i" "/$i"
done
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/40257?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I3a093ac7058d31db958785692444cb58525a6181
Gerrit-Change-Number: 40257
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/40257?usp=email )
Change subject: common/ttcn3-docker-prepare: add _scripts symlink
......................................................................
common/ttcn3-docker-prepare: add _scripts symlink
The ttcn3-*-{start,stop}.sh scripts include a file from the _scripts dir
since Ia63c37b54fb42a8c64a676334cef6f9df4152e18. As they are called
through symlinks in / in docker-playground.git, we must make the another
symlink available for _scripts as well.
Fix for:
../ttcn3-tcpdump-start.sh: 3: .: cannot open ../_scripts/tcpdump-dumpcap.inc.sh: No such file
Change-Id: I3a093ac7058d31db958785692444cb58525a6181
---
M common/ttcn3-docker-prepare.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/57/40257/1
diff --git a/common/ttcn3-docker-prepare.sh b/common/ttcn3-docker-prepare.sh
index c2b28b9..ef684be 100755
--- a/common/ttcn3-docker-prepare.sh
+++ b/common/ttcn3-docker-prepare.sh
@@ -33,7 +33,7 @@
fi
# Link start/stop scripts to /
-for i in ttcn3-*-start.sh ttcn3-*-stop.sh; do
+for i in ttcn3-*-start.sh ttcn3-*-stop.sh _scripts; do
ln -sv "/osmo-ttcn3-hacks/$i" "/$i"
done
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/40257?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I3a093ac7058d31db958785692444cb58525a6181
Gerrit-Change-Number: 40257
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>