Attention is currently required from: pespin.
Hello Jenkins Builder, fixeria, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/39939?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: vty: cpu_sched_vty.c: remove tdef references
......................................................................
vty: cpu_sched_vty.c: remove tdef references
Change-Id: Ic2f3a7553ffbb964036e81f0f7c67ad2e0c34b20
---
M src/vty/cpu_sched_vty.c
1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/39/39939/2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39939?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic2f3a7553ffbb964036e81f0f7c67ad2e0c34b20
Gerrit-Change-Number: 39939
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
Hello Jenkins Builder, fixeria, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/39940?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: core: osmo_io: Introduce API osmo_io_get_backend()
......................................................................
core: osmo_io: Introduce API osmo_io_get_backend()
It came up several times already that it's difficult figuring out the
osmo-io backend a process is actually using.
Add this API so that we can display the osmo-io backend through VTY
command in a follow-up commit.
Related: OS#6740
Change-Id: I9432efd6cb0453d7ab42d71765e897db6bd4c787
---
M TODO-RELEASE
M include/osmocom/core/osmo_io.h
M src/core/libosmocore.map
M src/core/osmo_io.c
4 files changed, 11 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/40/39940/2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39940?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I9432efd6cb0453d7ab42d71765e897db6bd4c787
Gerrit-Change-Number: 39940
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria, laforge, osmith.
Hello Jenkins Builder, fixeria, laforge, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/39938?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by fixeria, Code-Review-1 by osmith, Verified+1 by Jenkins Builder
Change subject: cosmetic: vty/Makefile.am: Split items one per line
......................................................................
cosmetic: vty/Makefile.am: Split items one per line
Change-Id: I71581f11bdcb4b186a271fc42d5745889c32f4c9
---
M src/vty/Makefile.am
1 file changed, 30 insertions(+), 7 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/38/39938/3
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39938?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I71581f11bdcb4b186a271fc42d5745889c32f4c9
Gerrit-Change-Number: 39938
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: fixeria.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/39941?usp=email )
Change subject: vty: Add 'show runtime' command
......................................................................
Patch Set 1:
(1 comment)
File src/vty/misc_vty.c:
https://gerrit.osmocom.org/c/libosmocore/+/39941/comment/f352c4dd_3ad37bd3?… :
PS1, Line 23: config.h
> Do we actually use this header here?
In general I prefer keeping the config.h included everywhere, to avoid weird scenarios where some define is checked but then silently failed to ever be defined.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39941?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I7994c820894b3525bfe78b5d389ff30a1e543226
Gerrit-Change-Number: 39941
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 07 Apr 2025 10:45:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>