Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/39941?usp=email ) Change subject: vty: Add 'show runtime' command ...................................................................... Patch Set 1: (1 comment) File src/vty/misc_vty.c: https://gerrit.osmocom.org/c/libosmocore/+/39941/comment/f352c4dd_3ad37bd3?u... : PS1, Line 23: config.h

Do we actually use this header here? In general I prefer keeping the config.h included everywhere, to avoid weird scenarios where some define is checked but then silently failed to ever be defined.

-- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39941?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7994c820894b3525bfe78b5d389ff30a1e543226 Gerrit-Change-Number: 39941 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Mon, 07 Apr 2025 10:45:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>