lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

April 2025

  • 1 participants
  • 1186 discussions
[XS] Change in osmo-ci[master]: jobs/ttcn3-testsuites-testenv: Add ttcn3-pcap-client-test-io_uring
by pespin 07 Apr '25

07 Apr '25
Attention is currently required from: osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ci/+/39943?usp=email ) Change subject: jobs/ttcn3-testsuites-testenv: Add ttcn3-pcap-client-test-io_uring ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: The new job still needs to be applied through jenkins-jobs once this patch is reviewed. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39943?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I817b4d27cd2e8faabf2ebb5ad28f025535571282 Gerrit-Change-Number: 39943 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Apr 2025 15:53:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
1 0
0 0
[XS] Change in osmo-ci[master]: jobs/ttcn3-testsuites-testenv: Add ttcn3-pcap-client-test-io_uring
by pespin 07 Apr '25

07 Apr '25
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/39943?usp=email ) Change subject: jobs/ttcn3-testsuites-testenv: Add ttcn3-pcap-client-test-io_uring ...................................................................... jobs/ttcn3-testsuites-testenv: Add ttcn3-pcap-client-test-io_uring Since osmo-pcap.git Change-Id I72e8a6ceb4fb1eb70372e13bb139ead0e2bc0860, osmo-pcap-client uses osmo_stream which in turn uses osmo_io (which can u io_uring backend). Hence, add io-uring backend to the test matrix for this project. Change-Id: I817b4d27cd2e8faabf2ebb5ad28f025535571282 --- M jobs/ttcn3-testsuites-testenv.yml 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/43/39943/1 diff --git a/jobs/ttcn3-testsuites-testenv.yml b/jobs/ttcn3-testsuites-testenv.yml index e5e78c9..4945b59 100644 --- a/jobs/ttcn3-testsuites-testenv.yml +++ b/jobs/ttcn3-testsuites-testenv.yml @@ -320,6 +320,11 @@ args: -b osmocom:nightly --io-uring -c all timer: H 14 * * * + - ttcn3-pcap-client-test-io_uring: # ~1 min + testsuite: pcap-client + args: -b osmocom:nightly --io-uring + timer: H 14 * * * + # --------------------------------------------- # Debian nightly + asan (OS#5301) # --------------------------------------------- -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39943?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I817b4d27cd2e8faabf2ebb5ad28f025535571282 Gerrit-Change-Number: 39943 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>
1 0
0 0
[S] Change in osmo-ci[master]: jobs/testsuites: move msc to testenv
by osmith 07 Apr '25

07 Apr '25
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/39942?usp=email ) Change subject: jobs/testsuites: move msc to testenv ...................................................................... Patch Set 1: Verified+1 (1 comment) Patchset: PS1: verified that we have 7 failing tests and 222 passing tests, the same as it is with docker-playground. * https://jenkins.osmocom.org/jenkins/job/osmith-ttcn3-msc-test/ * https://jenkins.osmocom.org/jenkins/job/osmith-ttcn3-msc-test-latest/ * https://jenkins.osmocom.org/jenkins/job/osmith-ttcn3-msc-test-asan/ * https://jenkins.osmocom.org/jenkins/job/osmith-ttcn3-msc-test-io_uring/ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39942?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia5879b5eeca80f2aac5834ce757a5953e2af98b7 Gerrit-Change-Number: 39942 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Apr 2025 13:19:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
1 0
0 0
[S] Change in osmo-ci[master]: jobs/testsuites: move msc to testenv
by osmith 07 Apr '25

07 Apr '25
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/39942?usp=email ) Change subject: jobs/testsuites: move msc to testenv ...................................................................... jobs/testsuites: move msc to testenv Related: OS#6494 Change-Id: Ia5879b5eeca80f2aac5834ce757a5953e2af98b7 --- M jobs/ttcn3-testsuites-testenv.yml M jobs/ttcn3-testsuites.yml 2 files changed, 20 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/42/39942/1 diff --git a/jobs/ttcn3-testsuites-testenv.yml b/jobs/ttcn3-testsuites-testenv.yml index 3deebd0..760b814 100644 --- a/jobs/ttcn3-testsuites-testenv.yml +++ b/jobs/ttcn3-testsuites-testenv.yml @@ -176,6 +176,11 @@ args: -b osmocom:nightly timer: H 10 * * * + - ttcn3-msc-test: # ~35 min + testsuite: msc + args: -b osmocom:nightly + timer: H 10 * * * + # --------------------------------------------- # Debian latest # --------------------------------------------- @@ -302,6 +307,11 @@ args: -b osmocom:latest timer: H 13 * * * + - ttcn3-msc-test-latest: # ~35 min + testsuite: msc + args: -b osmocom:latest + timer: H 13 * * * + # --------------------------------------------- # Debian nightly + io_uring (OS#6357) # --------------------------------------------- @@ -330,6 +340,11 @@ args: -b osmocom:nightly --io-uring -c all timer: H 14 * * * + - ttcn3-msc-test-io_uring: # ~35 min + testsuite: msc + args: -b osmocom:nightly --io-uring + timer: H 14 * * * + # --------------------------------------------- # Debian nightly + asan (OS#5301) # --------------------------------------------- @@ -413,6 +428,11 @@ args: -b osmocom:nightly:asan timer: H 17 * * * + - ttcn3-msc-test-asan: # ~35 min + testsuite: msc + args: -b osmocom:nightly:asan + timer: H 17 * * * + - job-template: name: '{job-name}' project-type: freestyle diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index 927e2af..9a22f0b 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -20,8 +20,6 @@ # timer: 10 per hour from 04:00 - 18:00, see jobs/README.adoc job-name: # debian nightly - order by time - - ttcn3-msc-test: # ~35 min - timer: H 03 * * * - nplab-m3ua-test: # ~1 min timer: H 03 * * * - nplab-sua-test: # ~1 min @@ -60,8 +58,6 @@ timer: H 04 * * * - nplab-sua-test-latest: # ~1 min timer: H 04 * * * - - ttcn3-msc-test-latest: # ~35 min - timer: H 04 * * * - ttcn3-gbproxy-test-latest: # ~15 min timer: H 05 * * * - ttcn3-gbproxy-test-fr-latest: # ~23 min @@ -83,8 +79,6 @@ timer: H 05 * * * # With LIBOSMO_IO_BACKEND=IO_URING (OS#6357) - - ttcn3-msc-test-io_uring: # ~35 min - timer: H 05 * * * - ttcn3-gbproxy-test-io_uring: # ~15 min timer: H 05 * * * @@ -105,9 +99,6 @@ # With sanitizer (OS#5301) - ttcn3-gbproxy-test-asan: # ~15 min timer: H 07 * * * - - ttcn3-msc-test-asan: # ~35 min - timer: H 07 * * * - - job-template: name: '{job-name}' -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39942?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia5879b5eeca80f2aac5834ce757a5953e2af98b7 Gerrit-Change-Number: 39942 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>
1 0
0 0
[M] Change in osmo-ci[master]: OBS: cleanup: new script
by laforge 07 Apr '25

07 Apr '25
Attention is currently required from: daniel, dexter, fixeria, osmith, pespin. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/39913?usp=email ) Change subject: OBS: cleanup: new script ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39913?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4649dedf0bb52f0bbdc7577ac0bc9e93cb3be192 Gerrit-Change-Number: 39913 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Apr 2025 13:04:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[M] Change in libosmocore[master]: vty: Add 'show runtime' command
by pespin 07 Apr '25

07 Apr '25
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/39941?usp=email ) Change subject: vty: Add 'show runtime' command ...................................................................... vty: Add 'show runtime' command It came up several times already that it's difficult figuring out the osmo-io backend a process is actually using. Add a VTY command to display the osmo-io backend in use. Related: OS#6740 Change-Id: I7994c820894b3525bfe78b5d389ff30a1e543226 --- M include/osmocom/vty/Makefile.am A include/osmocom/vty/vty_internal.h M src/vty/Makefile.am A src/vty/misc_vty.c M src/vty/vty.c 5 files changed, 80 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/vty/Makefile.am b/include/osmocom/vty/Makefile.am index adb05dc..2261da7 100644 --- a/include/osmocom/vty/Makefile.am +++ b/include/osmocom/vty/Makefile.am @@ -12,6 +12,10 @@ cpu_sched_vty.h \ tdef_vty.h \ $(NULL) + +noinst_HEADERS = \ + vty_internal.h \ + $(NULL) endif osmovtydir = $(includedir)/osmocom/vty diff --git a/include/osmocom/vty/vty_internal.h b/include/osmocom/vty/vty_internal.h new file mode 100644 index 0000000..bb800c8 --- /dev/null +++ b/include/osmocom/vty/vty_internal.h @@ -0,0 +1,30 @@ +/* (C) 2025 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> + * + * Author: Pau Espin Pedrol <pespin(a)sysmocom.de> + * + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see <http://www.gnu.org/licenses/>. + * + * SPDX-License-Identifier: GPL-2.0+ + */ +#pragma once + +/*! \defgroup vty_internal Osmocom vty internals + * @{ + * \file vty_internal.h */ + +void vty_misc_init(void); + +/*! @} */ diff --git a/src/vty/Makefile.am b/src/vty/Makefile.am index 360fddd..5007751 100644 --- a/src/vty/Makefile.am +++ b/src/vty/Makefile.am @@ -23,6 +23,7 @@ cpu_sched_vty.c \ fsm_vty.c \ logging_vty.c \ + misc_vty.c \ stats_vty.c \ talloc_ctx_vty.c \ tdef_vty.c \ diff --git a/src/vty/misc_vty.c b/src/vty/misc_vty.c new file mode 100644 index 0000000..7a59c74 --- /dev/null +++ b/src/vty/misc_vty.c @@ -0,0 +1,42 @@ +/* + * (C) 2025 by sysmocom - s.f.m.c. GmbH + * Author: Pau Espin Pedrol <pespin(a)sysmocom.de> + * All Rights Reserved + * + * SPDX-License-Identifier: GPL-2.0+ + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + */ + +#include <stdlib.h> +#include <string.h> + +#include "config.h" + +#include <osmocom/core/osmo_io.h> + +#include <osmocom/vty/command.h> +#include <osmocom/vty/vty.h> + +DEFUN(show_runtime, show_runtime_cmd, + "show runtime", + SHOW_STR "Display runtime information\n") +{ + enum osmo_io_backend io_backend = osmo_io_get_backend(); + vty_out(vty, "osmo-io backend: %s%s", osmo_io_backend_name(io_backend), VTY_NEWLINE); + return CMD_SUCCESS; +} + +void vty_misc_init(void) +{ + install_lib_element_ve(&show_runtime_cmd); +} diff --git a/src/vty/vty.c b/src/vty/vty.c index 3a549b4..5936ee8 100644 --- a/src/vty/vty.c +++ b/src/vty/vty.c @@ -65,6 +65,7 @@ #include <osmocom/vty/vty.h> #include <osmocom/vty/command.h> #include <osmocom/vty/buffer.h> +#include <osmocom/vty/vty_internal.h> #include <osmocom/core/talloc.h> #include <osmocom/core/timer.h> #include <osmocom/core/utils.h> @@ -1902,6 +1903,8 @@ install_lib_element(VTY_NODE, &vty_login_cmd); install_lib_element(VTY_NODE, &no_vty_login_cmd); install_lib_element(VTY_NODE, &vty_bind_cmd); + + vty_misc_init(); } /*! Read the configuration file using the VTY code -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39941?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7994c820894b3525bfe78b5d389ff30a1e543226 Gerrit-Change-Number: 39941 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
1 0
0 0
[XS] Change in libosmocore[master]: vty: cpu_sched_vty.c: remove tdef references
by pespin 07 Apr '25

07 Apr '25
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/39939?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: vty: cpu_sched_vty.c: remove tdef references ...................................................................... vty: cpu_sched_vty.c: remove tdef references Change-Id: Ic2f3a7553ffbb964036e81f0f7c67ad2e0c34b20 --- M src/vty/cpu_sched_vty.c 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/src/vty/cpu_sched_vty.c b/src/vty/cpu_sched_vty.c index 60fe930..4f3eeb1 100644 --- a/src/vty/cpu_sched_vty.c +++ b/src/vty/cpu_sched_vty.c @@ -45,12 +45,10 @@ #include <osmocom/vty/vty.h> #include <osmocom/vty/command.h> -#include <osmocom/vty/tdef_vty.h> -#include <osmocom/core/tdef.h> #include <osmocom/core/fsm.h> #include <osmocom/core/linuxlist.h> -/*! \addtogroup Tdef_VTY +/*! \addtogroup cpu_sched_vty * * CPU Scheduling related VTY API. * -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39939?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic2f3a7553ffbb964036e81f0f7c67ad2e0c34b20 Gerrit-Change-Number: 39939 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
1 0
0 0
[S] Change in libosmocore[master]: cosmetic: vty/Makefile.am: Split items one per line
by pespin 07 Apr '25

07 Apr '25
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/39938?usp=email ) Change subject: cosmetic: vty/Makefile.am: Split items one per line ...................................................................... cosmetic: vty/Makefile.am: Split items one per line Change-Id: I71581f11bdcb4b186a271fc42d5745889c32f4c9 --- M src/vty/Makefile.am 1 file changed, 30 insertions(+), 7 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/vty/Makefile.am b/src/vty/Makefile.am index 8818d89..360fddd 100644 --- a/src/vty/Makefile.am +++ b/src/vty/Makefile.am @@ -3,16 +3,39 @@ # before making any modifications: https://www.gnu.org/software/libtool/manual/html_node/Versioning.html LIBVERSION=13:2:0 -AM_CPPFLAGS = -I$(top_srcdir)/include -I$(top_builddir)/include -I$(top_builddir) -AM_CFLAGS = -Wall $(TALLOC_CFLAGS) $(PTHREAD_CFLAGS) +AM_CPPFLAGS = \ + -I$(top_srcdir)/include \ + -I$(top_builddir)/include \ + -I$(top_builddir) \ + $(NULL) +AM_CFLAGS = \ + -Wall \ + $(TALLOC_CFLAGS) \ + $(PTHREAD_CFLAGS) \ + $(NULL) if ENABLE_VTY lib_LTLIBRARIES = libosmovty.la -libosmovty_la_SOURCES = buffer.c command.c vty.c vector.c utils.c \ - telnet_interface.c logging_vty.c stats_vty.c \ - fsm_vty.c talloc_ctx_vty.c \ - cpu_sched_vty.c tdef_vty.c +libosmovty_la_SOURCES = \ + buffer.c \ + command.c \ + cpu_sched_vty.c \ + fsm_vty.c \ + logging_vty.c \ + stats_vty.c \ + talloc_ctx_vty.c \ + tdef_vty.c \ + telnet_interface.c \ + utils.c \ + vector.c \ + vty.c \ + $(NULL) + libosmovty_la_LDFLAGS = -version-info $(LIBVERSION) -no-undefined -libosmovty_la_LIBADD = $(top_builddir)/src/core/libosmocore.la $(TALLOC_LIBS) $(PTHREAD_LIBS) +libosmovty_la_LIBADD = \ + $(top_builddir)/src/core/libosmocore.la \ + $(TALLOC_LIBS) \ + $(PTHREAD_LIBS) \ + $(NULL) endif -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39938?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I71581f11bdcb4b186a271fc42d5745889c32f4c9 Gerrit-Change-Number: 39938 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
1 0
0 0
[S] Change in libosmocore[master]: core: osmo_io: Introduce API osmo_io_get_backend()
by pespin 07 Apr '25

07 Apr '25
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/39940?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: core: osmo_io: Introduce API osmo_io_get_backend() ...................................................................... core: osmo_io: Introduce API osmo_io_get_backend() It came up several times already that it's difficult figuring out the osmo-io backend a process is actually using. Add this API so that we can display the osmo-io backend through VTY command in a follow-up commit. Related: OS#6740 Change-Id: I9432efd6cb0453d7ab42d71765e897db6bd4c787 --- M TODO-RELEASE M include/osmocom/core/osmo_io.h M src/core/libosmocore.map M src/core/osmo_io.c 4 files changed, 11 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/TODO-RELEASE b/TODO-RELEASE index 0ed7189..5d97425 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,3 +7,4 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line +libosmocore add API osmo_io_get_backend() \ No newline at end of file diff --git a/include/osmocom/core/osmo_io.h b/include/osmocom/core/osmo_io.h index f4bfec4..c8b8517 100644 --- a/include/osmocom/core/osmo_io.h +++ b/include/osmocom/core/osmo_io.h @@ -79,6 +79,8 @@ OSMO_IO_BACKEND_IO_URING, }; +enum osmo_io_backend osmo_io_get_backend(void); + extern const struct value_string osmo_io_backend_names[]; /*! return the string name of an osmo_io_backend */ static inline const char *osmo_io_backend_name(enum osmo_io_backend val) diff --git a/src/core/libosmocore.map b/src/core/libosmocore.map index cd5dc94..b48c4e6 100644 --- a/src/core/libosmocore.map +++ b/src/core/libosmocore.map @@ -256,6 +256,7 @@ osmo_init_logging2; osmo_int_to_float_str_buf; osmo_int_to_float_str_c; +osmo_io_get_backend; osmo_io_backend_names; osmo_iofd_close; osmo_iofd_free; diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c index 65c9b33..9d377a8 100644 --- a/src/core/osmo_io.c +++ b/src/core/osmo_io.c @@ -122,6 +122,13 @@ osmo_iofd_init(); } +/*! Obtain the osmo_io_backend in use by the process + * \returns The osmo_io backend which was configured at startup time */ +enum osmo_io_backend osmo_io_get_backend(void) +{ + return g_io_backend; +} + /*! Allocate the msghdr. * \param[in] iofd the osmo_io file structure * \param[in] action the action this msg(hdr) is for (read, write, ..) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39940?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9432efd6cb0453d7ab42d71765e897db6bd4c787 Gerrit-Change-Number: 39940 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
1 0
0 0
[M] Change in libosmocore[master]: vty: Add 'show runtime' command
by pespin 07 Apr '25

07 Apr '25
Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/39941?usp=email ) Change subject: vty: Add 'show runtime' command ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39941?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7994c820894b3525bfe78b5d389ff30a1e543226 Gerrit-Change-Number: 39941 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Apr 2025 10:56:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 92
  • 93
  • 94
  • 95
  • 96
  • 97
  • 98
  • ...
  • 119
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.