Attention is currently required from: fixeria.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39944?usp=email )
Change subject: client: use osmo_stream_cli to transmit data to pcap-server
......................................................................
Patch Set 4:
(1 comment)
File src/osmo_client_network.c:
https://gerrit.osmocom.org/c/osmo-pcap/+/39944/comment/963c015a_9c5eb012?us… :
PS3, Line 575: OML BTS link
> this needs to be changed
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39944?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-Change-Id: I72e8a6ceb4fb1eb70372e13bb139ead0e2bc0860
Gerrit-Change-Number: 39944
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 08 Apr 2025 08:51:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: fixeria, pespin.
Hello Jenkins Builder, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-pcap/+/39944?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Code-Review+1 by fixeria, Verified+1 by Jenkins Builder
Change subject: client: use osmo_stream_cli to transmit data to pcap-server
......................................................................
client: use osmo_stream_cli to transmit data to pcap-server
Similarly to previous work done in osmo-pcap-server, the switch to
osmo_stream doesn't cover the TLS-enabled scenario, since moving TLS
related code to osmo_stream requires significant amount of work and can
be done in a subsequent step.
Related: SYS#7290
Change-Id: I72e8a6ceb4fb1eb70372e13bb139ead0e2bc0860
---
M include/osmo-pcap/osmo_pcap_client.h
M src/Makefile.am
M src/osmo_client_network.c
M src/osmo_client_vty.c
4 files changed, 143 insertions(+), 35 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/44/39944/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39944?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-Change-Id: I72e8a6ceb4fb1eb70372e13bb139ead0e2bc0860
Gerrit-Change-Number: 39944
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
Hello Jenkins Builder, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-pcap/+/39947?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: client: constify args in can_forward_packet()
......................................................................
client: constify args in can_forward_packet()
Change-Id: I3568b962fea7d0e34b68f75cea7b59b1df158238
---
M src/osmo_client_core.c
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/47/39947/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39947?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-Change-Id: I3568b962fea7d0e34b68f75cea7b59b1df158238
Gerrit-Change-Number: 39947
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39944?usp=email )
Change subject: client: use osmo_stream_cli to transmit data to pcap-server
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File src/osmo_client_network.c:
https://gerrit.osmocom.org/c/osmo-pcap/+/39944/comment/e6336a95_90c75c8e?us… :
PS3, Line 575: OML BTS link
this needs to be changed
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39944?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-Change-Id: I72e8a6ceb4fb1eb70372e13bb139ead0e2bc0860
Gerrit-Change-Number: 39944
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 08 Apr 2025 08:28:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes