April 2025 - gerrit-log - lists.osmocom.org

[XS] Change in libosmo-abis[rel-2.0.1]: ipaccess: Reset pointer before calling stream_cli func triggering cal...

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/40171?usp=email ) Change subject: ipaccess: Reset pointer before calling stream_cli func triggering callback ...................................................................... ipaccess: Reset pointer before calling stream_cli func triggering callback The osmo_stream_cli_destroy() may trigger the disconnect_cb, which we forward to the user through sign_link_down() callback. Hence, the user may call e1inp_ipa_bts_rsl_close_n() again (re-entrant, recursively) before we had time to nullify the pointer, calling osmo_stream_cli_destroy() again. Instead, make sure the pointer is reset bfore potentially calling the osmo_stream_cli_destroy() to make sure to catch this scenario. This issue was being triggered by BTS_Tests.TC_chopped_ipa_payload, which was hitting an assert due to incorrectly calling osmo_stream_cli_destroy() twice on a given stream_cli. Related: OS#6729 Change-Id: I2f1da24580effab5e3dfeacb6514c3b1e3a650c9 (cherry picked from commit 8076b58f5d7d22cb5dcc82843d1793adbc9ba4e4) --- M src/input/ipaccess.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/71/40171/1 diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index 6a7d753..44ec719 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -1168,8 +1168,8 @@ cli = il->ipa_cli[1 + trx_nr]; if (cli != NULL) { - osmo_stream_cli_destroy(cli); il->ipa_cli[1 + trx_nr] = NULL; + osmo_stream_cli_destroy(cli); } return 0; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/40171?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-abis Gerrit-Branch: rel-2.0.1 Gerrit-Change-Id: I2f1da24580effab5e3dfeacb6514c3b1e3a650c9 Gerrit-Change-Number: 40171 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de>

3 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ci[master]: tarballs: add libosmo-dsp

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/40166?usp=email ) Change subject: tarballs: add libosmo-dsp ...................................................................... tarballs: add libosmo-dsp Closes: OS#6765 Change-Id: I0506b323caa34a54f1284068130ccc006a9c103d --- M scripts/tarballs/publish-tarballs-for-tags.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/scripts/tarballs/publish-tarballs-for-tags.sh b/scripts/tarballs/publish-tarballs-for-tags.sh index 90dfb38..7f8c6d3 100755 --- a/scripts/tarballs/publish-tarballs-for-tags.sh +++ b/scripts/tarballs/publish-tarballs-for-tags.sh @@ -12,6 +12,7 @@ libasn1c libgtpnl libosmo-abis + libosmo-dsp libosmo-netif libosmo-pfcp libosmo-sccp-legacy -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40166?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0506b323caa34a54f1284068130ccc006a9c103d Gerrit-Change-Number: 40166 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

3 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/osmocom-release-tarballs: add email parameter

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/40165?usp=email ) Change subject: jobs/osmocom-release-tarballs: add email parameter ...................................................................... jobs/osmocom-release-tarballs: add email parameter Make it easy to disable emails when testing that releases for a newly added project work as expected. Change-Id: Ie90780dd37aa736739e41efda19bd3e21c306f31 --- M jobs/osmocom-release-tarballs.yml 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/jobs/osmocom-release-tarballs.yml b/jobs/osmocom-release-tarballs.yml index 4b3c8dc..1f5e9e2 100644 --- a/jobs/osmocom-release-tarballs.yml +++ b/jobs/osmocom-release-tarballs.yml @@ -23,6 +23,10 @@ description: | osmo-ci.git branch with scripts/tarballs/publish-tarballs-for-tags.sh default: 'master' + - string: + name: EMAIL_NOTIFICATIONS + description: For failed build notifications, set to empty to disable + default: 'jenkins-notifications(a)lists.osmocom.org' builders: - shell: | PUBLISH=1 scripts/tarballs/publish-tarballs-for-tags.sh @@ -39,7 +43,7 @@ publishers: - email: notify-every-unstable-build: true - recipients: 'jenkins-notifications(a)lists.osmocom.org' + recipients: '$EMAIL_NOTIFICATIONS' wrappers: - ssh-agent-credentials: users: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40165?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie90780dd37aa736739e41efda19bd3e21c306f31 Gerrit-Change-Number: 40165 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

3 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/osmocom-release-tarballs: add email parameter

by laforge

Attention is currently required from: fixeria, osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40165?usp=email ) Change subject: jobs/osmocom-release-tarballs: add email parameter ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40165?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie90780dd37aa736739e41efda19bd3e21c306f31 Gerrit-Change-Number: 40165 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 29 Apr 2025 14:25:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ci[master]: tarballs: add libosmo-dsp

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40166?usp=email ) Change subject: tarballs: add libosmo-dsp ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40166?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0506b323caa34a54f1284068130ccc006a9c103d Gerrit-Change-Number: 40166 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 29 Apr 2025 14:25:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ci[master]: tarballs: add libosmo-dsp

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40166?usp=email ) Change subject: tarballs: add libosmo-dsp ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40166?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0506b323caa34a54f1284068130ccc006a9c103d Gerrit-Change-Number: 40166 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 29 Apr 2025 10:00:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 2 weeks

1
0
0 0

[S] Change in osmo-ci[master]: jobs/ttcn3-testsuites: display load at start/end

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40167?usp=email ) Change subject: jobs/ttcn3-testsuites: display load at start/end ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40167?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5f891ae5d9b501e2e111e61d3aaa55ae24cb663b Gerrit-Change-Number: 40167 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 29 Apr 2025 10:00:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/osmocom-release-tarballs: add email parameter

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40165?usp=email ) Change subject: jobs/osmocom-release-tarballs: add email parameter ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40165?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie90780dd37aa736739e41efda19bd3e21c306f31 Gerrit-Change-Number: 40165 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 29 Apr 2025 09:58:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 2 weeks

1
0
0 0

[S] Change in osmo-ci[master]: jobs/ttcn3-testsuites: display load at start/end

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/40167?usp=email ) Change subject: jobs/ttcn3-testsuites: display load at start/end ...................................................................... jobs/ttcn3-testsuites: display load at start/end Display the load average line from uptime at the start and end of testsuite runs, e.g.: load average: 0.77, 0.68, 0.68 Change-Id: I5f891ae5d9b501e2e111e61d3aaa55ae24cb663b --- M jobs/ttcn3-testsuites-testenv.yml M jobs/ttcn3-testsuites.yml 2 files changed, 20 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/67/40167/1 diff --git a/jobs/ttcn3-testsuites-testenv.yml b/jobs/ttcn3-testsuites-testenv.yml index f6a7798..ac1b00e 100644 --- a/jobs/ttcn3-testsuites-testenv.yml +++ b/jobs/ttcn3-testsuites-testenv.yml @@ -533,18 +533,26 @@ export TESTENV_COREDUMP_FROM_LXC_HOST=1 set -x - ./testenv.py run \ + uptime | grep --color=always -o "load.*" + + RC=0 + if ! ./testenv.py run \ {testsuite} \ --podman \ --cache "$PWD"/_cache \ --ccache ~/ccache/testenv \ --log-dir "$PWD"/logs \ - {args} + {args}; then + RC=1 + fi # Free up space from downloaded apt packages, build artifacts etc. # The osmo-ttcn3-hacks deps dir and ccache are persistent. rm -rf _cache .linux + uptime | grep --color=always -o "load.*" + exit $RC + scm: - git: branches: diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index d842fff..6d76961 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -165,7 +165,16 @@ esac cd "$DIR" - ./jenkins.sh + + uptime | grep --color=always -o "load.*" + + RC=0 + if ! ./jenkins.sh; then + RC=1 + fi + + uptime | grep --color=always -o "load.*" + exit $RC scm: - git: branches: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40167?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5f891ae5d9b501e2e111e61d3aaa55ae24cb663b Gerrit-Change-Number: 40167 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

3 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/osmocom-release-tarballs: add email parameter

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/40165?usp=email ) Change subject: jobs/osmocom-release-tarballs: add email parameter ...................................................................... jobs/osmocom-release-tarballs: add email parameter Make it easy to disable emails when testing that releases for a newly added project work as expected. Change-Id: Ie90780dd37aa736739e41efda19bd3e21c306f31 --- M jobs/osmocom-release-tarballs.yml 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/65/40165/1 diff --git a/jobs/osmocom-release-tarballs.yml b/jobs/osmocom-release-tarballs.yml index 4b3c8dc..1f5e9e2 100644 --- a/jobs/osmocom-release-tarballs.yml +++ b/jobs/osmocom-release-tarballs.yml @@ -23,6 +23,10 @@ description: | osmo-ci.git branch with scripts/tarballs/publish-tarballs-for-tags.sh default: 'master' + - string: + name: EMAIL_NOTIFICATIONS + description: For failed build notifications, set to empty to disable + default: 'jenkins-notifications(a)lists.osmocom.org' builders: - shell: | PUBLISH=1 scripts/tarballs/publish-tarballs-for-tags.sh @@ -39,7 +43,7 @@ publishers: - email: notify-every-unstable-build: true - recipients: 'jenkins-notifications(a)lists.osmocom.org' + recipients: '$EMAIL_NOTIFICATIONS' wrappers: - ssh-agent-credentials: users: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40165?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie90780dd37aa736739e41efda19bd3e21c306f31 Gerrit-Change-Number: 40165 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

3 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2025