April 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ci[master]: tarballs: add pyosmocom, libosmo-gprs

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/40177?usp=email ) Change subject: tarballs: add pyosmocom, libosmo-gprs ...................................................................... tarballs: add pyosmocom, libosmo-gprs Fixes: OS#6786, OS#6785 Change-Id: I7eaf8d4091d6261a7e526148075c4a87f9de49b7 --- M scripts/tarballs/publish-tarballs-for-tags.sh 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/scripts/tarballs/publish-tarballs-for-tags.sh b/scripts/tarballs/publish-tarballs-for-tags.sh index 7f8c6d3..442c00f 100755 --- a/scripts/tarballs/publish-tarballs-for-tags.sh +++ b/scripts/tarballs/publish-tarballs-for-tags.sh @@ -13,6 +13,7 @@ libgtpnl libosmo-abis libosmo-dsp + libosmo-gprs libosmo-netif libosmo-pfcp libosmo-sccp-legacy @@ -49,6 +50,7 @@ osmo-upf osmo_dia2gsup osmocom-bb + pyosmocom rtl-sdr simtrace2 strongswan-epdg -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40177?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7eaf8d4091d6261a7e526148075c4a87f9de49b7 Gerrit-Change-Number: 40177 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

3 months, 1 week

1
0
0 0

[XS] Change in osmo-ci[master]: tarballs: add pyosmocom, libosmo-gprs

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40177?usp=email ) Change subject: tarballs: add pyosmocom, libosmo-gprs ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40177?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7eaf8d4091d6261a7e526148075c4a87f9de49b7 Gerrit-Change-Number: 40177 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Apr 2025 13:22:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 1 week

1
0
0 0

[S] Change in osmo-hnbgw[master]: Fix MAP_SCCP_EV_CN_LINK_LOST never dispatched

by laforge

Attention is currently required from: neels, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40175?usp=email ) Change subject: Fix MAP_SCCP_EV_CN_LINK_LOST never dispatched ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40175?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I3a37522da16d9a06764f58c2da9579b397d8a7f2 Gerrit-Change-Number: 40175 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Apr 2025 13:21:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 1 week

1
0
0 0

[S] Change in osmo-hnbgw[master]: Fix MAP_SCCP_EV_CN_LINK_LOST never dispatched

by pespin

Attention is currently required from: laforge, neels. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40175?usp=email ) Change subject: Fix MAP_SCCP_EV_CN_LINK_LOST never dispatched ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: See new patch. In the end the code paths of EV_CN_LINK_LOST and EV_RAN_LINK_LOST are the same currently in the context_map_sccp FSM. We may want to improve them later after this patch now that actually the events are triggered from the proper place. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40175?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I3a37522da16d9a06764f58c2da9579b397d8a7f2 Gerrit-Change-Number: 40175 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 30 Apr 2025 12:52:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

3 months, 1 week

1
0
0 0

[S] Change in osmo-hnbgw[master]: Fix MAP_SCCP_EV_CN_LINK_LOST never dispatched

by pespin

Attention is currently required from: laforge, neels. Hello Jenkins Builder, neels, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40175?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: Fix MAP_SCCP_EV_CN_LINK_LOST never dispatched ...................................................................... Fix MAP_SCCP_EV_CN_LINK_LOST never dispatched Commit introducing event MAP_SCCP_EV_CN_LINK_LOST into the FSM actually never dispatched it, and instead dispatched MAP_SCCP_EV_RAN_LINK_LOST, probably a copy-paste typo. At the same time, it becomes clear no param is passed to the FSM when dispatching it, so update related code paths since it becomes clear no ranap_msg is passed. Regarding comment in map_sccp_connected_action() about sending a RANAP RESET, that should be done previously through a MAP_SCCP_EV_RX_DATA_INDICATION prior to dispatching the CN_LINK_LOST event if needed, similar to how's done in the context_map_rua FSM. Fixes: b1c0bb19e2bfbc48e05a89a5f09b476d1243b5f3 Change-Id: I3a37522da16d9a06764f58c2da9579b397d8a7f2 --- M src/osmo-hnbgw/context_map.c M src/osmo-hnbgw/context_map_sccp.c 2 files changed, 1 insertion(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/75/40175/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40175?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I3a37522da16d9a06764f58c2da9579b397d8a7f2 Gerrit-Change-Number: 40175 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org>

3 months, 1 week

1
0
0 0

[S] Change in osmo-hnbgw[master]: context_map_sccp: Drop unused MAP_SCCP_EV_CN_LINK_LOST

by pespin

Attention is currently required from: laforge, neels. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40175?usp=email ) Change subject: context_map_sccp: Drop unused MAP_SCCP_EV_CN_LINK_LOST ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-hnbgw/+/40175/comment/331acdbc_495d31c8?u… : PS2, Line 9: This event is never called. Furthermore, this kind of "SCCP link went : down" should already be handled by libosmo-sigtran's sccp SAP : internally, and we should simply recieve an N-DISCONNECT.ind when that : happens which dispatches event MAP_SCCP_EV_RX_RELEASED. > There seems to be a mixup of events when receiving an SCCP N-PCSTATE. […] This looks like a bug introduced in osmo-hnbgw.git b1c0bb19e2bfbc48e05a89a5f09b476d1243b5f3, the commit where MAP_SCCP_EV_CN_LINK_LOST was introduced but never dispatched anywhere. Looks like there was probably a copy-paste issue in there. I'll continue investigating and submit a new patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40175?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I3a37522da16d9a06764f58c2da9579b397d8a7f2 Gerrit-Change-Number: 40175 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 30 Apr 2025 12:23:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

3 months, 1 week

1
0
0 0

[S] Change in osmo-hnbgw[master]: context_map_sccp: Drop unused MAP_SCCP_EV_CN_LINK_LOST

by pespin

Attention is currently required from: laforge, neels. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40175?usp=email ) Change subject: context_map_sccp: Drop unused MAP_SCCP_EV_CN_LINK_LOST ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-hnbgw/+/40175/comment/b88887b8_948e2e6d?u… : PS2, Line 9: This event is never called. Furthermore, this kind of "SCCP link went : down" should already be handled by libosmo-sigtran's sccp SAP : internally, and we should simply recieve an N-DISCONNECT.ind when that : happens which dispatches event MAP_SCCP_EV_RX_RELEASED. > This is a related ticket which I recalled existed but was unable to find yesterday: https://osmocom. […] There seems to be a mixup of events when receiving an SCCP N-PCSTATE.ind handle_pcstate_ind in(), which ends up calling: cnlink_set_disconnected() cnlink_fsm_state_chg(cnlink->fi, CNLINK_ST_DISC) cnlink_disc_onenter() link_lost() context_map_cnlink_lost() map_sccp_dispatch(map, MAP_SCCP_EV_RAN_LINK_LOST, NULL) See how context_map_cnlink_lost() is sending event MAP_SCCP_EV_RAN_LINK_LOST, but that should actually be MAP_SCCP_EV_CN_LINK_LOST afaiu... -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40175?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I3a37522da16d9a06764f58c2da9579b397d8a7f2 Gerrit-Change-Number: 40175 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 30 Apr 2025 12:20:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

3 months, 1 week

1
0
0 0

[S] Change in osmo-hnbgw[master]: context_map_sccp: Drop unused MAP_SCCP_EV_CN_LINK_LOST

by pespin

Attention is currently required from: laforge, neels. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40175?usp=email ) Change subject: context_map_sccp: Drop unused MAP_SCCP_EV_CN_LINK_LOST ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-hnbgw/+/40175/comment/c378fc09_eeec3687?u… : PS2, Line 9: This event is never called. Furthermore, this kind of "SCCP link went : down" should already be handled by libosmo-sigtran's sccp SAP : internally, and we should simply recieve an N-DISCONNECT.ind when that : happens which dispatches event MAP_SCCP_EV_RX_RELEASED. > N-DISCONNECT.ind is the termination of a sinle SCCP connection. […] This is a related ticket which I recalled existed but was unable to find yesterday: https://osmocom.org/issues/5917 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40175?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I3a37522da16d9a06764f58c2da9579b397d8a7f2 Gerrit-Change-Number: 40175 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 30 Apr 2025 12:08:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

3 months, 1 week

1
0
0 0

[XS] Change in osmo-ci[master]: tarballs: add pyosmocom, libosmo-gprs

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/40177?usp=email ) Change subject: tarballs: add pyosmocom, libosmo-gprs ...................................................................... tarballs: add pyosmocom, libosmo-gprs Fixes: OS#6786, OS#6785 Change-Id: I7eaf8d4091d6261a7e526148075c4a87f9de49b7 --- M scripts/tarballs/publish-tarballs-for-tags.sh 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/77/40177/1 diff --git a/scripts/tarballs/publish-tarballs-for-tags.sh b/scripts/tarballs/publish-tarballs-for-tags.sh index 7f8c6d3..442c00f 100755 --- a/scripts/tarballs/publish-tarballs-for-tags.sh +++ b/scripts/tarballs/publish-tarballs-for-tags.sh @@ -13,6 +13,7 @@ libgtpnl libosmo-abis libosmo-dsp + libosmo-gprs libosmo-netif libosmo-pfcp libosmo-sccp-legacy @@ -49,6 +50,7 @@ osmo-upf osmo_dia2gsup osmocom-bb + pyosmocom rtl-sdr simtrace2 strongswan-epdg -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40177?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7eaf8d4091d6261a7e526148075c4a87f9de49b7 Gerrit-Change-Number: 40177 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

3 months, 1 week

1
0
0 0

[S] Change in osmo-ci[master]: jobs/ttcn3-testsuites: display load at start/end

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/40167?usp=email ) Change subject: jobs/ttcn3-testsuites: display load at start/end ...................................................................... jobs/ttcn3-testsuites: display load at start/end Display the load average line from uptime at the start and end of testsuite runs, e.g.: load average: 0.77, 0.68, 0.68 Change-Id: I5f891ae5d9b501e2e111e61d3aaa55ae24cb663b --- M jobs/ttcn3-testsuites-testenv.yml M jobs/ttcn3-testsuites.yml 2 files changed, 20 insertions(+), 3 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/jobs/ttcn3-testsuites-testenv.yml b/jobs/ttcn3-testsuites-testenv.yml index f6a7798..ac1b00e 100644 --- a/jobs/ttcn3-testsuites-testenv.yml +++ b/jobs/ttcn3-testsuites-testenv.yml @@ -533,18 +533,26 @@ export TESTENV_COREDUMP_FROM_LXC_HOST=1 set -x - ./testenv.py run \ + uptime | grep --color=always -o "load.*" + + RC=0 + if ! ./testenv.py run \ {testsuite} \ --podman \ --cache "$PWD"/_cache \ --ccache ~/ccache/testenv \ --log-dir "$PWD"/logs \ - {args} + {args}; then + RC=1 + fi # Free up space from downloaded apt packages, build artifacts etc. # The osmo-ttcn3-hacks deps dir and ccache are persistent. rm -rf _cache .linux + uptime | grep --color=always -o "load.*" + exit $RC + scm: - git: branches: diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index d842fff..6d76961 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -165,7 +165,16 @@ esac cd "$DIR" - ./jenkins.sh + + uptime | grep --color=always -o "load.*" + + RC=0 + if ! ./jenkins.sh; then + RC=1 + fi + + uptime | grep --color=always -o "load.*" + exit $RC scm: - git: branches: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40167?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5f891ae5d9b501e2e111e61d3aaa55ae24cb663b Gerrit-Change-Number: 40167 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

3 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2025