April 2025 - gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: Use osmocom.construct.{Bytes,GreedyBytes} for hexstring input support

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/40120?usp=email ) Change subject: Use osmocom.construct.{Bytes,GreedyBytes} for hexstring input support ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40120?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I1c8df6350c68aa408ec96ff6cd1e405ceb1a4fbb Gerrit-Change-Number: 40120 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 29 Apr 2025 15:45:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 1 week

1
0
0 0

[S] Change in osmo-ci[master]: jobs/ttcn3-testsuites: display load at start/end

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40167?usp=email ) Change subject: jobs/ttcn3-testsuites: display load at start/end ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40167?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5f891ae5d9b501e2e111e61d3aaa55ae24cb663b Gerrit-Change-Number: 40167 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 29 Apr 2025 15:08:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 1 week

1
0
0 0

[XS] Change in libosmo-abis[rel-2.0.1]: Bump version: 2.0.0.1-20a9 → 2.0.1

by fixeria

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmo-abis/+/40172?usp=email ) Change subject: Bump version: 2.0.0.1-20a9 → 2.0.1 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Reminder: push tag after merged. https://gerrit.osmocom.org/plugins/gitiles/libosmo-abis/+/refs/tags/2.0.1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/40172?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: rel-2.0.1 Gerrit-Change-Id: Ib9f300745c86bd6421aa0cc7905bf5f545f9212b Gerrit-Change-Number: 40172 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 29 Apr 2025 15:04:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

3 months, 1 week

1
0
0 0

[XS] Change in libosmo-abis[rel-2.0.1]: ipaccess: Reset pointer before calling stream_cli func triggering cal...

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/40171?usp=email ) Change subject: ipaccess: Reset pointer before calling stream_cli func triggering callback ...................................................................... ipaccess: Reset pointer before calling stream_cli func triggering callback The osmo_stream_cli_destroy() may trigger the disconnect_cb, which we forward to the user through sign_link_down() callback. Hence, the user may call e1inp_ipa_bts_rsl_close_n() again (re-entrant, recursively) before we had time to nullify the pointer, calling osmo_stream_cli_destroy() again. Instead, make sure the pointer is reset bfore potentially calling the osmo_stream_cli_destroy() to make sure to catch this scenario. This issue was being triggered by BTS_Tests.TC_chopped_ipa_payload, which was hitting an assert due to incorrectly calling osmo_stream_cli_destroy() twice on a given stream_cli. Related: OS#6729 Change-Id: I2f1da24580effab5e3dfeacb6514c3b1e3a650c9 (cherry picked from commit 8076b58f5d7d22cb5dcc82843d1793adbc9ba4e4) --- M src/input/ipaccess.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index 6a7d753..44ec719 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -1168,8 +1168,8 @@ cli = il->ipa_cli[1 + trx_nr]; if (cli != NULL) { - osmo_stream_cli_destroy(cli); il->ipa_cli[1 + trx_nr] = NULL; + osmo_stream_cli_destroy(cli); } return 0; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/40171?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-abis Gerrit-Branch: rel-2.0.1 Gerrit-Change-Id: I2f1da24580effab5e3dfeacb6514c3b1e3a650c9 Gerrit-Change-Number: 40171 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

3 months, 1 week

1
0
0 0

[XS] Change in libosmo-abis[rel-2.0.1]: Bump version: 2.0.0.1-20a9 → 2.0.1

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/40172?usp=email ) Change subject: Bump version: 2.0.0.1-20a9 → 2.0.1 ...................................................................... Bump version: 2.0.0.1-20a9 → 2.0.1 Change-Id: Ib9f300745c86bd6421aa0cc7905bf5f545f9212b --- M debian/changelog M src/Makefile.am 2 files changed, 8 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/debian/changelog b/debian/changelog index d93e8b9..b0d1b66 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,10 @@ +libosmo-abis (2.0.1) unstable; urgency=medium + + [ Pau Espin Pedrol ] + * ipaccess: Reset pointer before calling stream_cli func triggering callback + + -- Vadim Yanitskiy <vyanitskiy(a)sysmocom.de> Tue, 29 Apr 2025 21:39:20 +0700 + libosmo-abis (2.0.0) unstable; urgency=medium [ Mychaela N. Falconia ] diff --git a/src/Makefile.am b/src/Makefile.am index f25fb8b..195129b 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -1,7 +1,7 @@ # This is _NOT_ the library release version, it's an API version. # Please read chapter "Library interface versions" of the libtool documentation # before making any modifications: https://www.gnu.org/software/libtool/manual/html_node/Versioning.html -ABIS_LIBVERSION=15:0:0 +ABIS_LIBVERSION=15:1:0 TRAU_LIBVERSION=11:0:0 AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -I$(top_builddir) -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/40172?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-abis Gerrit-Branch: rel-2.0.1 Gerrit-Change-Id: Ib9f300745c86bd6421aa0cc7905bf5f545f9212b Gerrit-Change-Number: 40172 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

3 months, 1 week

1
0
0 0

[XS] Change in libosmo-abis[rel-2.0.1]: Bump version: 2.0.0.1-20a9 → 2.0.1

by pespin

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmo-abis/+/40172?usp=email ) Change subject: Bump version: 2.0.0.1-20a9 → 2.0.1 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Reminder: push tag after merged. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/40172?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: rel-2.0.1 Gerrit-Change-Id: Ib9f300745c86bd6421aa0cc7905bf5f545f9212b Gerrit-Change-Number: 40172 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 29 Apr 2025 14:49:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

3 months, 1 week

1
0
0 0

[XS] Change in libosmo-abis[rel-2.0.1]: Bump version: 2.0.0.1-20a9 → 2.0.1

by pespin

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmo-abis/+/40172?usp=email ) Change subject: Bump version: 2.0.0.1-20a9 → 2.0.1 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/40172?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: rel-2.0.1 Gerrit-Change-Id: Ib9f300745c86bd6421aa0cc7905bf5f545f9212b Gerrit-Change-Number: 40172 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 29 Apr 2025 14:48:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 1 week

1
0
0 0

[XS] Change in libosmo-abis[rel-2.0.1]: ipaccess: Reset pointer before calling stream_cli func triggering cal...

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmo-abis/+/40171?usp=email ) Change subject: ipaccess: Reset pointer before calling stream_cli func triggering callback ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/40171?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: rel-2.0.1 Gerrit-Change-Id: I2f1da24580effab5e3dfeacb6514c3b1e3a650c9 Gerrit-Change-Number: 40171 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 29 Apr 2025 14:48:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 1 week

1
0
0 0

[XS] Change in libosmo-abis[rel-2.0.1]: Bump version: 2.0.0.1-20a9 → 2.0.1

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmo-abis/+/40172?usp=email ) Change subject: Bump version: 2.0.0.1-20a9 → 2.0.1 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: We need a patch release to fix the -latest version of ttcn3-bts-test. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/40172?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: rel-2.0.1 Gerrit-Change-Id: Ib9f300745c86bd6421aa0cc7905bf5f545f9212b Gerrit-Change-Number: 40172 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 29 Apr 2025 14:43:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

3 months, 1 week

1
0
0 0

[XS] Change in libosmo-abis[rel-2.0.1]: Bump version: 2.0.0.1-20a9 → 2.0.1

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/40172?usp=email ) Change subject: Bump version: 2.0.0.1-20a9 → 2.0.1 ...................................................................... Bump version: 2.0.0.1-20a9 → 2.0.1 Change-Id: Ib9f300745c86bd6421aa0cc7905bf5f545f9212b --- M debian/changelog M src/Makefile.am 2 files changed, 8 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/72/40172/1 diff --git a/debian/changelog b/debian/changelog index d93e8b9..b0d1b66 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,10 @@ +libosmo-abis (2.0.1) unstable; urgency=medium + + [ Pau Espin Pedrol ] + * ipaccess: Reset pointer before calling stream_cli func triggering callback + + -- Vadim Yanitskiy <vyanitskiy(a)sysmocom.de> Tue, 29 Apr 2025 21:39:20 +0700 + libosmo-abis (2.0.0) unstable; urgency=medium [ Mychaela N. Falconia ] diff --git a/src/Makefile.am b/src/Makefile.am index f25fb8b..195129b 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -1,7 +1,7 @@ # This is _NOT_ the library release version, it's an API version. # Please read chapter "Library interface versions" of the libtool documentation # before making any modifications: https://www.gnu.org/software/libtool/manual/html_node/Versioning.html -ABIS_LIBVERSION=15:0:0 +ABIS_LIBVERSION=15:1:0 TRAU_LIBVERSION=11:0:0 AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -I$(top_builddir) -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/40172?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-abis Gerrit-Branch: rel-2.0.1 Gerrit-Change-Id: Ib9f300745c86bd6421aa0cc7905bf5f545f9212b Gerrit-Change-Number: 40172 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

3 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2025