Attention is currently required from: laforge, neels. Hello Jenkins Builder, neels, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40175?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: Fix MAP_SCCP_EV_CN_LINK_LOST never dispatched ...................................................................... Fix MAP_SCCP_EV_CN_LINK_LOST never dispatched Commit introducing event MAP_SCCP_EV_CN_LINK_LOST into the FSM actually never dispatched it, and instead dispatched MAP_SCCP_EV_RAN_LINK_LOST, probably a copy-paste typo. At the same time, it becomes clear no param is passed to the FSM when dispatching it, so update related code paths since it becomes clear no ranap_msg is passed. Regarding comment in map_sccp_connected_action() about sending a RANAP RESET, that should be done previously through a MAP_SCCP_EV_RX_DATA_INDICATION prior to dispatching the CN_LINK_LOST event if needed, similar to how's done in the context_map_rua FSM. Fixes: b1c0bb19e2bfbc48e05a89a5f09b476d1243b5f3 Change-Id: I3a37522da16d9a06764f58c2da9579b397d8a7f2 --- M src/osmo-hnbgw/context_map.c M src/osmo-hnbgw/context_map_sccp.c 2 files changed, 1 insertion(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/75/40175/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40175?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I3a37522da16d9a06764f58c2da9579b397d8a7f2 Gerrit-Change-Number: 40175 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org>