April 2025 - gerrit-log - lists.osmocom.org

[S] Change in ...osmo dia2gsup[master]: Bump version: 0.3.2-7-gf9e423b → 0.3.3

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40150?usp=email ) Change subject: Bump version: 0.3.2-7-gf9e423b → 0.3.3 ...................................................................... Bump version: 0.3.2-7-gf9e423b → 0.3.3 Change-Id: I5d2d487bd49ee3159422edf93f8dee3b035ed3bb --- M debian/changelog 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/debian/changelog b/debian/changelog index eaa669e..9bf0542 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,15 @@ +osmo-diameter2gsup (0.3.3) unstable; urgency=medium + + * osmo_dia2gsup: add get_env/2 for convenience + * osmo_dia2gsup: add and use parse_addr/1 + * osmo_dia2gsup: move env parsing and logging to listen/1 + * osmo_dia2gsup: disable Nagle for TCP/SCTP by default + * osmo_dia2gsup: set sndbuf/recbuf explicitly for SCTP + * rebar.config: relx: fix wrong sys_config, drop vm_args + * rebar.config: relx: use semver instead of long git hash + + -- Vadim Yanitskiy <vyanitskiy(a)sysmocom.de> Fri, 25 Apr 2025 03:04:10 +0700 + osmo-diameter2gsup (0.3.2) unstable; urgency=medium [ Vadim Yanitskiy ] -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40150?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I5d2d487bd49ee3159422edf93f8dee3b035ed3bb Gerrit-Change-Number: 40150 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

[XS] Change in ...osmo_dia2gsup[master]: rebar.config: relx: use semver instead of long git hash

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40149?usp=email ) Change subject: rebar.config: relx: use semver instead of long git hash ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40149?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I6270e2057eba21d0727a54586b1e2fb1022159cf Gerrit-Change-Number: 40149 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Apr 2025 06:42:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[XS] Change in ...osmo_dia2gsup[master]: rebar.config: relx: fix wrong sys_config, drop vm_args

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40148?usp=email ) Change subject: rebar.config: relx: fix wrong sys_config, drop vm_args ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40148?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I07c161e0cabd479864ec8e927e8d45b523ae4b83 Gerrit-Change-Number: 40148 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Apr 2025 06:41:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[S] Change in ...osmo dia2gsup[master]: Bump version: 0.3.2-7-gf9e423b → 0.3.3

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40150?usp=email ) Change subject: Bump version: 0.3.2-7-gf9e423b → 0.3.3 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40150?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I5d2d487bd49ee3159422edf93f8dee3b035ed3bb Gerrit-Change-Number: 40150 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Apr 2025 06:41:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: testenv: support fetching coredumps in jenkins

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40140?usp=email ) Change subject: testenv: support fetching coredumps in jenkins ...................................................................... testenv: support fetching coredumps in jenkins The Osmocom jenkins nodes run inside LXCs. When we get a coredump it appears on the host, fetch it from there via testenv-coredump-helper, which gets added to the hosts in the related patch. Related: osmo-ci I7e66c98106b7028a393e3b873e96ae2dcb412c48 Related: OS#6769 Change-Id: I3784b4cbcef08b26f77b6f6f7a70a830d9c81a18 --- M _testenv/README.md M _testenv/testenv/coredump.py 2 files changed, 62 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/_testenv/README.md b/_testenv/README.md index 11cd8bd..66158c4 100644 --- a/_testenv/README.md +++ b/_testenv/README.md @@ -215,6 +215,15 @@ available but doesn't work in podman. QEMU runs a bit slower when this is set. +* `TESTENV_COREDUMP_FROM_LXC_HOST`: + Instead of using coredumpctl to retrieve the coredump, assume testenv is + running inside an LXC and try to retrieve the coredump from the LXC host + (OS#6769). This is used in jenkins. + +* `TESTENV_COREDUMP_FROM_LXC_HOST_IP`: + Instead of attempting to automatically detect the LXC host IP, use this IP. + This can be set to 127.0.0.1 for testing. + ## Troubleshooting ### Timeout waiting for RESET-ACK after sending RESET diff --git a/_testenv/testenv/coredump.py b/_testenv/testenv/coredump.py index 0d56328..0343c67 100644 --- a/_testenv/testenv/coredump.py +++ b/_testenv/testenv/coredump.py @@ -11,9 +11,54 @@ import testenv import testenv.daemons import testenv.testdir +import urllib +import urllib.request executable_path = None +lxc_netdev = "eth0" +lxc_ip_pattern = "10.0.*" +lxc_port = 8042 + + +def find_lxc_host_ip(): + cmd = ["ip", "-j", "-o", "-4", "addr", "show", "dev", lxc_netdev] + p = testenv.cmd.run(cmd, check=False, no_podman=True, capture_output=True, text=True) + ret = json.loads(p.stdout)[0]["addr_info"][0]["local"] + if fnmatch.fnmatch(ret, lxc_ip_pattern): + ret = ret.split(".") + ret = f"{ret[0]}.{ret[1]}.{ret[2]}.1" + return ret + return None + + +def get_from_coredumpctl_lxc_host(): + # Server implementation: osmo-ci, ansible/roles/testenv-coredump-helper + global executable_path + + logging.info("Looking for a coredump on lxc host") + + ip = os.environ.get("TESTENV_COREDUMP_FROM_LXC_HOST_IP") or find_lxc_host_ip() + if not ip: + logging.warning("Failed to get lxc host ip, can't look for coredump") + return + + try: + with urllib.request.urlopen(f"http://{ip}:{lxc_port}/core") as response: + executable_path = dict(response.getheaders())["X-Executable-Path"] + with open(f"{testenv.testdir.testdir}/core", "wb") as h: + shutil.copyfileobj(response, h) + logging.debug("Coredump found and copied to log dir") + except urllib.error.HTTPError as e: + executable_path = None + if e.code == 404: + logging.debug("No coredump found") + else: + logging.error(f"Unexpected error while attempting to fetch the coredump: {e}") + except urllib.error.URLError as e: + executable_path = None + logging.error(f"Unexpected error while attempting to fetch the coredump: {e}") + def executable_is_relevant(exe): if testenv.args.binary_repo: @@ -32,7 +77,7 @@ return False -def get_from_coredumpctl(): +def get_from_coredumpctl_local(): global executable_path logging.info("Looking for a coredump") @@ -68,6 +113,13 @@ executable_path = coredump["exe"] +def get_from_coredumpctl(): + if os.environ.get("TESTENV_COREDUMP_FROM_LXC_HOST"): + get_from_coredumpctl_lxc_host() + else: + get_from_coredumpctl_local() + + def get_backtrace(): global executable_path -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40140?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3784b4cbcef08b26f77b6f6f7a70a830d9c81a18 Gerrit-Change-Number: 40140 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

[XS] Change in ...osmo_dia2gsup[master]: osmo_dia2gsup: remove unused start/0

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40146?usp=email ) Change subject: osmo_dia2gsup: remove unused start/0 ...................................................................... Patch Set 1: (1 comment) File src/osmo_dia2gsup.erl: https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40146/comment/b653395c_… : PS1, Line 83: start() -> > isn't it neede dby behavior gen_server? Nope, it's not a gen_server's behavior function, neither `start_link/0` is. It's just a public (exported) API that is not used (nor needed). -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40146?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: Ibd4e1d86dc59d792f7f6ac027ee63fc2086b31c3 Gerrit-Change-Number: 40146 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Apr 2025 03:56:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

[S] Change in ...osmo dia2gsup[master]: Bump version: 0.3.2-7-gf9e423b → 0.3.3

by pespin

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40150?usp=email ) Change subject: Bump version: 0.3.2-7-gf9e423b → 0.3.3 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40150?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I5d2d487bd49ee3159422edf93f8dee3b035ed3bb Gerrit-Change-Number: 40150 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Apr 2025 21:05:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[XS] Change in ...osmo_dia2gsup[master]: rebar.config: relx: use semver instead of long git hash

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40149?usp=email ) Change subject: rebar.config: relx: use semver instead of long git hash ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40149?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I6270e2057eba21d0727a54586b1e2fb1022159cf Gerrit-Change-Number: 40149 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Apr 2025 21:05:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[XS] Change in ...osmo_dia2gsup[master]: rebar.config: relx: fix wrong sys_config, drop vm_args

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40148?usp=email ) Change subject: rebar.config: relx: fix wrong sys_config, drop vm_args ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40148?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I07c161e0cabd479864ec8e927e8d45b523ae4b83 Gerrit-Change-Number: 40148 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Apr 2025 21:04:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[XS] Change in ...osmo_dia2gsup[master]: server_cb: comment out unused fields in handle_request/3

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40145?usp=email ) Change subject: server_cb: comment out unused fields in handle_request/3 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40145?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I3b709cfc723418c1ec88d15bc25bb2cef462a4d3 Gerrit-Change-Number: 40145 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Apr 2025 21:03:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2025