April 2025 - gerrit-log - lists.osmocom.org

[XS] Change in ...osmo_dia2gsup[master]: server_cb: comment out unused fields in handle_request/3

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40145?usp=email ) Change subject: server_cb: comment out unused fields in handle_request/3 ...................................................................... server_cb: comment out unused fields in handle_request/3 This fixes the following warnings: * Warning: variable 'RatType' is unused * Warning: variable 'UlrFlags' is unused Change-Id: I3b709cfc723418c1ec88d15bc25bb2cef462a4d3 --- M src/server_cb.erl 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/45/40145/1 diff --git a/src/server_cb.erl b/src/server_cb.erl index 815eaf6..f51bb5c 100644 --- a/src/server_cb.erl +++ b/src/server_cb.erl @@ -287,8 +287,8 @@ % extract relevant fields from DIAMETER ULR #diameter_caps{origin_host = {OH,_}, origin_realm = {OR,_}} = Caps, #'ULR'{'Session-Id' = SessionId, - 'RAT-Type' = RatType, - 'ULR-Flags' = UlrFlags, +%% XXX 'RAT-Type' = RatType, +%% XXX 'ULR-Flags' = UlrFlags, 'User-Name' = UserName} = Req, % construct GSUP UpdateLocation request to HLR and transceive it; expect InsertSubscrDataReq -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40145?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I3b709cfc723418c1ec88d15bc25bb2cef462a4d3 Gerrit-Change-Number: 40145 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

[M] Change in osmo-ci[master]: jobs: run ttcn3-bts-test-* between 01:00 - 06:00

by fixeria

fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40142?usp=email ) Change subject: jobs: run ttcn3-bts-test-* between 01:00 - 06:00 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40142?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0162f7299c8e37f893ffa10ddc4c8edece29ed7f Gerrit-Change-Number: 40142 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Apr 2025 19:24:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[M] Change in osmo-ci[master]: jobs: run ttcn3-bts-test-* between 01:00 - 06:00

by fixeria

fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40142?usp=email ) Change subject: jobs: run ttcn3-bts-test-* between 01:00 - 06:00 ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > tbh with some fake_trx delays I saw myself on my own laptop I doubt it will improve a lot the proble […] I guess you're talking about recent master, which is doing queuing? FYI: I created a branch called `ttcn3-bts-test`, which points to the point predating Kirill's patches. So fake_trx.py is "reverted" back to a known working state, but we're still seeing clock issues in ttcn3-bts-test. Running 4 variants of ttcn3-bts-test (and thus 4 fake_trx.py instances and 4 osmo-bts-trx instances) on the same machine at the same time is prone to latency issues. Even when we had `respawn.sh` in place, this was likely the reason of sporadic testcase failures that I was unable to reproduce locally. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40142?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0162f7299c8e37f893ffa10ddc4c8edece29ed7f Gerrit-Change-Number: 40142 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Apr 2025 19:22:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: testenv: support fetching coredumps in jenkins

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40140?usp=email ) Change subject: testenv: support fetching coredumps in jenkins ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40140?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3784b4cbcef08b26f77b6f6f7a70a830d9c81a18 Gerrit-Change-Number: 40140 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Apr 2025 19:12:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: start-testsuite: remove workaround for TITAN < 9.0.0

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40129?usp=email ) Change subject: start-testsuite: remove workaround for TITAN < 9.0.0 ...................................................................... start-testsuite: remove workaround for TITAN < 9.0.0 We're using the 9.0.0 nowadays, which does not need this workaround. Change-Id: I57eecd6e0ea9e488a2110b029ddc313bd05cd1fa --- M start-testsuite.sh 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: osmith: Looks good to me, approved laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/start-testsuite.sh b/start-testsuite.sh index 7d06bf2..1cf544d 100755 --- a/start-testsuite.sh +++ b/start-testsuite.sh @@ -42,10 +42,6 @@ TEST=$3 fi -# Limit max num of open file descriptors to workaround titan.core bug: -# https://gitlab.eclipse.org/eclipse/titan/titan.core/-/issues/690 -ulimit -n 100000 - if [ -z "$TTCN3_DIR" ]; then # below is for the debian packages TTCN3_BIN_DIR="${TTCN3_BIN_DIR:-/usr/bin}" -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40129?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I57eecd6e0ea9e488a2110b029ddc313bd05cd1fa Gerrit-Change-Number: 40129 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

[S] Change in upf-benchmark[master]: osmo-upf-load-gen: Allow setting local PFCP port

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/upf-benchmark/+/40143?usp=email ) Change subject: osmo-upf-load-gen: Allow setting local PFCP port ...................................................................... osmo-upf-load-gen: Allow setting local PFCP port Change-Id: If74456aa85cc31fd940d47a3258ce566e12716da --- M src/osmo-upf-load-gen/pfcp_tool_vty.c 1 file changed, 8 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/upf-benchmark refs/changes/43/40143/1 diff --git a/src/osmo-upf-load-gen/pfcp_tool_vty.c b/src/osmo-upf-load-gen/pfcp_tool_vty.c index 86e4104..4cb6420 100644 --- a/src/osmo-upf-load-gen/pfcp_tool_vty.c +++ b/src/osmo-upf-load-gen/pfcp_tool_vty.c @@ -37,9 +37,10 @@ #include <osmocom/upfloadgen/pfcp_tool.h> DEFUN(c_local_addr, c_local_addr_cmd, - "local-addr IP_ADDR", + "local-addr IP_ADDR [<0-65535>]", "Set the local IP address to bind on for PFCP; see also 'listen'\n" - "IP address\n") + "IP address\n" + "PFCP port (default " OSMO_STRINGIFY_VAL(OSMO_PFCP_PORT) ")\n") { if (g_pfcp_tool->ep != NULL) { vty_out(vty, "Already listening on %s%s", @@ -50,6 +51,11 @@ osmo_talloc_replace_string(g_pfcp_tool, &g_pfcp_tool->vty_cfg.local_ip, argv[0]); + if (argc > 1) + g_pfcp_tool->vty_cfg.local_port = atoi(argv[1]); + else + g_pfcp_tool->vty_cfg.local_port = OSMO_PFCP_PORT; + return CMD_SUCCESS; } -- To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/40143?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: upf-benchmark Gerrit-Branch: master Gerrit-Change-Id: If74456aa85cc31fd940d47a3258ce566e12716da Gerrit-Change-Number: 40143 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: testenv: support fetching coredumps in jenkins

by pespin

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40140?usp=email ) Change subject: testenv: support fetching coredumps in jenkins ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40140?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3784b4cbcef08b26f77b6f6f7a70a830d9c81a18 Gerrit-Change-Number: 40140 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Apr 2025 14:41:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[M] Change in osmo-ci[master]: ansible: build-hosts: add testenv-coredump-helper

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40138?usp=email ) Change subject: ansible: build-hosts: add testenv-coredump-helper ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40138?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7e66c98106b7028a393e3b873e96ae2dcb412c48 Gerrit-Change-Number: 40138 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Apr 2025 14:41:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: testenv: support fetching coredumps in jenkins

by osmith

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40140?usp=email ) Change subject: testenv: support fetching coredumps in jenkins ...................................................................... Patch Set 3: (1 comment) File _testenv/testenv/coredump.py: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40140/comment/f7a4a14d_5f0e… : PS2, Line 35: def get_from_coredumpctl_lxc_host(): > I'm missing in here some reference to the script providing this service. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40140?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3784b4cbcef08b26f77b6f6f7a70a830d9c81a18 Gerrit-Change-Number: 40140 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Apr 2025 14:38:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: testenv: support fetching coredumps in jenkins

by osmith

Attention is currently required from: fixeria, osmith. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40140?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: testenv: support fetching coredumps in jenkins ...................................................................... testenv: support fetching coredumps in jenkins The Osmocom jenkins nodes run inside LXCs. When we get a coredump it appears on the host, fetch it from there via testenv-coredump-helper, which gets added to the hosts in the related patch. Related: osmo-ci I7e66c98106b7028a393e3b873e96ae2dcb412c48 Related: OS#6769 Change-Id: I3784b4cbcef08b26f77b6f6f7a70a830d9c81a18 --- M _testenv/README.md M _testenv/testenv/coredump.py 2 files changed, 62 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/40/40140/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40140?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3784b4cbcef08b26f77b6f6f7a70a830d9c81a18 Gerrit-Change-Number: 40140 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2025