lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

April 2025

  • 1 participants
  • 1186 discussions
[S] Change in upf-benchmark[master]: osmo-upf-load-gen: Allow setting local PFCP port
by pespin 25 Apr '25

25 Apr '25
pespin has submitted this change. ( https://gerrit.osmocom.org/c/upf-benchmark/+/40143?usp=email ) Change subject: osmo-upf-load-gen: Allow setting local PFCP port ...................................................................... osmo-upf-load-gen: Allow setting local PFCP port Change-Id: If74456aa85cc31fd940d47a3258ce566e12716da --- M src/osmo-upf-load-gen/pfcp_tool_vty.c 1 file changed, 8 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/src/osmo-upf-load-gen/pfcp_tool_vty.c b/src/osmo-upf-load-gen/pfcp_tool_vty.c index 86e4104..4cb6420 100644 --- a/src/osmo-upf-load-gen/pfcp_tool_vty.c +++ b/src/osmo-upf-load-gen/pfcp_tool_vty.c @@ -37,9 +37,10 @@ #include <osmocom/upfloadgen/pfcp_tool.h> DEFUN(c_local_addr, c_local_addr_cmd, - "local-addr IP_ADDR", + "local-addr IP_ADDR [<0-65535>]", "Set the local IP address to bind on for PFCP; see also 'listen'\n" - "IP address\n") + "IP address\n" + "PFCP port (default " OSMO_STRINGIFY_VAL(OSMO_PFCP_PORT) ")\n") { if (g_pfcp_tool->ep != NULL) { vty_out(vty, "Already listening on %s%s", @@ -50,6 +51,11 @@ osmo_talloc_replace_string(g_pfcp_tool, &g_pfcp_tool->vty_cfg.local_ip, argv[0]); + if (argc > 1) + g_pfcp_tool->vty_cfg.local_port = atoi(argv[1]); + else + g_pfcp_tool->vty_cfg.local_port = OSMO_PFCP_PORT; + return CMD_SUCCESS; } -- To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/40143?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: upf-benchmark Gerrit-Branch: master Gerrit-Change-Id: If74456aa85cc31fd940d47a3258ce566e12716da Gerrit-Change-Number: 40143 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
1 0
0 0
[XS] Change in osmo-ttcn3-hacks[master]: bts: set osmo-bts sched priority to 30
by osmith 25 Apr '25

25 Apr '25
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40153?usp=email ) Change subject: bts: set osmo-bts sched priority to 30 ...................................................................... bts: set osmo-bts sched priority to 30 Change the scheduling priority from 10 to 30, as we are currently see osmo-bts suffering from scheduling latency in jenkins even though we don't run other jobs at that time: 20250425034138405 DL1C ERROR PC clock skew: elapsed_us=387574, error_us=382959 (scheduler_trx.c:449) This testsuite currently gets executed through docker-playground and it fetches this config from osmo-ttcn3-hacks (see If15461240f3037c142c176fc7da745a1701ae3f8). Related: osmo-ci I0162f7299c8e37f893ffa10ddc4c8edece29ed7f Change-Id: I828422e2363a58ca8c19d0f1b8a1b7d4e4bc031e --- M bts/osmo-bts.cfg 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/53/40153/1 diff --git a/bts/osmo-bts.cfg b/bts/osmo-bts.cfg index a683a03..e0fadb1 100644 --- a/bts/osmo-bts.cfg +++ b/bts/osmo-bts.cfg @@ -33,7 +33,7 @@ bind 127.0.0.1 ! cpu-sched - policy rr 10 + policy rr 30 ! e1_input e1_line 0 driver ipa -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40153?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I828422e2363a58ca8c19d0f1b8a1b7d4e4bc031e Gerrit-Change-Number: 40153 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>
1 0
0 0
[XS] Change in osmo-hnbgw[master]: rua: Change log err level ERROR->NOTICE regarding received unexpected...
by pespin 25 Apr '25

25 Apr '25
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40152?usp=email ) Change subject: rua: Change log err level ERROR->NOTICE regarding received unexpected RUA context ...................................................................... rua: Change log err level ERROR->NOTICE regarding received unexpected RUA context This is not really an internal error but can actually happen if the HNB or the HNBGW crashed and state is no longer the same in both. Change-Id: Ib588bb71ccbe716a495afec27d38f48881e7e1bc --- M src/osmo-hnbgw/hnbgw_rua.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/52/40152/1 diff --git a/src/osmo-hnbgw/hnbgw_rua.c b/src/osmo-hnbgw/hnbgw_rua.c index 7cc1b27..7a51c8d 100644 --- a/src/osmo-hnbgw/hnbgw_rua.c +++ b/src/osmo-hnbgw/hnbgw_rua.c @@ -271,7 +271,7 @@ /* A Connect message can only be the first message for an unused RUA context */ if (map) { /* Already established this RUA context. But then how can it be a Connect message. */ - LOGHNB(hnb, DRUA, LOGL_ERROR, "rx RUA %s for already active RUA context %u\n", + LOGHNB(hnb, DRUA, LOGL_NOTICE, "rx RUA %s for already active RUA context %u\n", rua_procedure_code_name(rua_procedure), context_id); return -EINVAL; } @@ -300,7 +300,7 @@ default: /* Any message other than Connect must have a valid RUA context */ if (!map) { - LOGHNB(hnb, DRUA, LOGL_ERROR, "rx RUA %s for unknown RUA context %u\n", + LOGHNB(hnb, DRUA, LOGL_NOTICE, "rx RUA %s for unknown RUA context %u\n", rua_procedure_code_name(rua_procedure), context_id); rua_tx_disc_conn_fail(hnb, is_ps, context_id); return -EINVAL; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40152?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ib588bb71ccbe716a495afec27d38f48881e7e1bc Gerrit-Change-Number: 40152 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>
1 0
0 0
[S] Change in upf-benchmark[master]: osmo-upf-load-gen: Allow setting local PFCP port
by osmith 25 Apr '25

25 Apr '25
Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/upf-benchmark/+/40143?usp=email ) Change subject: osmo-upf-load-gen: Allow setting local PFCP port ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/40143?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: upf-benchmark Gerrit-Branch: master Gerrit-Change-Id: If74456aa85cc31fd940d47a3258ce566e12716da Gerrit-Change-Number: 40143 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Apr 2025 12:23:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[XS] Change in osmo-mgw[master]: mgw: osmux: Fix heap-use-after-free
by pespin 25 Apr '25

25 Apr '25
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/40151?usp=email ) Change subject: mgw: osmux: Fix heap-use-after-free ...................................................................... mgw: osmux: Fix heap-use-after-free As found by Asan on a osmo-mgw running in production: """ ==2238035==ERROR: AddressSanitizer: heap-use-after-free on address 0x62100043bdca at pc 0x7f9bcebaa070 bp 0x7ffcb08f2150 sp 0x7ffcb08f2148 READ of size 2 at 0x62100043bdca thread T0 #0 0x7f9bcebaa06f in msgb_length src/core/msgb.c:287 #1 0x55869457a8ff in conn_osmux_send_rtp src/libosmo-mgcp/mgcp_osmux.c:245 #2 0x558694563a86 in mgcp_dispatch_rtp_bridge_cb src/libosmo-mgcp/mgcp_network.c:1347 #3 0x5586945570a9 in rx_rtp src/libosmo-mgcp/mgcp_network.c:1550 #4 0x5586945570a9 in rtp_recvfrom_cb src/libosmo-mgcp/mgcp_network.c:1505 #5 0x7f9bcebc96cc in iofd_poll_ofd_cb_recvmsg_sendmsg src/core/osmo_io_poll.c:84 #6 0x7f9bcebcb699 in iofd_poll_ofd_cb_dispatch src/core/osmo_io_poll.c:136 #7 0x7f9bcebd7df5 in poll_disp_fds src/core/select.c:419 #8 0x7f9bcebd7df5 in _osmo_select_main src/core/select.c:457 #9 0x7f9bcebd8298 in osmo_select_main src/core/select.c:496 #10 0x558694534f2e in main src/osmo-mgw/mgw_main.c:428 """ Related: SYS#7450 Change-Id: Id90c77aaf44422c3ed70ffb06560537e920a468c --- M src/libosmo-mgcp/mgcp_osmux.c 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/libosmo-mgcp/mgcp_osmux.c b/src/libosmo-mgcp/mgcp_osmux.c index 620220f..711c6c6 100644 --- a/src/libosmo-mgcp/mgcp_osmux.c +++ b/src/libosmo-mgcp/mgcp_osmux.c @@ -211,6 +211,7 @@ int conn_osmux_send_rtp(struct mgcp_conn_rtp *conn, struct msgb *msg) { int ret; + size_t msg_len; if (!conn->end.output_enabled) { rtpconn_osmux_rate_ctr_inc(conn, OSMUX_RTP_PACKETS_TX_DROPPED_CTR); @@ -234,15 +235,17 @@ return -1; } + msg_len = msgb_length(msg); while ((ret = osmux_xfrm_input(conn->osmux.in, msg, conn->osmux.remote_cid)) > 0) { /* batch full, build and deliver it */ osmux_xfrm_input_deliver(conn->osmux.in); } + /* NOTE: At this point msg is now owned by osmux subsystem and may have been potentially freed. */ if (ret < 0) { rtpconn_osmux_rate_ctr_inc(conn, OSMUX_RTP_PACKETS_TX_DROPPED_CTR); } else { rtpconn_osmux_rate_ctr_inc(conn, OSMUX_RTP_PACKETS_TX_CTR); - rtpconn_osmux_rate_ctr_add(conn, OSMUX_AMR_OCTETS_TX_CTR, msgb_length(msg) - sizeof(struct rtp_hdr)); + rtpconn_osmux_rate_ctr_add(conn, OSMUX_AMR_OCTETS_TX_CTR, msg_len - sizeof(struct rtp_hdr)); } return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/40151?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Id90c77aaf44422c3ed70ffb06560537e920a468c Gerrit-Change-Number: 40151 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
1 0
0 0
[XS] Change in osmo-mgw[master]: mgw: osmux: Fix heap-use-after-free
by osmith 25 Apr '25

25 Apr '25
Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/40151?usp=email ) Change subject: mgw: osmux: Fix heap-use-after-free ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/40151?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Id90c77aaf44422c3ed70ffb06560537e920a468c Gerrit-Change-Number: 40151 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Apr 2025 11:54:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[XS] Change in osmo-mgw[master]: mgw: osmux: Fix heap-use-after-free
by pespin 25 Apr '25

25 Apr '25
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/40151?usp=email ) Change subject: mgw: osmux: Fix heap-use-after-free ...................................................................... mgw: osmux: Fix heap-use-after-free As found by Asan on a osmo-mgw running in production: """ ==2238035==ERROR: AddressSanitizer: heap-use-after-free on address 0x62100043bdca at pc 0x7f9bcebaa070 bp 0x7ffcb08f2150 sp 0x7ffcb08f2148 READ of size 2 at 0x62100043bdca thread T0 #0 0x7f9bcebaa06f in msgb_length src/core/msgb.c:287 #1 0x55869457a8ff in conn_osmux_send_rtp src/libosmo-mgcp/mgcp_osmux.c:245 #2 0x558694563a86 in mgcp_dispatch_rtp_bridge_cb src/libosmo-mgcp/mgcp_network.c:1347 #3 0x5586945570a9 in rx_rtp src/libosmo-mgcp/mgcp_network.c:1550 #4 0x5586945570a9 in rtp_recvfrom_cb src/libosmo-mgcp/mgcp_network.c:1505 #5 0x7f9bcebc96cc in iofd_poll_ofd_cb_recvmsg_sendmsg src/core/osmo_io_poll.c:84 #6 0x7f9bcebcb699 in iofd_poll_ofd_cb_dispatch src/core/osmo_io_poll.c:136 #7 0x7f9bcebd7df5 in poll_disp_fds src/core/select.c:419 #8 0x7f9bcebd7df5 in _osmo_select_main src/core/select.c:457 #9 0x7f9bcebd8298 in osmo_select_main src/core/select.c:496 #10 0x558694534f2e in main src/osmo-mgw/mgw_main.c:428 """ Related: SYS#7450 Change-Id: Id90c77aaf44422c3ed70ffb06560537e920a468c --- M src/libosmo-mgcp/mgcp_osmux.c 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/51/40151/1 diff --git a/src/libosmo-mgcp/mgcp_osmux.c b/src/libosmo-mgcp/mgcp_osmux.c index 620220f..711c6c6 100644 --- a/src/libosmo-mgcp/mgcp_osmux.c +++ b/src/libosmo-mgcp/mgcp_osmux.c @@ -211,6 +211,7 @@ int conn_osmux_send_rtp(struct mgcp_conn_rtp *conn, struct msgb *msg) { int ret; + size_t msg_len; if (!conn->end.output_enabled) { rtpconn_osmux_rate_ctr_inc(conn, OSMUX_RTP_PACKETS_TX_DROPPED_CTR); @@ -234,15 +235,17 @@ return -1; } + msg_len = msgb_length(msg); while ((ret = osmux_xfrm_input(conn->osmux.in, msg, conn->osmux.remote_cid)) > 0) { /* batch full, build and deliver it */ osmux_xfrm_input_deliver(conn->osmux.in); } + /* NOTE: At this point msg is now owned by osmux subsystem and may have been potentially freed. */ if (ret < 0) { rtpconn_osmux_rate_ctr_inc(conn, OSMUX_RTP_PACKETS_TX_DROPPED_CTR); } else { rtpconn_osmux_rate_ctr_inc(conn, OSMUX_RTP_PACKETS_TX_CTR); - rtpconn_osmux_rate_ctr_add(conn, OSMUX_AMR_OCTETS_TX_CTR, msgb_length(msg) - sizeof(struct rtp_hdr)); + rtpconn_osmux_rate_ctr_add(conn, OSMUX_AMR_OCTETS_TX_CTR, msg_len - sizeof(struct rtp_hdr)); } return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/40151?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Id90c77aaf44422c3ed70ffb06560537e920a468c Gerrit-Change-Number: 40151 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>
1 0
0 0
[XS] Change in ...osmo_dia2gsup[master]: osmo_dia2gsup.app.src: add missing 'crypto' app
by fixeria 25 Apr '25

25 Apr '25
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40147?usp=email ) Change subject: osmo_dia2gsup.app.src: add missing 'crypto' app ...................................................................... osmo_dia2gsup.app.src: add missing 'crypto' app This fixes the following warning when generating a release tarball: ===> server_cb:compute_kasme/4 calls undefined function crypto:macN/5 Change-Id: I59d21522b99c0ab1a02a57a8cbb898f222a94ec4 --- M src/osmo_dia2gsup.app.src 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo_dia2gsup.app.src b/src/osmo_dia2gsup.app.src index 941573a..d7f4a7f 100644 --- a/src/osmo_dia2gsup.app.src +++ b/src/osmo_dia2gsup.app.src @@ -5,6 +5,7 @@ {applications, [ kernel, stdlib, + crypto, lager, diameter, osmo_gsup, -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40147?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I59d21522b99c0ab1a02a57a8cbb898f222a94ec4 Gerrit-Change-Number: 40147 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
1 0
0 0
[XS] Change in ...osmo_dia2gsup[master]: server_cb: comment out unused fields in handle_request/3
by fixeria 25 Apr '25

25 Apr '25
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40145?usp=email ) Change subject: server_cb: comment out unused fields in handle_request/3 ...................................................................... server_cb: comment out unused fields in handle_request/3 This fixes the following warnings: * Warning: variable 'RatType' is unused * Warning: variable 'UlrFlags' is unused Change-Id: I3b709cfc723418c1ec88d15bc25bb2cef462a4d3 --- M src/server_cb.erl 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/src/server_cb.erl b/src/server_cb.erl index 815eaf6..f51bb5c 100644 --- a/src/server_cb.erl +++ b/src/server_cb.erl @@ -287,8 +287,8 @@ % extract relevant fields from DIAMETER ULR #diameter_caps{origin_host = {OH,_}, origin_realm = {OR,_}} = Caps, #'ULR'{'Session-Id' = SessionId, - 'RAT-Type' = RatType, - 'ULR-Flags' = UlrFlags, +%% XXX 'RAT-Type' = RatType, +%% XXX 'ULR-Flags' = UlrFlags, 'User-Name' = UserName} = Req, % construct GSUP UpdateLocation request to HLR and transceive it; expect InsertSubscrDataReq -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40145?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I3b709cfc723418c1ec88d15bc25bb2cef462a4d3 Gerrit-Change-Number: 40145 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
1 0
0 0
[XS] Change in ...osmo_dia2gsup[master]: osmo_dia2gsup: remove unused start/0
by fixeria 25 Apr '25

25 Apr '25
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40146?usp=email ) Change subject: osmo_dia2gsup: remove unused start/0 ...................................................................... osmo_dia2gsup: remove unused start/0 This function is not used anywhere. It's also not consistent with the start_link/0, which is starting the gen_server instance. Change-Id: Ibd4e1d86dc59d792f7f6ac027ee63fc2086b31c3 --- M src/osmo_dia2gsup.erl 1 file changed, 1 insertion(+), 5 deletions(-) Approvals: pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo_dia2gsup.erl b/src/osmo_dia2gsup.erl index cda616b..47ca2a4 100644 --- a/src/osmo_dia2gsup.erl +++ b/src/osmo_dia2gsup.erl @@ -40,7 +40,7 @@ % API -export([start_link/0]). --export([start/0, stop/0]). +-export([stop/0]). % gen_server callbacks -export([init/1, handle_call/3, handle_cast/2, handle_info/2]). @@ -80,10 +80,6 @@ start_link() -> gen_server:start_link({local, ?SERVER}, ?MODULE, [], []). -start() -> - application:ensure_all_started(?MODULE), - start_link(). - stop() -> gen_server:cast(?SERVER, stop). -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40146?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: Ibd4e1d86dc59d792f7f6ac027ee63fc2086b31c3 Gerrit-Change-Number: 40146 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 13
  • 14
  • 15
  • 16
  • 17
  • 18
  • 19
  • ...
  • 119
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.