December 2025 - gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: gsmtap_util: Avoid sink_fd leak gsmtap_source_add_sinki() called mult...
by pespin 18 Dec '25

18 Dec '25

Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41706?usp=email ) Change subject: gsmtap_util: Avoid sink_fd leak gsmtap_source_add_sinki() called multiple times ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41706?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7af5a6c7d64954ee2cc013711702b846dfaa02b1 Gerrit-Change-Number: 41706 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 18 Dec 2025 13:24:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: gsmtap_util: Avoid sink_fd leak gsmtap_source_add_sinki() called mult...
by osmith 18 Dec '25

18 Dec '25

Attention is currently required from: laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41706?usp=email ) Change subject: gsmtap_util: Avoid sink_fd leak gsmtap_source_add_sinki() called multiple times ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41706?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7af5a6c7d64954ee2cc013711702b846dfaa02b1 Gerrit-Change-Number: 41706 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Dec 2025 13:24:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmocore[master]: logging_vty: Allow setting gsmtap log tgt as (blocking-io|nonblocking...
by pespin 18 Dec '25

18 Dec '25

Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41702?usp=email ) Change subject: logging_vty: Allow setting gsmtap log tgt as (blocking-io|nonblocking-io|wq) ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > I've just did a small test: […] I'll do the setsockopt(SO_SNDBUF) to 4MB in a separate follow-up patch, since that is really orthogonal to this specific patch. Yes, it probably makes sense to do it in all cases (nonblocking|blocking|wq). -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41702?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id5d31bedd7d265d18f6e475ccbc94ced80598d04 Gerrit-Change-Number: 41702 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 18 Dec 2025 13:23:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[S] Change in libosmocore[master]: gsmtap_util: Avoid sink_fd leak gsmtap_source_add_sinki() called mult...
by fixeria 18 Dec '25

18 Dec '25

Attention is currently required from: laforge, osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41706?usp=email ) Change subject: gsmtap_util: Avoid sink_fd leak gsmtap_source_add_sinki() called multiple times ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41706?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7af5a6c7d64954ee2cc013711702b846dfaa02b1 Gerrit-Change-Number: 41706 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Dec 2025 13:19:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: gsmtap_util: Avoid sink_fd leak gsmtap_source_add_sinki() called mult...
by pespin 18 Dec '25

18 Dec '25

Attention is currently required from: fixeria, laforge, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41706?usp=email ) Change subject: gsmtap_util: Avoid sink_fd leak gsmtap_source_add_sinki() called multiple times ...................................................................... Patch Set 1: (1 comment) File src/core/gsmtap_util.c: https://gerrit.osmocom.org/c/libosmocore/+/41706/comment/076f04dd_dae56719?… : PS1, Line 424: returns > ... […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41706?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7af5a6c7d64954ee2cc013711702b846dfaa02b1 Gerrit-Change-Number: 41706 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Dec 2025 13:17:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: gsmtap_util: Avoid sink_fd leak gsmtap_source_add_sinki() called mult...
by pespin 18 Dec '25

18 Dec '25

Attention is currently required from: fixeria, laforge, osmith, pespin. Hello Jenkins Builder, fixeria, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/41706?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Verified+1 by Jenkins Builder Change subject: gsmtap_util: Avoid sink_fd leak gsmtap_source_add_sinki() called multiple times ...................................................................... gsmtap_util: Avoid sink_fd leak gsmtap_source_add_sinki() called multiple times gti->sink_fd could leak if gsmtap_source_add_sink() was called multiple times. Also if gsmtap_source_add_sink_fd() failed, rc != -1 was returned and hence a close() on a wrong fd would be attempted. This commit fixes both issues, making the whole sink_fd field much more robust. Change-Id: I7af5a6c7d64954ee2cc013711702b846dfaa02b1 --- M src/core/gsmtap_util.c 1 file changed, 11 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/06/41706/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41706?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7af5a6c7d64954ee2cc013711702b846dfaa02b1 Gerrit-Change-Number: 41706 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: gsmtap_util: Avoid sink_fd leak gsmtap_source_add_sinki() called mult...
by fixeria 18 Dec '25

18 Dec '25

Attention is currently required from: laforge, osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41706?usp=email ) Change subject: gsmtap_util: Avoid sink_fd leak gsmtap_source_add_sinki() called multiple times ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/core/gsmtap_util.c: https://gerrit.osmocom.org/c/libosmocore/+/41706/comment/5f8becca_397d88f1?… : PS1, Line 424: returns ...; negative on error -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41706?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7af5a6c7d64954ee2cc013711702b846dfaa02b1 Gerrit-Change-Number: 41706 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Dec 2025 13:16:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: gsmtap_util: Avoid sink_fd leak gsmtap_source_add_sinki() called mult...
by pespin 18 Dec '25

18 Dec '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/41706?usp=email ) Change subject: gsmtap_util: Avoid sink_fd leak gsmtap_source_add_sinki() called multiple times ...................................................................... gsmtap_util: Avoid sink_fd leak gsmtap_source_add_sinki() called multiple times gti->sink_fd could leak if gsmtap_source_add_sink() was called multiple times. Also if gsmtap_source_add_sink_fd() failed, rc != -1 was returned and hence a close() on a wrong fd would be attempted. This commit fixes both issues, making the whole sink_fd field much more robust. Change-Id: I7af5a6c7d64954ee2cc013711702b846dfaa02b1 --- M src/core/gsmtap_util.c 1 file changed, 10 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/06/41706/1 diff --git a/src/core/gsmtap_util.c b/src/core/gsmtap_util.c index f1a2abf..065dc51 100644 --- a/src/core/gsmtap_util.c +++ b/src/core/gsmtap_util.c @@ -436,7 +436,15 @@ */ int gsmtap_source_add_sink(struct gsmtap_inst *gti) { - return gti->sink_fd = gsmtap_source_add_sink_fd(gsmtap_inst_fd2(gti)); + int rc; + + if (gti->sink_fd >= 0) + return -EALREADY; + + rc = gsmtap_source_add_sink_fd(gsmtap_inst_fd2(gti)); + if (rc >= 0) + gti->sink_fd = rc; + return rc; } /* Registered in Osmo IO as a no-op to set the write callback. */ @@ -520,7 +528,7 @@ close(gti->source_fd); - if (gti->sink_fd != -1) { + if (gti->sink_fd >= 0) { close(gti->sink_fd); gti->sink_fd = -1; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41706?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7af5a6c7d64954ee2cc013711702b846dfaa02b1 Gerrit-Change-Number: 41706 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: vty/test: Validate optional-multi-choice param followed by optional-m...
by pespin 18 Dec '25

18 Dec '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/41705?usp=email ) Change subject: vty/test: Validate optional-multi-choice param followed by optional-multi-choice param ...................................................................... vty/test: Validate optional-multi-choice param followed by optional-multi-choice param Change-Id: I4517437c19190200181fecb9bbaf075b507ad7f3 --- M tests/vty/vty_transcript_test.c M tests/vty/vty_transcript_test.vty 2 files changed, 37 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/tests/vty/vty_transcript_test.c b/tests/vty/vty_transcript_test.c index 5f8157a..ac5bb75 100644 --- a/tests/vty/vty_transcript_test.c +++ b/tests/vty/vty_transcript_test.c @@ -218,6 +218,17 @@ return CMD_SUCCESS; } +DEFUN(multi4, multi4_cmd, + "multi4 [(foo|bar)] [(one|two|three)]", + "multi4 test command\n" "foo\nbar\n" "1\n2\n3\n") +{ + vty_out(vty, "ok argc=%d%s%s%s%s%s", argc, + argc > 0 ? " " : "", argc > 0 ? argv[0] : "", + argc > 1 ? " " : "", argc > 1 ? argv[1] : "", + VTY_NEWLINE); + return CMD_SUCCESS; +} + #define X(f) (1 << f) enum { @@ -392,6 +403,7 @@ install_element_ve(&multi1_cmd); install_element_ve(&multi2_cmd); install_element_ve(&multi3_cmd); + install_element_ve(&multi4_cmd); install_element(CONFIG_NODE, &cfg_attr_test_cmd); install_node(&attr_test_node, NULL); diff --git a/tests/vty/vty_transcript_test.vty b/tests/vty/vty_transcript_test.vty index a1c044a..938c949 100644 --- a/tests/vty/vty_transcript_test.vty +++ b/tests/vty/vty_transcript_test.vty @@ -4,6 +4,7 @@ multi1 ([one]|[two]|[three]) multi2 [(one|two|three)] multi3 (foo|bar) [(one|two|three)] + multi4 [(foo|bar)] [(one|two|three)] vty_transcript_test> multi0 ? one 1 @@ -89,6 +90,27 @@ vty_transcript_test> multi3 bar three ok argc=2 bar three +vty_transcript_test> multi4 ? + [foo] foo + [bar] bar + +vty_transcript_test> multi4 foo ? + [one] 1 + [two] 2 + [three] 3 + +vty_transcript_test> multi4 foo +ok argc=1 foo + +vty_transcript_test> multi4 bar +ok argc=1 bar + +vty_transcript_test> multi4 foo one +ok argc=2 foo one + +vty_transcript_test> multi3 bar three +ok argc=2 bar three + vty_transcript_test> multi0 thr ok argc=1 three @@ -101,6 +123,9 @@ vty_transcript_test> multi3 foo t % Ambiguous command. +vty_transcript_test> multi4 foo t +% Ambiguous command. + vty_transcript_test> single0 one ok argc=1 one -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41705?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4517437c19190200181fecb9bbaf075b507ad7f3 Gerrit-Change-Number: 41705 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in pysim[master]: esim.saip.data_source: Different source of data for personalization
by laforge 18 Dec '25

18 Dec '25

Attention is currently required from: neels. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41691?usp=email ) Change subject: esim.saip.data_source: Different source of data for personalization ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I have a parameter source implementation sitting on my branch neels/saip in code review Would be great to see that advance. This code is from 2024 btw, and what I've been using for manual profile personalization ever since. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41691?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia6f70ff467ba58024d94742ba5cecd8141b93ad6 Gerrit-Change-Number: 41691 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Dec 2025 12:47:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>

1 0