December 2025 - gerrit-log - lists.osmocom.org

[XS] Change in libosmocore[master]: vty: assert in optional param followed by optional-multi-choice param...
by osmith 18 Dec '25

18 Dec '25

Attention is currently required from: falconia, neels, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41704?usp=email ) Change subject: vty: assert in optional param followed by optional-multi-choice param: Fix [2/2] ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41704?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4c184db53bec28ab42bcd45e033733d850eea5d2 Gerrit-Change-Number: 41704 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Dec 2025 12:30:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: vty: assert in optional param followed by optional-multi-choice param...
by osmith 18 Dec '25

18 Dec '25

Attention is currently required from: falconia, fixeria, fixeria, neels, pespin. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/35961?usp=email ) Change subject: vty: assert in optional param followed by optional-multi-choice param: Reproduce [1/2] ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35961?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6ad93a304ce498ba9d57fc7e2fd238e6c16e29e0 Gerrit-Change-Number: 35961 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <axilirator(a)gmail.com> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <axilirator(a)gmail.com> Gerrit-Comment-Date: Thu, 18 Dec 2025 12:30:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: vty: assert in optional param followed by optional-multi-choice param...
by fixeria 18 Dec '25

18 Dec '25

Attention is currently required from: falconia, neels, osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41704?usp=email ) Change subject: vty: assert in optional param followed by optional-multi-choice param: Fix [2/2] ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41704?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4c184db53bec28ab42bcd45e033733d850eea5d2 Gerrit-Change-Number: 41704 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Dec 2025 12:30:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-msc[master]: add vty setting for ThemWi RTP formats
by pespin 18 Dec '25

18 Dec '25

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-msc/+/41698?usp=email ) Change subject: add vty setting for ThemWi RTP formats ...................................................................... Patch Set 4: (1 comment) File src/libmsc/msc_vty.c: https://gerrit.osmocom.org/c/osmo-msc/+/41698/comment/523f8e6a_620e43dc?usp… : PS2, Line 711: DEFUN(cfg_msc_twformat1, > This is a known limitation of the VTY parser, see: […] I submitted a fix here: https://gerrit.osmocom.org/c/libosmocore/+/41704/ @falcon@freecalypso.org feel free to submit patches to update other vty commands you found that which could use this syntax. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41698?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Icea152f5f2cdbcb0df09ef5b7211d1461b499f14 Gerrit-Change-Number: 41698 Gerrit-PatchSet: 4 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Thu, 18 Dec 2025 12:29:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: vty: assert in optional param followed by optional-multi-choice param...
by fixeria 18 Dec '25

18 Dec '25

Attention is currently required from: falconia, fixeria, neels, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/35961?usp=email ) Change subject: vty: assert in optional param followed by optional-multi-choice param: Reproduce [1/2] ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: LOL, why are you requesting review from my other account? I am the author of this patch and it looks good to me by definition 😄 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35961?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6ad93a304ce498ba9d57fc7e2fd238e6c16e29e0 Gerrit-Change-Number: 35961 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <axilirator(a)gmail.com> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <axilirator(a)gmail.com> Gerrit-Comment-Date: Thu, 18 Dec 2025 12:28:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in libosmocore[master]: vty: assert in optional param followed by optional-multi-choice param...
by pespin 18 Dec '25

18 Dec '25

Attention is currently required from: falconia, fixeria, fixeria, neels. pespin has uploaded a new patch set (#4) to the change originally created by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/35961?usp=email ) Change subject: vty: assert in optional param followed by optional-multi-choice param: Reproduce [1/2] ...................................................................... vty: assert in optional param followed by optional-multi-choice param: Reproduce [1/2] The test added below makes cmd_make_descvec() assert in "OSMO_ASSERT(multiple);" line, so it's expected to fail during CI. Follow-up patch provides a fixes for it. Change-Id: I6ad93a304ce498ba9d57fc7e2fd238e6c16e29e0 Related: b55f4d2df21b966c3953264d8961f259814f4650 Related: OS#6360 --- M tests/vty/vty_transcript_test.c M tests/vty/vty_transcript_test.vty 2 files changed, 37 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/61/35961/4 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35961?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6ad93a304ce498ba9d57fc7e2fd238e6c16e29e0 Gerrit-Change-Number: 35961 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <axilirator(a)gmail.com> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <axilirator(a)gmail.com>

1 0

[XS] Change in libosmocore[master]: vty: assert in optional param followed by optional-multi-choice param...
by pespin 18 Dec '25

18 Dec '25

Attention is currently required from: falconia, fixeria, neels, osmith. Hello falconia, fixeria, neels, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/41704?usp=email to look at the new patch set (#2). Change subject: vty: assert in optional param followed by optional-multi-choice param: Fix [2/2] ...................................................................... vty: assert in optional param followed by optional-multi-choice param: Fix [2/2] in cmd_make_descr, cp during the asserting iteration looks like this: (gdb) print cp $18 = 0x555555c1939d ") [(one|two|three)" As a result, first multiple is set to 0 and later on logic was missing for this specific case. Change-Id: I4c184db53bec28ab42bcd45e033733d850eea5d2 Fixes: b55f4d2df21b966c3953264d8961f259814f4650 Related: OS#6360 --- M src/vty/command.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/04/41704/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41704?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4c184db53bec28ab42bcd45e033733d850eea5d2 Gerrit-Change-Number: 41704 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: vty: optional param follwed by optional-multi-choice param: Fix [2/2]
by pespin 18 Dec '25

18 Dec '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/41704?usp=email ) Change subject: vty: optional param follwed by optional-multi-choice param: Fix [2/2] ...................................................................... vty: optional param follwed by optional-multi-choice param: Fix [2/2] in cmd_make_descr, cp during the asserting iteration looks like this: (gdb) print cp $18 = 0x555555c1939d ") [(one|two|three)" As a result, first multiple is set to 0 and later on logic was missing for this specific case. Change-Id: I4c184db53bec28ab42bcd45e033733d850eea5d2 Fixes: b55f4d2df21b966c3953264d8961f259814f4650 Related: OS#6360 --- M src/vty/command.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/04/41704/1 diff --git a/src/vty/command.c b/src/vty/command.c index 8594290..c1bda8a 100644 --- a/src/vty/command.c +++ b/src/vty/command.c @@ -443,6 +443,12 @@ while (isspace((int)*cp) && *cp != '\0') cp++; + /* Explicitly detect optional multi-choice braces like [(one|two)]. */ + if (cp[0] == '[' && cp[1] == '(') { + optional_brace = 1; + cp++; + } + if (*cp == '(') { multiple = 1; cp++; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41704?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4c184db53bec28ab42bcd45e033733d850eea5d2 Gerrit-Change-Number: 41704 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: vty: optional param follwed by optional-multi-choice param: Reproduce...
by pespin 18 Dec '25

18 Dec '25

Attention is currently required from: fixeria, neels, pespin. pespin has uploaded a new patch set (#3) to the change originally created by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/35961?usp=email ) The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: vty: optional param follwed by optional-multi-choice param: Reproduce [1/2] ...................................................................... vty: optional param follwed by optional-multi-choice param: Reproduce [1/2] The test added below makes cmd_make_descvec() assert in "OSMO_ASSERT(multiple);" line, so it's expected to fail during CI. Follow-up patch provides a fixes for it. Change-Id: I6ad93a304ce498ba9d57fc7e2fd238e6c16e29e0 Related: b55f4d2df21b966c3953264d8961f259814f4650 Related: OS#6360 --- M tests/vty/vty_transcript_test.c M tests/vty/vty_transcript_test.vty 2 files changed, 37 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/61/35961/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35961?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6ad93a304ce498ba9d57fc7e2fd238e6c16e29e0 Gerrit-Change-Number: 35961 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-msc[master]: add vty setting for ThemWi RTP formats
by fixeria 18 Dec '25

18 Dec '25

Attention is currently required from: falconia. fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-msc/+/41698?usp=email ) Change subject: add vty setting for ThemWi RTP formats ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File src/libmsc/msc_vty.c: https://gerrit.osmocom.org/c/osmo-msc/+/41698/comment/47834fd9_b3472e32?usp… : PS2, Line 711: DEFUN(cfg_msc_twformat1, > Uh-oh: the cleaner-looking approach recommended by @pespin@sysmocom. […] This is a known limitation of the VTY parser, see: https://osmocom.org/issues/6360 https://gerrit.osmocom.org/c/libosmocore/+/35961 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41698?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Icea152f5f2cdbcb0df09ef5b7211d1461b499f14 Gerrit-Change-Number: 41698 Gerrit-PatchSet: 4 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Thu, 18 Dec 2025 11:59:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0