Attention is currently required from: fixeria, laforge, osmith, pespin. Hello Jenkins Builder, fixeria, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/41706?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Verified+1 by Jenkins Builder Change subject: gsmtap_util: Avoid sink_fd leak gsmtap_source_add_sinki() called multiple times ...................................................................... gsmtap_util: Avoid sink_fd leak gsmtap_source_add_sinki() called multiple times gti->sink_fd could leak if gsmtap_source_add_sink() was called multiple times. Also if gsmtap_source_add_sink_fd() failed, rc != -1 was returned and hence a close() on a wrong fd would be attempted. This commit fixes both issues, making the whole sink_fd field much more robust. Change-Id: I7af5a6c7d64954ee2cc013711702b846dfaa02b1 --- M src/core/gsmtap_util.c 1 file changed, 11 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/06/41706/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41706?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7af5a6c7d64954ee2cc013711702b846dfaa02b1 Gerrit-Change-Number: 41706 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de>