November 2025 - gerrit-log - lists.osmocom.org

[XL] Change in libosmo-sigtran[master]: Add TCAP based loadsharing/routing
by daniel 14 Nov '25

14 Nov '25

Attention is currently required from: laforge, lynxis lazus, pespin. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email ) Change subject: Add TCAP based loadsharing/routing ...................................................................... Patch Set 10: (1 comment) Patchset: PS10: Not everything is addressed -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d Gerrit-Change-Number: 41309 Gerrit-PatchSet: 10 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 13 Nov 2025 16:48:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XL] Change in libosmo-sigtran[master]: Add TCAP based loadsharing/routing
by daniel 14 Nov '25

14 Nov '25

Attention is currently required from: laforge, lynxis lazus, pespin. daniel has uploaded a new patch set (#10) to the change originally created by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email ) The following approvals got outdated and were removed: Code-Review-1 by pespin, Verified-1 by Jenkins Builder Change subject: Add TCAP based loadsharing/routing ...................................................................... Add TCAP based loadsharing/routing TCAP based loadsharing will share the load based on the TCAP oTID and dTID. Because TCAP are session based, a TCAP session based tracking is implemented, to allow following traffic to forwarded to the same ASP. This TCAP session tracking is similar to IP connection tracking. ASPs within an AS can use the new IPA TCAP ROUTING protocol to register for specific TCAP ranges. TCAP sessions initiated by a peer (traffic towards such loadsharing AS/ASP), will use the oTID of the `TCAP Begin` to loadshare and select a ASP. Further if the TCAP session was initiated by a `loadshared` ASP, the oTID will be added to the session tracking. Co-authored-by: Harald Welte <laforge(a)osmocom.org> Co-authored-by: Daniel Willmann <dwillmann(a)sysmocom.de> Related: SYS#5423 Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d --- M configure.ac M src/Makefile.am M src/ipa.c M src/ss7_as.c M src/ss7_as.h A src/ss7_as_loadshare_tcap.c A src/ss7_as_loadshare_tcap.h M src/ss7_as_vty.c M src/ss7_asp.c M src/ss7_asp.h A src/tcap_transaction_tracking.c A src/tcap_transaction_tracking.h M tests/Makefile.am A tests/tcap/Makefile.am A tests/tcap/tcap_transaction_tracking_test.c A tests/tcap/tcap_transaction_tracking_test.ok M tests/testsuite.at M tests/vty/osmo_stp_test.vty 18 files changed, 1,965 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/09/41309/10 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d Gerrit-Change-Number: 41309 Gerrit-PatchSet: 10 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XL] Change in libosmo-sigtran[master]: Add TCAP based loadsharing/routing
by daniel 14 Nov '25

14 Nov '25

Attention is currently required from: laforge, lynxis lazus, pespin. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email ) Change subject: Add TCAP based loadsharing/routing ...................................................................... Patch Set 10: (20 comments) File examples/sccp_demo_user.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/ac650df0_151b4… : PS8, Line 30: void *talloc_asn1_ctx; > If it is required, do you mind explaining why? Doesn't seem obvious to me. It's not required, will remove it File src/ipa.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/f2b47446_acc57… : PS8, Line 360: case IPAC_PROTO_OSMO: > I could move it further upwards. Done https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/d30c31ae_973fc… : PS8, Line 368: if (hh_ext->proto == IPAC_PROTO_EXT_TCAP_ROUTING) { > yes, I can use switch/case there. Should be ok with the ifdef encompassing the whole case. File src/m3ua.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/7238899a_81ed7… : PS8, Line 50: #include "ss7_as_loadshare_tcap.h" > I prefer the style how it is currently. It reduces the usage of #ifdef in the common code. Not needed here, removed https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/5a5b3d3f_9a597… : PS8, Line 343: if (!xua) > Ack. Done File src/ss7_as.h: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/e34133a1_15cd0… : PS8, Line 97: /* optimisation: true if tid_ranges contains PCs (not only wildcards) */ > #ifdef WITH_TCAP_LOADSHARING Done https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/feae522b_d41b7… : PS8, Line 145: /* Should we do load-sharing based on tcap ids? */ > #ifdef WITH_TCAP_LOADSHARING Done File src/ss7_as.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/a6382c8a_30e89… : PS8, Line 139: hash_init(as->tcap.tid_ranges); > #ifdef WITH_TCAP_LOADSHARING Done https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/757b4052_aea76… : PS8, Line 545: case OSMO_SS7_AS_TMOD_LOADSHARE: > This is fine. Done https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/779e6bed_26960… : PS8, Line 634: > Acknowledged Done File src/ss7_as_loadshare_tcap.h: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/ee27e2c7_e8d9d… : PS8, Line 3: #include <complex.h> > I wonder why do we need this here... Acknowledged File src/ss7_as_loadshare_tcap.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/40b30e96_916a3… : PS8, Line 61: return osmo_ntohl(*(uint32_t *)src->buf); > is this always properly aligned? maybe use osmo_load_32be or however it's called? Done https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/e4fc72e4_d93f9… : PS8, Line 72: tcapmsg = talloc_zero(as, struct TCAP_TCMessage); > Can we avoid talloc-allocating a new chunk for every message? Simply "struct TCAP_TCMessage tcapmsg […] Done https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/fcd4dd97_98e33… : PS8, Line 159: static struct osmo_ss7_asp *tcap_hlist_get(struct osmo_ss7_as *as, uint32_t pc, uint8_t ssn, uint32_t tid) > const as? Acknowledged File src/ss7_as_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/6d99e087_6b46c… : PS8, Line 165: "traffic-mode (loadshare|loadshare-tcap) [bindings] [sls] [opc-sls] [opc-shift] [<0-2>]", > traffic-mode loadshare-tcap is an extension to the general loadshare. […] I'm not 100% familiar with the tcap_enable/disable hooks, but wouldn't you need to call tcap_disable in other traffic modes even with the separate command? It's always possible to ``` traffic-mode loadshare tcap-loadshare [...later] traffic-mode roundrobin ``` and then you'd end up in a bad state (if calling tcap_disable is required). File src/ss7_asp.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/87fc4c21_6f047… : PS8, Line 1435: /*! Received an unknown packet on asp > Will look into it. Done File src/ss7_internal.h: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/90db1725_09505… : PS8, Line 9: #include <osmocom/sigtran/mtp_sap.h> > why is this now needed here? if needed, please submit another commit. Done File src/tcap_transaction_tracking.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/87ba06d1_706ae… : PS8, Line 122: LOGPASP(entry->asp, DLSS7, LOGL_DEBUG, "Creating tcap cache, entry (own) pc/ssn/tid %u/%u/%u -> %u/%u/%u\n", > Ack Done File src/xua_as_fsm.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/41902dc8_f40ba… : PS8, Line 204: asp = ss7_as_select_asp(as, xua); > This could actually go in a preparatory patch to simplify this one a bit. Done File stp/stp_main.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/1cba7d0b_e3f6b… : PS8, Line 52: void *talloc_asn1_ctx; > Need to check it again, if it is still required. It's not needed, removed -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d Gerrit-Change-Number: 41309 Gerrit-PatchSet: 10 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 13 Nov 2025 16:47:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in libosmo-sigtran[master]: Add VTY command to list TCAP ranges for an AS
by daniel 14 Nov '25

14 Nov '25

Attention is currently required from: lynxis lazus, pespin. daniel has uploaded a new patch set (#10) to the change originally created by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311?usp=email ) The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Add VTY command to list TCAP ranges for an AS ...................................................................... Add VTY command to list TCAP ranges for an AS Related: SYS#5423 Change-Id: I8026248d9897aadab5bf13a425269ec1e948dfdf --- M src/Makefile.am A src/ss7_as_loadshare_tcap_vty.c A src/ss7_as_loadshare_tcap_vty.h M src/ss7_as_vty.c M src/ss7_vty.c M tests/vty/osmo_stp_test.vty 6 files changed, 154 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/11/41311/10 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8026248d9897aadab5bf13a425269ec1e948dfdf Gerrit-Change-Number: 41311 Gerrit-PatchSet: 10 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in libosmo-sigtran[master]: Add VTY command to list TCAP ranges for an AS
by daniel 14 Nov '25

14 Nov '25

Attention is currently required from: lynxis lazus, pespin. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311?usp=email ) Change subject: Add VTY command to list TCAP ranges for an AS ...................................................................... Patch Set 10: (1 comment) File src/ss7_as_loadshare_tcap_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311/comment/10e37411_07c09… : PS8, Line 50: "show cs7 instance <0-15> as tcap-ranges name AS_NAME", > @dwillmann@sysmocom. […] I chose that way because of "show cs7 instance <0-15> as binding-table name AS_NAME" but the other way around makes mores sense so I'm happy to swap it around. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8026248d9897aadab5bf13a425269ec1e948dfdf Gerrit-Change-Number: 41311 Gerrit-PatchSet: 10 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 13 Nov 2025 16:47:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in libosmo-sigtran[master]: Constify xua_msg in data_hdr_from_m3ua()
by daniel 14 Nov '25

14 Nov '25

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41428?usp=email ) Change subject: Constify xua_msg in data_hdr_from_m3ua() ...................................................................... Constify xua_msg in data_hdr_from_m3ua() Related: SYS#5423 Change-Id: I372054dcb7f153e3ca7c845ce0bd1f558e7bb9fa --- M src/m3ua.c M src/xua_internal.h 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/28/41428/1 diff --git a/src/m3ua.c b/src/m3ua.c index f5030d0..8e93515 100644 --- a/src/m3ua.c +++ b/src/m3ua.c @@ -570,7 +570,7 @@ ***********************************************************************/ /* obtain the destination point code from a M3UA message in XUA fmt * */ -struct m3ua_data_hdr *data_hdr_from_m3ua(struct xua_msg *xua) +struct m3ua_data_hdr *data_hdr_from_m3ua(const struct xua_msg *xua) { struct xua_msg_part *data_ie; struct m3ua_data_hdr *data_hdr; diff --git a/src/xua_internal.h b/src/xua_internal.h index 6cc0d72..36393f3 100644 --- a/src/xua_internal.h +++ b/src/xua_internal.h @@ -64,7 +64,7 @@ struct msgb *m3ua_msgb_alloc(const char *name); struct xua_msg *m3ua_xfer_from_data(const struct m3ua_data_hdr *data_hdr, const uint8_t *data, unsigned int data_len); -struct m3ua_data_hdr *data_hdr_from_m3ua(struct xua_msg *xua); +struct m3ua_data_hdr *data_hdr_from_m3ua(const struct xua_msg *xua); void m3ua_dh_to_xfer_param(struct osmo_mtp_transfer_param *param, const struct m3ua_data_hdr *mdh); void mtp_xfer_param_to_m3ua_dh(struct m3ua_data_hdr *mdh, -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41428?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I372054dcb7f153e3ca7c845ce0bd1f558e7bb9fa Gerrit-Change-Number: 41428 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: ss7_as_select_asp: Pass xua_msg instead of osmo_mtp_transfer_param
by daniel 14 Nov '25

14 Nov '25

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41427?usp=email ) Change subject: ss7_as_select_asp: Pass xua_msg instead of osmo_mtp_transfer_param ...................................................................... ss7_as_select_asp: Pass xua_msg instead of osmo_mtp_transfer_param For TCAP-based loadsharing we need to access the xua_msg. Related: SYS#5423 Change-Id: I9f376cf4078ccf4001400db4d430b36c540a2790 --- M src/ss7_as.c M src/ss7_as.h M src/xua_as_fsm.c 3 files changed, 6 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/27/41427/1 diff --git a/src/ss7_as.c b/src/ss7_as.c index b4eb439..c2dee9d 100644 --- a/src/ss7_as.c +++ b/src/ss7_as.c @@ -42,6 +42,7 @@ #include "ss7_internal.h" #include "xua_as_fsm.h" #include "xua_asp_fsm.h" +#include "xua_msg.h" /*********************************************************************** * SS7 Application Server @@ -517,8 +518,9 @@ * This function returns NULL too if multiple ASPs would be selected, ie. AS is * configured in broadcast mode and more than one ASP is configured. */ -struct osmo_ss7_asp *ss7_as_select_asp(struct osmo_ss7_as *as, const struct osmo_mtp_transfer_param *mtp) +struct osmo_ss7_asp *ss7_as_select_asp(struct osmo_ss7_as *as, const struct xua_msg *xua) { + const struct osmo_mtp_transfer_param *mtp = &xua->mtp; struct osmo_ss7_asp *asp = NULL; switch (as->cfg.mode) { diff --git a/src/ss7_as.h b/src/ss7_as.h index 98151f8..4f5db78 100644 --- a/src/ss7_as.h +++ b/src/ss7_as.h @@ -10,6 +10,7 @@ #include <osmocom/sigtran/osmo_ss7.h> #include "ss7_internal.h" +#include "xua_msg.h" /*********************************************************************** * SS7 Application Server @@ -132,7 +133,7 @@ }; struct osmo_ss7_as *ss7_as_alloc(struct osmo_ss7_instance *inst, const char *name, enum osmo_ss7_asp_protocol proto); -struct osmo_ss7_asp *ss7_as_select_asp(struct osmo_ss7_as *as, const struct osmo_mtp_transfer_param *mtp); +struct osmo_ss7_asp *ss7_as_select_asp(struct osmo_ss7_as *as, const struct xua_msg *xua); unsigned int osmo_ss7_as_count_asp(const struct osmo_ss7_as *as); int ss7_as_add_asp(struct osmo_ss7_as *as, struct osmo_ss7_asp *asp); diff --git a/src/xua_as_fsm.c b/src/xua_as_fsm.c index c39132b..fd44e70 100644 --- a/src/xua_as_fsm.c +++ b/src/xua_as_fsm.c @@ -201,7 +201,7 @@ * strictly required by M3UA RFC, but would fit the overall * principle. */ case OSMO_SS7_AS_TMOD_ROUNDROBIN: - asp = ss7_as_select_asp(as, &xua->mtp); + asp = ss7_as_select_asp(as, xua); break; case OSMO_SS7_AS_TMOD_BCAST: return xua_as_transmit_msg_broadcast(as, xua); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41427?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I9f376cf4078ccf4001400db4d430b36c540a2790 Gerrit-Change-Number: 41427 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>

1 0

[M] Change in osmo-bsc[master]: handover: Move log macros to handover_fsm.h
by matanp 14 Nov '25

14 Nov '25

matanp has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41413?usp=email ) Change subject: handover: Move log macros to handover_fsm.h ...................................................................... handover: Move log macros to handover_fsm.h Change-Id: I65fdde44042b8c4a050aaa07961676c4c18c0431 --- M include/osmocom/bsc/handover_fsm.h M src/osmo-bsc/handover_decision_2.c 2 files changed, 45 insertions(+), 45 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve diff --git a/include/osmocom/bsc/handover_fsm.h b/include/osmocom/bsc/handover_fsm.h index 03a8436..229bf8a 100644 --- a/include/osmocom/bsc/handover_fsm.h +++ b/include/osmocom/bsc/handover_fsm.h @@ -4,6 +4,51 @@ #include <osmocom/bsc/debug.h> #include <osmocom/bsc/handover.h> +#define LOGPHOBTS(bts, level, fmt, args...) \ + LOGP(DHODEC, level, "(BTS %u) " fmt, bts->nr, ## args) + +#define LOGPHOLCHAN(lchan, level, fmt, args...) \ + LOGP(DHODEC, level, "(lchan %u.%u%u%u %s %s) (subscr %s) " fmt, \ + lchan->ts->trx->bts->nr, \ + lchan->ts->trx->nr, \ + lchan->ts->nr, \ + lchan->nr, \ + gsm_chan_t_name(lchan->type), \ + gsm48_chan_mode_name(lchan->current_ch_mode_rate.chan_mode), \ + bsc_subscr_name(lchan->conn ? lchan->conn->bsub : NULL), \ + ## args) + +#define LOGPHOLCHANTOBTS(lchan, new_bts, level, fmt, args...) \ + LOGP(DHODEC, level, "(lchan %u.%u%u%u %s %s)->(BTS %u) (subscr %s) " fmt, \ + lchan->ts->trx->bts->nr, \ + lchan->ts->trx->nr, \ + lchan->ts->nr, \ + lchan->nr, \ + gsm_chan_t_name(lchan->type), \ + gsm48_chan_mode_name(lchan->current_ch_mode_rate.chan_mode), \ + new_bts->nr, \ + bsc_subscr_name(lchan->conn ? lchan->conn->bsub : NULL), \ + ## args) + +#define LOGPHOLCHANTOREMOTE(lchan, remote_cil, level, fmt, args...) \ + LOGP(DHODEC, level, "(lchan %u.%u%u%u %s %s)->(remote-BSS %s) (subscr %s) " fmt, \ + lchan->ts->trx->bts->nr, \ + lchan->ts->trx->nr, \ + lchan->ts->nr, \ + lchan->nr, \ + gsm_chan_t_name(lchan->type), \ + gsm48_chan_mode_name(lchan->current_ch_mode_rate.chan_mode), \ + gsm0808_cell_id_list_name(remote_cil), \ + bsc_subscr_name(lchan->conn ? lchan->conn->bsub : NULL), \ + ## args) + +#define LOGPHOCAND(candidate, level, fmt, args...) do {\ + if ((candidate)->target.bts) \ + LOGPHOLCHANTOBTS((candidate)->current.lchan, (candidate)->target.bts, level, fmt, ## args); \ + else if ((candidate)->target.cell_ids.id_list_len) \ + LOGPHOLCHANTOREMOTE((candidate)->current.lchan, &(candidate)->target.cell_ids, level, fmt, ## args); \ + } while (0) + /* Terminology: * Intra-Cell: stays within one BTS, this should actually be an Assignment. * Intra-BSC: stays within one BSC, but moves between BTSes. diff --git a/src/osmo-bsc/handover_decision_2.c b/src/osmo-bsc/handover_decision_2.c index 073e013..204c438 100644 --- a/src/osmo-bsc/handover_decision_2.c +++ b/src/osmo-bsc/handover_decision_2.c @@ -44,51 +44,6 @@ #include <osmocom/bsc/lchan_select.h> #include <osmocom/bsc/chan_counts.h> -#define LOGPHOBTS(bts, level, fmt, args...) \ - LOGP(DHODEC, level, "(BTS %u) " fmt, bts->nr, ## args) - -#define LOGPHOLCHAN(lchan, level, fmt, args...) \ - LOGP(DHODEC, level, "(lchan %u.%u%u%u %s %s) (subscr %s) " fmt, \ - lchan->ts->trx->bts->nr, \ - lchan->ts->trx->nr, \ - lchan->ts->nr, \ - lchan->nr, \ - gsm_chan_t_name(lchan->type), \ - gsm48_chan_mode_name(lchan->current_ch_mode_rate.chan_mode), \ - bsc_subscr_name(lchan->conn? lchan->conn->bsub : NULL), \ - ## args) - -#define LOGPHOLCHANTOBTS(lchan, new_bts, level, fmt, args...) \ - LOGP(DHODEC, level, "(lchan %u.%u%u%u %s %s)->(BTS %u) (subscr %s) " fmt, \ - lchan->ts->trx->bts->nr, \ - lchan->ts->trx->nr, \ - lchan->ts->nr, \ - lchan->nr, \ - gsm_chan_t_name(lchan->type), \ - gsm48_chan_mode_name(lchan->current_ch_mode_rate.chan_mode), \ - new_bts->nr, \ - bsc_subscr_name(lchan->conn? lchan->conn->bsub : NULL), \ - ## args) - -#define LOGPHOLCHANTOREMOTE(lchan, remote_cil, level, fmt, args...) \ - LOGP(DHODEC, level, "(lchan %u.%u%u%u %s %s)->(remote-BSS %s) (subscr %s) " fmt, \ - lchan->ts->trx->bts->nr, \ - lchan->ts->trx->nr, \ - lchan->ts->nr, \ - lchan->nr, \ - gsm_chan_t_name(lchan->type), \ - gsm48_chan_mode_name(lchan->current_ch_mode_rate.chan_mode), \ - gsm0808_cell_id_list_name(remote_cil), \ - bsc_subscr_name(lchan->conn? lchan->conn->bsub : NULL), \ - ## args) - -#define LOGPHOCAND(candidate, level, fmt, args...) do {\ - if ((candidate)->target.bts) \ - LOGPHOLCHANTOBTS((candidate)->current.lchan, (candidate)->target.bts, level, fmt, ## args); \ - else if ((candidate)->target.cell_ids.id_list_len) \ - LOGPHOLCHANTOREMOTE((candidate)->current.lchan, &(candidate)->target.cell_ids, level, fmt, ## args); \ - } while (0) - #define REQUIREMENT_A_TCHF 0x01 #define REQUIREMENT_B_TCHF 0x02 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41413?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I65fdde44042b8c4a050aaa07961676c4c18c0431 Gerrit-Change-Number: 41413 Gerrit-PatchSet: 2 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-bsc[master]: handover_decision_2: Drop unused include
by matanp 14 Nov '25

14 Nov '25

matanp has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41414?usp=email ) Change subject: handover_decision_2: Drop unused include ...................................................................... handover_decision_2: Drop unused include Change-Id: I599d9f92b29258ee17672a973a37aa1aab3971bf --- M src/osmo-bsc/handover_decision_2.c 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/handover_decision_2.c b/src/osmo-bsc/handover_decision_2.c index 204c438..5309699 100644 --- a/src/osmo-bsc/handover_decision_2.c +++ b/src/osmo-bsc/handover_decision_2.c @@ -31,7 +31,6 @@ #include <osmocom/bsc/gsm_data.h> #include <osmocom/bsc/assignment_fsm.h> #include <osmocom/bsc/handover_fsm.h> -#include <osmocom/bsc/handover_decision.h> #include <osmocom/bsc/handover_decision_2.h> #include <osmocom/bsc/handover_cfg.h> #include <osmocom/bsc/bsc_subscriber.h> -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41414?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I599d9f92b29258ee17672a973a37aa1aab3971bf Gerrit-Change-Number: 41414 Gerrit-PatchSet: 2 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: cosmetic: SCCP_Test/SCCP_Testcases.{cfg,ttcn}: Fix trailing whitespace
by pespin 14 Nov '25

14 Nov '25

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41425?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: cosmetic: SCCP_Test/SCCP_Testcases.{cfg,ttcn}: Fix trailing whitespace ...................................................................... cosmetic: SCCP_Test/SCCP_Testcases.{cfg,ttcn}: Fix trailing whitespace Change-Id: I17140056c40305a8eb8024df5403897d0853098e --- M SCCP_Test/SCCP_Testcases.cfg M SCCP_Test/SCCP_Testcases.ttcn 2 files changed, 94 insertions(+), 94 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/25/41425/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41425?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I17140056c40305a8eb8024df5403897d0853098e Gerrit-Change-Number: 41425 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

2026

2025

2024

2023

2022

gerrit-log November 2025