November 2025 - gerrit-log - lists.osmocom.org

[XS] Change in libosmo-asn1-tcap[master]: libosmo-asn1-tcap.pc.in: fix include path in Cflags
by pespin 06 Nov '25

06 Nov '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41374?usp=email ) Change subject: libosmo-asn1-tcap.pc.in: fix include path in Cflags ...................................................................... libosmo-asn1-tcap.pc.in: fix include path in Cflags Including header files from this library like this: #include <osmocom/tcap/OCTET_STRING.h> #include <osmocom/tcap/TCAP_TCMessage.h> currently fails if libosmo-asn1-tcap is installed to a non-standard location (other than /usr/include/). The reason is that this file tells the compiler to use the following include path: -I${includedir}/osmocom/tcap/ so the compiler will be looking for headers in there: ${includedir}/osmocom/tcap/osmocom/tcap/OCTET_STRING.h ${includedir}/osmocom/tcap/osmocom/tcap/TCAP_TCMessage.h This is wrong and will obviously fail. Let's use `-I${includedir}/` - this is what most of the Osmocom libraries specify in their `*.pc.in`. Change-Id: If65c43a34fd100ce712457dcf91abe2a8e49b7d2 Fixes: c454c74 ("Regenerate code with newer asn1c") Related: SYS#5423 --- M libosmo-asn1-tcap.pc.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/libosmo-asn1-tcap.pc.in b/libosmo-asn1-tcap.pc.in index 490dd41..17971a1 100644 --- a/libosmo-asn1-tcap.pc.in +++ b/libosmo-asn1-tcap.pc.in @@ -7,4 +7,4 @@ Description: C Utility Library Version: @VERSION@ Libs: -L${libdir} -losmo-asn1-tcap -Cflags: -I${includedir}/osmocom/tcap/ +Cflags: -I${includedir}/ -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41374?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: If65c43a34fd100ce712457dcf91abe2a8e49b7d2 Gerrit-Change-Number: 41374 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-asn1-tcap[master]: libosmo-asn1-tcap.pc.in: fix include path in Cflags
by pespin 06 Nov '25

06 Nov '25

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41374?usp=email ) Change subject: libosmo-asn1-tcap.pc.in: fix include path in Cflags ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41374?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: If65c43a34fd100ce712457dcf91abe2a8e49b7d2 Gerrit-Change-Number: 41374 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Nov 2025 20:43:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-asn1-tcap[master]: libosmo-asn1-tcap.pc.in: fix include path in Cflags
by fixeria 06 Nov '25

06 Nov '25

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41374?usp=email ) Change subject: libosmo-asn1-tcap.pc.in: fix include path in Cflags ...................................................................... libosmo-asn1-tcap.pc.in: fix include path in Cflags Including header files from this library like this: #include <osmocom/tcap/OCTET_STRING.h> #include <osmocom/tcap/TCAP_TCMessage.h> currently fails if libosmo-asn1-tcap is installed to a non-standard location (other than /usr/include/). The reason is that this file tells the compiler to use the following include path: -I${includedir}/osmocom/tcap/ so the compiler will be looking for headers in there: ${includedir}/osmocom/tcap/osmocom/tcap/OCTET_STRING.h ${includedir}/osmocom/tcap/osmocom/tcap/TCAP_TCMessage.h This is wrong and will obviously fail. Let's use `-I${includedir}/` - this is what most of the Osmocom libraries specify in their `*.pc.in`. Change-Id: If65c43a34fd100ce712457dcf91abe2a8e49b7d2 Fixes: c454c74 ("Regenerate code with newer asn1c") Related: SYS#5423 --- M libosmo-asn1-tcap.pc.in 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-asn1-tcap refs/changes/74/41374/1 diff --git a/libosmo-asn1-tcap.pc.in b/libosmo-asn1-tcap.pc.in index 490dd41..17971a1 100644 --- a/libosmo-asn1-tcap.pc.in +++ b/libosmo-asn1-tcap.pc.in @@ -7,4 +7,4 @@ Description: C Utility Library Version: @VERSION@ Libs: -L${libdir} -losmo-asn1-tcap -Cflags: -I${includedir}/osmocom/tcap/ +Cflags: -I${includedir}/ -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41374?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: If65c43a34fd100ce712457dcf91abe2a8e49b7d2 Gerrit-Change-Number: 41374 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: fixup! build-system: depend on libosmo-asn1-tcap
by fixeria 06 Nov '25

06 Nov '25

fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41373?usp=email ) Change subject: fixup! build-system: depend on libosmo-asn1-tcap ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41373?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I9e6eec418a356f4e72acc03275c5c57261733323 Gerrit-Change-Number: 41373 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[XS] Change in libosmo-sigtran[master]: fixup! build-system: depend on libosmo-asn1-tcap
by fixeria 06 Nov '25

06 Nov '25

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41373?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: fixup! build-system: depend on libosmo-asn1-tcap ...................................................................... fixup! build-system: depend on libosmo-asn1-tcap Change-Id: I9e6eec418a356f4e72acc03275c5c57261733323 --- M contrib/jenkins.sh 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/73/41373/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41373?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I9e6eec418a356f4e72acc03275c5c57261733323 Gerrit-Change-Number: 41373 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: fixup! build-system: depend on libosmo-asn1-tcap
by fixeria 06 Nov '25

06 Nov '25

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41373?usp=email ) Change subject: fixup! build-system: depend on libosmo-asn1-tcap ...................................................................... fixup! build-system: depend on libosmo-asn1-tcap Change-Id: I9e6eec418a356f4e72acc03275c5c57261733323 --- M contrib/jenkins.sh 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/73/41373/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 5e92595..f43b4ba 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -59,6 +59,8 @@ make -C "$base/doc/manuals" publish fi +$MAKE $PARALLEL_MAKE maintainer-clean + set +x echo echo @@ -70,7 +72,7 @@ ./configure --enable-sanitize --enable-werror --enable-external-tests --enable-tcap-loadsharing $CONFIG $MAKE $PARALLEL_MAKE $MAKE $PARALLEL_MAKE check || cat-testlogs.sh -DISTCHECK_CONFIGURE_FLAGS="--enable-external-tests $CONFIG" \ +DISTCHECK_CONFIGURE_FLAGS="--enable-external-tests --enable-tcap-loadsharing $CONFIG" \ $MAKE $PARALLEL_MAKE distcheck \ || cat-testlogs.sh -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41373?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I9e6eec418a356f4e72acc03275c5c57261733323 Gerrit-Change-Number: 41373 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: tests/testsuite.at: fix invalid if-endif syntax
by lynxis lazus 06 Nov '25

06 Nov '25

Attention is currently required from: fixeria. lynxis lazus has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/41362?usp=email ) Change subject: tests/testsuite.at: fix invalid if-endif syntax ...................................................................... Patch Set 1: (1 comment) File tests/testsuite.at: https://gerrit.osmocom.org/c/libosmocore/+/41362/comment/74538698_b27baf09?… : PS1, Line 86: AT_SKIP_IF([test ! -e $abs_top_builddir/tests/msgfile/msgfile_test]) > @pespin@sysmocom.de if you grep for `ENABLE_URING`, for instance: […] I would like in general spent more time on a different build system, than trying to debug the current one. Spent already so much time again in this one. (not related to this commit, but to sigtran build system problems). -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41362?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I81e044dc0bda4674c0d0dc46118d46816712a76c Gerrit-Change-Number: 41362 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Nov 2025 18:18:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: Revert "epdg: add sleep to f_TC_hss_initiated_deregister_permanent_te...
by pespin 06 Nov '25

06 Nov '25

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41304?usp=email ) Change subject: Revert "epdg: add sleep to f_TC_hss_initiated_deregister_permanent_termination" ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I plan to merge this one tomorrow, after the osmo-epdg patches are for sure being incorporated when running the ttcn3 testsuite. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41304?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I900394cb02c1ff7ea85aaba6ef29a64fd84f679c Gerrit-Change-Number: 41304 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Nov 2025 17:24:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-ttcn3-hacks[master]: hlr: testenv: fix running pyhss from debian pkg
by fixeria 06 Nov '25

06 Nov '25

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41372?usp=email ) Change subject: hlr: testenv: fix running pyhss from debian pkg ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41372?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0cdf1a9f220ddd2ef0866d0d11d1e3f6056a1cba Gerrit-Change-Number: 41372 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Nov 2025 16:37:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: hlr: testenv: fix running pyhss from debian pkg
by pespin 06 Nov '25

06 Nov '25

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41372?usp=email ) Change subject: hlr: testenv: fix running pyhss from debian pkg ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41372?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0cdf1a9f220ddd2ef0866d0d11d1e3f6056a1cba Gerrit-Change-Number: 41372 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Nov 2025 15:46:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2025

2024

2023

2022

gerrit-log November 2025