November 2025 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: Configure all ttcn-3 SCCP endpoints to match IUT ss7 network-indicator
by laforge 14 Nov '25

14 Nov '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41426?usp=email ) Change subject: Configure all ttcn-3 SCCP endpoints to match IUT ss7 network-indicator ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41426?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I32d36dbb294632c340df3dba2a0f249189449699 Gerrit-Change-Number: 41426 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Nov 2025 19:02:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: Configure all ttcn-3 SCCP endpoints to match IUT ss7 network-indicator
by laforge 14 Nov '25

14 Nov '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41426?usp=email ) Change subject: Configure all ttcn-3 SCCP endpoints to match IUT ss7 network-indicator ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: it was intentional that osmocom software uses international by default (as that's the only one standardized to use ITU SS7, while "national" can mean many different national flavours of SS7 including ANSI, which we never implemented. The test suites have been wrong and should be fixed with a patch like this. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41426?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I32d36dbb294632c340df3dba2a0f249189449699 Gerrit-Change-Number: 41426 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Nov 2025 19:02:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: Configure all ttcn-3 SCCP endpoints to match IUT ss7 network-indicator
by pespin 14 Nov '25

14 Nov '25

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41426?usp=email ) Change subject: Configure all ttcn-3 SCCP endpoints to match IUT ss7 network-indicator ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: @laforge@gnumonks.org I see a problem here: Cisco ITP manual states "national" (10) is the default, but we so far have been setting no explicit default in code during ss7_instance_alloc(), which means our defualt is "international" (00). So we either: * keep our own default as "international" (00) different from Cisco ITP and merge this commit as presented now. * Change our default to be "national" (10) in libosmo-sigtran and adapt this commit to make sure we use sio "83" everywhere instead of "03". -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41426?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I32d36dbb294632c340df3dba2a0f249189449699 Gerrit-Change-Number: 41426 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 13 Nov 2025 17:21:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in libosmo-sigtran[master]: mtp: Introduce osmo_ss7_user_find_by_si() public API
by pespin 14 Nov '25

14 Nov '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41429?usp=email ) Change subject: mtp: Introduce osmo_ss7_user_find_by_si() public API ...................................................................... mtp: Introduce osmo_ss7_user_find_by_si() public API This is needed by mtp_sap/ss7_user API users to figure out whether there's a user set up already for a given Service Indicator. Change-Id: I7db659dc443148f3aab70d2c6229c2271346cf38 --- M TODO-RELEASE M include/osmocom/sigtran/osmo_ss7.h M src/ss7_hmrt.c M src/ss7_user.c M src/ss7_user.h M src/xua_snm.c 6 files changed, 5 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/29/41429/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index 28aed5b..8a42b9c 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -12,3 +12,4 @@ libosmo-sigtran add osmo_ss7_instance_get_network_indicator() libosmo-sigtran add osmo_ss7_user_mtp_sap_prim_down() libosmo-sigtran add osmo_mtp_prim_xfer_req_prepend() +libosmo-sigtran add osmo_ss7_user_find_by_si() diff --git a/include/osmocom/sigtran/osmo_ss7.h b/include/osmocom/sigtran/osmo_ss7.h index b560caf..9ea929f 100644 --- a/include/osmocom/sigtran/osmo_ss7.h +++ b/include/osmocom/sigtran/osmo_ss7.h @@ -95,6 +95,7 @@ int osmo_ss7_user_register(struct osmo_ss7_user *user, uint8_t service_ind); int osmo_ss7_user_unregister(struct osmo_ss7_user *user, uint8_t service_ind); +struct osmo_ss7_user *osmo_ss7_user_find_by_si(const struct osmo_ss7_instance *inst, uint8_t service_indicator); /* MTP User wants to submit a primitive down to MTP SAP */ int osmo_ss7_user_mtp_sap_prim_down(struct osmo_ss7_user *user, diff --git a/src/ss7_hmrt.c b/src/ss7_hmrt.c index 81a56a8..72b26d8 100644 --- a/src/ss7_hmrt.c +++ b/src/ss7_hmrt.c @@ -123,7 +123,7 @@ } /* "User Part Available?" */ - osu = ss7_user_find(inst, service_ind); + osu = osmo_ss7_user_find_by_si(inst, service_ind); if (!osu) { /* "Discard Message" */ LOGSS7(inst, LOGL_NOTICE, "No MTP-User for SI %u\n", service_ind); diff --git a/src/ss7_user.c b/src/ss7_user.c index 0ec42ff..7137b7a 100644 --- a/src/ss7_user.c +++ b/src/ss7_user.c @@ -54,7 +54,7 @@ talloc_free(user); } -struct osmo_ss7_user *ss7_user_find(struct osmo_ss7_instance *inst, uint8_t service_indicator) +struct osmo_ss7_user *osmo_ss7_user_find_by_si(const struct osmo_ss7_instance *inst, uint8_t service_indicator) { if (service_indicator >= ARRAY_SIZE(inst->user)) return NULL; diff --git a/src/ss7_user.h b/src/ss7_user.h index bec6c22..25259e8 100644 --- a/src/ss7_user.h +++ b/src/ss7_user.h @@ -23,7 +23,6 @@ void *priv; }; -struct osmo_ss7_user *ss7_user_find(struct osmo_ss7_instance *inst, uint8_t service_indicator); void ss7_user_unregister_all(struct osmo_ss7_user *user); int ss7_user_mtp_sap_prim_up(const struct osmo_ss7_user *osu, struct osmo_mtp_prim *omp); diff --git a/src/xua_snm.c b/src/xua_snm.c index 4890f79..efa7e91 100644 --- a/src/xua_snm.c +++ b/src/xua_snm.c @@ -309,7 +309,7 @@ unsigned int num_rctx; /* Translate to MTP-STATUS.ind towards MTP-User (SCCP will create N-PCSTATE.ind to SCU) */ - osu = ss7_user_find(s7i, user); + osu = osmo_ss7_user_find_by_si(s7i, user); if (osu) { struct osmo_mtp_prim *omp = mtp_prim_status_ind_alloc(dpc, cause, false, 0); ss7_user_mtp_sap_prim_up(osu, omp); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41429?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I7db659dc443148f3aab70d2c6229c2271346cf38 Gerrit-Change-Number: 41429 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: Constify xua_msg in data_hdr_from_m3ua()
by pespin 14 Nov '25

14 Nov '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41428?usp=email ) Change subject: Constify xua_msg in data_hdr_from_m3ua() ...................................................................... Constify xua_msg in data_hdr_from_m3ua() Related: SYS#5423 Change-Id: I372054dcb7f153e3ca7c845ce0bd1f558e7bb9fa --- M src/m3ua.c M src/xua_internal.h 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/m3ua.c b/src/m3ua.c index f5030d0..8e93515 100644 --- a/src/m3ua.c +++ b/src/m3ua.c @@ -570,7 +570,7 @@ ***********************************************************************/ /* obtain the destination point code from a M3UA message in XUA fmt * */ -struct m3ua_data_hdr *data_hdr_from_m3ua(struct xua_msg *xua) +struct m3ua_data_hdr *data_hdr_from_m3ua(const struct xua_msg *xua) { struct xua_msg_part *data_ie; struct m3ua_data_hdr *data_hdr; diff --git a/src/xua_internal.h b/src/xua_internal.h index 6cc0d72..36393f3 100644 --- a/src/xua_internal.h +++ b/src/xua_internal.h @@ -64,7 +64,7 @@ struct msgb *m3ua_msgb_alloc(const char *name); struct xua_msg *m3ua_xfer_from_data(const struct m3ua_data_hdr *data_hdr, const uint8_t *data, unsigned int data_len); -struct m3ua_data_hdr *data_hdr_from_m3ua(struct xua_msg *xua); +struct m3ua_data_hdr *data_hdr_from_m3ua(const struct xua_msg *xua); void m3ua_dh_to_xfer_param(struct osmo_mtp_transfer_param *param, const struct m3ua_data_hdr *mdh); void mtp_xfer_param_to_m3ua_dh(struct m3ua_data_hdr *mdh, -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41428?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I372054dcb7f153e3ca7c845ce0bd1f558e7bb9fa Gerrit-Change-Number: 41428 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: ss7_as_select_asp: Pass xua_msg instead of osmo_mtp_transfer_param
by pespin 14 Nov '25

14 Nov '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41427?usp=email ) Change subject: ss7_as_select_asp: Pass xua_msg instead of osmo_mtp_transfer_param ...................................................................... ss7_as_select_asp: Pass xua_msg instead of osmo_mtp_transfer_param For TCAP-based loadsharing we need to access the xua_msg. Related: SYS#5423 Change-Id: I9f376cf4078ccf4001400db4d430b36c540a2790 --- M src/ss7_as.c M src/ss7_as.h M src/xua_as_fsm.c 3 files changed, 6 insertions(+), 3 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/ss7_as.c b/src/ss7_as.c index b4eb439..c2dee9d 100644 --- a/src/ss7_as.c +++ b/src/ss7_as.c @@ -42,6 +42,7 @@ #include "ss7_internal.h" #include "xua_as_fsm.h" #include "xua_asp_fsm.h" +#include "xua_msg.h" /*********************************************************************** * SS7 Application Server @@ -517,8 +518,9 @@ * This function returns NULL too if multiple ASPs would be selected, ie. AS is * configured in broadcast mode and more than one ASP is configured. */ -struct osmo_ss7_asp *ss7_as_select_asp(struct osmo_ss7_as *as, const struct osmo_mtp_transfer_param *mtp) +struct osmo_ss7_asp *ss7_as_select_asp(struct osmo_ss7_as *as, const struct xua_msg *xua) { + const struct osmo_mtp_transfer_param *mtp = &xua->mtp; struct osmo_ss7_asp *asp = NULL; switch (as->cfg.mode) { diff --git a/src/ss7_as.h b/src/ss7_as.h index 98151f8..4f5db78 100644 --- a/src/ss7_as.h +++ b/src/ss7_as.h @@ -10,6 +10,7 @@ #include <osmocom/sigtran/osmo_ss7.h> #include "ss7_internal.h" +#include "xua_msg.h" /*********************************************************************** * SS7 Application Server @@ -132,7 +133,7 @@ }; struct osmo_ss7_as *ss7_as_alloc(struct osmo_ss7_instance *inst, const char *name, enum osmo_ss7_asp_protocol proto); -struct osmo_ss7_asp *ss7_as_select_asp(struct osmo_ss7_as *as, const struct osmo_mtp_transfer_param *mtp); +struct osmo_ss7_asp *ss7_as_select_asp(struct osmo_ss7_as *as, const struct xua_msg *xua); unsigned int osmo_ss7_as_count_asp(const struct osmo_ss7_as *as); int ss7_as_add_asp(struct osmo_ss7_as *as, struct osmo_ss7_asp *asp); diff --git a/src/xua_as_fsm.c b/src/xua_as_fsm.c index c39132b..fd44e70 100644 --- a/src/xua_as_fsm.c +++ b/src/xua_as_fsm.c @@ -201,7 +201,7 @@ * strictly required by M3UA RFC, but would fit the overall * principle. */ case OSMO_SS7_AS_TMOD_ROUNDROBIN: - asp = ss7_as_select_asp(as, &xua->mtp); + asp = ss7_as_select_asp(as, xua); break; case OSMO_SS7_AS_TMOD_BCAST: return xua_as_transmit_msg_broadcast(as, xua); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41427?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I9f376cf4078ccf4001400db4d430b36c540a2790 Gerrit-Change-Number: 41427 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: ss7_as_select_asp: Pass xua_msg instead of osmo_mtp_transfer_param
by pespin 14 Nov '25

14 Nov '25

Attention is currently required from: daniel. pespin has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41427?usp=email ) Change subject: ss7_as_select_asp: Pass xua_msg instead of osmo_mtp_transfer_param ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41427?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I9f376cf4078ccf4001400db4d430b36c540a2790 Gerrit-Change-Number: 41427 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Nov 2025 16:51:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: Constify xua_msg in data_hdr_from_m3ua()
by pespin 14 Nov '25

14 Nov '25

Attention is currently required from: daniel. pespin has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41428?usp=email ) Change subject: Constify xua_msg in data_hdr_from_m3ua() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41428?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I372054dcb7f153e3ca7c845ce0bd1f558e7bb9fa Gerrit-Change-Number: 41428 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Nov 2025 16:51:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: Add VTY command to list TCAP ranges for an AS
by pespin 14 Nov '25

14 Nov '25

Attention is currently required from: daniel, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311?usp=email ) Change subject: Add VTY command to list TCAP ranges for an AS ...................................................................... Patch Set 10: (1 comment) File src/ss7_as_loadshare_tcap_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311/comment/aca07250_5f709… : PS8, Line 50: "show cs7 instance <0-15> as tcap-ranges name AS_NAME", > I chose that way because of […] I see this syntax is the currently used everywhere (grep for "show cs7 instance <0-15> as" in code), so let's keep it this way then. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8026248d9897aadab5bf13a425269ec1e948dfdf Gerrit-Change-Number: 41311 Gerrit-PatchSet: 10 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 13 Nov 2025 16:51:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in libosmo-sigtran[master]: Add VTY command to list TCAP ranges for an AS
by daniel 14 Nov '25

14 Nov '25

Attention is currently required from: lynxis lazus, pespin. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311?usp=email ) Change subject: Add VTY command to list TCAP ranges for an AS ...................................................................... Patch Set 10: (1 comment) File tests/vty/osmo_stp_test.vty: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311/comment/ebc1a3f7_22df3… : PS10, Line 21: show cs7 instance <0-15> as name AS_NAME tcap-ranges tid TID This still needs some way to test a different file depending on whether HAVE_TCAP_ROUTING is defined or not -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8026248d9897aadab5bf13a425269ec1e948dfdf Gerrit-Change-Number: 41311 Gerrit-PatchSet: 10 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 13 Nov 2025 16:50:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

2026

2025

2024

2023

2022

gerrit-log November 2025