November 2025 - gerrit-log - lists.osmocom.org

[S] Change in ...pyosmocom[master]: Fix lint errors: don't use star imports
by pespin 07 Nov '25

07 Nov '25

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/41384?usp=email ) Change subject: Fix lint errors: don't use star imports ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/41384?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I0ca76a40d47f72635682de9303ff73e9b2197266 Gerrit-Change-Number: 41384 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 07 Nov 2025 15:20:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...pyosmocom[master]: Fix lint errors: do not use bare except
by pespin 07 Nov '25

07 Nov '25

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/41383?usp=email ) Change subject: Fix lint errors: do not use bare except ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/41383?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: Ia5fe852b6d990ad728fc3dedc7012c8fced92e13 Gerrit-Change-Number: 41383 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 07 Nov 2025 15:19:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in ...pyosmocom[master]: Fix lint errors: remove unnecessary semicolons
by pespin 07 Nov '25

07 Nov '25

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/41382?usp=email ) Change subject: Fix lint errors: remove unnecessary semicolons ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/41382?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I8c8586476d12461d555a2278ef936256944c9cde Gerrit-Change-Number: 41382 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 07 Nov 2025 15:19:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...pyosmocom[master]: Fix lint errors: unused imports
by pespin 07 Nov '25

07 Nov '25

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/41381?usp=email ) Change subject: Fix lint errors: unused imports ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/41381?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: Ie71039d05e9a7cc8b65543c9475b35adcb458f7e Gerrit-Change-Number: 41381 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 07 Nov 2025 15:19:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...pyosmocom[master]: README: mention the pypi package
by pespin 07 Nov '25

07 Nov '25

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/41380?usp=email ) Change subject: README: mention the pypi package ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/41380?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: Iac6fcbc1b5f0caa4cf63de5b8effe46d731080bc Gerrit-Change-Number: 41380 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 07 Nov 2025 15:18:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: lint/lint_diff: test_ruff: add pyosmocom
by osmith 07 Nov '25

07 Nov '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/41387?usp=email ) Change subject: lint/lint_diff: test_ruff: add pyosmocom ...................................................................... lint/lint_diff: test_ruff: add pyosmocom Ruff is very fast and detects some additional things that pylint (which is already used with pyosmocom) does not. Depends: pyosmocom I2ca3135f1ce38dcc06dc95c38f4b6258a60121cd Change-Id: I2fdb36c79efbd0f0fb4bdce3cd0045bb35d4cf64 --- M lint/lint_diff.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/87/41387/1 diff --git a/lint/lint_diff.sh b/lint/lint_diff.sh index d76d951..6d8c64b 100755 --- a/lint/lint_diff.sh +++ b/lint/lint_diff.sh @@ -85,6 +85,7 @@ osmo-ci osmo-dev osmo-ttcn3-hacks + pyosmocom " local format_projects=" osmo-ttcn3-hacks -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41387?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I2fdb36c79efbd0f0fb4bdce3cd0045bb35d4cf64 Gerrit-Change-Number: 41387 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in ...pyosmocom[master]: Fix lint errors: remove unnecessary semicolons
by osmith 07 Nov '25

07 Nov '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/41382?usp=email ) Change subject: Fix lint errors: remove unnecessary semicolons ...................................................................... Fix lint errors: remove unnecessary semicolons Change-Id: I8c8586476d12461d555a2278ef936256944c9cde --- M src/osmocom/construct.py M tests/test_tlv.py 2 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/python/pyosmocom refs/changes/82/41382/1 diff --git a/src/osmocom/construct.py b/src/osmocom/construct.py index a7e5f41..d312e07 100644 --- a/src/osmocom/construct.py +++ b/src/osmocom/construct.py @@ -462,7 +462,7 @@ if self.steps == []: return obj else: - return obj_step_aligned; + return obj_step_aligned class StripHeaderAdapter(Adapter): """ @@ -505,7 +505,7 @@ if self.steps == []: return obj else: - return obj_step_aligned; + return obj_step_aligned def filter_dict(d, exclude_prefix='_'): """filter the input dict to ensure no keys starting with 'exclude_prefix' remain.""" diff --git a/tests/test_tlv.py b/tests/test_tlv.py index 894ef63..3af1e07 100755 --- a/tests/test_tlv.py +++ b/tests/test_tlv.py @@ -45,7 +45,7 @@ self.assertEqual(bertlv_parse_len(b'\x83\x12\x34\x56\x78'), (0x123456, b'\x78')) def test_BerTlvParseOne(self): - res = bertlv_parse_one(b'\x81\x01\x01'); + res = bertlv_parse_one(b'\x81\x01\x01') self.assertEqual(res, ({'tag':1, 'constructed':False, 'class':2}, 1, b'\x01', b'')) class TestComprTlv(unittest.TestCase): @@ -127,7 +127,7 @@ class XC_constr_class(Transcodable): _construct = Int8ub def __init__(self): - super().__init__(); + super().__init__() def test_XC_constr_class(self): """Transcodable derived class with _construct class variable""" @@ -137,7 +137,7 @@ class XC_constr_instance(Transcodable): def __init__(self): - super().__init__(); + super().__init__() self._construct = Int8ub def test_XC_constr_instance(self): @@ -148,7 +148,7 @@ class XC_method_instance(Transcodable): def __init__(self): - super().__init__(); + super().__init__() def _from_bytes(self, do): return ('decoded', do) def _to_bytes(self): -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/41382?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I8c8586476d12461d555a2278ef936256944c9cde Gerrit-Change-Number: 41382 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in ...pyosmocom[master]: Fix lint errors: unused imports
by osmith 07 Nov '25

07 Nov '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/41381?usp=email ) Change subject: Fix lint errors: unused imports ...................................................................... Fix lint errors: unused imports This is the first patch in a series to address everything found with "ruff check", so we can run it in CI (additionally to pylint) and locally as pre-commit hook. Change-Id: Ie71039d05e9a7cc8b65543c9475b35adcb458f7e --- M src/osmocom/construct.py M src/osmocom/gsmtap.py M src/osmocom/gsup/message.py 3 files changed, 1 insertion(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/python/pyosmocom refs/changes/81/41381/1 diff --git a/src/osmocom/construct.py b/src/osmocom/construct.py index 5e062c3..a7e5f41 100644 --- a/src/osmocom/construct.py +++ b/src/osmocom/construct.py @@ -4,7 +4,6 @@ import codecs import ipaddress -import gsm0338 # pylint: disable=import-error,no-name-in-module diff --git a/src/osmocom/gsmtap.py b/src/osmocom/gsmtap.py index f21ba03..60d7ee4 100644 --- a/src/osmocom/gsmtap.py +++ b/src/osmocom/gsmtap.py @@ -23,7 +23,6 @@ # import socket -from construct import Optional as COptional from construct import Int8ub, Int8sb, Int32ub, BitStruct, Enum, GreedyBytes, Struct, Switch from construct import this, PaddedString, Flag, BitsInteger, Bytes from osmocom.construct import * diff --git a/src/osmocom/gsup/message.py b/src/osmocom/gsup/message.py index e48cd54..31fab2c 100644 --- a/src/osmocom/gsup/message.py +++ b/src/osmocom/gsup/message.py @@ -30,7 +30,7 @@ from construct import Optional as COptional from osmocom.tlv import TLV_IE, TLV_IE_Collection -from osmocom.construct import TonNpi, Rpad, OsmoRatType +from osmocom.construct import TonNpi, OsmoRatType from osmocom.construct import PaddedBcdAdapter, DnsAdapter, Ipv4Adapter, Ipv6Adapter class GSUP_TLV_IE(TLV_IE): -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/41381?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: Ie71039d05e9a7cc8b65543c9475b35adcb458f7e Gerrit-Change-Number: 41381 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in ...pyosmocom[master]: Fix lint errors: do not use bare except
by osmith 07 Nov '25

07 Nov '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/41383?usp=email ) Change subject: Fix lint errors: do not use bare except ...................................................................... Fix lint errors: do not use bare except src/osmocom/construct.py:90:9: E722 Do not use bare `except` | 88 | ad = GsmString(GreedyBytes) 89 | return ad._encode(obj, context, path) 90 | except: | ^^^^^^ E722 91 | ad = Ucs2Adapter(GreedyBytes) 92 | return ad._encode(obj, context, path) Change-Id: Ia5fe852b6d990ad728fc3dedc7012c8fced92e13 --- M src/osmocom/construct.py M src/osmocom/utils.py 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/python/pyosmocom refs/changes/83/41383/1 diff --git a/src/osmocom/construct.py b/src/osmocom/construct.py index d312e07..643f314 100644 --- a/src/osmocom/construct.py +++ b/src/osmocom/construct.py @@ -87,7 +87,7 @@ try: ad = GsmString(GreedyBytes) return ad._encode(obj, context, path) - except: + except Exception: ad = Ucs2Adapter(GreedyBytes) return ad._encode(obj, context, path) diff --git a/src/osmocom/utils.py b/src/osmocom/utils.py index 347bb93..3991da2 100644 --- a/src/osmocom/utils.py +++ b/src/osmocom/utils.py @@ -209,7 +209,7 @@ try: _try_encode = h2b(string) return True - except: + except Exception: return False ######################################################################### -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/41383?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: Ia5fe852b6d990ad728fc3dedc7012c8fced92e13 Gerrit-Change-Number: 41383 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in ...pyosmocom[master]: Fix lint errors: don't use star imports
by osmith 07 Nov '25

07 Nov '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/41384?usp=email ) Change subject: Fix lint errors: don't use star imports ...................................................................... Fix lint errors: don't use star imports tests/test_tlv.py:21:1: F403 `from osmocom.tlv import *` used; unable to detect undefined names | 19 | import unittest 20 | from construct import Int8ub, GreedyBytes 21 | from osmocom.tlv import * | ^^^^^^^^^^^^^^^^^^^^^^^^^ F403 22 | from osmocom.utils import h2b Change-Id: I0ca76a40d47f72635682de9303ff73e9b2197266 --- M src/osmocom/gsmtap.py M tests/test_construct.py M tests/test_gsup.py M tests/test_tlv.py M tests/test_utils.py 5 files changed, 31 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/python/pyosmocom refs/changes/84/41384/1 diff --git a/src/osmocom/gsmtap.py b/src/osmocom/gsmtap.py index 60d7ee4..3474396 100644 --- a/src/osmocom/gsmtap.py +++ b/src/osmocom/gsmtap.py @@ -25,7 +25,7 @@ import socket from construct import Int8ub, Int8sb, Int32ub, BitStruct, Enum, GreedyBytes, Struct, Switch from construct import this, PaddedString, Flag, BitsInteger, Bytes -from osmocom.construct import * +from osmocom.construct import parse_construct # The root definition of GSMTAP can be found at # https://cgit.osmocom.org/cgit/libosmocore/tree/include/osmocom/core/gsmtap.h diff --git a/tests/test_construct.py b/tests/test_construct.py index 94ae71f..4c56734 100755 --- a/tests/test_construct.py +++ b/tests/test_construct.py @@ -2,7 +2,18 @@ import unittest from osmocom.utils import b2h, h2b -from osmocom.construct import * +from osmocom.construct import ( + Asn1DerInteger, + Bytes, + DnsAdapter, + GreedyInteger, + GreedyBytes, + PlmnAdapter, + StripHeaderAdapter, + StripTrailerAdapter, + Ucs2Adapter, + filter_dict, +) # pylint: disable=no-name-in-module from construct import FlagsEnum diff --git a/tests/test_gsup.py b/tests/test_gsup.py index db3f29e..c6f2429 100755 --- a/tests/test_gsup.py +++ b/tests/test_gsup.py @@ -4,7 +4,7 @@ from pprint import pprint as pp from osmocom.utils import b2h, h2b -from osmocom.gsup.message import * +from osmocom.gsup.message import GsupMessage class Test_GSUP(unittest.TestCase): diff --git a/tests/test_tlv.py b/tests/test_tlv.py index 3af1e07..0a02b55 100755 --- a/tests/test_tlv.py +++ b/tests/test_tlv.py @@ -18,7 +18,22 @@ import unittest from construct import Int8ub, GreedyBytes -from osmocom.tlv import * +from osmocom.tlv import ( + COMPACT_TLV_IE, + IE, + TLV_IE_Collection, + Transcodable, + bertlv_encode_len, + bertlv_parse_len, + bertlv_parse_one, + bertlv_parse_tag, + camel_to_snake, + comprehensiontlv_encode_tag, + comprehensiontlv_parse_tag, + dgi_encode_len, + dgi_parse_len, + flatten_dict_lists, +) from osmocom.utils import h2b class TestBerTlv(unittest.TestCase): diff --git a/tests/test_utils.py b/tests/test_utils.py index 0f22e35..1b80011 100755 --- a/tests/test_utils.py +++ b/tests/test_utils.py @@ -18,7 +18,7 @@ import unittest -from osmocom.utils import * +from osmocom.utils import hexstr, int_bytes_required class TestHexstr(unittest.TestCase): def test_cmp(self): -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/41384?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I0ca76a40d47f72635682de9303ff73e9b2197266 Gerrit-Change-Number: 41384 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

2025

2024

2023

2022

gerrit-log November 2025