Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41417?usp=email )
Change subject: mtp: Introduce mtp_prim_* API helpers
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41417?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I4af154a65b8c23b9e8647845337ad1b5aa3901aa
Gerrit-Change-Number: 41417
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 14 Nov 2025 13:17:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: daniel, fixeria, laforge, pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/docker-playground/+/41430?usp=email )
Change subject: nplab-m3ua-test: Parametrize git branch and change it to osmocom/master
......................................................................
Patch Set 1:
(1 comment)
File nplab-m3ua-test/Dockerfile:
https://gerrit.osmocom.org/c/docker-playground/+/41430/comment/b3b8907d_f67… :
PS1, Line 12: cp runtest-junitxml.py /usr/local/bin/
> No idea, but I don't really want to spend further time on this now :D
Acknowledged
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41430?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I78b2a27b355f11ba64476216bc7ef76713e8f61e
Gerrit-Change-Number: 41430
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 14 Nov 2025 13:11:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: daniel, fixeria, laforge, osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/docker-playground/+/41430?usp=email )
Change subject: nplab-m3ua-test: Parametrize git branch and change it to osmocom/master
......................................................................
Patch Set 1:
(1 comment)
File nplab-m3ua-test/Dockerfile:
https://gerrit.osmocom.org/c/docker-playground/+/41430/comment/e72bce08_a44… :
PS1, Line 12: cp runtest-junitxml.py /usr/local/bin/
> not sure if only this one file is needed. but if that is the case, you could also directly do this: […]
No idea, but I don't really want to spend further time on this now :D
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41430?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I78b2a27b355f11ba64476216bc7ef76713e8f61e
Gerrit-Change-Number: 41430
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 14 Nov 2025 13:10:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41411?usp=email )
Change subject: mtp: Improve mtp_sap/ss7_user APIs
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
File TODO-RELEASE:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41411/comment/d8f87ff7_9f9b6… :
PS3, Line 13: libosmo-sigtran add osmo_ss7_user_mtp_sap_prim_down()
maybe note here that ss7_user APIs (that were not used by anyone yet) were reworked?
File src/mtp_sap.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41411/comment/f4e1f5ba_56c8c… :
PS3, Line 100: rc = -1;
maybe add a break here for consistency?
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41411?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: If320db2bcec7ccbbc2cdac0cbf018fd8be7bde22
Gerrit-Change-Number: 41411
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 14 Nov 2025 13:10:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/docker-playground/+/41431?usp=email )
Change subject: nplab-m3ua-test: Configure Network Indicator as International
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41431?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Iae825ebc588524c7a3761c80392940733f3887a6
Gerrit-Change-Number: 41431
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 14 Nov 2025 12:46:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: daniel, fixeria, laforge, pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/docker-playground/+/41430?usp=email )
Change subject: nplab-m3ua-test: Parametrize git branch and change it to osmocom/master
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File nplab-m3ua-test/Dockerfile:
https://gerrit.osmocom.org/c/docker-playground/+/41430/comment/8fc37645_62c… :
PS1, Line 12: cp runtest-junitxml.py /usr/local/bin/
not sure if only this one file is needed. but if that is the case, you could also directly do this:
```
wget https://gitea.osmocom.org/nplab/m3ua-testtool/raw/branch/osmocom/master/run… -O /usr/local/bin/runtest-junitxml.py
```
just an optimization, doesn't need to block this patch
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41430?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I78b2a27b355f11ba64476216bc7ef76713e8f61e
Gerrit-Change-Number: 41430
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 14 Nov 2025 12:45:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/41431?usp=email )
Change subject: nplab-m3ua-test: Configure Network Indicator as International
......................................................................
nplab-m3ua-test: Configure Network Indicator as International
That's what we are using at the osmo-stp configuration.
Until now it didn't matter since libosmo-sigtran didn't validate NI
matching configuration on received messages, but since
1af56bf8cf266dd708b623e75d6d175a58f3dd47 it does.
Change-Id: Iae825ebc588524c7a3761c80392940733f3887a6
---
M nplab-m3ua-test/m3ua-param-testtool.scm
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/31/41431/1
diff --git a/nplab-m3ua-test/m3ua-param-testtool.scm b/nplab-m3ua-test/m3ua-param-testtool.scm
index 10ca653..c919195 100644
--- a/nplab-m3ua-test/m3ua-param-testtool.scm
+++ b/nplab-m3ua-test/m3ua-param-testtool.scm
@@ -66,7 +66,7 @@
(define ss7-message (list 11 34 45 67 67 89))
(define ss7-si 0)
-(define iut-ni 1)
+(define iut-ni 0)
(define iut-mp 0)
(define iut-sls 0)
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41431?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Iae825ebc588524c7a3761c80392940733f3887a6
Gerrit-Change-Number: 41431
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>