October 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-el2tpd[master]: src/l2tp_protocol.h: include netinet/in.h
by osmith 02 Oct '25

02 Oct '25

Attention is currently required from: Hoernchen. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-el2tpd/+/41184?usp=email ) Change subject: src/l2tp_protocol.h: include netinet/in.h ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-el2tpd/+/41184?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-el2tpd Gerrit-Branch: master Gerrit-Change-Id: Iaec15ee59a1e740d41e616142637612d2aacf1dc Gerrit-Change-Number: 41184 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Oct 2025 05:53:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in dahdi-tools[master]: xpp/echo_loader: make get_ver static
by osmith 02 Oct '25

02 Oct '25

osmith has submitted this change. ( https://gerrit.osmocom.org/c/dahdi-tools/+/41174?usp=email ) Change subject: xpp/echo_loader: make get_ver static ...................................................................... xpp/echo_loader: make get_ver static Fix the following errors seen with CFLAGS=-g in the master-dahdi-tools job in jenkins: /usr/bin/ld: ./.libs/libecholoader.a(libecholoader_la-echo_loader.o): in function `init_octasic': /build/xpp/echo_loader.c:598:(.text+0x1777): undefined reference to `get_ver' /usr/bin/ld: ./.libs/libecholoader.a(libecholoader_la-echo_loader.o): in function `echo_ver': /build/xpp/echo_loader.c:883:(.text+0x2503): undefined reference to `get_ver' Related: https://stackoverflow.com/a/77501693 Change-Id: I835d82c11f02c9635923d93fa36b46bbb46a9b48 --- M xpp/echo_loader.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified osmith: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/xpp/echo_loader.c b/xpp/echo_loader.c index 827f6ef..117414e 100644 --- a/xpp/echo_loader.c +++ b/xpp/echo_loader.c @@ -564,7 +564,7 @@ return cOCT6100_ERR_OK; } -inline int get_ver(struct astribank *astribank) +static inline int get_ver(struct astribank *astribank) { return spi_send(astribank, 0, 0, 1, 1); } -- To view, visit https://gerrit.osmocom.org/c/dahdi-tools/+/41174?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: dahdi-tools Gerrit-Branch: master Gerrit-Change-Id: I835d82c11f02c9635923d93fa36b46bbb46a9b48 Gerrit-Change-Number: 41174 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in dahdi-tools[master]: xpp/echo_loader: make get_ver static
by osmith 02 Oct '25

02 Oct '25

Attention is currently required from: Hoernchen. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/dahdi-tools/+/41174?usp=email ) Change subject: xpp/echo_loader: make get_ver static ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/dahdi-tools/+/41174?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: dahdi-tools Gerrit-Branch: master Gerrit-Change-Id: I835d82c11f02c9635923d93fa36b46bbb46a9b48 Gerrit-Change-Number: 41174 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Oct 2025 05:53:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ccid-firmware[master]: ccid_gen_notify_slot_status: add msgb_put cast
by osmith 02 Oct '25

02 Oct '25

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/41176?usp=email ) Change subject: ccid_gen_notify_slot_status: add msgb_put cast ...................................................................... ccid_gen_notify_slot_status: add msgb_put cast Fix this error seen in master-osmo-ccid-firmware after switching to debian trixie with 14.2: ../main.c:338:57: error: initialization of 'struct ccid_rdr_to_pc_notify_slot_change *' from incompatible pointer type 'unsigned char *' [-Wincompatible-pointer-types] 338 | struct ccid_rdr_to_pc_notify_slot_change *nsc = msgb_put(msg, sizeof(*nsc) + sizeof(statusbytes)); Change-Id: I5618297533246adc8adaacf49fd58ec1f0f97cfc --- M sysmoOCTSIM/main.c 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/sysmoOCTSIM/main.c b/sysmoOCTSIM/main.c index 7d81853..fe569fd 100644 --- a/sysmoOCTSIM/main.c +++ b/sysmoOCTSIM/main.c @@ -335,7 +335,8 @@ uint8_t statusbytes[2] = {0}; //struct msgb *msg = ccid_msgb_alloc(); struct msgb *msg = msgb_alloc(300,"IRQ"); - struct ccid_rdr_to_pc_notify_slot_change *nsc = msgb_put(msg, sizeof(*nsc) + sizeof(statusbytes)); + struct ccid_rdr_to_pc_notify_slot_change *nsc = + (struct ccid_rdr_to_pc_notify_slot_change *)msgb_put(msg, sizeof(*nsc) + sizeof(statusbytes)); nsc->bMessageType = RDR_to_PC_NotifySlotChange; for(int i = 0; i <8; i++) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/41176?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I5618297533246adc8adaacf49fd58ec1f0f97cfc Gerrit-Change-Number: 41176 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ccid-firmware[master]: ccid_host: fix read_timeout defined but not used
by osmith 02 Oct '25

02 Oct '25

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/41177?usp=email ) Change subject: ccid_host: fix read_timeout defined but not used ...................................................................... ccid_host: fix read_timeout defined but not used Comment out the read_timeout fuction, as it is only used in already commented out code. Fix for: cuart_driver_tty.c:90:12: warning: 'read_timeout' defined but not used [-Wunused-function] 90 | static int read_timeout(int fd, uint8_t *out, size_t len, unsigned long timeout_ms) Change-Id: I49fc59ebaa4abc3e9b8838e1b427f4455acdb390 --- M ccid_host/cuart_driver_tty.c 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/ccid_host/cuart_driver_tty.c b/ccid_host/cuart_driver_tty.c index f8a1438..a9032fa 100644 --- a/ccid_host/cuart_driver_tty.c +++ b/ccid_host/cuart_driver_tty.c @@ -87,6 +87,7 @@ OSMO_ASSERT(rc == 0); } +#if 0 static int read_timeout(int fd, uint8_t *out, size_t len, unsigned long timeout_ms) { struct timeval tv = { .tv_sec = timeout_ms / 1000, .tv_usec = (timeout_ms % 1000) * 1000 }; @@ -103,6 +104,7 @@ return read(fd, out, len); } +#endif static int _flush(int fd) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/41177?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I49fc59ebaa4abc3e9b8838e1b427f4455acdb390 Gerrit-Change-Number: 41177 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ccid-firmware[master]: contrib/jenkins: fix a typo
by osmith 02 Oct '25

02 Oct '25

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/41175?usp=email ) Change subject: contrib/jenkins: fix a typo ...................................................................... contrib/jenkins: fix a typo Change-Id: Iaa8349e90d222ef918051c344e45ec51ae649884 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 9111965..0bf6771 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -16,7 +16,7 @@ echo -echo "=============== libosmocore hostt build ===========" +echo "=============== libosmocore host build ===========" osmo-build-dep.sh libosmocore "" --disable-doxygen export PKG_CONFIG_PATH="$inst/lib/pkgconfig:$PKG_CONFIG_PATH" export LD_LIBRARY_PATH="$inst/lib" -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/41175?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Iaa8349e90d222ef918051c344e45ec51ae649884 Gerrit-Change-Number: 41175 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmocom-bb[master]: firmware(libosmocore): update function header
by osmith 02 Oct '25

02 Oct '25

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41191?usp=email ) Change subject: firmware(libosmocore): update function header ...................................................................... firmware(libosmocore): update function header Update the function header to be the same as in target/firmware/include/string.h, so it compiles successfully with GCC 14.2. Otherwise: lib/strcmp.c:5:1: error: return type defaults to 'int' [-Wimplicit-int] 5 | strcmp(s1, s2) | ^~~~~~ Change-Id: Ic601d84c3366d9aec661663c80ba9d7586510d63 --- M src/target/firmware/lib/strcmp.c 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/target/firmware/lib/strcmp.c b/src/target/firmware/lib/strcmp.c index 9a7fa81..c098d6e 100644 --- a/src/target/firmware/lib/strcmp.c +++ b/src/target/firmware/lib/strcmp.c @@ -2,8 +2,7 @@ * Compare strings: s1>s2: >0 s1==s2: 0 s1<s2: <0 */ -strcmp(s1, s2) - register char *s1, *s2; +int strcmp(const char *s1, const char *s2) { while (*s1 == *s2++) if (*s1++=='\0') -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41191?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ic601d84c3366d9aec661663c80ba9d7586510d63 Gerrit-Change-Number: 41191 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in osmocom-bb[master]: firmware(libosmocore): add missing 'if !EMBEDDED'
by osmith 02 Oct '25

02 Oct '25

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41190?usp=email ) Change subject: firmware(libosmocore): add missing 'if !EMBEDDED' ...................................................................... firmware(libosmocore): add missing 'if !EMBEDDED' Fix compilation with GCC 14.2, which otherwise fails with errors like: ../../src/utils.c:49:22: error: implicit declaration of function 'strcasecmp' [-Wimplicit-function-declaration] Change-Id: Ia7fdd5edd5edd1ee126dfbcaa75b3d988143f2e1 --- M src/shared/libosmocore/src/logging.c M src/shared/libosmocore/src/utils.c 2 files changed, 13 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/src/shared/libosmocore/src/logging.c b/src/shared/libosmocore/src/logging.c index e187df2..4738f99 100644 --- a/src/shared/libosmocore/src/logging.c +++ b/src/shared/libosmocore/src/logging.c @@ -151,6 +151,7 @@ return -EINVAL; } +#if (!EMBEDDED) /*! \brief parse the log category mask * \param[in] target log target to be configured * \param[in] _mask log category mask string @@ -202,6 +203,7 @@ free(mask); } +#endif /* !EMBEDDED */ static const char* color(int subsys) { @@ -436,12 +438,14 @@ target->categories[category].loglevel = level; } +#if (!EMBEDDED) static void _file_output(struct log_target *target, unsigned int level, const char *log) { fprintf(target->tgt_file.out, "%s", log); fflush(target->tgt_file.out); } +#endif /* !EMBEDDED */ /*! \brief Create a new log target skeleton */ struct log_target *log_target_create(void) @@ -500,6 +504,7 @@ #endif /* stderr */ } +#if (!EMBEDDED) /*! \brief Create a new file-based log target * \param[in] fname File name of the new log file * \returns Log target in case of success, NULL otherwise @@ -523,6 +528,7 @@ return target; } +#endif /* !EMBEDDED */ /*! \brief Find a registered log target * \param[in] type Log target type @@ -552,6 +558,7 @@ /* just in case, to make sure we don't have any references */ log_del_target(target); +#if (!EMBEDDED) if (target->output == &_file_output) { /* since C89/C99 says stderr is a macro, we can safely do this! */ #ifdef stderr @@ -563,10 +570,12 @@ target->tgt_file.out = NULL; } } +#endif /* !EMBEDDED */ talloc_free(target); } +#if (!EMBEDDED) /*! \brief close and re-open a log file (for log file rotation) */ int log_target_file_reopen(struct log_target *target) { @@ -580,6 +589,7 @@ return 0; } +#endif /* !EMBEDDED */ /*! \brief Generates the logging command string for VTY * \param[in] unused_info Deprecated parameter, no longer used! diff --git a/src/shared/libosmocore/src/utils.c b/src/shared/libosmocore/src/utils.c index cf0c934..79c42cb 100644 --- a/src/shared/libosmocore/src/utils.c +++ b/src/shared/libosmocore/src/utils.c @@ -1,4 +1,5 @@ +#include "config.h" #include <string.h> #include <stdint.h> #include <errno.h> @@ -34,6 +35,7 @@ return namebuf; } +#if (!EMBEDDED) /*! \brief get numeric value for given human-readable string * \param[in] vs Array of value_string tuples * \param[in] str human-readable string @@ -51,6 +53,7 @@ } return -EINVAL; } +#endif /* !EMBEDDED */ /*! \brief Convert BCD-encoded digit into printable character * \param[in] bcd A single BCD-encoded digit -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41190?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia7fdd5edd5edd1ee126dfbcaa75b3d988143f2e1 Gerrit-Change-Number: 41190 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: hnbgw: fix missing TC_sccp_cr_limit() from control section
by neels 02 Oct '25

02 Oct '25

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41194?usp=email ) Change subject: hnbgw: fix missing TC_sccp_cr_limit() from control section ...................................................................... hnbgw: fix missing TC_sccp_cr_limit() from control section fixup for f2c95021e, add TC_sccp_cr_limit() to the control{ } section. Related: f2c95021e Related: Ia68dad973ef18513b52f5accb5264c557c7295ea Change-Id: I0604d937fc909fa66f2a8668c2f6926a269b2b42 --- M hnbgw/HNBGW_Tests.ttcn 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified neels: Looks good to me, approved diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index 2ef7b4d..cb7cdff 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -2713,6 +2713,7 @@ execute(TC_ranap_ps_initial_ue_empty_cr()); execute(TC_ranap_cs_bidir()); execute(TC_ranap_ps_bidir()); + execute(TC_sccp_cr_limit()); execute(TC_rab_assignment()); execute(TC_rab_assignment_concurrent()); execute(TC_rab_release()); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41194?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0604d937fc909fa66f2a8668c2f6926a269b2b42 Gerrit-Change-Number: 41194 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: hnbgw: fix missing TC_sccp_cr_limit() from control section
by neels 02 Oct '25

02 Oct '25

neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41194?usp=email ) Change subject: hnbgw: fix missing TC_sccp_cr_limit() from control section ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41194?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0604d937fc909fa66f2a8668c2f6926a269b2b42 Gerrit-Change-Number: 41194 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Oct 2025 23:56:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0