Attention is currently required from: Hoernchen, osmith.
laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/41177?usp=email )
Change subject: ccid_host: fix read_timeout defined but not used
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/41177?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: I49fc59ebaa4abc3e9b8838e1b427f4455acdb390
Gerrit-Change-Number: 41177
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 01 Oct 2025 14:22:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: jolly.
laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41189?usp=email )
Change subject: MME-Tests: Add test for emergency bearer setup
......................................................................
Patch Set 2: -Code-Review
(1 comment)
File mme/ConnHdlr.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41189/comment/5ed79341_bcbd… :
PS2, Line 393: var charstring apn := char(0, 0, 0, 4) & "test" & char(0, 0, 0, 3) & "sos";
actually, this should probably simply use `f_dns_enc_label("test.sos")` - or is there anythin different in what our librarry/DNS_Helpers.ttcn code does?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41189?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I2a81defc96bcebdf1a4ec765278ca502800cbe46
Gerrit-Change-Number: 41189
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Wed, 01 Oct 2025 14:21:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: jolly.
laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41189?usp=email )
Change subject: MME-Tests: Add test for emergency bearer setup
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File mme/ConnHdlr.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41189/comment/497bb19e_23cf… :
PS2, Line 397: char2oct(apn)
wouldn't it make sense to define "var octetstring apn := O'00000004' & char2oct("test") & O'00000003' & char2oct("sos");" instead, so we don't have to convert it here in the compare?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41189?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I2a81defc96bcebdf1a4ec765278ca502800cbe46
Gerrit-Change-Number: 41189
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Wed, 01 Oct 2025 14:19:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes