October 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ccid-firmware[master]: ccid_hosts: fix missing talloc_report_full
by osmith 02 Oct '25

02 Oct '25

Attention is currently required from: Hoernchen, fixeria, laforge. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/41181?usp=email ) Change subject: ccid_hosts: fix missing talloc_report_full ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File contrib/jenkins.sh: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/41181/comment/411fec70_28… : PS1, Line 20: --disable-pseudotalloc > I believe `pseudotalloc` is not enabled unless you pass `--enable-pseudotalloc`? Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/41181?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I2b79d6f28e80acef8e1cab0dab949233698336ad Gerrit-Change-Number: 41181 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Oct 2025 05:58:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-ccid-firmware[master]: ccid_hosts: fix missing talloc_report_full
by osmith 02 Oct '25

02 Oct '25

Attention is currently required from: Hoernchen, fixeria, laforge, osmith. Hello Hoernchen, Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/41181?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: ccid_hosts: fix missing talloc_report_full ...................................................................... ccid_hosts: fix missing talloc_report_full Fix for: ccid_main_functionfs.c:534:17: error: implicit declaration of function 'talloc_report_full' [-Wimplicit-function-declaration] 534 | talloc_report_full(g_tall_ctx, stderr); Change-Id: I2b79d6f28e80acef8e1cab0dab949233698336ad --- M ccid_host/Makefile M ccid_host/ccid_main_functionfs.c M ccid_host/cuart_fsm_test.c M ccid_host/hub_main_functionfs.c 4 files changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/81/41181/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/41181?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I2b79d6f28e80acef8e1cab0dab949233698336ad Gerrit-Change-Number: 41181 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-ccid-firmware[master]: ysmoOCTSIM/usb/class/dfu: fix missing include
by osmith 02 Oct '25

02 Oct '25

Attention is currently required from: Hoernchen, osmith. Hello Hoernchen, Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/41182?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: ysmoOCTSIM/usb/class/dfu: fix missing include ...................................................................... ysmoOCTSIM/usb/class/dfu: fix missing include Fix for: ../usb/class/dfu/device/dfudf.c:199:17: error: implicit declaration of function 'delay_us' [-Wimplicit-function-declaration] Change-Id: Ia36d25d47f4d5dc4e38c1ea9c8e193ff52f5b5d1 --- M sysmoOCTSIM/usb/class/dfu/device/dfudf.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/82/41182/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/41182?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ia36d25d47f4d5dc4e38c1ea9c8e193ff52f5b5d1 Gerrit-Change-Number: 41182 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>

1 0

[XS] Change in osmo-ccid-firmware[master]: contrib/jenkins: use osmo-clean-workspace.sh
by osmith 02 Oct '25

02 Oct '25

Attention is currently required from: Hoernchen, osmith. Hello Hoernchen, Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/41183?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: contrib/jenkins: use osmo-clean-workspace.sh ...................................................................... contrib/jenkins: use osmo-clean-workspace.sh Clean the workspace at the beginning, because otherwise the build fails when running twice in a row. For some reason a pseudo-talloc.h from libosmocore appears, resulting in: error: implicit declaration of function 'talloc_report_full' Change-Id: If2e29ffd5150b57858b46e92e157f83a0cf3a11a --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/83/41183/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/41183?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: If2e29ffd5150b57858b46e92e157f83a0cf3a11a Gerrit-Change-Number: 41183 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>

1 0

[XS] Change in osmo-ccid-firmware[master]: gitreview: new file
by osmith 02 Oct '25

02 Oct '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/41195?usp=email ) Change subject: gitreview: new file ...................................................................... gitreview: new file Change-Id: I3a230ecee24ac034546088a6e753cbe8e4930c12 --- A .gitreview 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/95/41195/1 diff --git a/.gitreview b/.gitreview new file mode 100644 index 0000000..a34860b --- /dev/null +++ b/.gitreview @@ -0,0 +1,3 @@ +[gerrit] +host=gerrit.osmocom.org +project=osmo-ccid-firmware -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/41195?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I3a230ecee24ac034546088a6e753cbe8e4930c12 Gerrit-Change-Number: 41195 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ccid-firmware[master]: ccid_host: fix unused variable warnings
by osmith 02 Oct '25

02 Oct '25

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/41179?usp=email ) Change subject: ccid_host: fix unused variable warnings ...................................................................... ccid_host: fix unused variable warnings Fix for: hub_main_functionfs.c:232:13: warning: unused variable 'rc' [-Wunused-variable] hub_main_functionfs.c:343:30: warning: unused variable 'uh' [-Wunused-variable] … Change-Id: Ib4c28e4ab3106175d450ea7ac78313866d35f600 --- M ccid_host/cuart_fsm_test.c M ccid_host/hub_main_functionfs.c 2 files changed, 1 insertion(+), 4 deletions(-) Approvals: fixeria: Looks good to me, approved laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/ccid_host/cuart_fsm_test.c b/ccid_host/cuart_fsm_test.c index db14779..001f8e7 100644 --- a/ccid_host/cuart_fsm_test.c +++ b/ccid_host/cuart_fsm_test.c @@ -71,7 +71,6 @@ int main(int argc, char **argv) { struct osmo_fsm_inst *fi; - uint8_t atr[64]; int rc; g_tall_ctx = talloc_named_const(NULL, 0, "main"); diff --git a/ccid_host/hub_main_functionfs.c b/ccid_host/hub_main_functionfs.c index 93363a6..6d31243 100644 --- a/ccid_host/hub_main_functionfs.c +++ b/ccid_host/hub_main_functionfs.c @@ -228,7 +228,6 @@ { const struct _usb_ctrl_req *req = (const struct _usb_ctrl_req *) ctrl_req; static uint16_t status[2]; - int rc; LOGP(DUSB, LOGL_NOTICE, "CTRL bmReqT=0x%02X bRequest=%s, wValue=0x%04X, wIndex=0x%04X, wLength=%d\n", req->bRequestType, get_value_string(hub_class_spec_req_vals, req->bRequest), @@ -339,7 +338,7 @@ static int ep_0_cb(struct osmo_fd *ofd, unsigned int what) { - struct ufunc_handle *uh = (struct ufunc_handle *) ofd->data; + // struct ufunc_handle *uh = (struct ufunc_handle *) ofd->data; int rc; if (what & OSMO_FD_READ) { @@ -389,7 +388,6 @@ { struct ufunc_handle *uh = (struct ufunc_handle *) ofd->data; struct io_event evt[1]; - struct msgb *msg; uint64_t ev_cnt; int i, rc; -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/41179?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ib4c28e4ab3106175d450ea7ac78313866d35f600 Gerrit-Change-Number: 41179 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in osmo-ccid-firmware[master]: ccid_host: remove unused _set_dtr
by osmith 02 Oct '25

02 Oct '25

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/41178?usp=email ) Change subject: ccid_host: remove unused _set_dtr ...................................................................... ccid_host: remove unused _set_dtr Fix for: cuart_driver_tty.c:62:13: warning: '_set_dtr' defined but not used [-Wunused-function] 62 | static void _set_dtr(int fd, bool dtr) Change-Id: I43b08a584891e94b9cfab095834e499dd5914b4f --- M ccid_host/cuart_driver_tty.c 1 file changed, 0 insertions(+), 14 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/ccid_host/cuart_driver_tty.c b/ccid_host/cuart_driver_tty.c index a9032fa..66d1e9d 100644 --- a/ccid_host/cuart_driver_tty.c +++ b/ccid_host/cuart_driver_tty.c @@ -59,20 +59,6 @@ return 0; } -static void _set_dtr(int fd, bool dtr) -{ - int status, rc; - - rc = ioctl(fd, TIOCMGET, &status); - OSMO_ASSERT(rc == 0); - if (dtr) /* set DTR */ - status |= TIOCM_DTR; - else - status &= ~TIOCM_DTR; - rc = ioctl(fd, TIOCMSET, &status); - OSMO_ASSERT(rc == 0); -} - static void _set_rts(int fd, bool rts) { int status, rc; -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/41178?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I43b08a584891e94b9cfab095834e499dd5914b4f Gerrit-Change-Number: 41178 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in osmo-ccid-firmware[master]: ccid_host/Makefile: tweak formatting (cosmetic)
by osmith 02 Oct '25

02 Oct '25

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/41180?usp=email ) Change subject: ccid_host/Makefile: tweak formatting (cosmetic) ...................................................................... ccid_host/Makefile: tweak formatting (cosmetic) Change-Id: Ic2e92f9364361af0989b447d3824e867c0cb23d4 --- M ccid_host/Makefile 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/ccid_host/Makefile b/ccid_host/Makefile index 7625177..b117232 100644 --- a/ccid_host/Makefile +++ b/ccid_host/Makefile @@ -1,5 +1,14 @@ -CFLAGS=-Wall -g $(shell pkg-config --cflags libosmocore) -I../ccid_common -I. -LIBS?=-lasan $(shell pkg-config --libs libosmocore) +CFLAGS= \ + -Wall \ + -g \ + $(shell pkg-config --cflags libosmocore) \ + -I../ccid_common \ + -I. \ + $(NULL) +LIBS?= \ + -lasan \ + $(shell pkg-config --libs libosmocore) \ + $(NULL) all: ccid_functionfs hub_functionfs cuart_test cuart_fsm_test -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/41180?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ic2e92f9364361af0989b447d3824e867c0cb23d4 Gerrit-Change-Number: 41180 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in osmo-ccid-firmware[master]: ccid_host: remove unused _set_dtr
by osmith 02 Oct '25

02 Oct '25

Attention is currently required from: Hoernchen. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/41178?usp=email ) Change subject: ccid_host: remove unused _set_dtr ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/41178?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I43b08a584891e94b9cfab095834e499dd5914b4f Gerrit-Change-Number: 41178 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Oct 2025 05:53:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-el2tpd[master]: src/l2tp_protocol.h: include netinet/in.h
by osmith 02 Oct '25

02 Oct '25

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-el2tpd/+/41184?usp=email ) Change subject: src/l2tp_protocol.h: include netinet/in.h ...................................................................... src/l2tp_protocol.h: include netinet/in.h Fix the following error seen in the master-osmo-el2tpd jenkins job after switching it to debian 13: In file included from l2tpd_lapd.c:31: l2tp_protocol.h:28:25: error: expected identifier before numeric constant 28 | #define IPPROTO_L2TP 115 This happens, because /usr/include/netinet/in.h has: /* Standard well-defined IP protocols. */ enum { IPPROTO_IP = 0, /* Dummy protocol for TCP. */ #define IPPROTO_IP IPPROTO_IP IPPROTO_ICMP = 1, /* Internet Control Message Protocol. */ #define IPPROTO_ICMP IPPROTO_ICMP … IPPROTO_COMP = 108, /* Compression Header Protocol. */ #define IPPROTO_COMP IPPROTO_COMP IPPROTO_L2TP = 115, /* Layer 2 Tunnelling Protocol. */ #define IPPROTO_L2TP IPPROTO_L2TP … }; Which then becomes (seen with gcc -E): IPPROTO_COMP = 108, # 84 "/usr/include/netinet/in.h" 115 # 84 "/usr/include/netinet/in.h" 3 4 = 115, IPPROTO_SCTP = 132, Fix this by including netinet/in.h first, so it won't be redefined if it is already there. Change-Id: Iaec15ee59a1e740d41e616142637612d2aacf1dc --- M src/l2tp_protocol.h 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified osmith: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/src/l2tp_protocol.h b/src/l2tp_protocol.h index 32821f5..6b9fe55 100644 --- a/src/l2tp_protocol.h +++ b/src/l2tp_protocol.h @@ -24,6 +24,8 @@ * */ +#include "netinet/in.h" + #ifndef IPPROTO_L2TP #define IPPROTO_L2TP 115 #endif -- To view, visit https://gerrit.osmocom.org/c/osmo-el2tpd/+/41184?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-el2tpd Gerrit-Branch: master Gerrit-Change-Id: Iaec15ee59a1e740d41e616142637612d2aacf1dc Gerrit-Change-Number: 41184 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0