October 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ttcn3-hacks[master]: hnbgw: fix missing TC_sccp_cr_limit() from control section
by neels 02 Oct '25

02 Oct '25

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41194?usp=email ) Change subject: hnbgw: fix missing TC_sccp_cr_limit() from control section ...................................................................... hnbgw: fix missing TC_sccp_cr_limit() from control section fixup for f2c95021e, add TC_sccp_cr_limit() to the control{ } section. Related: f2c95021e Related: Ia68dad973ef18513b52f5accb5264c557c7295ea Change-Id: I0604d937fc909fa66f2a8668c2f6926a269b2b42 --- M hnbgw/HNBGW_Tests.ttcn 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/94/41194/1 diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index 2ef7b4d..cb7cdff 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -2713,6 +2713,7 @@ execute(TC_ranap_ps_initial_ue_empty_cr()); execute(TC_ranap_cs_bidir()); execute(TC_ranap_ps_bidir()); + execute(TC_sccp_cr_limit()); execute(TC_rab_assignment()); execute(TC_rab_assignment_concurrent()); execute(TC_rab_release()); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41194?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0604d937fc909fa66f2a8668c2f6926a269b2b42 Gerrit-Change-Number: 41194 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: fixup for SCCP_MAX_OPTIONAL_DATA changing to 128
by neels 02 Oct '25

02 Oct '25

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41193?usp=email ) Change subject: fixup for SCCP_MAX_OPTIONAL_DATA changing to 128 ...................................................................... fixup for SCCP_MAX_OPTIONAL_DATA changing to 128 Change-Id: I2fdafa88be1f25c90c7e1a34423a25aa7f5bff5c --- M hnbgw/HNBGW_Tests.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/93/41193/1 diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index 2ef7b4d..6bbebc6 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -958,8 +958,8 @@ f_init(); const Testdata_CR_Limits tests := { - { data_len := 130, max_optional_data := -1, expect_separate_sccp_cr := false }, - { data_len := 131, max_optional_data := -1, expect_separate_sccp_cr := true }, + { data_len := 128, max_optional_data := -1, expect_separate_sccp_cr := false }, + { data_len := 129, max_optional_data := -1, expect_separate_sccp_cr := true }, { data_len := 100, max_optional_data := 100, expect_separate_sccp_cr := false }, { data_len := 101, max_optional_data := 100, expect_separate_sccp_cr := true }, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41193?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2fdafa88be1f25c90c7e1a34423a25aa7f5bff5c Gerrit-Change-Number: 41193 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: fix SCCP_MAX_OPTIONAL_DATA 128
by neels 02 Oct '25

02 Oct '25

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41192?usp=email ) Change subject: fix SCCP_MAX_OPTIONAL_DATA 128 ...................................................................... fix SCCP_MAX_OPTIONAL_DATA 128 Related: SYS#7600 Change-Id: I841dbb2e8cbc13708ba7f5593f6bdd3b8da4329c --- M include/osmocom/sccp/sccp_types.h 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/92/41192/1 diff --git a/include/osmocom/sccp/sccp_types.h b/include/osmocom/sccp/sccp_types.h index 5be0392..ab688b3 100644 --- a/include/osmocom/sccp/sccp_types.h +++ b/include/osmocom/sccp/sccp_types.h @@ -24,7 +24,25 @@ #include <osmocom/core/endian.h> #include <osmocom/core/utils.h> -#define SCCP_MAX_OPTIONAL_DATA 130 +/* ITU Q.713 3.16 Data is a variable-length IE, meaning it has two header + * octets: + * - one octet of "Parameter name code", + * - plus one octet of length. + * + * In + * - 4.2 CR, + * - 4.3 CC, + * - 4.4 CREF, + * - 4.5 RLSD, + * there are optional "Data" IEs with length indicated as "3-130" octets: the + * minimum of 3 stems from the two header octets plus one data octet. Note that + * when there are zero data octets, the entire "Data" IE is omitted. + * + * Hence, the maximum of 130 includes the two header octets, and the actual + * maximum data length is 128. + */ +#define SCCP_MAX_OPTIONAL_DATA 128 + #define SCCP_MAX_DATA 256 /* Table 1/Q.713 - SCCP message types */ -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41192?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I841dbb2e8cbc13708ba7f5593f6bdd3b8da4329c Gerrit-Change-Number: 41192 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: MME-Tests: Add test for emergency bearer setup
by fixeria 01 Oct '25

01 Oct '25

Attention is currently required from: jolly. fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41189?usp=email ) Change subject: MME-Tests: Add test for emergency bearer setup ...................................................................... Patch Set 2: (4 comments) File mme/ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41189/comment/4a8cabe6_e714… : PS2, Line 947: Request Request or Success? The altstep name suggests the later. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41189/comment/8236d672_2712… : PS2, Line 952: log2str `log2str` not really needed here. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41189/comment/67945095_bb86… : PS2, Line 955: .start You're re-using a timer that may already be running. Either do `T.stop` before starting it again, or use a different timer. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41189/comment/6109fc00_4d63… : PS2, Line 958: log2str `log2str` not really needed here. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41189?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2a81defc96bcebdf1a4ec765278ca502800cbe46 Gerrit-Change-Number: 41189 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 01 Oct 2025 16:32:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-ttcn3-hacks[master]: MME-Tests: Add tests for emergency cappability indication
by fixeria 01 Oct '25

01 Oct '25

Attention is currently required from: jolly. fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41188?usp=email ) Change subject: MME-Tests: Add tests for emergency cappability indication ...................................................................... Patch Set 1: (4 comments) File mme/ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41188/comment/979eca67_b188… : PS1, Line 344: if (lengthof(enl_tlv.emergencyNumberList) != g_pars.emerg_pars.numbers) { I see you're doing a lot of "manual" matching here. Why not defining templates for `EmergencyNumber` and `EmergencyNumberList`? This way you could have a template in `EmergParams` and simply do `match(attach_accept.emergencyNumberList, template)` here. File mme/MME_Tests_emergency.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41188/comment/fb0be5fe_a277… : PS1, Line 3: SGsAP related procedures copy-paste https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41188/comment/54805032_f6b1… : PS1, Line 3: in in fixme https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41188/comment/493e73f5_4cb4… : PS1, Line 4: 2025 Andreas Eversberg <aeversberg(a)sysmocom.de> I believe the copyright holder should be sysmocom. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41188?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3d84486dd3826d0f60a3c06693118e36b01ecd2b Gerrit-Change-Number: 41188 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 01 Oct 2025 16:10:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-ttcn3-hacks[master]: library/s1ap: Add support for E_RABSetupRequest
by fixeria 01 Oct '25

01 Oct '25

Attention is currently required from: jolly. fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41187?usp=email ) Change subject: library/s1ap: Add support for E_RABSetupRequest ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41187?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4593bb8a7845b4b1dd10866fca47f473bd585cf6 Gerrit-Change-Number: 41187 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 01 Oct 2025 15:52:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: Fix length indicators in tr_NAS_ActDefEpsBearCtxReq
by fixeria 01 Oct '25

01 Oct '25

Attention is currently required from: jolly. fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41186?usp=email ) Change subject: Fix length indicators in tr_NAS_ActDefEpsBearCtxReq ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41186?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibce4b56c479fb5e31ee1f7871eab168facfef94e Gerrit-Change-Number: 41186 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 01 Oct 2025 15:47:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: Allow matching tr_GTP2C_CreateSessionReq with any tEID
by fixeria 01 Oct '25

01 Oct '25

Attention is currently required from: jolly. fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41185?usp=email ) Change subject: Allow matching tr_GTP2C_CreateSessionReq with any tEID ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41185?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6fe3ba9f24bd0615e70ffe515c5b8c907ca8a494 Gerrit-Change-Number: 41185 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 01 Oct 2025 15:46:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-msc[master]: vlr: add PS support
by fixeria 01 Oct '25

01 Oct '25

Attention is currently required from: daniel, laforge, lynxis lazus, neels, pespin. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email ) Change subject: vlr: add PS support ...................................................................... Patch Set 12: (2 comments) File src/libvlr/vlr_lu_fsm.c: https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/ff4acfff_67554bc6?usp… : PS12, Line 582: lcvp->vsub->vlr Use `vlr` here. https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/4104772e_9e3672e8?usp… : PS12, Line 1764: struct osmo_fsm_inst *fi = _vlr_loc_update( Please use consistent formatting with `vlr_loc_update()`: spaces vs tabs. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie9ffeb140c9d354b3a0f4822e2619f623235add0 Gerrit-Change-Number: 38490 Gerrit-PatchSet: 12 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 01 Oct 2025 15:41:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XL] Change in osmo-ttcn3-hacks[master]: smdpp: es9p testsuite
by dexter 01 Oct '25

01 Oct '25

Attention is currently required from: Hoernchen. dexter has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119?usp=email ) Change subject: smdpp: es9p testsuite ...................................................................... Patch Set 5: Verified-1 (1 comment) File smdpp/gen_links.sh: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/10c66909_82ff… : PS5, Line 5: . ../gen_links.sh.inc There seems to be a problem: $ ./gen_links.sh ./gen_links.sh: line 5: ../gen_links.sh.inc: No such file or directory ./gen_links.sh: line 9: gen_links: command not found ./gen_links.sh: line 13: gen_links: command not found ./gen_links.sh: line 17: gen_links: command not found ./gen_links.sh: line 22: gen_links: command not found ./gen_links.sh: line 26: gen_links: command not found ./gen_links.sh: line 34: gen_links: command not found ./gen_links.sh: line 38: gen_links: command not found ./gen_links.sh: line 40: ignore_pp_results: command not found Can you do a clean checkout and try if it still compiles as expected. (for testing I have checked out with change id: I9dcb3249fc712e2ddb2c7cf48d4fc54425848bc6) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3ba163d9155a3b019214dbccc3c8031dfd7deb6b Gerrit-Change-Number: 41119 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Oct 2025 15:29:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0