January 2025 - gerrit-log - lists.osmocom.org

[M] Change in osmo-msc[master]: vlr: when receiving imsi detach, purge the subscriber towards HLR

by neels

Attention is currently required from: lynxis lazus. neels has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38489?usp=email ) Change subject: vlr: when receiving imsi detach, purge the subscriber towards HLR ...................................................................... Patch Set 5: Code-Review+1 (1 comment) File src/libvlr/vlr.c: https://gerrit.osmocom.org/c/osmo-msc/+/38489/comment/ad95ea64_87212864?usp… : PS5, Line 1523: rc |= vlr_subscr_detach(vsub); (for me personally, '|=' on int type indicates some sort of bitmask logic; here it seems to be boolean logic. so i tend to want to look up what is the bitmask. If it were explicitly boolean, it would be a bit clearer, cosmetically. Returning a | of return code "enum values" forms meaningless enum values, right?) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38489?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9c2569c45e69b422ce26050b682e6eb26c1c2625 Gerrit-Change-Number: 38489 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 15 Jan 2025 13:33:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

5 months, 1 week

1
0
0 0

[M] Change in osmocom-bb[master]: trx_toolkit/clck_gen.py: Fix clock generator not to accumulate timing...

by pespin

Attention is currently required from: fixeria, kirr, osmith. pespin has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/39327?usp=email ) Change subject: trx_toolkit/clck_gen.py: Fix clock generator not to accumulate timing error ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: LGTM but letting @vyanitskiy@sysmocom.de have a look before merging. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/39327?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I928801422c9af80c368261f617b91d7ecfedbabf Gerrit-Change-Number: 39327 Gerrit-PatchSet: 2 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: kirr <kirr(a)nexedi.com> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jan 2025 12:53:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

5 months, 1 week

1
0
0 0

[XS] Change in osmo-ci[master]: ansible: build5-deb12build is also a coverity builder

by osmith

Attention is currently required from: laforge. osmith has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-ci/+/39333?usp=email ) Change subject: ansible: build5-deb12build is also a coverity builder ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39333?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id9d35658197409bcaba3e267cab36d7aa2a28972 Gerrit-Change-Number: 39333 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 15 Jan 2025 12:52:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 1 week

1
0
0 0

[XS] Change in osmo-ci[master]: update coverity version to 2024.6.1 (current one)

by osmith

Attention is currently required from: laforge. osmith has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-ci/+/39332?usp=email ) Change subject: update coverity version to 2024.6.1 (current one) ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39332?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ifa5621279bbf14839096e10ced74ed855908897b Gerrit-Change-Number: 39332 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 15 Jan 2025 12:52:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 1 week

1
0
0 0

[XS] Change in libosmo-netif[master]: add dependency on libosmovty

by pespin

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39308?usp=email ) Change subject: add dependency on libosmovty ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I'd also prefer it the way Harald suggests. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39308?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I57cb919891e5c7ee0f828b98af11199cd9c123f8 Gerrit-Change-Number: 39308 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Wed, 15 Jan 2025 12:41:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

5 months, 1 week

1
0
0 0

[M] Change in osmocom-bb[master]: [WIP] Revert "Revert "trx_toolkit/transceiver.py: implement the trans...

by laforge

Attention is currently required from: kirr. laforge has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/39328?usp=email ) Change subject: [WIP] Revert "Revert "trx_toolkit/transceiver.py: implement the transmit burst queue"" ...................................................................... Patch Set 1: (1 comment) File src/target/trx_toolkit/transceiver.py: https://gerrit.osmocom.org/c/osmocom-bb/+/39328/comment/81d62c6f_9128f61c?u… : PS1, Line 134: a L12TRX message on the TRXD (data) inteface, so it gets queued by > > 'inteface' may be misspelled - perhaps 'interface'? […] yeah, the linter obviously doesn't underestand that this is a revert. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/39328?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I41291708effdd2c767be680fff22ffbd9a56815e Gerrit-Change-Number: 39328 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: kirr <kirr(a)nexedi.com> Gerrit-Comment-Date: Wed, 15 Jan 2025 12:39:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: kirr <kirr(a)nexedi.com>

5 months, 1 week

1
0
0 0

[XS] Change in osmo-pcap[master]: cosmetic: server: Fix formatting of return in main()

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39313?usp=email ) Change subject: cosmetic: server: Fix formatting of return in main() ...................................................................... cosmetic: server: Fix formatting of return in main() Change-Id: I70af88cd62258f6b6de71d5ba9d8c29699c96f68 --- M src/osmo_server_main.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo_server_main.c b/src/osmo_server_main.c index 49ee449..e570e89 100644 --- a/src/osmo_server_main.c +++ b/src/osmo_server_main.c @@ -271,5 +271,5 @@ osmo_select_main(0); } - return(0); + return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39313?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I70af88cd62258f6b6de71d5ba9d8c29699c96f68 Gerrit-Change-Number: 39313 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

5 months, 1 week

1
0
0 0

[M] Change in osmo-pcap[master]: server: Use osmo_sockaddr in remote_addr field

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39307?usp=email ) Change subject: server: Use osmo_sockaddr in remote_addr field ...................................................................... server: Use osmo_sockaddr in remote_addr field Change-Id: Id63c7047bbc49ed5991b14fecfb3835972442165 --- M include/osmo-pcap/osmo_pcap_server.h M src/osmo_server_network.c M src/osmo_server_vty.c 3 files changed, 35 insertions(+), 17 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/include/osmo-pcap/osmo_pcap_server.h b/include/osmo-pcap/osmo_pcap_server.h index 8bd1dee..f394c7c 100644 --- a/include/osmo-pcap/osmo_pcap_server.h +++ b/include/osmo-pcap/osmo_pcap_server.h @@ -32,6 +32,7 @@ #include <osmocom/core/select.h> #include <osmocom/core/linuxlist.h> #include <osmocom/core/write_queue.h> +#include <osmocom/core/socket.h> #include <osmo-pcap/wireformat.h> #include <osmo-pcap/osmo_tls.h> @@ -80,7 +81,7 @@ char *name; char *remote_host; bool store; - struct in_addr remote_addr; + struct osmo_sockaddr rem_addr; /* Remote connection */ struct osmo_wqueue rem_wq; diff --git a/src/osmo_server_network.c b/src/osmo_server_network.c index c1cc47e..21ff255 100644 --- a/src/osmo_server_network.c +++ b/src/osmo_server_network.c @@ -462,13 +462,15 @@ static int accept_cb(struct osmo_fd *fd, unsigned int when) { - struct osmo_pcap_conn *conn; + struct osmo_pcap_conn *conn = NULL; struct osmo_pcap_server *server; - struct sockaddr_in addr; - socklen_t size = sizeof(addr); + char str[INET6_ADDRSTRLEN]; + struct osmo_sockaddr osa; + socklen_t len = sizeof(osa.u.sas); int new_fd; - new_fd = accept(fd->fd, (struct sockaddr *) &addr, &size); + memset(&osa, 0, sizeof(osa)); + new_fd = accept(fd->fd, &osa.u.sa, &len); if (new_fd < 0) { LOGP(DSERVER, LOGL_ERROR, "Failed to accept socket: %d\n", errno); return -1; @@ -480,13 +482,20 @@ rate_ctr_inc2(server->ctrg, SERVER_CTR_CONNECT); llist_for_each_entry(conn, &server->conn, entry) { - if (conn->remote_addr.s_addr == addr.sin_addr.s_addr) { - LOGP(DSERVER, LOGL_NOTICE, - "New connection from %s\n", conn->name); - osmo_pcap_conn_event(conn, "connect", NULL); - new_connection(server, conn, new_fd); - return 0; - } + if (conn->rem_addr.u.sa.sa_family != osa.u.sa.sa_family) + continue; + switch (conn->rem_addr.u.sa.sa_family) { + case AF_INET: + if (conn->rem_addr.u.sin.sin_addr.s_addr != osa.u.sin.sin_addr.s_addr) + continue; + goto found; + case AF_INET6: + if (memcmp(&conn->rem_addr.u.sin6.sin6_addr, &osa.u.sin6.sin6_addr, sizeof(struct in6_addr))) + continue; + goto found; + default: + continue; + }; } rate_ctr_inc2(server->ctrg, SERVER_CTR_NOCLIENT); @@ -496,10 +505,16 @@ * this client. */ - LOGP(DSERVER, LOGL_ERROR, - "Failed to find client for %s\n", inet_ntoa(addr.sin_addr)); + LOGP(DSERVER, LOGL_ERROR, "Failed to find client for %s\n", + osmo_sockaddr_ntop(&osa.u.sa, str)); close(new_fd); return -1; + +found: + LOGP(DSERVER, LOGL_NOTICE, "New connection from %s\n", conn->name); + osmo_pcap_conn_event(conn, "connect", NULL); + new_connection(server, conn, new_fd); + return 0; } int osmo_pcap_server_listen(struct osmo_pcap_server *server) diff --git a/src/osmo_server_vty.c b/src/osmo_server_vty.c index eab5cb4..51448ff 100644 --- a/src/osmo_server_vty.c +++ b/src/osmo_server_vty.c @@ -360,9 +360,11 @@ return CMD_WARNING; } - talloc_free(conn->remote_host); - conn->remote_host = talloc_strdup(pcap_server, remote_host); - inet_aton(remote_host, &conn->remote_addr); + if (osmo_sockaddr_from_str_and_uint(&conn->rem_addr, remote_host, 0) < 0) { + vty_out(vty, "Failed parsing address\n"); + return CMD_WARNING; + } + osmo_talloc_replace_string(pcap_server, &conn->remote_host, remote_host); /* Checking store and maybe closing a pcap file */ if (!store) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39307?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Id63c7047bbc49ed5991b14fecfb3835972442165 Gerrit-Change-Number: 39307 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

5 months, 1 week

1
0
0 0

[XS] Change in osmo-pcap[master]: tests: Remove unneeded .o files after osmo-pcap-server network/core f...

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39311?usp=email ) Change subject: tests: Remove unneeded .o files after osmo-pcap-server network/core file split ...................................................................... tests: Remove unneeded .o files after osmo-pcap-server network/core file split Change-Id: I8c90d986c5ca60cc3c1083dc0c643d66044dc40e --- M tests/rotate_localtime/Makefile.am 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/tests/rotate_localtime/Makefile.am b/tests/rotate_localtime/Makefile.am index f6ced6e..a9402aa 100644 --- a/tests/rotate_localtime/Makefile.am +++ b/tests/rotate_localtime/Makefile.am @@ -28,9 +28,7 @@ $(NULL) rotate_localtime_test_LDADD = \ - $(top_builddir)/src/osmo_pcap_file.o \ $(top_builddir)/src/osmo_server_core.o \ - $(top_builddir)/src/osmo_server_network.o \ $(top_builddir)/src/osmo_server_stats.o \ $(top_builddir)/src/osmo_tls.o \ $(LIBOSMOCORE_LIBS) \ -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39311?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I8c90d986c5ca60cc3c1083dc0c643d66044dc40e Gerrit-Change-Number: 39311 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

5 months, 1 week

1
0
0 0

[M] Change in pysim[master]: global_platform: add new command "install_cap"

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39199?usp=email ) Change subject: global_platform: add new command "install_cap" ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: I'ts great that you're adding a separate tutorial, but I think in addition to that you also need to add the command reference of the newly-introduced command to the normal manual? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39199?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6cbd37f0fad5579b20e83c27349bd5acc129e6d0 Gerrit-Change-Number: 39199 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jan 2025 12:38:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

5 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2025