January 2025 - gerrit-log - lists.osmocom.org

[M] Change in pysim[master]: global_platform: add new command "install_cap"

by dexter

Attention is currently required from: laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39199?usp=email ) Change subject: global_platform: add new command "install_cap" ...................................................................... Patch Set 6: (1 comment) Patchset: PS5: > I'ts great that you're adding a separate tutorial, but I think in addition to that you also need to […] Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39199?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6cbd37f0fad5579b20e83c27349bd5acc129e6d0 Gerrit-Change-Number: 39199 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 15 Jan 2025 15:01:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

5 months, 1 week

1
0
0 0

[M] Change in libosmo-netif[master]: Revert "contrib: remove rpm spec file"

by osmith

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39338?usp=email ) Change subject: Revert "contrib: remove rpm spec file" ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: CI: https://gerrit.osmocom.org/c/osmo-ci/+/39339 > [centos:7] https://jenkins.osmocom.org/jenkins/job/gerrit-binpkgs/13432/consoleFull -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39338?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I287b11059b0d45a691e7a8cde1d507081e57ea04 Gerrit-Change-Number: 39338 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Wed, 15 Jan 2025 15:01:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

5 months, 1 week

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/gerrit: build libosmo-netif for centos7

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/39339?usp=email ) Change subject: jobs/gerrit: build libosmo-netif for centos7 ...................................................................... jobs/gerrit: build libosmo-netif for centos7 osmo-pcap will soon depend on libosmo-netif, and we build osmo-pcap for centos7. Related: SYS#6760 Related: osmo-pcap I3562185f98685ea5a412273212e6dfbe55b360e2 Change-Id: Ie39f375152e8000c4e34bddd591c2c1ea91f9765 --- M jobs/gerrit-verifications.yml 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/39/39339/1 diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index fdec2e8..440f032 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -125,7 +125,10 @@ - libgtpnl - libosmo-abis - libosmo-gprs - - libosmo-netif + + - libosmo-netif: + pipeline_binpkgs: "centos:7 debian:10 debian:12" # centos7: SYS#6760 (osmo-pcap dep) + - libosmo-pfcp - libosmo-sigtran -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39339?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie39f375152e8000c4e34bddd591c2c1ea91f9765 Gerrit-Change-Number: 39339 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

5 months, 1 week

1
0
0 0

[M] Change in libosmo-netif[master]: Revert "contrib: remove rpm spec file"

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39338?usp=email ) Change subject: Revert "contrib: remove rpm spec file" ...................................................................... Revert "contrib: remove rpm spec file" Bring back the rpm spec file, as osmo-pcap will soon depend on libosmo-netif and we build osmo-pcap for centos7. This reverts commit 6930cceab0d54778e1e93d7a6ea9a891092469c4. Related: SYS#6760 Related: osmo-pcap I3562185f98685ea5a412273212e6dfbe55b360e2 Change-Id: I287b11059b0d45a691e7a8cde1d507081e57ea04 --- M Makefile.am M configure.ac A contrib/libosmo-netif.spec.in 3 files changed, 87 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/38/39338/1 diff --git a/Makefile.am b/Makefile.am index fd03b74..f50cd0f 100644 --- a/Makefile.am +++ b/Makefile.am @@ -9,6 +9,7 @@ EXTRA_DIST = \ .version \ README.md \ + contrib/libosmo-netif.spec.in \ debian \ git-version-gen \ $(NULL) diff --git a/configure.ac b/configure.ac index 9513270..ea8031b 100644 --- a/configure.ac +++ b/configure.ac @@ -135,4 +135,5 @@ utils/Makefile tests/Makefile Doxyfile - Makefile) + Makefile + contrib/libosmo-netif.spec) diff --git a/contrib/libosmo-netif.spec.in b/contrib/libosmo-netif.spec.in new file mode 100644 index 0000000..4ac1302 --- /dev/null +++ b/contrib/libosmo-netif.spec.in @@ -0,0 +1,84 @@ +# +# spec file for package libosmo-netif +# +# Copyright (c) 2018 SUSE LINUX GmbH, Nuernberg, Germany. +# +# All modifications and additions to the file contributed by third parties +# remain the property of their copyright owners, unless otherwise agreed +# upon. The license for this file, and modifications and additions to the +# file, is the same license as for the pristine package itself (unless the +# license for the pristine package is not an Open Source License, in which +# case the license is the MIT License). An "Open Source License" is a +# license that conforms to the Open Source Definition (Version 1.9) +# published by the Open Source Initiative. + +Name: libosmo-netif +Version: @VERSION@ +Release: 0 +Summary: Osmocom library for muxed audio +License: GPL-2.0-or-later +Group: Productivity/Telephony/Utilities +URL: https://osmocom.org/projects/libosmo-netif +Source: %{name}-%{version}.tar.xz +BuildRequires: automake +BuildRequires: libtool >= 2 +BuildRequires: lksctp-tools-devel +BuildRequires: pkgconfig >= 0.20 +BuildRequires: pkgconfig(libosmocore) >= 1.9.0 +BuildRequires: pkgconfig(libosmogsm) >= 1.9.0 +BuildRequires: pkgconfig(libosmocodec) >= 1.9.0 + +%description +Network interface demuxer library for OsmoCom projects. + +%package -n libosmonetif11 +Summary: Osmocom library for muxed audio +License: AGPL-3.0-or-later +Group: System/Libraries + +%description -n libosmonetif11 +Network interface demuxer library for OsmoCom projects. + +%package -n libosmonetif-devel +Summary: Development files for the Osmocom muxed audio library +License: AGPL-3.0-or-later +Group: Development/Libraries/C and C++ +Requires: libosmonetif11 = %{version} + +%description -n libosmonetif-devel +Network interface demuxer library for OsmoCom projects. + +This subpackage contains libraries and header files for developing +applications that want to make use of libosmo-netif. + +%prep +%setup -q + +%build +echo "%{version}" >.tarball-version +autoreconf -fiv +%configure --enable-shared --disable-static --includedir="%{_includedir}/%{name}" +make %{?_smp_mflags} + +%install +%make_install +find %{buildroot} -type f -name "*.la" -delete -print + +%check +make %{?_smp_mflags} check || (find . -name testsuite.log -exec cat {} +) + +%post -n libosmonetif11 -p /sbin/ldconfig +%postun -n libosmonetif11 -p /sbin/ldconfig + +%files -n libosmonetif11 +%{_libdir}/libosmonetif.so.11* + +%files -n libosmonetif-devel +%license COPYING +%dir %{_includedir}/%{name} +%dir %{_includedir}/%{name}/osmocom +%{_includedir}/%{name}/osmocom/netif/ +%{_libdir}/libosmonetif.so +%{_libdir}/pkgconfig/libosmo-netif.pc + +%changelog -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39338?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I287b11059b0d45a691e7a8cde1d507081e57ea04 Gerrit-Change-Number: 39338 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

5 months, 1 week

1
0
0 0

[M] Change in osmo-pcap[master]: server: Use osmo_stream_srv_link on tcp listen socket

by pespin

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcap/+/39324?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: server: Use osmo_stream_srv_link on tcp listen socket ...................................................................... server: Use osmo_stream_srv_link on tcp listen socket Related: SYS#7080 Change-Id: I3562185f98685ea5a412273212e6dfbe55b360e2 --- M configure.ac M contrib/jenkins.sh M contrib/osmo-pcap.spec.in M debian/control M include/osmo-pcap/osmo_pcap_server.h M src/Makefile.am M src/osmo_server_core.c M src/osmo_server_network.c M tests/rotate_localtime/Makefile.am 9 files changed, 31 insertions(+), 28 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/24/39324/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39324?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I3562185f98685ea5a412273212e6dfbe55b360e2 Gerrit-Change-Number: 39324 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

5 months, 1 week

1
0
0 0

[M] Change in osmo-pcap[master]: server: Use osmo_stream_srv_link on tcp listen socket

by pespin

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcap/+/39324?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified-1 by Jenkins Builder Change subject: server: Use osmo_stream_srv_link on tcp listen socket ...................................................................... server: Use osmo_stream_srv_link on tcp listen socket Related: SYS#7080 Change-Id: I3562185f98685ea5a412273212e6dfbe55b360e2 --- M configure.ac M contrib/jenkins.sh M debian/control M include/osmo-pcap/osmo_pcap_server.h M src/Makefile.am M src/osmo_server_core.c M src/osmo_server_network.c M tests/rotate_localtime/Makefile.am 8 files changed, 30 insertions(+), 28 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/24/39324/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39324?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I3562185f98685ea5a412273212e6dfbe55b360e2 Gerrit-Change-Number: 39324 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

5 months, 1 week

1
0
0 0

[M] Change in osmo-msc[master]: vlr: add PS support

by neels

Attention is currently required from: laforge, lynxis lazus, pespin. neels has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email ) Change subject: vlr: add PS support ...................................................................... Patch Set 5: Code-Review+1 (14 comments) Patchset: PS5: just some cosmetic and maintainability comments. File src/libvlr/vlr_lu_fsm.c: https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/7abdc8f4_c58932b8?usp… : PS5, Line 357: *! about the doxygen format comment: the `/*!` is in the wrong place here. To be associated with the 'N' member, a `/*! ... */` doxygen comment needs to go above the item. For inline commenting, you need to use `/*< ... */` instead. (no need to use doxygen IMHO, and IMHO comments above are in general nicer than inline ones, less clutter in future editing.) https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/9963069f_44d3e2b1?usp… : PS5, Line 569: static void vlr_lu_compl_fsm_reset_n(struct osmo_fsm_inst *fi, uint32_t prev_state) > I'll copy the same code in here then. […] I think this does not need to change -- this function is called for multiple different FSM onenter events, so there is no single accurate name. So I think the naming is actually chosen well. We could have three individually named my_state_name_onenter() functions and each of them calls the non-duplicated vlr_lu_compl_fsm_reset_n() function. That would be ultra perfect but given the short function body, this is clearly clutter, which is also a thing to aviod. All in all this is an even steven, on a purely cosmetic item, and i would just leave the patch as it is. https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/08254f62_88407a50?usp… : PS5, Line 587: return 1; (personally i prefer incrementing on a separate code line, for more trivial code clarity) https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/1b4bc96b_414fde38?usp… : PS5, Line 589: LOGPFSML(fi, LOGL_ERROR, "LU Compl timeout %d / %d\n", fi->T, lcvp->N); let's have "T%d / N%d" https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/3217ef09_af7c2e47?usp… : PS5, Line 598: break; (we often have a default: OSMO_ASSERT(false) in these to ensure we notice enum bugs) https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/fb26f96e_e605c48a?usp… : PS5, Line 771: /*! count times timer T timed out */ (maybe: "count nr of times that timer...") https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/e19badc2_afbf9456?usp… : PS5, Line 1437: static void lu_fsm_reset_n(struct osmo_fsm_inst *fi, uint32_t prev_state) > Acknowledged i agree with pau here because it is only one FSM state's onenter action https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/2f512e72_c77a3092?usp… : PS5, Line 1570: { (would be nice to have a short one-liner comment to indicate what this does / why it needs to go in the rather unusual _preterm()) https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/4331c108_c82d930f?usp… : PS5, Line 1582: RVIV a libosmocore typo? https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/66157004_af050256?usp… : PS5, Line 1586: gsm48_cause = GSM48_REJECT_NETWORK_FAILURE; (add "break;" in the end) https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/22e5df51_1de64d5a?usp… : PS5, Line 1597: mian typo https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/364b8e8e_e12b4583?usp… : PS5, Line 1611: fi->T technically, middle arg should be 0 or -1 or so, because vlr_is_cs() == false from above. (btw, i wonder a bit why it is necessary to pass two args to vlr_timer_secs(), still waiting for the caller that passes two distinct values. the patch adding the second arg is already merged.) https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/dc8d3532_034439a0?usp… : PS5, Line 1742: (two blank lines, unusual for osmocom) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie9ffeb140c9d354b3a0f4822e2619f623235add0 Gerrit-Change-Number: 38490 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 15 Jan 2025 14:31:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

5 months, 1 week

1
0
0 0

[XS] Change in libosmo-netif[master]: add dependency on libosmovty

by falconia

Attention is currently required from: laforge. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39308?usp=email ) Change subject: add dependency on libosmovty ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I would suggest to merge this into the actual commit that makes use of libosmovty. […] That was how I had it originally, but then I thought that dependency additions should be factored out and made very explicit. But if both you and @pespin@sysmocom.de prefer it the other way, I'll go back to the way I had it originally. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39308?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I57cb919891e5c7ee0f828b98af11199cd9c123f8 Gerrit-Change-Number: 39308 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 15 Jan 2025 14:25:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

5 months, 1 week

1
0
0 0

[XS] Change in osmo-pcap[master]: server: Log unable to figure out pcap vs pcapng

by pespin

Attention is currently required from: laforge, pespin. Hello laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcap/+/39326?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge Change subject: server: Log unable to figure out pcap vs pcapng ...................................................................... server: Log unable to figure out pcap vs pcapng Change-Id: I110456f142cab88ba9d51409b66d66cf093adb9f --- M src/osmo_server_network.c 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/26/39326/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39326?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I110456f142cab88ba9d51409b66d66cf093adb9f Gerrit-Change-Number: 39326 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

5 months, 1 week

1
0
0 0

[XS] Change in osmo-msc[master]: vlr: extend the subscriber invalidate callback with reasons

by neels

Attention is currently required from: lynxis lazus. neels has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38488?usp=email ) Change subject: vlr: extend the subscriber invalidate callback with reasons ...................................................................... Patch Set 5: Code-Review+1 (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-msc/+/38488/comment/9db0eaec_dddc7a71?usp… : PS5, Line 10: There are multiple cases when this happens: (maybe a good idea too add this very useful list in the api doc comment for the callback) File include/osmocom/vlr/vlr.h: https://gerrit.osmocom.org/c/osmo-msc/+/38488/comment/0643a0a8_eb8d2369?usp… : PS5, Line 253: (maybe good to describe the meaning of the cancel_by_update argument) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38488?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie5b687318b106a230fcee52deba86649641004b3 Gerrit-Change-Number: 38488 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 15 Jan 2025 13:34:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

5 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2025