January 2025 - gerrit-log - lists.osmocom.org

[M] Change in osmo-bsc[master]: nokia_site: add object_type, object_state and reset_type

by csaba.sipos

csaba.sipos has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39315?usp=email ) Change subject: nokia_site: add object_type, object_state and reset_type ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Hi Pau, The only warning Jenkins gave is that the newly added functions are not used. Which is correct as this commit only adds these elements, related functions are coming later. What should I do? Keep it like this and then this can be reviewed and merged, or I can also revoke this commit and add everything together later. Although I think it is better to keep these patches small and separate. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39315?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0f31cd711768c963e5c14c0f4969ff76cb05c12b Gerrit-Change-Number: 39315 Gerrit-PatchSet: 1 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jan 2025 15:13:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

5 months, 1 week

1
0
0 0

[M] Change in osmo-pcap[master]: server: Split buffer read from full msg handling

by pespin

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcap/+/39323?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: server: Split buffer read from full msg handling ...................................................................... server: Split buffer read from full msg handling This also simplifies follow-up patches modifying the way we read packets through osmo_stream. Change-Id: Ie7b8af0edbccc83812a44c6bfd61c98fbc3df324 --- M src/osmo_server_network.c 1 file changed, 37 insertions(+), 28 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/23/39323/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39323?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Ie7b8af0edbccc83812a44c6bfd61c98fbc3df324 Gerrit-Change-Number: 39323 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

5 months, 1 week

1
0
0 0

[M] Change in libosmo-netif[master]: Revert "contrib: remove rpm spec file"

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39338?usp=email ) Change subject: Revert "contrib: remove rpm spec file" ...................................................................... Revert "contrib: remove rpm spec file" Bring back the rpm spec file, as osmo-pcap will soon depend on libosmo-netif and we build osmo-pcap for centos7. This reverts commit 6930cceab0d54778e1e93d7a6ea9a891092469c4. Related: SYS#6760 Related: osmo-pcap I3562185f98685ea5a412273212e6dfbe55b360e2 Change-Id: I287b11059b0d45a691e7a8cde1d507081e57ea04 --- M Makefile.am M configure.ac A contrib/libosmo-netif.spec.in 3 files changed, 87 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/Makefile.am b/Makefile.am index fd03b74..f50cd0f 100644 --- a/Makefile.am +++ b/Makefile.am @@ -9,6 +9,7 @@ EXTRA_DIST = \ .version \ README.md \ + contrib/libosmo-netif.spec.in \ debian \ git-version-gen \ $(NULL) diff --git a/configure.ac b/configure.ac index 9513270..ea8031b 100644 --- a/configure.ac +++ b/configure.ac @@ -135,4 +135,5 @@ utils/Makefile tests/Makefile Doxyfile - Makefile) + Makefile + contrib/libosmo-netif.spec) diff --git a/contrib/libosmo-netif.spec.in b/contrib/libosmo-netif.spec.in new file mode 100644 index 0000000..4ac1302 --- /dev/null +++ b/contrib/libosmo-netif.spec.in @@ -0,0 +1,84 @@ +# +# spec file for package libosmo-netif +# +# Copyright (c) 2018 SUSE LINUX GmbH, Nuernberg, Germany. +# +# All modifications and additions to the file contributed by third parties +# remain the property of their copyright owners, unless otherwise agreed +# upon. The license for this file, and modifications and additions to the +# file, is the same license as for the pristine package itself (unless the +# license for the pristine package is not an Open Source License, in which +# case the license is the MIT License). An "Open Source License" is a +# license that conforms to the Open Source Definition (Version 1.9) +# published by the Open Source Initiative. + +Name: libosmo-netif +Version: @VERSION@ +Release: 0 +Summary: Osmocom library for muxed audio +License: GPL-2.0-or-later +Group: Productivity/Telephony/Utilities +URL: https://osmocom.org/projects/libosmo-netif +Source: %{name}-%{version}.tar.xz +BuildRequires: automake +BuildRequires: libtool >= 2 +BuildRequires: lksctp-tools-devel +BuildRequires: pkgconfig >= 0.20 +BuildRequires: pkgconfig(libosmocore) >= 1.9.0 +BuildRequires: pkgconfig(libosmogsm) >= 1.9.0 +BuildRequires: pkgconfig(libosmocodec) >= 1.9.0 + +%description +Network interface demuxer library for OsmoCom projects. + +%package -n libosmonetif11 +Summary: Osmocom library for muxed audio +License: AGPL-3.0-or-later +Group: System/Libraries + +%description -n libosmonetif11 +Network interface demuxer library for OsmoCom projects. + +%package -n libosmonetif-devel +Summary: Development files for the Osmocom muxed audio library +License: AGPL-3.0-or-later +Group: Development/Libraries/C and C++ +Requires: libosmonetif11 = %{version} + +%description -n libosmonetif-devel +Network interface demuxer library for OsmoCom projects. + +This subpackage contains libraries and header files for developing +applications that want to make use of libosmo-netif. + +%prep +%setup -q + +%build +echo "%{version}" >.tarball-version +autoreconf -fiv +%configure --enable-shared --disable-static --includedir="%{_includedir}/%{name}" +make %{?_smp_mflags} + +%install +%make_install +find %{buildroot} -type f -name "*.la" -delete -print + +%check +make %{?_smp_mflags} check || (find . -name testsuite.log -exec cat {} +) + +%post -n libosmonetif11 -p /sbin/ldconfig +%postun -n libosmonetif11 -p /sbin/ldconfig + +%files -n libosmonetif11 +%{_libdir}/libosmonetif.so.11* + +%files -n libosmonetif-devel +%license COPYING +%dir %{_includedir}/%{name} +%dir %{_includedir}/%{name}/osmocom +%{_includedir}/%{name}/osmocom/netif/ +%{_libdir}/libosmonetif.so +%{_libdir}/pkgconfig/libosmo-netif.pc + +%changelog -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39338?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I287b11059b0d45a691e7a8cde1d507081e57ea04 Gerrit-Change-Number: 39338 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

5 months, 1 week

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/gerrit: build libosmo-netif for centos7

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/39339?usp=email ) Change subject: jobs/gerrit: build libosmo-netif for centos7 ...................................................................... jobs/gerrit: build libosmo-netif for centos7 osmo-pcap will soon depend on libosmo-netif, and we build osmo-pcap for centos7. Related: SYS#6760 Related: osmo-pcap I3562185f98685ea5a412273212e6dfbe55b360e2 Change-Id: Ie39f375152e8000c4e34bddd591c2c1ea91f9765 --- M jobs/gerrit-verifications.yml 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index fdec2e8..440f032 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -125,7 +125,10 @@ - libgtpnl - libosmo-abis - libosmo-gprs - - libosmo-netif + + - libosmo-netif: + pipeline_binpkgs: "centos:7 debian:10 debian:12" # centos7: SYS#6760 (osmo-pcap dep) + - libosmo-pfcp - libosmo-sigtran -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39339?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie39f375152e8000c4e34bddd591c2c1ea91f9765 Gerrit-Change-Number: 39339 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

5 months, 1 week

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/gerrit: build libosmo-netif for centos7

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/39339?usp=email ) Change subject: jobs/gerrit: build libosmo-netif for centos7 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39339?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie39f375152e8000c4e34bddd591c2c1ea91f9765 Gerrit-Change-Number: 39339 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jan 2025 15:08:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 1 week

1
0
0 0

[M] Change in libosmo-netif[master]: Revert "contrib: remove rpm spec file"

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39338?usp=email ) Change subject: Revert "contrib: remove rpm spec file" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39338?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I287b11059b0d45a691e7a8cde1d507081e57ea04 Gerrit-Change-Number: 39338 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jan 2025 15:06:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 1 week

1
0
0 0

[M] Change in osmo-pcap[master]: server: Split buffer read from full msg handling

by pespin

Attention is currently required from: laforge, pespin. Hello laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcap/+/39323?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge Change subject: server: Split buffer read from full msg handling ...................................................................... server: Split buffer read from full msg handling This also simplifies follow-up patches modifying the way we read packets through osmo_stream. Change-Id: Ie7b8af0edbccc83812a44c6bfd61c98fbc3df324 --- M src/osmo_server_network.c 1 file changed, 37 insertions(+), 28 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/23/39323/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39323?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Ie7b8af0edbccc83812a44c6bfd61c98fbc3df324 Gerrit-Change-Number: 39323 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

5 months, 1 week

1
0
0 0

[M] Change in pysim[master]: global_platform: LOAD and INSTALL [for load] support

by dexter

Attention is currently required from: laforge. dexter has uploaded a new patch set (#7) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/pysim/+/37454?usp=email ) The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: global_platform: LOAD and INSTALL [for load] support ...................................................................... global_platform: LOAD and INSTALL [for load] support In this patch we add the commands "install_for_load" and "load". Depends: pyosmocom.git I86df064fa41db85923eeb0d83cc399504fdd4488 Change-Id: I924aaeecbb3a72bdb65eefbff6135e4e9570579e Related: OS#6679 --- M docs/shell.rst M pySim/global_platform/__init__.py M requirements.txt M setup.py 4 files changed, 80 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/54/37454/7 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37454?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I924aaeecbb3a72bdb65eefbff6135e4e9570579e Gerrit-Change-Number: 37454 Gerrit-PatchSet: 7 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org>

5 months, 1 week

1
0
0 0

[M] Change in pysim[master]: global_platform: LOAD and INSTALL [for load] support

by dexter

Attention is currently required from: laforge. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/37454?usp=email ) Change subject: global_platform: LOAD and INSTALL [for load] support ...................................................................... Patch Set 7: (1 comment) Patchset: PS6: > I think the manual will need an update to cover this new command? Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37454?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I924aaeecbb3a72bdb65eefbff6135e4e9570579e Gerrit-Change-Number: 37454 Gerrit-PatchSet: 7 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 15 Jan 2025 15:01:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

5 months, 1 week

1
0
0 0

[M] Change in pysim[master]: global_platform: add new command "install_cap"

by dexter

Attention is currently required from: laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/39199?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: global_platform: add new command "install_cap" ...................................................................... global_platform: add new command "install_cap" Installing JAVA-card applets from a CAP file is a multi step process, which is difficult when done manually. Fortunately it is easy to automate the process, so let's add a dedicated command for that. Change-Id: I6cbd37f0fad5579b20e83c27349bd5acc129e6d0 Related: OS#6679 --- A docs/cap-tutorial.rst M docs/shell.rst M pySim/global_platform/__init__.py A pySim/global_platform/install_param.py M tests/unittests/test_globalplatform.py 5 files changed, 241 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/99/39199/6 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39199?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6cbd37f0fad5579b20e83c27349bd5acc129e6d0 Gerrit-Change-Number: 39199 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org>

5 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2025