January 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ttcn3-hacks[master]: L3_Templates: add MM cause codes

by lynxis lazus

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39264?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: L3_Templates: add MM cause codes ...................................................................... L3_Templates: add MM cause codes It will be used by SGSN Context Req/Resp/Ack test cases in the SGSN. Change-Id: I396ddaf5b08faddcf002317307dcc20840898aa9 --- M library/L3_Templates.ttcn 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/64/39264/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39264?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I396ddaf5b08faddcf002317307dcc20840898aa9 Gerrit-Change-Number: 39264 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

4 months, 3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: SGSN: Remove unsupport test cases

by lynxis lazus

Attention is currently required from: fixeria. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39261?usp=email ) Change subject: SGSN: Remove unsupport test cases ...................................................................... Patch Set 3: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39261/comment/e9571221_eb95… : PS3, Line 7: Remove > (nitpick: you're actually disabling and not removing them) right, i'll remove them now https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39261/comment/38335075_af06… : PS3, Line 10: the IMSI, but don't request information from the HLR) will be removed from the > is there a line break where it shouldn't be. […] because of 60 char limit? I added a new line to improve readability. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39261?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1506324300fe3864069706d5b05860e7b44cd895 Gerrit-Change-Number: 39261 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Jan 2025 22:55:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: SGSN: add TC_attach_gmm_attach_req_while_gmm_attach_changed

by lynxis lazus

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256?usp=email ) Change subject: SGSN: add TC_attach_gmm_attach_req_while_gmm_attach_changed ...................................................................... Patch Set 3: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256/comment/9bb93f71_9bff… : PS3, Line 12: message, the old GMM Attach should be discard silently and a new > dicarded? Done File sgsn/SGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256/comment/d104dca4_fde9… : PS3, Line 2215: /* FIXME: Extract P-TMSI, if any. Only send Complete if necessary */ > what about this? Something to improve, but the test case is already testing the important stuff. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia721d3c29bf09014b197670ae02d1cd1901750bc Gerrit-Change-Number: 39256 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Jan 2025 22:44:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: SGSN: add TC_attach_gmm_attach_req_while_gmm_attach_retransmit

by lynxis lazus

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39255?usp=email ) Change subject: SGSN: add TC_attach_gmm_attach_req_while_gmm_attach_retransmit ...................................................................... Patch Set 3: (1 comment) File sgsn/SGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39255/comment/4ea89820_0ae3… : PS3, Line 2125: /* send out a second GMM_Attach Request. > same here, this is not true here, no second GMM attach here... please re-read the whole test. removed it. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39255?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8d208c0a98675238dba439ab3e75758293928588 Gerrit-Change-Number: 39255 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Jan 2025 22:40:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: SGSN: TC_attach_gmm_attach_req_while_gmm_attach: fix test case

by lynxis lazus

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39254?usp=email ) Change subject: SGSN: TC_attach_gmm_attach_req_while_gmm_attach: fix test case ...................................................................... Patch Set 2: (2 comments) File sgsn/SGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39254/comment/e1e8d923_1d25… : PS2, Line 2044: /* send out a second GMM_Attach Request. > this comment no longer matches the code, you moved the second attach above... […] because the test case doesn't work this way anymore (or as soon libvlr is used). I'll remove case https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39254/comment/c442672b_3f8e… : PS2, Line 2050: [] as_gmm_auth(umts_aka_challenge := true, expect_sai := true) {}; > AFAIU the auth is exected to happen at the end of the whole alt? maybe simply move it outside to exp […] I don't see what's the problem. The flow is something like this: -> Attach Req (tmsi unknown) <- Id Req -> Id Resp HLR: SAI -> Attach Req (2nd) The second Attach Req should be ignored by the SGSN, because it contains the same Attach Req. <- Auth Req -> Auth Resp HLR: LU/ISD <- Attach Accept -> Attach Complete -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39254?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I026499844940d4c3d82b0fbd61be636c6ca348e6 Gerrit-Change-Number: 39254 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Jan 2025 22:37:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: SGSN: TC_attach_gmm_attach_req_while_gmm_attach: fix test case

by lynxis lazus

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39254?usp=email ) Change subject: SGSN: TC_attach_gmm_attach_req_while_gmm_attach: fix test case ...................................................................... Patch Set 2: (2 comments) File sgsn/BSSGP_ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39254/comment/81439817_1b43… : PS2, Line 534: function f_random_ptmsi(OCT1 suffix := '00'O) return OCT4 { > library/Osmocom_Gb_Types.ttcn […] Unsure what you want to tell me here. TLLI != P-TMSI. I also want to have a suffix. Further the or4b doesn't seem the right for me, because I explicit want to have 0xc0 in the highest byte and not 0xcX, where X is random. File sgsn/SGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39254/comment/b9e85387_8726… : PS2, Line 2088: f_vty_config(SGSNVTY, "sgsn", "auth-policy accept-all"); > why was this removed? Because the test case doesn't require it, nor is this feature supported in the future. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39254?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I026499844940d4c3d82b0fbd61be636c6ca348e6 Gerrit-Change-Number: 39254 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Jan 2025 22:28:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: MSC Tests: add TC_gsup_lu_and_det: do a LU, Detach and expect GSUP MS...

by lynxis lazus

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39236?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: MSC Tests: add TC_gsup_lu_and_det: do a LU, Detach and expect GSUP MS Purge ...................................................................... MSC Tests: add TC_gsup_lu_and_det: do a LU, Detach and expect GSUP MS Purge Currently the MSC/VLR doesn't inform the HLR when a MS detaches. Change-Id: I9e87537efc2c921fa860539a706316ed410b45d5 --- M msc/MSC_Tests.ttcn M msc/expected-results.xml 2 files changed, 21 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/36/39236/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39236?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9e87537efc2c921fa860539a706316ed410b45d5 Gerrit-Change-Number: 39236 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

4 months, 3 weeks

1
0
0 0

[XS] Change in osmo-msc[master]: vlr: only set HLR number if field is present

by lynxis lazus

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/39232?usp=email ) Change subject: vlr: only set HLR number if field is present ...................................................................... vlr: only set HLR number if field is present Change-Id: I26dc4c00b81723cd7ead095a515269afd0f73f8e --- M src/libvlr/vlr.c 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified daniel: Looks good to me, approved diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c index 12efdea..95b081a 100644 --- a/src/libvlr/vlr.c +++ b/src/libvlr/vlr.c @@ -439,8 +439,10 @@ gsup_msg.message_type = OSMO_GSUP_MSGT_PURGE_MS_REQUEST; /* provide HLR number in case we know it */ - gsup_msg.hlr_enc_len = vsub->hlr.len; - gsup_msg.hlr_enc = vsub->hlr.buf; + if (vsub->hlr.len) { + gsup_msg.hlr_enc_len = vsub->hlr.len; + gsup_msg.hlr_enc = vsub->hlr.buf; + } gsup_msg.cn_domain = vlr_is_cs(vsub->vlr) ? OSMO_GSUP_CN_DOMAIN_CS : OSMO_GSUP_CN_DOMAIN_PS; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/39232?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I26dc4c00b81723cd7ead095a515269afd0f73f8e Gerrit-Change-Number: 39232 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[S] Change in ...osmo-s1gw[master]: Add GSMTAP logging handler

by pespin

Attention is currently required from: fixeria, laforge, osmith. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39415?usp=email ) Change subject: Add GSMTAP logging handler ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39415?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Iea884e2ca146b852c64bd9f135d8c71f4c925f09 Gerrit-Change-Number: 39415 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Jan 2025 19:27:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 3 weeks

1
0
0 0

[S] Change in ...osmo-s1gw[master]: Add GSMTAP logging handler

by fixeria

Attention is currently required from: laforge, osmith, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39415?usp=email ) Change subject: Add GSMTAP logging handler ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39415?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Iea884e2ca146b852c64bd9f135d8c71f4c925f09 Gerrit-Change-Number: 39415 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Jan 2025 19:12:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

4 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2025