January 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-msc[master]: vlr: extend the subscriber invalidate callback with reasons

by lynxis lazus

Attention is currently required from: neels, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38488?usp=email ) Change subject: vlr: extend the subscriber invalidate callback with reasons ...................................................................... Patch Set 5: (6 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-msc/+/38488/comment/9b4592a5_f1231a9f?usp… : PS5, Line 9: The VLR must be allowed to notify the MSC if an subscriber becomes invalid. > a subscriber Done https://gerrit.osmocom.org/c/osmo-msc/+/38488/comment/ace03b52_c41d61f8?usp… : PS5, Line 10: There are multiple cases when this happens: > (maybe a good idea too add this very useful list in the api doc comment for the callback) Done https://gerrit.osmocom.org/c/osmo-msc/+/38488/comment/4396518e_7dbe7fb4?usp… : PS5, Line 13: b) if the HLR do a Cancel Location Procedure with reason withdraw > does Done https://gerrit.osmocom.org/c/osmo-msc/+/38488/comment/547fb219_a2cce661?usp… : PS5, Line 13: b) if the HLR do a Cancel Location Procedure with reason withdraw @neels I'm a little bit unsure, if the MSC informs the user. So far there isn't a IMSI detach by the network. You could do a paging, but why should you do it? This would increase the traffic for a subscriber which shouldn't get any further service. If you do paging, what do you send? A MM Status with reason 33 (Requested service option not subscribed)? So if you don't page, the MS will do a Location update Request or Service Request at some point which can be rejected (guess with the same code?). https://gerrit.osmocom.org/c/osmo-msc/+/38488/comment/c677a83c_032a8a97?usp… : PS5, Line 14: c) if the HLR do a Cancel Location Procedure with reason update location. > does Done https://gerrit.osmocom.org/c/osmo-msc/+/38488/comment/e9839180_8840abe3?usp… : PS5, Line 17: For c) the MSC must inform the MS about the reason. > This line is wrong. For c) the MSC doesn't inform the MS about the reason, it is already gone. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38488?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie5b687318b106a230fcee52deba86649641004b3 Gerrit-Change-Number: 38488 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Jan 2025 23:49:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

4 months, 3 weeks

1
0
0 0

[S] Change in osmo-sgsn[master]: gprs_gmm_util: use a RAU specific TLV dictionary

by lynxis lazus

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39247?usp=email ) Change subject: gprs_gmm_util: use a RAU specific TLV dictionary ...................................................................... Patch Set 2: (1 comment) File src/sgsn/gprs_gmm_util.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/39247/comment/319fcdef_a1f8ed0d?us… : PS1, Line 265: ret = tlv_parse(&rau_req->tlv, &gsm48_gmm_rau_ie_tlvdef, > struct osmo_tlv_prot_def, osmo_tlv_prot_parse() I'm not sure if osmo_tlv_prot_def is a big help here. The IE/TLVs differ a lot between the messages (which you can also do with osmo_tlv_prot_def), but the static parts, which doesn't have a "T" of TLV are complete different from each other. Also the offsets, where the TLVs are starting are different from each message. So I would keep it as it is and migrate, if reasonable, to osmo_tlv_prot_def in a later commit. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39247?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I460971deeebc9977a984937c542b263d941e78df Gerrit-Change-Number: 39247 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Jan 2025 23:23:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

4 months, 3 weeks

1
0
0 0

[M] Change in osmo-sgsn[master]: GMM: rework PDP context status

by lynxis lazus

Attention is currently required from: laforge, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39241?usp=email ) Change subject: GMM: rework PDP context status ...................................................................... Patch Set 2: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-sgsn/+/39241/comment/16cfe2e2_aaa79d9b?us… : PS2, Line 11: mobilty this could change). It resynchronize the UE with the SGSN > resynchronizes Done File src/sgsn/gprs_gmm.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/39241/comment/401cc2c9_250934d3?us… : PS1, Line 200: /* 3GPP TS 24.008 § 10.5.7.1 Process PDP context status value, bit 0 correspond to nsapi 0 */ > corresponds Done -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39241?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I12d3110c9365132f96ef7ff8a1be22a431682c81 Gerrit-Change-Number: 39241 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Jan 2025 23:16:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[M] Change in osmo-ggsn[master]: gtp: split gtp_req into 2 parts: transmit and fill header

by lynxis lazus

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/39237?usp=email ) Change subject: gtp: split gtp_req into 2 parts: transmit and fill header ...................................................................... gtp: split gtp_req into 2 parts: transmit and fill header Split the preparing the data from the socket and queue handling into two functions: gtp_req(): preparing the data gtp_req_transmit(): selecting socket, port and adding it to the transmit queue. In a following commit gtp_req_transmit() can be used by gtpv1 function as well. Change-Id: Icda0ef7b0ce3631e23da88827dd54cf019878b5d --- M gtp/gtp.c 1 file changed, 47 insertions(+), 29 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve daniel: Looks good to me, approved laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/gtp/gtp.c b/gtp/gtp.c index c40e767..3209a64 100644 --- a/gtp/gtp.c +++ b/gtp/gtp.c @@ -339,13 +339,12 @@ * a predefined timeout. *************************************************************/ -static int gtp_req(struct gsn_t *gsn, uint8_t version, struct pdp_t *pdp, - union gtp_packet *packet, int len, - const struct in_addr *inetaddr, void *cbp) +static int gtp_req_transmit(struct gsn_t *gsn, uint8_t version, const struct in_addr *inetaddr, + union gtp_packet *packet, int len, + struct pdp_t *pdp, void *cbp) { - uint8_t ver = GTPHDR_F_GET_VER(packet->flags); - struct sockaddr_in addr; struct qmsg_t *qmsg; + struct sockaddr_in addr; int fd; memset(&addr, 0, sizeof(addr)); @@ -355,33 +354,18 @@ addr.sin_len = sizeof(addr); #endif - if (ver == 0) { /* Version 0 */ - addr.sin_port = htons(GTP0_PORT); - packet->gtp0.h.length = hton16(len - GTP0_HEADER_SIZE); - packet->gtp0.h.seq = hton16(gsn->seq_next); - if (pdp) { - packet->gtp0.h.tid = - htobe64(pdp_gettid(pdp->imsi, pdp->nsapi)); - } - if (pdp && ((packet->gtp0.h.type == GTP_GPDU) - || (packet->gtp0.h.type == GTP_ERROR))) - packet->gtp0.h.flow = hton16(pdp->flru); - else if (pdp) - packet->gtp0.h.flow = hton16(pdp->flrc); + switch (version) { + case 0: fd = gsn->fd0; - } else if (ver == 1 && (packet->flags & GTP1HDR_F_SEQ)) { /* Version 1 with seq */ + addr.sin_port = htons(GTP0_PORT); + break; + case 1: addr.sin_port = htons(GTP1C_PORT); - packet->gtp1l.h.length = hton16(len - GTP1_HEADER_SIZE_SHORT); - packet->gtp1l.h.seq = hton16(gsn->seq_next); - if (pdp && ((packet->gtp1l.h.type == GTP_GPDU) || - (packet->gtp1l.h.type == GTP_ERROR))) - packet->gtp1l.h.tei = hton32(pdp->teid_gn); - else if (pdp) - packet->gtp1l.h.tei = hton32(pdp->teic_gn); fd = gsn->fd1c; - } else { - LOGP(DLGTP, LOGL_ERROR, "Unknown packet flags: 0x%02x\n", packet->flags); - return -1; + break; + default: + LOGP(DLGTP, LOGL_ERROR, "Invalid GTP version %d\n", version); + return -EINVAL; } if (sendto(fd, packet, len, 0, @@ -420,6 +404,40 @@ return 0; } +static int gtp_req(struct gsn_t *gsn, uint8_t version, struct pdp_t *pdp, + union gtp_packet *packet, int len, + const struct in_addr *inetaddr, void *cbp) +{ + uint8_t ver = GTPHDR_F_GET_VER(packet->flags); + + if (ver == 0) { /* Version 0 */ + packet->gtp0.h.length = hton16(len - GTP0_HEADER_SIZE); + packet->gtp0.h.seq = hton16(gsn->seq_next); + if (pdp) { + packet->gtp0.h.tid = + htobe64(pdp_gettid(pdp->imsi, pdp->nsapi)); + } + if (pdp && ((packet->gtp0.h.type == GTP_GPDU) + || (packet->gtp0.h.type == GTP_ERROR))) + packet->gtp0.h.flow = hton16(pdp->flru); + else if (pdp) + packet->gtp0.h.flow = hton16(pdp->flrc); + } else if (ver == 1 && (packet->flags & GTP1HDR_F_SEQ)) { /* Version 1 with seq */ + packet->gtp1l.h.length = hton16(len - GTP1_HEADER_SIZE_SHORT); + packet->gtp1l.h.seq = hton16(gsn->seq_next); + if (pdp && ((packet->gtp1l.h.type == GTP_GPDU) || + (packet->gtp1l.h.type == GTP_ERROR))) + packet->gtp1l.h.tei = hton32(pdp->teid_gn); + else if (pdp) + packet->gtp1l.h.tei = hton32(pdp->teic_gn); + } else { + LOGP(DLGTP, LOGL_ERROR, "Unknown packet flags: 0x%02x\n", packet->flags); + return -1; + } + + return gtp_req_transmit(gsn, version, inetaddr, packet, len, pdp, cbp); +} + /* gtp_conf * Remove signalling packet from retransmission queue. * return 0 on success, EOF if packet was not found */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/39237?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Icda0ef7b0ce3631e23da88827dd54cf019878b5d Gerrit-Change-Number: 39237 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[M] Change in osmo-ggsn[master]: gtpie: add gtp_encaps a modern encapsulation method

by lynxis lazus

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/39032?usp=email ) Change subject: gtpie: add gtp_encaps a modern encapsulation method ...................................................................... gtpie: add gtp_encaps a modern encapsulation method No idea why the previous ones started at the second IE. Further add more length arguments to the encapsulation method. Change-Id: I8bb086c568e07052c52d880df06049490346e91e --- M gtp/gtpie.c M include/osmocom/gtp/gtpie.h 2 files changed, 188 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified daniel: Looks good to me, approved diff --git a/gtp/gtpie.c b/gtp/gtpie.c index b3f2ff7..84a3ec2 100644 --- a/gtp/gtpie.c +++ b/gtp/gtpie.c @@ -944,3 +944,189 @@ } return 0; } + +/*! Encode GTP packet payload from Array of Information Elements. + * \param[in] ie Input Array of GTPIE + * \param[in] ie_len Length of \a ie array + * \param[in] pack Pointer to caller-allocated buffer for raw GTP packet (GTPIE_MAX length) + * \param[in] pack_len Length of \a pack buffer + * \param[out] encoded_len Encoded length of \a pack in bytes + * \returns 0 on success; 2 for out-of-space + * GTP requires a certain order, the call must follow those which are defined for every message */ +int gtpie_encaps3(union gtpie_member *ies[], unsigned int ie_len, + void *pack, unsigned pack_len, unsigned *encoded_len) +{ + unsigned int i; + unsigned char *p; + unsigned char *end; + int iesize; + union gtpie_member *ie; + + *encoded_len = 0; + p = pack; + + memset(pack, 0, pack_len); + end = p + pack_len; + for (i = 0; i < ie_len; i++) { + if (!ies[i]) + continue; + ie = ies[i]; + + if (GTPIE_DEBUG) + printf + ("gtpie_encaps. Number %d, Type %d\n", + i, ie->t); + switch (ie->t) { + case GTPIE_CAUSE: /* TV GTPIE types with value length 1 */ + case GTPIE_REORDER: + case GTPIE_MAP_CAUSE: + case GTPIE_MS_VALIDATED: + case GTPIE_RECOVERY: + case GTPIE_SELECTION_MODE: + case GTPIE_TEARDOWN: + case GTPIE_NSAPI: + case GTPIE_RANAP_CAUSE: + case GTPIE_RP_SMS: + case GTPIE_RP: + case GTPIE_MS_NOT_REACH: + case GTPIE_BCM: + iesize = 2; + break; + case GTPIE_PFI: /* TV GTPIE types with value length 2 */ + case GTPIE_CHARGING_C: + case GTPIE_TRACE_REF: + case GTPIE_TRACE_TYPE: + iesize = 3; + break; + case GTPIE_QOS_PROFILE0: /* TV GTPIE types with value length 3 */ + case GTPIE_P_TMSI_S: + iesize = 4; + break; + case GTPIE_TLLI: /* TV GTPIE types with value length 4 */ + case GTPIE_P_TMSI: + case GTPIE_TEI_DI: + case GTPIE_TEI_C: + case GTPIE_CHARGING_ID: + iesize = 5; + break; + case GTPIE_TEI_DII: /* TV GTPIE types with value length 5 */ + iesize = 6; + break; + case GTPIE_RAI: /* TV GTPIE types with value length 6 */ + iesize = 7; + break; + case GTPIE_RAB_CONTEXT: /* TV GTPIE types with value length 7 */ + iesize = 8; + break; + case GTPIE_IMSI: /* TV GTPIE types with value length 8 */ + iesize = 9; + break; + case GTPIE_AUTH_TRIPLET: /* TV GTPIE types with value length 28 */ + iesize = 29; + break; + case GTPIE_EXT_HEADER_T: /* GTP extension header */ + iesize = 2 + hton8(ie->ext.l); + break; + case GTPIE_EUA: /* TLV GTPIE types with length length 2 */ + case GTPIE_MM_CONTEXT: + case GTPIE_PDP_CONTEXT: + case GTPIE_APN: + case GTPIE_PCO: + case GTPIE_GSN_ADDR: + case GTPIE_MSISDN: + case GTPIE_QOS_PROFILE: + case GTPIE_AUTH_QUINTUP: + case GTPIE_TFT: + case GTPIE_TARGET_INF: + case GTPIE_UTRAN_TRANS: + case GTPIE_RAB_SETUP: + case GTPIE_TRIGGER_ID: + case GTPIE_OMC_ID: + case GTPIE_RAN_T_CONTAIN: + case GTPIE_PDP_CTX_PRIO: + case GTPIE_ADDL_RAB_S_I: + case GTPIE_SGSN_NUMBER: + case GTPIE_COMMON_FLAGS: + case GTPIE_APN_RESTR: + case GTPIE_R_PRIO_LCS: + case GTPIE_RAT_TYPE: + case GTPIE_USER_LOC: + case GTPIE_MS_TZ: + case GTPIE_IMEI_SV: + case GTPIE_CML_CHG_I_CT: + case GTPIE_MBMS_UE_CTX: + case GTPIE_TMGI: + case GTPIE_RIM_ROUT_ADDR: + case GTPIE_MBMS_PCO: + case GTPIE_MBMS_SA: + case GTPIE_SRNC_PDCP_CTX: + case GTPIE_ADDL_TRACE: + case GTPIE_HOP_CTR: + case GTPIE_SEL_PLMN_ID: + case GTPIE_MBMS_SESS_ID: + case GTPIE_MBMS_2_3G_IND: + case GTPIE_ENH_NSAPI: + case GTPIE_MBMS_SESS_DUR: + case GTPIE_A_MBMS_TRAC_I: + case GTPIE_MBMS_S_REP_N: + case GTPIE_MBMS_TTDT: + case GTPIE_PS_HO_REQ_CTX: + case GTPIE_BSS_CONTAINER: + case GTPIE_CELL_ID: + case GTPIE_PDU_NUMBERS: + case GTPIE_BSSGP_CAUSE: + case GTPIE_RQD_MBMS_BCAP: + case GTPIE_RIM_RA_DISCR: + case GTPIE_L_SETUP_PFCS: + case GTPIE_PS_HO_XID_PAR: + case GTPIE_MS_CHG_REP_A: + case GTPIE_DIR_TUN_FLAGS: + case GTPIE_CORREL_ID: + case GTPIE_MBMS_FLOWI: + case GTPIE_MBMS_MC_DIST: + case GTPIE_MBMS_DIST_ACK: + case GTPIE_R_IRAT_HO_INF: + case GTPIE_RFSP_IDX: + case GTPIE_FQDN: + case GTPIE_E_ALL_PRIO_1: + case GTPIE_E_ALL_PRIO_2: + case GTPIE_E_CMN_FLAGS: + case GTPIE_U_CSG_INFO: + case GTPIE_CSG_I_REP_ACT: + case GTPIE_CSG_ID: + case GTPIE_CSG_MEMB_IND: + case GTPIE_AMBR: + case GTPIE_UE_NET_CAPA: + case GTPIE_UE_AMBR: + case GTPIE_APN_AMBR_NS: + case GTPIE_GGSN_BACKOFF: + case GTPIE_S_PRIO_IND: + case GTPIE_S_PRIO_IND_NS: + case GTPIE_H_BR_16MBPS_F: + case GTPIE_A_MMCTX_SRVCC: + case GTPIE_A_FLAGS_SRVCC: + case GTPIE_STN_SR: + case GTPIE_C_MSISDN: + case GTPIE_E_RANAP_CAUSE: + case GTPIE_ENODEB_ID: + case GTPIE_SEL_MODE_NS: + case GTPIE_ULI_TIMESTAMP: + case GTPIE_CHARGING_ADDR: + case GTPIE_PRIVATE: + iesize = 3 + hton16(ie->tlv.l); + break; + default: + return 2; /* We received something unknown */ + } + + if (p + iesize < end) { + memcpy(p, ie, iesize); + p += iesize; + *encoded_len += iesize; + } else + return 2; /* Out of space */ + } + + return 0; +} + diff --git a/include/osmocom/gtp/gtpie.h b/include/osmocom/gtp/gtpie.h index b6fea6e..b3e3ddf 100644 --- a/include/osmocom/gtp/gtpie.h +++ b/include/osmocom/gtp/gtpie.h @@ -321,5 +321,7 @@ extern int gtpie_encaps(union gtpie_member *ie[], void *pack, unsigned *len); extern int gtpie_encaps2(union gtpie_member ie[], unsigned int size, void *pack, unsigned *len); +extern int gtpie_encaps3(union gtpie_member *ie[], unsigned int ie_len, + void *pack, unsigned pack_len, unsigned *encoded_len); #endif /* !_GTPIE_H */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/39032?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I8bb086c568e07052c52d880df06049490346e91e Gerrit-Change-Number: 39032 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[S] Change in osmo-iuh[master]: iu_client: add a new event NEW_AREA

by lynxis lazus

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/38947?usp=email to look at the new patch set (#9). Change subject: iu_client: add a new event NEW_AREA ...................................................................... iu_client: add a new event NEW_AREA When the IU client learns a new LAC/RAC or the LAC/RAC has moved from one RNC to another RNC, inform the user via an event. Allows the SGSN to track RACs which uses Iu. Change-Id: I8b1b8c58bf72b00e2705ca87a89a91481bac3470 --- M TODO-RELEASE M include/osmocom/ranap/iu_client.h M src/iu_client.c 3 files changed, 39 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/47/38947/9 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/38947?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I8b1b8c58bf72b00e2705ca87a89a91481bac3470 Gerrit-Change-Number: 38947 Gerrit-PatchSet: 9 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

4 months, 3 weeks

1
0
0 0

[M] Change in osmo-iuh[master]: iu_client: add ranap_iu_page_cs2/ranap_iu_page_ps2

by lynxis lazus

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/38946?usp=email to look at the new patch set (#9). Change subject: iu_client: add ranap_iu_page_cs2/ranap_iu_page_ps2 ...................................................................... iu_client: add ranap_iu_page_cs2/ranap_iu_page_ps2 ranap_iu_page_cs2 and ranap_iu_page_ps2 are using the new osmocom osmo_location_area_id or osmo_routing_area_id which also contain the PLMN. Change-Id: I1f07e96642737160d387de3e4c3f71d288d356dd --- M TODO-RELEASE M include/osmocom/ranap/iu_client.h M src/iu_client.c 3 files changed, 81 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/46/38946/9 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/38946?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I1f07e96642737160d387de3e4c3f71d288d356dd Gerrit-Change-Number: 38946 Gerrit-PatchSet: 9 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[M] Change in osmo-iuh[master]: iu_client: refactor LAC/RAC handling

by lynxis lazus

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/38945?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Code-Review+1 by pespin Change subject: iu_client: refactor LAC/RAC handling ...................................................................... iu_client: refactor LAC/RAC handling The iu client ignored the PLMN which might ran into duplicate RACs. Replace all lac/rac handling by the "new" osmo_routing_area_id struct which has improved handling. Further it allows to use the embedded lac when CS paging is only required. The old gprs_ra_id is still used to contain api stability. RAC with 0xff will be rejected (which should be invalid already, because the SIM is using this value for an invalid entry). Internally RAC = 0xff will be used to differentiate between LAI and RAI. Change-Id: Ie38fa3751cfce1c981d8d0bed1b8ff891593a638 --- M src/iu_client.c 1 file changed, 58 insertions(+), 21 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/45/38945/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/38945?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Ie38fa3751cfce1c981d8d0bed1b8ff891593a638 Gerrit-Change-Number: 38945 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[M] Change in osmo-iuh[master]: iu_client: refactor LAC/RAC handling

by lynxis lazus

Attention is currently required from: laforge, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-iuh/+/38945?usp=email ) Change subject: iu_client: refactor LAC/RAC handling ...................................................................... Patch Set 4: (1 comment) File src/iu_client.c: https://gerrit.osmocom.org/c/osmo-iuh/+/38945/comment/04b78103_218c4fe7?usp… : PS4, Line 453: ra_id.rac = 0xfe; > @laforge@gnumonks. […] I switched to 0xff which is invalid. Also rejecting such RAC. -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/38945?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Ie38fa3751cfce1c981d8d0bed1b8ff891593a638 Gerrit-Change-Number: 38945 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Jan 2025 23:12:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

4 months, 3 weeks

1
0
0 0

[M] Change in osmo-iuh[master]: iu_client: add ranap_iu_page_cs2/ranap_iu_page_ps2

by lynxis lazus

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-iuh/+/38946?usp=email ) Change subject: iu_client: add ranap_iu_page_cs2/ranap_iu_page_ps2 ...................................................................... Patch Set 8: (2 comments) File src/iu_client.c: https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/2732f19c_1f9375fb?usp… : PS8, Line 870: osmo_rai_name2(ra_id), imsi, tmsi_or_ptmsi ? *tmsi_or_ptmsi : 0xffffffff); > GSM_RESERVED_TMSI Done https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/05b12301_67c98163?usp… : PS8, Line 879: osmo_rai_name2(ra_id), imsi, tmsi_or_ptmsi ? *tmsi_or_ptmsi : 0xffffffff); > GSM_RESERVED_TMSI Done -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/38946?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I1f07e96642737160d387de3e4c3f71d288d356dd Gerrit-Change-Number: 38946 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Jan 2025 23:12:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2025